From nobody Tue Feb 10 15:45:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1695723036; cv=none; d=zohomail.com; s=zohoarc; b=Ma/nnbT7gl5ll1N7Xwt/U3RzH9edd8ZtYejvwoN7d/aAX2i1FlQjhQVRxaxgjPGikVQipBrWu3SN1C16odQLxxWSH7j/djP/K5SxyFowHYd5LqtUEZsOKxjsgqlj8axJRaxozXfPIVxC2clH/DFxMSiNFyOkA59+uKMqbYX71Xw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695723036; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=CN8Sd3o8x0O2vsIldFs3OHZHbGYJwvIKIAB1Vw9p3l4=; b=YfBswPDMnbnlhxK2QyoRIGghIkb4uel1GTAwS2fndwAwkhbKJz72mb1JEbMD6hvsAx5UH95F2cZClj4aoqk0fKHlrpu8Aya7FanhlTZjKJYkcVhN/CY2P1bKLqGadrzFOnqNFjZmAaBwyPcDnAYKJ/VMvfMUQOBO1IVx0CG5X6o= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 169572303691714.829502794739938; Tue, 26 Sep 2023 03:10:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ql51V-0005Pr-4A; Tue, 26 Sep 2023 06:10:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql51E-0004mh-P3; Tue, 26 Sep 2023 06:10:20 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql51A-0004mw-BW; Tue, 26 Sep 2023 06:10:13 -0400 Received: from lhrpeml500001.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RvwR73p2Wz6D98H; Tue, 26 Sep 2023 18:07:47 +0800 (CST) Received: from A190218597.china.huawei.com (10.126.174.16) by lhrpeml500001.china.huawei.com (7.191.163.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 26 Sep 2023 11:09:49 +0100 To: , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RFC V2 15/37] arm/virt: Create GED dev before *disabled* CPU Objs are destroyed Date: Tue, 26 Sep 2023 11:04:14 +0100 Message-ID: <20230926100436.28284-16-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20230926100436.28284-1-salil.mehta@huawei.com> References: <20230926100436.28284-1-salil.mehta@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.126.174.16] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To lhrpeml500001.china.huawei.com (7.191.163.213) X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=salil.mehta@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Salil Mehta From: Salil Mehta via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1695723039100100007 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ACPI CPU hotplug state (is_present=3D_STA.PRESENT, is_enabled=3D_STA.ENABLE= D) for all the possible vCPUs MUST be initialized during machine init. This is done during the creation of the GED device. VMM/Qemu MUST expose/fake the ACPI s= tate of the disabled vCPUs to the Guest kernel as 'present' (_STA.PRESENT) always i.e. ACPI persistent. if the 'disabled' vCPU objectes are destroyed before = the GED device has been created then their ACPI hotplug state might not get initialized correctly as acpi_persistent flag is part of the CPUState. This= will expose wrong status of the unplugged vCPUs to the Guest kernel. Hence, moving the GED device creation before disabled vCPU objects get dest= royed as part of the post CPU init routine. Signed-off-by: Salil Mehta --- hw/arm/virt.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 5c8a0672dc..cbb6199ec6 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2376,6 +2376,12 @@ static void machvirt_init(MachineState *machine) =20 create_gic(vms, sysmem); =20 + has_ged =3D has_ged && aarch64 && firmware_loaded && + virt_is_acpi_enabled(vms); + if (has_ged) { + vms->acpi_dev =3D create_acpi_ged(vms); + } + virt_cpu_post_init(vms, sysmem); =20 fdt_add_pmu_nodes(vms); @@ -2398,9 +2404,7 @@ static void machvirt_init(MachineState *machine) =20 create_pcie(vms); =20 - if (has_ged && aarch64 && firmware_loaded && virt_is_acpi_enabled(vms)= ) { - vms->acpi_dev =3D create_acpi_ged(vms); - } else { + if (!has_ged) { create_gpio_devices(vms, VIRT_GPIO, sysmem); } =20 --=20 2.34.1