From nobody Mon Sep 16 18:54:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695048643; cv=none; d=zohomail.com; s=zohoarc; b=S7+DzdQzYkf6zAwjjbP9459f0BmXy2mgLVX9xkT65duZHff6VjFjJC+g4PCSaT0mVfxce26sGIiFpc7UrRhBptXTzN8qFeVksu7qYYSG30Jdy6bRu1343/OiQidtGSx4GJ/CkVgHruMlYINfjdY8Q/WQDpfRMMpTXvkJeba9xlQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695048643; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=80wzI07F/vBfJq+6JDGB1yJg2AyjK5HMXn7NuHI3+EY=; b=l3ldb1uQ3PdN09RVhMGRLXmVuV1aYbwmpSCxW87+OamXVtEcDkzVEK1mj92SMdRsm7f+AeOxkCBUR1vv09ur/L4n+lgJ+iMQpcC2jjxaFa4+PAGLhQzLzWBiki0Q2kSqpgSaoZ0Q6G/xHhW8wSfWxjsTa+mn/+MrVrP1+BSPSGE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 169504864317763.88005907977015; Mon, 18 Sep 2023 07:50:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiFST-00035E-71; Mon, 18 Sep 2023 10:42:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiFSJ-0002wq-QN for qemu-devel@nongnu.org; Mon, 18 Sep 2023 10:42:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiFS2-0002Yl-MM for qemu-devel@nongnu.org; Mon, 18 Sep 2023 10:42:30 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-91-ifa3oQh1PpqDKADfnoPkDw-1; Mon, 18 Sep 2023 10:42:08 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1716D945923 for ; Mon, 18 Sep 2023 14:42:08 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8FCC1005E27 for ; Mon, 18 Sep 2023 14:42:07 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E5D0A21E6905; Mon, 18 Sep 2023 16:42:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695048130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=80wzI07F/vBfJq+6JDGB1yJg2AyjK5HMXn7NuHI3+EY=; b=R7ZS13IaXVMnOMa/lv1IWaGm/SxVLrSWPK+q70guDM5uOWE8y8wAErKNQobTOXtuFrNq8Z kZ/l3dYbAHf6KlTtrXwQtjCZenAI3lCbY355CTr86RksDKXZXdrf5GjwxkhbTBpxH/H0Pw AJoINxNLxbjBFfqSo+SELghzW8sbruw= X-MC-Unique: ifa3oQh1PpqDKADfnoPkDw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: quintela@redhat.com, peterx@redhat.com, leobras@redhat.com Subject: [PATCH 03/52] migration/rdma: Clean up rdma_delete_block()'s return type Date: Mon, 18 Sep 2023 16:41:17 +0200 Message-ID: <20230918144206.560120-4-armbru@redhat.com> In-Reply-To: <20230918144206.560120-1-armbru@redhat.com> References: <20230918144206.560120-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695048644930100005 Content-Type: text/plain; charset="utf-8" rdma_delete_block() always returns 0, which its only caller ignores. Return void instead. Signed-off-by: Markus Armbruster Reviewed-by: Fabiano Rosas Reviewed-by: Li Zhijian --- migration/rdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 3b9e21f8de..320c291a96 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -668,7 +668,7 @@ static int qemu_rdma_init_ram_blocks(RDMAContext *rdma) * Note: If used outside of cleanup, the caller must ensure that the desti= nation * block structures are also updated */ -static int rdma_delete_block(RDMAContext *rdma, RDMALocalBlock *block) +static void rdma_delete_block(RDMAContext *rdma, RDMALocalBlock *block) { RDMALocalBlocks *local =3D &rdma->local_ram_blocks; RDMALocalBlock *old =3D local->block; @@ -754,8 +754,6 @@ static int rdma_delete_block(RDMAContext *rdma, RDMALoc= alBlock *block) &local->block[x]); } } - - return 0; } =20 /* --=20 2.41.0