From nobody Tue Feb 10 10:11:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=swemel.ru ARC-Seal: i=1; a=rsa-sha256; t=1694676812; cv=none; d=zohomail.com; s=zohoarc; b=DYPcOgRNv7JuXbIn0YrV3CPISNmrmOY9tpuvHMiNZlliaWCctrCdyAFBPlPPgsyiHaTK6PWuIVFA7+B8BNGP4vfj7cTkJVlhiT2kgCntatS033SYyBb+8q9AXReRAmanyx/g9bDH224hLNQe+LmLKN5GFUPZoQL3vLHwF6BI1jE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694676812; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HCwrGCLhgL3KJl+vRri9TNh+xtSoWwP0nZKcQDdb9aQ=; b=CWFPwjXAVgnJS3jzXg4CeigueAIrWEW4WS2gwwEettLy1jEofr2Pyvb/TUpYWqSktXGC+rM8yrR8p3AhVdrtE8z8OCO3dZ04DEBu/V5sBymNpKT1zYoBVHnN3YU8PiAUur6OKk5Qnkpy1gJaw+qi802Dw6/xfciA1swSpRX4dUQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1694676812305125.9247672859783; Thu, 14 Sep 2023 00:33:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qggpi-0007dv-L7; Thu, 14 Sep 2023 03:32:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qggpF-0006pL-Qt for qemu-devel@nongnu.org; Thu, 14 Sep 2023 03:31:48 -0400 Received: from mx.swemel.ru ([95.143.211.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qggpC-0004KO-BN for qemu-devel@nongnu.org; Thu, 14 Sep 2023 03:31:45 -0400 From: Dmitry Frolov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1694676695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HCwrGCLhgL3KJl+vRri9TNh+xtSoWwP0nZKcQDdb9aQ=; b=VAPXD5qT0UlahgdJvOFwLpmI/MJb5MjT/NqCMhzYlYC0JLxuQqoklqA1m6u5NFrLKdQbIy ZHABFQqgLA6SuiTfh5UnsVfHi/8rahLu0y9mjEhKmzhWkDTxaH33Lq8+tKDlnUBVENbjP8 BiobO5aCjE/7joyFXlLw7OTACcofX+4= To: jonathan.cameron@huawei.com, fan.ni@samsung.com, qemu-devel@nongnu.org Cc: sdl.qemu@linuxtesting.org, Dmitry Frolov Subject: [PATCH v3] hw/cxl: Fix out of bound array access Date: Thu, 14 Sep 2023 10:06:37 +0300 Message-Id: <20230914070635.1141840-1-frolov@swemel.ru> In-Reply-To: <20230913175649.00001447@Huawei.com> References: <20230913175649.00001447@Huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=95.143.211.150; envelope-from=frolov@swemel.ru; helo=mx.swemel.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @swemel.ru) X-ZM-MESSAGEID: 1694676816527100009 Content-Type: text/plain; charset="utf-8" According to cxl_interleave_ways_enc(), fw->num_targets is allowed to be up to 16. This also corresponds to CXL specs. So, the fw->target_hbs[] array is iterated from 0 to 15. But it is statically declared of length 8. Thus, out of bound array access may occur. Found by Linux Verification Center (linuxtesting.org) with SVACE. v2: assert added v3: assert removed Fixes: c28db9e000 ("hw/pci-bridge: Make PCIe and CXL PXB Devices inherit fr= om TYPE_PXB_DEV") Signed-off-by: Dmitry Frolov --- include/hw/cxl/cxl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h index 56c9e7676e..4944725849 100644 --- a/include/hw/cxl/cxl.h +++ b/include/hw/cxl/cxl.h @@ -29,7 +29,7 @@ typedef struct PXBCXLDev PXBCXLDev; typedef struct CXLFixedWindow { uint64_t size; char **targets; - PXBCXLDev *target_hbs[8]; + PXBCXLDev *target_hbs[16]; uint8_t num_targets; uint8_t enc_int_ways; uint8_t enc_int_gran; --=20 2.34.1