From nobody Thu Nov 28 07:43:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1693936034; cv=none; d=zohomail.com; s=zohoarc; b=JdXcCFD5orxbMM06gqdOQFevjC6YQ38mSKz6WcC/Z7V4Dn5s3hAOm3W+X1qXTKQ4jnjIxdssPz57G3g0QnRFeMESjDNymfNXX20t6LSTYBIeUJUvTIn9gqZU5nYj91G7S/HZR6nVIb+Ka5kaT1d5NjwQsHZpTWWiJIVM0twTnRk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693936034; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=L/WAEDSFNLpsb5m9BlWlLp+qgIbutuYimcNiIgtUEIE=; b=Z78gO0suATO885T9rcgIrKptNmM8f6Fs1yfHkeIKRWtiH0OklolyP/dEv1Q1y+6yiYT0NaXKzYgAwuX2NjAUXy0LINaPJfdVgcl64ygJXnuoT7lG4/EEWVokb29EFAvRey8GLY3pMHZDvhevjYzqHVVrs1YxyNOE7o3rvf5/4gk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1693936034781919.1828590215057; Tue, 5 Sep 2023 10:47:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qda8b-00041Y-Uy; Tue, 05 Sep 2023 13:46:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qda8S-0003yL-Ky for qemu-devel@nongnu.org; Tue, 05 Sep 2023 13:46:44 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qda8Q-0006MZ-8j for qemu-devel@nongnu.org; Tue, 05 Sep 2023 13:46:44 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 96A0F1FF64; Tue, 5 Sep 2023 17:46:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 49EDC13499; Tue, 5 Sep 2023 17:46:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +dhEBX5p92SFQgAAMHmgww (envelope-from ); Tue, 05 Sep 2023 17:46:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1693935999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=L/WAEDSFNLpsb5m9BlWlLp+qgIbutuYimcNiIgtUEIE=; b=Y2/IjpQFdT1QoVpWIX6FFaIhbZUYVstRSt2aFDQYLemcrJEsJ4i9+/xg7ipSwEzG9ZXcYG qM+5bjyj3zpvE0UhJ1YhBTGrPebp2iYxqiz+D5eUodO0wdXSndKEBLtTgROecQOwMW82/I q2Cca4xKGp2iBUep5chUv7/CUK9qEsE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1693935999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=L/WAEDSFNLpsb5m9BlWlLp+qgIbutuYimcNiIgtUEIE=; b=sqDwnR5T8QSHM4r8jzf9TieJaRBpk6EaUBuTByIO5ppNMHQJGUrYgmB6ANhAzCFpqLC/sA XIk8FhWyYH2+y4Bw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2] iothread: Set the GSource "name" field Date: Tue, 5 Sep 2023 14:46:35 -0300 Message-Id: <20230905174635.10112-1-farosas@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1693936035529100001 Content-Type: text/plain; charset="utf-8" Having a name in the source helps with debugging core dumps when one might not have access to TLS data to cross-reference AioContexts with their addresses. Signed-off-by: Fabiano Rosas --- v2: used g_autofree where appropriate --- iothread.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/iothread.c b/iothread.c index b41c305bd9..78ac1153ac 100644 --- a/iothread.c +++ b/iothread.c @@ -138,12 +138,14 @@ static void iothread_instance_finalize(Object *obj) qemu_sem_destroy(&iothread->init_done_sem); } =20 -static void iothread_init_gcontext(IOThread *iothread) +static void iothread_init_gcontext(IOThread *iothread, char *thread_name) { GSource *source; + g_autofree char *name =3D g_strdup_printf("%s aio-context", thread_nam= e); =20 iothread->worker_context =3D g_main_context_new(); source =3D aio_get_g_source(iothread_get_aio_context(iothread)); + g_source_set_name(source, name); g_source_attach(source, iothread->worker_context); g_source_unref(source); iothread->main_loop =3D g_main_loop_new(iothread->worker_context, TRUE= ); @@ -180,7 +182,7 @@ static void iothread_init(EventLoopBase *base, Error **= errp) { Error *local_error =3D NULL; IOThread *iothread =3D IOTHREAD(base); - char *thread_name; + g_autofree char *thread_name =3D NULL; =20 iothread->stopping =3D false; iothread->running =3D true; @@ -189,11 +191,14 @@ static void iothread_init(EventLoopBase *base, Error = **errp) return; } =20 + thread_name =3D g_strdup_printf("IO %s", + object_get_canonical_path_component(OBJECT(base))); + /* * Init one GMainContext for the iothread unconditionally, even if * it's not used */ - iothread_init_gcontext(iothread); + iothread_init_gcontext(iothread, thread_name); =20 iothread_set_aio_context_params(base, &local_error); if (local_error) { @@ -206,11 +211,8 @@ static void iothread_init(EventLoopBase *base, Error *= *errp) /* This assumes we are called from a thread with useful CPU affinity f= or us * to inherit. */ - thread_name =3D g_strdup_printf("IO %s", - object_get_canonical_path_component(OBJECT(base))); qemu_thread_create(&iothread->thread, thread_name, iothread_run, iothread, QEMU_THREAD_JOINABLE); - g_free(thread_name); =20 /* Wait for initialization to complete */ while (iothread->thread_id =3D=3D -1) { --=20 2.35.3