From nobody Thu Nov 28 07:53:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1693838979; cv=none; d=zohomail.com; s=zohoarc; b=Hn1ACKS/w1jnkJdsgWvhYGeYW5Y36a51qJy4bYKmidatSLROJGvvecNzTSUY6BgYeFTr5G1yw1EMHOSSbZoI3T3AWn2T0I8P4KFPK5Zv2cmWYEgdE2KkT2W5xLBLZevAAl6Vw9Lb9Rp2mVMO0X+QDcv4HJ9M4lEGxNT6vCpJauc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693838979; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=+2qHZq5YHWZa5PL6pR5iirRHx0XHgaVsG7iMF7ATyyQ=; b=OxT2BOr7sE4mEIf5HTQYBzEvsGWr2U+tLzAWIiYULiaIIkSCurcRcmTOhq9dM1qTQQ5qQ7GP+gkT6+qM/knCgjlkCEwHdNKIcI8bqV3pREW7FAA3gQeZV9aCRWVAVx0BkZ21K2WBHBbyCVNzIsf4halEo4KnAHbhyCiMrLc9Rd8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1693838979415189.1341123019364; Mon, 4 Sep 2023 07:49:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdAsS-0006k0-F6; Mon, 04 Sep 2023 10:48:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdAsR-0006je-JW for qemu-devel@nongnu.org; Mon, 04 Sep 2023 10:48:31 -0400 Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdAsC-0004cP-Gn for qemu-devel@nongnu.org; Mon, 04 Sep 2023 10:48:31 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A8C341F38C; Mon, 4 Sep 2023 14:48:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9274A13425; Mon, 4 Sep 2023 14:48:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iLHlFi3u9WRAOQAAMHmgww (envelope-from ); Mon, 04 Sep 2023 14:48:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1693838894; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+2qHZq5YHWZa5PL6pR5iirRHx0XHgaVsG7iMF7ATyyQ=; b=UoVmTX5oJkktBG1hfz5SKFFbOKldDqBM3zes8bs19YDny9pMx18O8ZY6nYR368dWf24rJ8 yOfWROlCWprAwQgdHUcP7GtG2KROzvuUg+kufP5S2KTPy1izhjIc7l5utkD2dDmua5lVgQ GJSrP4OKdWVI/Ur68qAQHkFp7ST+WxA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1693838894; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+2qHZq5YHWZa5PL6pR5iirRHx0XHgaVsG7iMF7ATyyQ=; b=OI1H7nxyEF8+Q3jwDY0EEdfJjDNp0IZaEaD5IiZ8vk0rzKmKqmOuPWTesAqGbuVG3vLT7E nqJ6LNtGr+vyoDAQ== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Peter Xu Subject: [PATCH] iothread: Set the GSource "name" field Date: Mon, 4 Sep 2023 11:48:11 -0300 Message-Id: <20230904144811.4218-1-farosas@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1d; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1693838980065100001 Content-Type: text/plain; charset="utf-8" Having a name in the source helps with debugging core dumps when one might not have access to TLS data to cross-reference AioContexts with their addresses. Signed-off-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- iothread.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/iothread.c b/iothread.c index b41c305bd9..8cfb9d5be6 100644 --- a/iothread.c +++ b/iothread.c @@ -138,15 +138,19 @@ static void iothread_instance_finalize(Object *obj) qemu_sem_destroy(&iothread->init_done_sem); } =20 -static void iothread_init_gcontext(IOThread *iothread) +static void iothread_init_gcontext(IOThread *iothread, char *thread_name) { GSource *source; + gchar *name =3D g_strdup_printf("%s aio-context", thread_name); =20 iothread->worker_context =3D g_main_context_new(); source =3D aio_get_g_source(iothread_get_aio_context(iothread)); + g_source_set_name(source, name); g_source_attach(source, iothread->worker_context); g_source_unref(source); iothread->main_loop =3D g_main_loop_new(iothread->worker_context, TRUE= ); + + g_free(name); } =20 static void iothread_set_aio_context_params(EventLoopBase *base, Error **e= rrp) @@ -189,11 +193,14 @@ static void iothread_init(EventLoopBase *base, Error = **errp) return; } =20 + thread_name =3D g_strdup_printf("IO %s", + object_get_canonical_path_component(OBJECT(base))); + /* * Init one GMainContext for the iothread unconditionally, even if * it's not used */ - iothread_init_gcontext(iothread); + iothread_init_gcontext(iothread, thread_name); =20 iothread_set_aio_context_params(base, &local_error); if (local_error) { @@ -206,8 +213,6 @@ static void iothread_init(EventLoopBase *base, Error **= errp) /* This assumes we are called from a thread with useful CPU affinity f= or us * to inherit. */ - thread_name =3D g_strdup_printf("IO %s", - object_get_canonical_path_component(OBJECT(base))); qemu_thread_create(&iothread->thread, thread_name, iothread_run, iothread, QEMU_THREAD_JOINABLE); g_free(thread_name); --=20 2.35.3