From nobody Thu Nov 28 11:00:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1693828626; cv=none; d=zohomail.com; s=zohoarc; b=SVUK03BiWNhW7hMRS/x85zHgV163MlQCR5uJeLUPZfVqNtNs5Lv2L62BaICPlb3N0+8I/nxREm9K1ErhfNb1jytv5ytdSB9vkc1cNlvLIGG/pDSfPWaJ8AVvN3V0htQzf3xts2mCriiPRUp8bpyVYIxLyzOfJ7ReHceJGUNI7+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693828626; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7NUYymtfm45Q9J6UHwQZHTSqfBewE0YOcr1sRCaqdAg=; b=IN2K8ZvwboZ1DVp3HlgughpWvASigTqCAiW2iWZD9iJuUhts62QXJe0DpmTxc+3lTDgasyU1OyLorFUrBhwJ+Pel0f5+Bp9+F9OtBKg/0l/VllF+7dA7nB2pHIMVd1M+8sJ/q6Wme9O51xAs1SBYb4haZzVBYdwo/lfut1WZ+7A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1693828626314447.0996510728497; Mon, 4 Sep 2023 04:57:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qd8AO-0004UZ-BC; Mon, 04 Sep 2023 07:54:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd8A0-0003ng-67 for qemu-devel@nongnu.org; Mon, 04 Sep 2023 07:54:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd89x-0008W9-0C for qemu-devel@nongnu.org; Mon, 04 Sep 2023 07:54:27 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-67-HdRwvCCiOjuHPtLym7Q9DQ-1; Mon, 04 Sep 2023 07:54:21 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3BF86811C32 for ; Mon, 4 Sep 2023 11:54:21 +0000 (UTC) Received: from localhost (unknown [10.39.208.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7929E2013570; Mon, 4 Sep 2023 11:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693828462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7NUYymtfm45Q9J6UHwQZHTSqfBewE0YOcr1sRCaqdAg=; b=d6Sp9DQ993UEgzKsssWTfiLV1EPzyhYepXDoPZR8+/W80XZz4DUlYIT8EbdC9xy/9a7ukk csMgAV9Ta9ZWWUxXlDyG9Ov3g48rBdmd83IxH+wXYjA1Gb2R3et6Pp+iUXaymW6WthEys5 z7v8sot+51MguMQuLkCAKVyv4l481FU= X-MC-Unique: HdRwvCCiOjuHPtLym7Q9DQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Subject: [PULL 22/52] ui/console: remove new_console() Date: Mon, 4 Sep 2023 15:52:19 +0400 Message-ID: <20230904115251.4161397-23-marcandre.lureau@redhat.com> In-Reply-To: <20230904115251.4161397-1-marcandre.lureau@redhat.com> References: <20230904115251.4161397-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1693828627596100009 From: Marc-Andr=C3=A9 Lureau The constructor helper isn't of much used now. "head" is only specified for graphic console (and default to 0), and we are going to move it to QemuGraphicConsole next. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 Message-Id: <20230830093843.3531473-23-marcandre.lureau@redhat.com> --- ui/console.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/ui/console.c b/ui/console.c index 02a24eaf5d..e0e4f980d7 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1414,16 +1414,6 @@ qemu_fixed_text_console_init(Object *obj) { } =20 -static QemuConsole *new_console(const char *typename, - uint32_t head) -{ - QemuConsole *c =3D QEMU_CONSOLE(object_new(typename)); - - c->head =3D head; - - return c; -} - #ifdef WIN32 void qemu_displaysurface_win32_set_handle(DisplaySurface *surface, HANDLE h, uint32_t offset) @@ -2163,7 +2153,7 @@ DisplayState *init_displaystate(void) QemuConsole *con; =20 QTAILQ_FOREACH(con, &consoles, next) { - /* Hook up into the qom tree here (not in new_console()), once + /* Hook up into the qom tree here (not in object_new()), once * all QemuConsoles are created and the order / numbering * doesn't change any more */ name =3D g_strdup_printf("console[%d]", con->index); @@ -2201,7 +2191,8 @@ QemuConsole *graphic_console_init(DeviceState *dev, u= int32_t head, height =3D qemu_console_get_height(s, 0); } else { trace_console_gfx_new(); - s =3D new_console(TYPE_QEMU_GRAPHIC_CONSOLE, head); + s =3D (QemuConsole *)object_new(TYPE_QEMU_GRAPHIC_CONSOLE); + s->head =3D head; s->ui_timer =3D timer_new_ms(QEMU_CLOCK_REALTIME, dpy_set_ui_info_timer, s); } @@ -2578,9 +2569,9 @@ static void vc_chr_open(Chardev *chr, =20 trace_console_txt_new(width, height); if (width =3D=3D 0 || height =3D=3D 0) { - s =3D new_console(TYPE_QEMU_TEXT_CONSOLE, 0); + s =3D (QemuConsole *)object_new(TYPE_QEMU_TEXT_CONSOLE); } else { - s =3D new_console(TYPE_QEMU_FIXED_TEXT_CONSOLE, 0); + s =3D (QemuConsole *)object_new(TYPE_QEMU_FIXED_TEXT_CONSOLE); s->scanout.kind =3D SCANOUT_SURFACE; s->surface =3D qemu_create_displaysurface(width, height); } --=20 2.41.0