From nobody Tue Feb 10 18:54:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1693388426; cv=none; d=zohomail.com; s=zohoarc; b=XNEh93yPHQ+sapM3YbUV2kWiHF8LD/DPabnMzRNk7ysy+fA/aX0cQHus7MFZ5b9+IV0p0auSHaQAObgVDzCTi/uSMBXKEp3JTF6JM/s22LHhQ8e61/mtNSXcdhJsJ33J4ssK5DWebX4yCTNhADEsp5YWOfpmMgOVdTgGiCexHYo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693388426; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EIie1hpxepfdzgYXnssJ1FtdBJvj090cN1kuFa3cINw=; b=NRBVYx36TcQV8V0e/9Vzkj4eVlplDAa/boIRjPu5Y9BtBSoPLWAE+zZtlP+7bbCNXQTKQSy00e/rQo02moeQuuU+gMikgb3zhtR3BfOWaloCK7epykWWMadLkVhWnCuH0oOpS2LRI/ng7xFIUy1hc1Z/NUr8m1jg1H3RTq0lUkI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1693388426571830.6275028585449; Wed, 30 Aug 2023 02:40:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbHg6-0001Tx-KR; Wed, 30 Aug 2023 05:39:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbHg4-0001JS-7d for qemu-devel@nongnu.org; Wed, 30 Aug 2023 05:39:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbHg1-0000yg-Oa for qemu-devel@nongnu.org; Wed, 30 Aug 2023 05:39:56 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-176-OfOivLzAME20tDy3hSUTXA-1; Wed, 30 Aug 2023 05:39:51 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EB2058030A9 for ; Wed, 30 Aug 2023 09:39:50 +0000 (UTC) Received: from localhost (unknown [10.39.208.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id B448E6466B; Wed, 30 Aug 2023 09:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693388393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EIie1hpxepfdzgYXnssJ1FtdBJvj090cN1kuFa3cINw=; b=POiUu9xJE9+4XrkEpuR2YSF5CeKJXuHcAlgUQN/5kAlDe1IOqPzPQyECFdAWVdgFIEyc33 ltsXxcB2pbJkB4U/tmcFDJVU3lAXF3nUEn8mzgqx0TMWaj9t/drcG1JKfEyJepYC4WTywv 5Z3dPhZqD8vYDFT6tOzrqoOgNl+x/60= X-MC-Unique: OfOivLzAME20tDy3hSUTXA-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 16/67] ui/vc: move VCCharDev specific fields out of QemuConsole Date: Wed, 30 Aug 2023 13:37:50 +0400 Message-ID: <20230830093843.3531473-17-marcandre.lureau@redhat.com> In-Reply-To: <20230830093843.3531473-1-marcandre.lureau@redhat.com> References: <20230830093843.3531473-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1693388427166100009 From: Marc-Andr=C3=A9 Lureau Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- ui/console.c | 147 +++++++++++++++++++++++++-------------------------- 1 file changed, 73 insertions(+), 74 deletions(-) diff --git a/ui/console.c b/ui/console.c index 8fe39aa5e3..b9b545fa3d 100644 --- a/ui/console.c +++ b/ui/console.c @@ -106,10 +106,8 @@ struct QemuConsole { int total_height; int backscroll_height; int x, y; - int x_saved, y_saved; int y_displayed; int y_base; - TextAttributes t_attrib; /* currently active text attributes */ TextCell *cells; int text_x[2], text_y[2], cursor_invalidate; int echo; @@ -119,10 +117,6 @@ struct QemuConsole { int update_x1; int update_y1; =20 - enum TTYState state; - int esc_params[MAX_ESC_PARAMS]; - int nb_esc_params; - Chardev *chr; /* fifo for key pressed */ Fifo8 out_fifo; @@ -134,6 +128,12 @@ struct QemuConsole { struct VCChardev { Chardev parent; QemuConsole *console; + + enum TTYState state; + int esc_params[MAX_ESC_PARAMS]; + int nb_esc_params; + TextAttributes t_attrib; /* currently active text attributes */ + int x_saved, y_saved; }; typedef struct VCChardev VCChardev; =20 @@ -607,93 +607,92 @@ static void vc_put_lf(VCChardev *vc) */ static void vc_handle_escape(VCChardev *vc) { - QemuConsole *s =3D vc->console; int i; =20 - for (i=3D0; inb_esc_params; i++) { - switch (s->esc_params[i]) { + for (i =3D 0; i < vc->nb_esc_params; i++) { + switch (vc->esc_params[i]) { case 0: /* reset all console attributes to default */ - s->t_attrib =3D TEXT_ATTRIBUTES_DEFAULT; + vc->t_attrib =3D TEXT_ATTRIBUTES_DEFAULT; break; case 1: - s->t_attrib.bold =3D 1; + vc->t_attrib.bold =3D 1; break; case 4: - s->t_attrib.uline =3D 1; + vc->t_attrib.uline =3D 1; break; case 5: - s->t_attrib.blink =3D 1; + vc->t_attrib.blink =3D 1; break; case 7: - s->t_attrib.invers =3D 1; + vc->t_attrib.invers =3D 1; break; case 8: - s->t_attrib.unvisible =3D 1; + vc->t_attrib.unvisible =3D 1; break; case 22: - s->t_attrib.bold =3D 0; + vc->t_attrib.bold =3D 0; break; case 24: - s->t_attrib.uline =3D 0; + vc->t_attrib.uline =3D 0; break; case 25: - s->t_attrib.blink =3D 0; + vc->t_attrib.blink =3D 0; break; case 27: - s->t_attrib.invers =3D 0; + vc->t_attrib.invers =3D 0; break; case 28: - s->t_attrib.unvisible =3D 0; + vc->t_attrib.unvisible =3D 0; break; /* set foreground color */ case 30: - s->t_attrib.fgcol =3D QEMU_COLOR_BLACK; + vc->t_attrib.fgcol =3D QEMU_COLOR_BLACK; break; case 31: - s->t_attrib.fgcol =3D QEMU_COLOR_RED; + vc->t_attrib.fgcol =3D QEMU_COLOR_RED; break; case 32: - s->t_attrib.fgcol =3D QEMU_COLOR_GREEN; + vc->t_attrib.fgcol =3D QEMU_COLOR_GREEN; break; case 33: - s->t_attrib.fgcol =3D QEMU_COLOR_YELLOW; + vc->t_attrib.fgcol =3D QEMU_COLOR_YELLOW; break; case 34: - s->t_attrib.fgcol =3D QEMU_COLOR_BLUE; + vc->t_attrib.fgcol =3D QEMU_COLOR_BLUE; break; case 35: - s->t_attrib.fgcol =3D QEMU_COLOR_MAGENTA; + vc->t_attrib.fgcol =3D QEMU_COLOR_MAGENTA; break; case 36: - s->t_attrib.fgcol =3D QEMU_COLOR_CYAN; + vc->t_attrib.fgcol =3D QEMU_COLOR_CYAN; break; case 37: - s->t_attrib.fgcol =3D QEMU_COLOR_WHITE; + vc->t_attrib.fgcol =3D QEMU_COLOR_WHITE; break; /* set background color */ case 40: - s->t_attrib.bgcol =3D QEMU_COLOR_BLACK; + vc->t_attrib.bgcol =3D QEMU_COLOR_BLACK; break; case 41: - s->t_attrib.bgcol =3D QEMU_COLOR_RED; + vc->t_attrib.bgcol =3D QEMU_COLOR_RED; break; case 42: - s->t_attrib.bgcol =3D QEMU_COLOR_GREEN; + vc->t_attrib.bgcol =3D QEMU_COLOR_GREEN; break; case 43: - s->t_attrib.bgcol =3D QEMU_COLOR_YELLOW; + vc->t_attrib.bgcol =3D QEMU_COLOR_YELLOW; break; case 44: - s->t_attrib.bgcol =3D QEMU_COLOR_BLUE; + vc->t_attrib.bgcol =3D QEMU_COLOR_BLUE; break; case 45: - s->t_attrib.bgcol =3D QEMU_COLOR_MAGENTA; + vc->t_attrib.bgcol =3D QEMU_COLOR_MAGENTA; break; case 46: - s->t_attrib.bgcol =3D QEMU_COLOR_CYAN; + vc->t_attrib.bgcol =3D QEMU_COLOR_CYAN; break; case 47: - s->t_attrib.bgcol =3D QEMU_COLOR_WHITE; + vc->t_attrib.bgcol =3D QEMU_COLOR_WHITE; break; } } @@ -725,7 +724,7 @@ static void vc_put_one(VCChardev *vc, int ch) y1 =3D (s->y_base + s->y) % s->total_height; c =3D &s->cells[y1 * s->width + s->x]; c->ch =3D ch; - c->t_attrib =3D s->t_attrib; + c->t_attrib =3D vc->t_attrib; vc_update_xy(vc, s->x, s->y); s->x++; } @@ -767,7 +766,7 @@ static void vc_putchar(VCChardev *vc, int ch) int x, y; char response[40]; =20 - switch(s->state) { + switch(vc->state) { case TTY_STATE_NORM: switch(ch) { case '\r': /* carriage return */ @@ -798,7 +797,7 @@ static void vc_putchar(VCChardev *vc, int ch) /* SO (shift out), character set 1 (ignored) */ break; case 27: /* esc (introducing an escape sequence) */ - s->state =3D TTY_STATE_ESC; + vc->state =3D TTY_STATE_ESC; break; default: vc_put_one(vc, ch); @@ -808,71 +807,71 @@ static void vc_putchar(VCChardev *vc, int ch) case TTY_STATE_ESC: /* check if it is a terminal escape sequence */ if (ch =3D=3D '[') { for(i=3D0;iesc_params[i] =3D 0; - s->nb_esc_params =3D 0; - s->state =3D TTY_STATE_CSI; + vc->esc_params[i] =3D 0; + vc->nb_esc_params =3D 0; + vc->state =3D TTY_STATE_CSI; } else { - s->state =3D TTY_STATE_NORM; + vc->state =3D TTY_STATE_NORM; } break; case TTY_STATE_CSI: /* handle escape sequence parameters */ if (ch >=3D '0' && ch <=3D '9') { - if (s->nb_esc_params < MAX_ESC_PARAMS) { - int *param =3D &s->esc_params[s->nb_esc_params]; + if (vc->nb_esc_params < MAX_ESC_PARAMS) { + int *param =3D &vc->esc_params[vc->nb_esc_params]; int digit =3D (ch - '0'); =20 *param =3D (*param <=3D (INT_MAX - digit) / 10) ? *param * 10 + digit : INT_MAX; } } else { - if (s->nb_esc_params < MAX_ESC_PARAMS) - s->nb_esc_params++; + if (vc->nb_esc_params < MAX_ESC_PARAMS) + vc->nb_esc_params++; if (ch =3D=3D ';' || ch =3D=3D '?') { break; } - trace_console_putchar_csi(s->esc_params[0], s->esc_params[1], - ch, s->nb_esc_params); - s->state =3D TTY_STATE_NORM; + trace_console_putchar_csi(vc->esc_params[0], vc->esc_params[1], + ch, vc->nb_esc_params); + vc->state =3D TTY_STATE_NORM; switch(ch) { case 'A': /* move cursor up */ - if (s->esc_params[0] =3D=3D 0) { - s->esc_params[0] =3D 1; + if (vc->esc_params[0] =3D=3D 0) { + vc->esc_params[0] =3D 1; } - vc_set_cursor(vc, s->x, s->y - s->esc_params[0]); + vc_set_cursor(vc, s->x, s->y - vc->esc_params[0]); break; case 'B': /* move cursor down */ - if (s->esc_params[0] =3D=3D 0) { - s->esc_params[0] =3D 1; + if (vc->esc_params[0] =3D=3D 0) { + vc->esc_params[0] =3D 1; } - vc_set_cursor(vc, s->x, s->y + s->esc_params[0]); + vc_set_cursor(vc, s->x, s->y + vc->esc_params[0]); break; case 'C': /* move cursor right */ - if (s->esc_params[0] =3D=3D 0) { - s->esc_params[0] =3D 1; + if (vc->esc_params[0] =3D=3D 0) { + vc->esc_params[0] =3D 1; } - vc_set_cursor(vc, s->x + s->esc_params[0], s->y); + vc_set_cursor(vc, s->x + vc->esc_params[0], s->y); break; case 'D': /* move cursor left */ - if (s->esc_params[0] =3D=3D 0) { - s->esc_params[0] =3D 1; + if (vc->esc_params[0] =3D=3D 0) { + vc->esc_params[0] =3D 1; } - vc_set_cursor(vc, s->x - s->esc_params[0], s->y); + vc_set_cursor(vc, s->x - vc->esc_params[0], s->y); break; case 'G': /* move cursor to column */ - vc_set_cursor(vc, s->esc_params[0] - 1, s->y); + vc_set_cursor(vc, vc->esc_params[0] - 1, s->y); break; case 'f': case 'H': /* move cursor to row, column */ - vc_set_cursor(vc, s->esc_params[1] - 1, s->esc_params[0] -= 1); + vc_set_cursor(vc, vc->esc_params[1] - 1, vc->esc_params[0]= - 1); break; case 'J': - switch (s->esc_params[0]) { + switch (vc->esc_params[0]) { case 0: /* clear to end of screen */ for (y =3D s->y; y < s->height; y++) { @@ -906,7 +905,7 @@ static void vc_putchar(VCChardev *vc, int ch) } break; case 'K': - switch (s->esc_params[0]) { + switch (vc->esc_params[0]) { case 0: /* clear to eol */ for(x =3D s->x; x < s->width; x++) { @@ -931,7 +930,7 @@ static void vc_putchar(VCChardev *vc, int ch) vc_handle_escape(vc); break; case 'n': - switch (s->esc_params[0]) { + switch (vc->esc_params[0]) { case 5: /* report console status (always succeed)*/ vc_respond_str(vc, "\033[0n"); @@ -947,13 +946,13 @@ static void vc_putchar(VCChardev *vc, int ch) break; case 's': /* save cursor position */ - s->x_saved =3D s->x; - s->y_saved =3D s->y; + vc->x_saved =3D s->x; + vc->y_saved =3D s->y; break; case 'u': /* restore cursor position */ - s->x =3D s->x_saved; - s->y =3D s->y_saved; + s->x =3D vc->x_saved; + s->y =3D vc->y_saved; break; default: trace_console_putchar_unhandled(ch); @@ -2428,17 +2427,17 @@ static void text_console_do_init(Chardev *chr) s->hw =3D s; =20 /* set current text attributes to default */ - s->t_attrib =3D TEXT_ATTRIBUTES_DEFAULT; + drv->t_attrib =3D TEXT_ATTRIBUTES_DEFAULT; text_console_resize(s); =20 if (chr->label) { char *msg; =20 - s->t_attrib.bgcol =3D QEMU_COLOR_BLUE; + drv->t_attrib.bgcol =3D QEMU_COLOR_BLUE; msg =3D g_strdup_printf("%s console\r\n", chr->label); qemu_chr_write(chr, (uint8_t *)msg, strlen(msg), true); g_free(msg); - s->t_attrib =3D TEXT_ATTRIBUTES_DEFAULT; + drv->t_attrib =3D TEXT_ATTRIBUTES_DEFAULT; } =20 qemu_chr_be_event(chr, CHR_EVENT_OPENED); --=20 2.41.0