From nobody Thu Nov 28 11:04:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1693235487; cv=none; d=zohomail.com; s=zohoarc; b=XpqYr0XFZ31S0XKrs3fUDM5eqVucIub+/CQ/AcjbAgBpKT/uM1b84meN5ty8tx3AEs/a4xfEHs5HWl1z+gh1eri816iNfyeo+Ca0xqXqcJzG/fFxhKvN/Dm96/r0ZUaTBPvRo7j64v3nRHdhILDw92fodFn5ZU8T0UW1Uw+VIKg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693235487; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9A1Ac8lvMvOZ+zYwwmMvvd+L3KzIzXoKURP8CGpQUys=; b=JPKtMIKyIphCEaN6vvA5JIMm97v47M6s/OUnZKNpVoQKeQwwtLSF/VvyGtDB6z9XZcWMXZf2F+7sGCWBwi65Qbe0UGvrohIBsPTPUL7CsXnjFn2x30v6UrtRd3ZYQyOd37rbeKVIWr838tjLNI2/ym1ws9SK/C8aAzW7N4jJgtk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1693235487652190.4280488388871; Mon, 28 Aug 2023 08:11:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qadtM-0007i1-U9; Mon, 28 Aug 2023 11:11:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qadt3-0007U7-Qk; Mon, 28 Aug 2023 11:10:41 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qadsz-000477-Bb; Mon, 28 Aug 2023 11:10:40 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1c0d5b16aacso16833545ad.1; Mon, 28 Aug 2023 08:10:36 -0700 (PDT) Received: from fedlinux.. ([106.84.130.225]) by smtp.gmail.com with ESMTPSA id i19-20020a170902eb5300b001b8b26fa6c1sm7427456pli.115.2023.08.28.08.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 08:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693235435; x=1693840235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9A1Ac8lvMvOZ+zYwwmMvvd+L3KzIzXoKURP8CGpQUys=; b=df+OQQv7f+MG8r32WzfhEsVQiX+0PKc3pAZ8NtsIO/9YRtb5y6zPUWjujyEHUJiE6I 5Up75yloZbULhT/S6IJaoH55MerQHdiZJB5bTVJ4XXshCZVaa3MOf85AYn1EbAGNzO9n 5INPoy4zbZ9B+v3QitBPTP8U0hM3DQuP1vYcQnd2d/BGFwW2exsihcRCqbsIYkyz6F0Q 8r9pD/9ja1ojrD0yxwFASaOTGt6lz+8h15IeCyf0y3kiModPYilUM084qKiuizojNhRy bevr7jO92Gvic0ixLTun1cwOXllHMlzjHzp884KXUnAo6J22CqbEDbY+WDcrGlRWzsSw t7nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693235435; x=1693840235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9A1Ac8lvMvOZ+zYwwmMvvd+L3KzIzXoKURP8CGpQUys=; b=BfYnR0Xx/efFx4/0ZJ6YS6JzAFlU/dopeC2v2kBe5FPuOki6VvSi1oOj7sgE8cUN5q OEcXwKKEysV82yDDs9x9EPiHhLHcmHFrE81dcDBwGWyeSIbzb1T7g4/k5kZ0xaNX0UHi kAPqTk58YK6mD/1LJlL6S64Z40Kvi0fdvB85evy4tGjqB3Lqk1edGzHTVv882C4rAx8w DP8MkVzrgt0Y+sEM7mgjCRE9/DHdei9TlUXTG0WrLatcRIyEPHb5G9TApzpRcyj8cQzl ph3tMgYDaqSSBKfoQ88FzJG8CbkQbu0dw7x5fQLm6IywCpoJRWrvKq+Y5AtQtAl6PD0g ScrA== X-Gm-Message-State: AOJu0YwqsOxJbpdphDhKMCMInVO7ZgHTifKjxAFKunYEoeryU8LQvruE m0CfnTpbo90GH4vW1TfoHaGZd42O/8tTf9V9d5w= X-Google-Smtp-Source: AGHT+IE77VAW09tIfbLKzHjPN+BXJd2lqXVlpmHgQu+2FvSsXP7m1N9Zc6c29wJIzPa5aaGpy+ay9Q== X-Received: by 2002:a17:902:e741:b0:1c0:ad3c:c723 with SMTP id p1-20020a170902e74100b001c0ad3cc723mr15512041plf.10.1693235434216; Mon, 28 Aug 2023 08:10:34 -0700 (PDT) From: Sam Li To: qemu-devel@nongnu.org Cc: Kevin Wolf , dmitry.fomichev@wdc.com, Hanna Reitz , Markus Armbruster , Eric Blake , hare@suse.de, qemu-block@nongnu.org, stefanha@redhat.com, dlemoal@kernel.org, Sam Li Subject: [PATCH v3 3/4] qcow2: add zoned emulation capability Date: Mon, 28 Aug 2023 23:09:54 +0800 Message-Id: <20230828150955.3481-4-faithilikerun@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230828150955.3481-1-faithilikerun@gmail.com> References: <20230828150955.3481-1-faithilikerun@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=faithilikerun@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1693235488398100001 Content-Type: text/plain; charset="utf-8" By adding zone operations and zoned metadata, the zoned emulation capability enables full emulation support of zoned device using a qcow2 file. The zoned device metadata includes zone type, zoned device state and write pointer of each zone, which is stored to an array of unsigned integers. Each zone of a zoned device makes state transitions following the zone state machine. The zone state machine mainly describes five states, IMPLICIT OPEN, EXPLICIT OPEN, FULL, EMPTY and CLOSED. READ ONLY and OFFLINE states will generally be affected by device internal events. The operations on zones cause corresponding state changing. Zoned devices have a limit on zone resources, which puts constraints on write operations into zones. Signed-off-by: Sam Li --- block/qcow2.c | 657 ++++++++++++++++++++++++++++++++++++++++- block/qcow2.h | 2 + block/trace-events | 1 + docs/interop/qcow2.txt | 6 + 4 files changed, 664 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 7074bfc620..bc98d98c8e 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -194,6 +194,153 @@ qcow2_extract_crypto_opts(QemuOpts *opts, const char = *fmt, Error **errp) return cryptoopts_qdict; } =20 +#define QCOW2_ZT_IS_CONV(wp) (wp & 1ULL << 59) + +static inline int qcow2_get_wp(uint64_t wp) +{ + /* clear state and type information */ + return ((wp << 5) >> 5); +} + +static inline int qcow2_get_zs(uint64_t wp) +{ + return (wp >> 60); +} + +static inline void qcow2_set_zs(uint64_t *wp, BlockZoneState zs) +{ + uint64_t addr =3D qcow2_get_wp(*wp); + addr |=3D ((uint64_t)zs << 60); + *wp =3D addr; +} + +/* + * Perform a state assignment and a flush operation that writes the new wp + * value to the dedicated location of the disk file. + */ +static int qcow2_write_wp_at(BlockDriverState *bs, uint64_t *wp, + uint32_t index, BlockZoneState zs) { + BDRVQcow2State *s =3D bs->opaque; + uint64_t wpv =3D *wp; + int ret; + + qcow2_set_zs(wp, zs); + ret =3D bdrv_pwrite(bs->file, s->zoned_header.zonedmeta_offset + + sizeof(uint64_t) * index, sizeof(uint64_t), wp, 0); + + if (ret < 0) { + goto exit; + } + trace_qcow2_wp_tracking(index, qcow2_get_wp(*wp) >> BDRV_SECTOR_BITS); + return ret; + +exit: + *wp =3D wpv; + error_report("Failed to write metadata with file"); + return ret; +} + +static bool qcow2_check_active_zones(BlockDriverState *bs) +{ + BDRVQcow2State *s =3D bs->opaque; + + if (!s->zoned_header.max_active_zones) { + return true; + } + + if (s->nr_zones_exp_open + s->nr_zones_imp_open + s->nr_zones_closed + < s->zoned_header.max_active_zones) { + return true; + } + + return false; +} + +static int qcow2_check_open_zones(BlockDriverState *bs) +{ + BDRVQcow2State *s =3D bs->opaque; + int ret; + + if (!s->zoned_header.max_open_zones) { + return 0; + } + + if (s->nr_zones_exp_open + s->nr_zones_imp_open + < s->zoned_header.max_open_zones) { + return 0; + } + + if(s->nr_zones_imp_open && qcow2_check_active_zones(bs)) { + /* TODO: it takes O(n) time complexity (n =3D nr_zones). + * Optimizations required. */ + /* close one implicitly open zones to make it available */ + for (int i =3D s->zoned_header.nr_conv_zones; + i < bs->bl.nr_zones; ++i) { + uint64_t *wp =3D &bs->wps->wp[i]; + if (qcow2_get_zs(*wp) =3D=3D BLK_ZS_IOPEN) { + ret =3D qcow2_write_wp_at(bs, wp, i, BLK_ZS_CLOSED); + if (ret < 0) { + return ret; + } + bs->wps->wp[i] =3D *wp; + s->nr_zones_imp_open--; + s->nr_zones_closed++; + break; + } + } + return 0; + } + + return -EINVAL; +} + +/* + * The zoned device has limited zone resources of open, closed, active + * zones. + */ +static int qcow2_check_zone_resources(BlockDriverState *bs, + BlockZoneState zs) +{ + int ret =3D 0; + + switch (zs) { + case BLK_ZS_EMPTY: + if (!qcow2_check_active_zones(bs)) { + error_report("No enough active zones"); + return -EINVAL; + } + return ret; + case BLK_ZS_CLOSED: + ret =3D qcow2_check_open_zones(bs); + if (ret < 0) { + error_report("No enough open zones"); + return ret; + } + return ret; + default: + return -EINVAL; + } + +} + +static inline int qcow2_refresh_zonedmeta(BlockDriverState *bs) +{ + int ret; + BDRVQcow2State *s =3D bs->opaque; + uint64_t wps_size =3D s->zoned_header.zonedmeta_size; + g_autofree uint64_t *temp =3D NULL; + temp =3D g_new(uint64_t, wps_size); + ret =3D bdrv_pread(bs->file, s->zoned_header.zonedmeta_offset, + wps_size, temp, 0); + if (ret < 0) { + error_report("Can not read metadata"); + return ret; + } + + memcpy(s->wps->wp, temp, wps_size); + return 0; +} + /* * read qcow2 extension and fill bs * start reading from start_offset @@ -455,7 +602,19 @@ qcow2_read_extensions(BlockDriverState *bs, uint64_t s= tart_offset, be32_to_cpu(zoned_ext.max_active_zones); zoned_ext.max_append_sectors =3D be32_to_cpu(zoned_ext.max_append_sectors); + zoned_ext.zonedmeta_offset =3D + be64_to_cpu(zoned_ext.zonedmeta_offset); + zoned_ext.zonedmeta_size =3D be64_to_cpu(zoned_ext.zonedmeta_s= ize); s->zoned_header =3D zoned_ext; + s->wps =3D g_malloc(sizeof(BlockZoneWps) + + s->zoned_header.zonedmeta_size); + ret =3D qcow2_refresh_zonedmeta(bs); + if (ret < 0) { + error_setg_errno(errp, -ret, "zonedmeta: " + "Could not update zoned meta"= ); + return ret; + } + qemu_co_mutex_init(&s->wps->colock); =20 /* refuse to open broken images */ if (zoned_ext.zone_size =3D=3D 0) { @@ -2716,9 +2875,26 @@ qcow2_co_pwritev_part(BlockDriverState *bs, int64_t = offset, int64_t bytes, uint64_t host_offset; QCowL2Meta *l2meta =3D NULL; AioTaskPool *aio =3D NULL; + int64_t start_offset, start_bytes; + BlockZoneState zs; + int64_t end; + uint64_t *wp; + int64_t zone_size =3D bs->bl.zone_size; + int index; =20 trace_qcow2_writev_start_req(qemu_coroutine_self(), offset, bytes); =20 + start_offset =3D offset; + start_bytes =3D bytes; + /* The offset should not less than the wp of that + * zone where offset starts. */ + if (zone_size) { + index =3D start_offset / zone_size; + wp =3D &bs->wps->wp[index]; + if (offset < qcow2_get_wp(*wp)) { + return -EINVAL; + } + } while (bytes !=3D 0 && aio_task_pool_status(aio) =3D=3D 0) { =20 l2meta =3D NULL; @@ -2764,6 +2940,47 @@ qcow2_co_pwritev_part(BlockDriverState *bs, int64_t = offset, int64_t bytes, qiov_offset +=3D cur_bytes; trace_qcow2_writev_done_part(qemu_coroutine_self(), cur_bytes); } + + if (zone_size) { + index =3D start_offset / zone_size; + wp =3D &bs->wps->wp[index]; + uint64_t wpv =3D *wp; + if (!QCOW2_ZT_IS_CONV(wpv)) { + /* + * Implicitly open one closed zone to write if there are zone = resources + * left. + */ + zs =3D qcow2_get_zs(wpv); + if (zs =3D=3D BLK_ZS_CLOSED || zs =3D=3D BLK_ZS_EMPTY) { + ret =3D qcow2_check_zone_resources(bs, zs); + if (ret < 0) { + goto fail_nometa; + } + + if (zs =3D=3D BLK_ZS_CLOSED) { + s->nr_zones_closed--; + s->nr_zones_imp_open++; + } else { + s->nr_zones_imp_open++; + } + } + + /* align up (start_offset, zone_size), the start offset is not + * necessarily power of two. */ + end =3D ((start_offset + zone_size) / zone_size) * zone_size; + if (start_offset + start_bytes <=3D end) { + *wp =3D start_offset + start_bytes; + } else { + ret =3D -EINVAL; + goto fail_nometa; + } + + ret =3D qcow2_write_wp_at(bs, wp, index,BLK_ZS_IOPEN); + if (ret < 0) { + goto fail_nometa; + } + } + } ret =3D 0; =20 qemu_co_mutex_lock(&s->lock); @@ -3160,7 +3377,9 @@ int qcow2_update_header(BlockDriverState *bs) .max_active_zones =3D cpu_to_be32(s->zoned_header.max_active_zones), .max_append_sectors =3D - cpu_to_be32(s->zoned_header.max_append_sectors) + cpu_to_be32(s->zoned_header.max_append_sectors), + .zonedmeta_offset =3D cpu_to_be64(s->zoned_header.zonedmeta_= offset), + .zonedmeta_size =3D cpu_to_be64(s->zoned_header.zonedmeta_= size) }; ret =3D header_ext_add(buf, QCOW2_EXT_MAGIC_ZONED_FORMAT, &zoned_header, sizeof(zoned_header), @@ -3565,7 +3784,8 @@ qcow2_co_create(BlockdevCreateOptions *create_options= , Error **errp) int version; int refcount_order; uint64_t *refcount_table; - int ret; + uint64_t zoned_meta_size, zoned_clusterlen; + int ret, offset, i; uint8_t compression_type =3D QCOW2_COMPRESSION_TYPE_ZLIB; =20 assert(create_options->driver =3D=3D BLOCKDEV_DRIVER_QCOW2); @@ -3901,6 +4121,49 @@ qcow2_co_create(BlockdevCreateOptions *create_option= s, Error **errp) } } s->zoned_header.max_append_sectors =3D qcow2_opts->max_append_sect= ors; + + uint32_t nrz =3D s->zoned_header.nr_zones; + zoned_meta_size =3D sizeof(uint64_t) * nrz; + g_autofree uint64_t *meta =3D NULL; + meta =3D g_new0(uint64_t, nrz); + + for (i =3D 0; i < s->zoned_header.nr_conv_zones; ++i) { + meta[i] =3D i * s->zoned_header.zone_size; + meta[i] |=3D 1ULL << 59; + } + + for (; i < nrz; ++i) { + meta[i] =3D i * s->zoned_header.zone_size; + /* For sequential zones, the first four most significant bit + * indicates zone states. */ + meta[i] |=3D ((uint64_t)BLK_ZS_EMPTY << 60); + } + + offset =3D qcow2_alloc_clusters(blk_bs(blk), zoned_meta_size); + if (offset < 0) { + error_setg_errno(errp, -offset, "Could not allocate clusters " + "for zoned metadata size"); + goto out; + } + s->zoned_header.zonedmeta_offset =3D offset; + s->zoned_header.zonedmeta_size =3D zoned_meta_size; + + zoned_clusterlen =3D size_to_clusters(s, zoned_meta_size) + * s->cluster_size; + assert(qcow2_pre_write_overlap_check(bs, 0, offset, + zoned_clusterlen,false) =3D= =3D 0); + ret =3D bdrv_pwrite_zeroes(blk_bs(blk)->file, offset, + zoned_clusterlen, 0); + if (ret < 0) { + error_setg_errno(errp, -ret, "Could not zero fill zoned metada= ta"); + goto out; + } + ret =3D bdrv_pwrite(blk_bs(blk)->file, offset, zoned_meta_size, me= ta, 0); + if (ret < 0) { + error_setg_errno(errp, -ret, "Could not write zoned metadata " + "to disk"); + goto out; + } } else { s->zoned_header.zoned =3D BLK_Z_NONE; } @@ -4239,6 +4502,392 @@ static coroutine_fn int qcow2_co_pdiscard(BlockDriv= erState *bs, return ret; } =20 +static int coroutine_fn +qcow2_co_zone_report(BlockDriverState *bs, int64_t offset, + unsigned int *nr_zones, BlockZoneDescriptor *zones) +{ + BDRVQcow2State *s =3D bs->opaque; + uint64_t zone_size =3D s->zoned_header.zone_size; + int64_t capacity =3D bs->total_sectors << BDRV_SECTOR_BITS; + int64_t size =3D bs->bl.nr_zones * zone_size; + unsigned int nrz =3D *nr_zones; + int i =3D 0; + int si; + + if (offset >=3D capacity) { + error_report("offset %" PRId64 " is equal to or greater than the" + "device capacity %" PRId64 "", offset, capacity); + return -EINVAL; + } + + if (nrz > bs->bl.nr_zones) { + error_report("nr_zones %" PRId32 " should not exceed the device zo= nes" + "%" PRId32 "", nrz, bs->bl.nr_zones); + return -EINVAL; + } + + if (zone_size > 0) { + si =3D offset / zone_size; + qemu_co_mutex_lock(&bs->wps->colock); + for (; i < nrz; ++i) { + if (i + si >=3D bs->bl.nr_zones) { + break; + } + + zones[i].start =3D (si + i) * zone_size; + + /* The last zone can be smaller than the zone size */ + if ((si + i + 1) =3D=3D bs->bl.nr_zones && size > capacity) { + uint32_t l =3D zone_size - (size - capacity); + zones[i].length =3D l; + zones[i].cap =3D l; + } else { + zones[i].length =3D zone_size; + zones[i].cap =3D zone_size; + } + + uint64_t wp =3D bs->wps->wp[si + i]; + if (QCOW2_ZT_IS_CONV(wp)) { + zones[i].type =3D BLK_ZT_CONV; + zones[i].state =3D BLK_ZS_NOT_WP; + /* Clear the zone type bit */ + wp &=3D ~(1ULL << 59); + } else { + zones[i].type =3D BLK_ZT_SWR; + zones[i].state =3D qcow2_get_zs(wp); + /* Clear the zone state bits */ + wp =3D qcow2_get_wp(wp); + } + zones[i].wp =3D wp; + } + qemu_co_mutex_unlock(&bs->wps->colock); + } + *nr_zones =3D i; + return 0; +} + +static int qcow2_open_zone(BlockDriverState *bs, uint32_t index) { + BDRVQcow2State *s =3D bs->opaque; + int ret; + + qemu_co_mutex_lock(&bs->wps->colock); + uint64_t *wp =3D &bs->wps->wp[index]; + BlockZoneState zs =3D qcow2_get_zs(*wp); + + switch(zs) { + case BLK_ZS_EMPTY: + ret =3D qcow2_check_zone_resources(bs, BLK_ZS_EMPTY); + if (ret < 0) { + goto unlock; + } + break; + case BLK_ZS_IOPEN: + s->nr_zones_imp_open--; + break; + case BLK_ZS_EOPEN: + return 0; + case BLK_ZS_CLOSED: + ret =3D qcow2_check_zone_resources(bs, BLK_ZS_CLOSED); + if (ret < 0) { + goto unlock; + } + s->nr_zones_closed--; + break; + case BLK_ZS_FULL: + break; + default: + ret =3D -EINVAL; + goto unlock; + } + ret =3D qcow2_write_wp_at(bs, wp, index, BLK_ZS_EOPEN); + if (!ret) { + s->nr_zones_exp_open++; + } + +unlock: + qemu_co_mutex_unlock(&bs->wps->colock); + return ret; +} + +static int qcow2_close_zone(BlockDriverState *bs, uint32_t index) { + BDRVQcow2State *s =3D bs->opaque; + int ret; + + qemu_co_mutex_lock(&bs->wps->colock); + uint64_t *wp =3D &bs->wps->wp[index]; + BlockZoneState zs =3D qcow2_get_zs(*wp); + + switch(zs) { + case BLK_ZS_EMPTY: + break; + case BLK_ZS_IOPEN: + s->nr_zones_imp_open--; + break; + case BLK_ZS_EOPEN: + s->nr_zones_exp_open--; + break; + case BLK_ZS_CLOSED: + ret =3D qcow2_check_zone_resources(bs, BLK_ZS_CLOSED); + if (ret < 0) { + goto unlock; + } + s->nr_zones_closed--; + break; + case BLK_ZS_FULL: + break; + default: + ret =3D -EINVAL; + goto unlock; + } + + if (zs =3D=3D BLK_ZS_EMPTY) { + ret =3D qcow2_write_wp_at(bs, wp, index, BLK_ZS_EMPTY); + } else { + ret =3D qcow2_write_wp_at(bs, wp, index, BLK_ZS_CLOSED); + if (!ret) { + s->nr_zones_closed++; + } + } + +unlock: + qemu_co_mutex_unlock(&bs->wps->colock); + return ret; +} + +static int qcow2_finish_zone(BlockDriverState *bs, uint32_t index) { + BDRVQcow2State *s =3D bs->opaque; + int ret; + + qemu_co_mutex_lock(&bs->wps->colock); + uint64_t *wp =3D &bs->wps->wp[index]; + BlockZoneState zs =3D qcow2_get_zs(*wp); + + switch(zs) { + case BLK_ZS_EMPTY: + ret =3D qcow2_check_zone_resources(bs, BLK_ZS_EMPTY); + if (ret < 0) { + goto unlock; + } + break; + case BLK_ZS_IOPEN: + s->nr_zones_imp_open--; + break; + case BLK_ZS_EOPEN: + s->nr_zones_exp_open--; + break; + case BLK_ZS_CLOSED: + ret =3D qcow2_check_zone_resources(bs, BLK_ZS_CLOSED); + if (ret < 0) { + goto unlock; + } + s->nr_zones_closed--; + break; + case BLK_ZS_FULL: + ret =3D 0; + goto unlock; + default: + ret =3D -EINVAL; + goto unlock; + } + + *wp =3D ((uint64_t)index + 1) * s->zoned_header.zone_size; + ret =3D qcow2_write_wp_at(bs, wp, index, BLK_ZS_FULL); + +unlock: + qemu_co_mutex_unlock(&bs->wps->colock); + return ret; +} + +static int qcow2_reset_zone(BlockDriverState *bs, uint32_t index, + int64_t len) { + BDRVQcow2State *s =3D bs->opaque; + int nrz =3D bs->bl.nr_zones; + int zone_size =3D bs->bl.zone_size; + int n, ret =3D 0; + + qemu_co_mutex_lock(&bs->wps->colock); + uint64_t *wp =3D &bs->wps->wp[index]; + if (len =3D=3D bs->total_sectors << BDRV_SECTOR_BITS) { + n =3D nrz; + index =3D 0; + } else { + n =3D len / zone_size; + } + + for (int i =3D 0; i < n; ++i) { + uint64_t *wp_i =3D (uint64_t *)(wp + i); + uint64_t wpi_v =3D *wp_i; + if (QCOW2_ZT_IS_CONV(wpi_v)) { + continue; + } + =20 + BlockZoneState zs =3D qcow2_get_zs(wpi_v); + switch (zs) { + case BLK_ZS_EMPTY: + break; + case BLK_ZS_IOPEN: + s->nr_zones_imp_open--; + break; + case BLK_ZS_EOPEN: + s->nr_zones_exp_open--; + break; + case BLK_ZS_CLOSED: + s->nr_zones_closed--; + break; + case BLK_ZS_FULL: + break; + default: + ret =3D -EINVAL; + goto unlock; + } + + if (zs =3D=3D BLK_ZS_EMPTY) { + continue; + } + + *wp_i =3D ((uint64_t)index + i) * zone_size; + ret =3D qcow2_write_wp_at(bs, wp_i, index + i, BLK_ZS_EMPTY); + if (ret < 0) { + goto unlock; + } + /* clear data */ + ret =3D qcow2_co_pwrite_zeroes(bs, qcow2_get_wp(*wp_i), zone_size,= 0); + if (ret < 0) { + error_report("Failed to reset zone at 0x%" PRIx64 "", *wp_i); + } + } + +unlock: + qemu_co_mutex_unlock(&bs->wps->colock); + return ret; +} + +static int coroutine_fn qcow2_co_zone_mgmt(BlockDriverState *bs, BlockZone= Op op, + int64_t offset, int64_t len) +{ + BDRVQcow2State *s =3D bs->opaque; + int ret =3D 0; + int64_t capacity =3D bs->total_sectors << BDRV_SECTOR_BITS; + int64_t zone_size =3D s->zoned_header.zone_size; + int64_t zone_size_mask =3D zone_size - 1; + uint32_t index =3D offset / zone_size; + BlockZoneWps *wps =3D bs->wps; + + if (offset >=3D capacity) { + error_report("offset %" PRId64 " is equal to or greater than the" + "device capacity %" PRId64 "", offset, capacity); + return -EINVAL; + } + + if (offset & zone_size_mask) { + error_report("sector offset %" PRId64 " is not aligned to zone siz= e" + " %" PRId64 "", offset / 512, zone_size / 512); + return -EINVAL; + } + + if (((offset + len) < capacity && len & zone_size_mask) || + offset + len > capacity) { + error_report("number of sectors %" PRId64 " is not aligned to zone" + " size %" PRId64 "", len / 512, zone_size / 512); + return -EINVAL; + } + + qemu_co_mutex_lock(&wps->colock); + uint64_t wpv =3D wps->wp[index]; + if (QCOW2_ZT_IS_CONV(wpv) && len !=3D capacity) { + error_report("zone mgmt operations are not allowed for " + "conventional zones"); + ret =3D -EIO; + goto unlock; + } + qemu_co_mutex_unlock(&wps->colock); + + switch(op) { + case BLK_ZO_OPEN: + ret =3D qcow2_open_zone(bs, index); + break; + case BLK_ZO_CLOSE: + ret =3D qcow2_close_zone(bs, index); + break; + case BLK_ZO_FINISH: + ret =3D qcow2_finish_zone(bs, index); + break; + case BLK_ZO_RESET: + ret =3D qcow2_reset_zone(bs, index, len); + break; + default: + error_report("Unsupported zone op: 0x%x", op); + ret =3D -ENOTSUP; + break; + } + return ret; + +unlock: + qemu_co_mutex_unlock(&wps->colock); + return ret; +} + +static int coroutine_fn +qcow2_co_zone_append(BlockDriverState *bs, int64_t *offset, QEMUIOVector *= qiov, + BdrvRequestFlags flags) +{ + assert(flags =3D=3D 0); + int64_t capacity =3D bs->total_sectors << BDRV_SECTOR_BITS; + uint32_t index; + int ret; + int64_t zone_size_mask =3D bs->bl.zone_size - 1; + int64_t iov_len =3D 0; + int64_t len =3D 0; + + if (*offset >=3D capacity) { + error_report("*offset %" PRId64 " is equal to or greater than the" + "device capacity %" PRId64 "", *offset, capacity); + return -EINVAL; + } + + /* offset + len should not pass the end of that zone starting from off= set */ + if (*offset & zone_size_mask) { + error_report("sector offset %" PRId64 " is not aligned to zone siz= e " + "%" PRId32 "", *offset / 512, bs->bl.zone_size / 512); + return -EINVAL; + } + + int64_t wg =3D bs->bl.write_granularity; + int64_t wg_mask =3D wg - 1; + for (int i =3D 0; i < qiov->niov; i++) { + iov_len =3D qiov->iov[i].iov_len; + if (iov_len & wg_mask) { + error_report("len of IOVector[%d] %" PRId64 " is not aligned t= o " + "block size %" PRId64 "", i, iov_len, wg); + return -EINVAL; + } + } + len =3D qiov->size; + index =3D *offset / bs->bl.zone_size; + + if ((len >> BDRV_SECTOR_BITS) > bs->bl.max_append_sectors) { + return -ENOTSUP; + } + + qemu_co_mutex_lock(&bs->wps->colock); + uint64_t wp =3D bs->wps->wp[index]; + uint64_t wp_i =3D qcow2_get_wp(wp); + ret =3D qcow2_co_pwritev_part(bs, wp_i, len, qiov, 0, 0); + if (ret =3D=3D 0) { + *offset =3D wp_i; + /* the zone state is set to full when the wp reaches the end */ + uint64_t wp_final =3D bs->wps->wp[index]; + if (!(qcow2_get_wp(wp_final) & zone_size_mask)) { + ret =3D qcow2_write_wp_at(bs, &wp_final, index, BLK_ZS_FULL); + } + } else { + error_report("qcow2: zap failed"); + } + + qemu_co_mutex_unlock(&bs->wps->colock); + return ret; +} + static int coroutine_fn GRAPH_RDLOCK qcow2_co_copy_range_from(BlockDriverState *bs, BdrvChild *src, int64_t src_offset, @@ -6287,6 +6936,10 @@ BlockDriver bdrv_qcow2 =3D { .bdrv_co_pwritev_part =3D qcow2_co_pwritev_part, .bdrv_co_flush_to_os =3D qcow2_co_flush_to_os, =20 + .bdrv_co_zone_report =3D qcow2_co_zone_report, + .bdrv_co_zone_mgmt =3D qcow2_co_zone_mgmt, + .bdrv_co_zone_append =3D qcow2_co_zone_append, + .bdrv_co_pwrite_zeroes =3D qcow2_co_pwrite_zeroes, .bdrv_co_pdiscard =3D qcow2_co_pdiscard, .bdrv_co_copy_range_from =3D qcow2_co_copy_range_from, diff --git a/block/qcow2.h b/block/qcow2.h index edb8eebcb3..b1930ddbd2 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -247,6 +247,8 @@ typedef struct Qcow2ZonedHeaderExtension { uint32_t max_active_zones; uint32_t max_open_zones; uint32_t max_append_sectors; + uint64_t zonedmeta_offset; + uint64_t zonedmeta_size; } QEMU_PACKED Qcow2ZonedHeaderExtension; =20 typedef struct Qcow2UnknownHeaderExtension { diff --git a/block/trace-events b/block/trace-events index 6f121b7636..06af0c79fb 100644 --- a/block/trace-events +++ b/block/trace-events @@ -82,6 +82,7 @@ qcow2_writev_data(void *co, uint64_t offset) "co %p offse= t 0x%" PRIx64 qcow2_pwrite_zeroes_start_req(void *co, int64_t offset, int64_t bytes) "co= %p offset 0x%" PRIx64 " bytes %" PRId64 qcow2_pwrite_zeroes(void *co, int64_t offset, int64_t bytes) "co %p offset= 0x%" PRIx64 " bytes %" PRId64 qcow2_skip_cow(void *co, uint64_t offset, int nb_clusters) "co %p offset 0= x%" PRIx64 " nb_clusters %d" +qcow2_wp_tracking(int index, uint64_t wp) "wps[%d]: 0x%" PRIx64 =20 # qcow2-cluster.c qcow2_alloc_clusters_offset(void *co, uint64_t offset, int bytes) "co %p o= ffset 0x%" PRIx64 " bytes %d" diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index 80ff03a826..e4002b443c 100644 --- a/docs/interop/qcow2.txt +++ b/docs/interop/qcow2.txt @@ -367,6 +367,12 @@ The fields of the zoned extension are: The maximal data size in sectors of a zone append request that can be issued to the device. =20 + 36 - 43: zonedmeta_offset + The offset of zoned metadata structure in the file in = bytes. + + 44 - 51: zonedmeta_size + The size of zoned metadata in bytes. + =3D=3D Full disk encryption header pointer =3D=3D =20 The full disk encryption header must be present if, and only if, the --=20 2.40.1