From nobody Thu Nov 28 08:38:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=swemel.ru ARC-Seal: i=1; a=rsa-sha256; t=1692964951; cv=none; d=zohomail.com; s=zohoarc; b=CyyvKwVhTub4vZeQM/SR59Hy0oKsmfjTUkKAb850xbeYXf6bG0/Ec8yvVthBvfL4dHo8KlZLed/4b9fcg5+pD8mBc1TZZkugThGkw97DwDyigHYKc7/+TnV2EfMXhNACBnFlyNQXpu8XURKLMTkpgAplUQT7rZqp9FRaYMJWlko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692964951; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=wdhQsie481OSJQDBF+B2VeHjsKtO9y9HcfuRQtdd90E=; b=KNRPj6hXhBa5pxlL3laZ87DztgeTlgFIPwWsD7A2SZk/5yGqdWZEsldutNLcmEHNVCMyB6KjUQ//S0eB0V/bE1klZm8wCtmDqwUcp9FQBLXI/qv+2nyAM9LwvfApmPA6zeHFItv9kOM+Ozs1Mkb8NpJIdT0Ak8zUx3tCxFxOmBc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1692964951100417.0558701608526; Fri, 25 Aug 2023 05:02:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZVVP-0007bo-Dd; Fri, 25 Aug 2023 08:01:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZVVM-0007bd-US for qemu-devel@nongnu.org; Fri, 25 Aug 2023 08:01:33 -0400 Received: from mx.swemel.ru ([95.143.211.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZVVJ-0000W1-Jd for qemu-devel@nongnu.org; Fri, 25 Aug 2023 08:01:32 -0400 From: Dmitry Frolov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1692964884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wdhQsie481OSJQDBF+B2VeHjsKtO9y9HcfuRQtdd90E=; b=v9EqbnQx8uMPEjYNkCQmkNTIhIXVjI5IHmS8fNT/KrDSP++J0PbnXLjB0s5u71xePK9NGg MkbFk/bZIQN7xV7unoK4zBZ4sPo/z4frqLAZuhPteHnquO80ZQgGkY6/n2Gda+ZlWRQYKK sMJbLBWxSQVNizEuYzgtt9iNfo2NubM= To: kraxel@redhat.com, marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: sdl.qemu@linuxtesting.org, Dmitry Frolov Subject: [PATCH] fix leaks found wtih fuzzing Date: Fri, 25 Aug 2023 14:58:19 +0300 Message-Id: <20230825115818.1091936-1-frolov@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=95.143.211.150; envelope-from=frolov@swemel.ru; helo=mx.swemel.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @swemel.ru) X-ZM-MESSAGEID: 1692964957167100001 Content-Type: text/plain; charset="utf-8" It is true, that there is no problem during runtime from the first sight, because the memory is lost just before qemu exits. Nevertheless, this change is necessary, because AddressSanitizer is not able to recognize this situation and produces crash-report (which is false-positive in fact). Lots of False-Positive warnings are davaluing problems, found with fuzzing, and thus the whole methodology of dynamic analysis. This patch eliminates such False-Positive reports, and makes every problem, found with fuzzing, more valuable. Fixes: 060ab76356 ("gtk: don't exit early in case gtk init fails") Signed-off-by: Dmitry Frolov Reviewed-by: Michael Tokarev --- v2: Moved declarations in the beginning. v3: Fixed errors in v2. ui/gtk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 8ba41c8f13..7db972732b 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -2360,7 +2360,7 @@ static void gtk_display_init(DisplayState *ds, Displa= yOptions *opts) { VirtualConsole *vc; =20 - GtkDisplayState *s =3D g_malloc0(sizeof(*s)); + GtkDisplayState *s; GdkDisplay *window_display; GtkIconTheme *theme; char *dir; @@ -2370,6 +2370,7 @@ static void gtk_display_init(DisplayState *ds, Displa= yOptions *opts) exit(1); } assert(opts->type =3D=3D DISPLAY_TYPE_GTK); + s =3D g_malloc0(sizeof(*s)); s->opts =3D opts; =20 theme =3D gtk_icon_theme_get_default(); --=20 2.34.1