From nobody Wed Feb 11 02:14:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1692193331; cv=none; d=zohomail.com; s=zohoarc; b=TxIdF0MhTil+OjjlyblQ/tCHF6lwqyCyBcFa6Ev+XL3UblG1vLJxmtINdtIULMF76XgjHA4ehV8nxl7pTqK/YLJi54P4SOHIpT2ahD8Ku8fpp2EokvZRYAqddvAamXjdeA92pfo3VA3yGeLIb+RnDhPfLxNjA7R4/XhFLratqRM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692193331; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=J9NUjmmUVHXy03kGyd299wa55TND6+t1PgSeJs0BSLU=; b=Q3hjujXjiLCqjMuQlztBp6Vn63o76RnMCmr1oxNwpnxB1ly1YiCpnf3J6jwJTVgERpfBPyzynhgxv73mSgcv28Sx0hf4kWQXpucqIgjHNF08Mqe4aPJPlK3me3objzeDTTtFobUcIT1NTsi6mq83Qpn0K/DTNu7Z5ifqPGHyOQ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1692193331614465.90215979043774; Wed, 16 Aug 2023 06:42:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWGm9-0005Yz-QX; Wed, 16 Aug 2023 09:41:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWGlz-0005UX-PC for qemu-devel@nongnu.org; Wed, 16 Aug 2023 09:41:23 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWGlw-000179-Bx for qemu-devel@nongnu.org; Wed, 16 Aug 2023 09:41:19 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6889288a31fso353326b3a.1 for ; Wed, 16 Aug 2023 06:41:15 -0700 (PDT) Received: from alarm.flets-east.jp ([2400:4050:a840:1e00:78d2:b862:10a7:d486]) by smtp.gmail.com with ESMTPSA id k3-20020a637b43000000b0056601f864aesm928355pgn.2.2023.08.16.06.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 06:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1692193275; x=1692798075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J9NUjmmUVHXy03kGyd299wa55TND6+t1PgSeJs0BSLU=; b=hJ3MtACN1nsYq7/mQuEIGAyZ6Xu+bHrXQmY69YkIEWwkBy9gSDTe/8KWy++BTsnj94 GsumDoEGwNqEXtb9HUo6TK3QdOsiIvrzaaacFhxO+mXdSbgoUngZh5LA6hvJL9vBOXwS i2HNr/lik65Jc0FOO6LBbfNnwDWZhAAbCqlx4A8Ivg3k+oT6VJo0hbe0OOEXDX+axQ7w MxKfEMuiadaaa063XGdvse5ytKZfMctm0CRAsmQYoiVzuW67VF8a3G91DxhcJIxjeppk jqk6zTLH0D7qCuJnJzsv8uUhq1bd822+ddcxxW6BpBO1hI8m7rEgB+9MwevjkzSBA6dM A5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692193275; x=1692798075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J9NUjmmUVHXy03kGyd299wa55TND6+t1PgSeJs0BSLU=; b=a/pdI4+58NdvWOXcFmfsdDQA75Imp/xT573taPn46ICtKJ3PJxLek4zKMeU0XJBo0+ gdLNxJUiswBO8b37x0i9klIbnv8BN8I2JpjzqTsg84VXEgsJy8+tNDYR/qFBWbhRee1K 7QZBKNczeeDaDst12CUJTuR9E/AzCyQwRJAie7sG7rW+flLzPjm1d8fH3CVElrUDpI6+ qZiSL57Fp+uRH0OrrVIMYxg5w7GpVt6P++Kkzj4hADB9ATYUlKi1TVhdOh6xK6FozDFk 7PRakHhmuwJAkVqlpXABBXhos91UIXLKanQL3c8373oa4JPkyT3drXekIn6z458Kqpoz 0xNw== X-Gm-Message-State: AOJu0YxLX4sxTm+F7GJ5gXXDvy5kg1N6UooPl28pvb9h7a2a4FFApxCD rR4qptQTi/oa6evpF/aReXxdGw== X-Google-Smtp-Source: AGHT+IHIYHv/NqJ9AysQA1Z2e/44Ks9b3BqgNgwtM+Rpgb/FcX0fjx+O4zRWsadS63qu4efnBJeojQ== X-Received: by 2002:a05:6a00:23d5:b0:666:c1ab:d6e5 with SMTP id g21-20020a056a0023d500b00666c1abd6e5mr2386984pfc.16.1692193275064; Wed, 16 Aug 2023 06:41:15 -0700 (PDT) From: Akihiko Odaki To: Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth , Alexandre Iooss , Mahmoud Mandour , Eduardo Habkost , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yanan Wang , Richard Henderson , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , John Snow , Cleber Rosa , Peter Maydell , Michael Rolnik , "Edgar E . Iglesias" , Brian Cain , Song Gao , Xiaojuan Yang , Laurent Vivier , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo , Chris Wulff , Marek Vasut , Stafford Horne , Daniel Henrique Barboza , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Greg Kurz , Nicholas Piggin , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Liu Zhiwei , Yoshinori Sato , David Hildenbrand , Ilya Leoshkevich , Mark Cave-Ayland , Artyom Tarasenko , Bastian Koppelmann , Max Filippov , qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, Anton Kochkov , Akihiko Odaki Subject: [PATCH v3 07/25] gdbstub: Introduce GDBFeatureBuilder Date: Wed, 16 Aug 2023 22:39:17 +0900 Message-ID: <20230816133938.18310-8-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230816133938.18310-1-akihiko.odaki@daynix.com> References: <20230816133938.18310-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::435; envelope-from=akihiko.odaki@daynix.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1692193333413100003 Content-Type: text/plain; charset="utf-8" GDBFeatureBuilder unifies the logic to generate dynamic GDBFeature. Signed-off-by: Akihiko Odaki --- include/exec/gdbstub.h | 20 ++++++++++++++ gdbstub/gdbstub.c | 59 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 79 insertions(+) diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index d0dcc99ed4..1f4608d4f9 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -16,6 +16,11 @@ typedef struct GDBFeature { int num_regs; } GDBFeature; =20 +typedef struct GDBFeatureBuilder { + GDBFeature *feature; + GPtrArray *xml; +} GDBFeatureBuilder; + =20 /* Get or set a register. Returns the size of the register. */ typedef int (*gdb_get_reg_cb)(CPUArchState *env, GByteArray *buf, int reg); @@ -34,6 +39,21 @@ void gdb_register_coprocessor(CPUState *cpu, */ int gdbserver_start(const char *port_or_device); =20 +void gdb_feature_builder_init(GDBFeatureBuilder *builder, GDBFeature *feat= ure, + const char *name, const char *xmlname); + +void gdb_feature_builder_append_tag(const GDBFeatureBuilder *builder, + const char *format, ...) + G_GNUC_PRINTF(2, 3); + +void gdb_feature_builder_append_reg(const GDBFeatureBuilder *builder, + const char *name, + int bitsize, + const char *type, + const char *group); + +void gdb_feature_builder_end(const GDBFeatureBuilder *builder); + const GDBFeature *gdb_find_static_feature(const char *xmlname); =20 void gdb_set_stop_cpu(CPUState *cpu); diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 293e8ea439..32e88de431 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -414,6 +414,65 @@ static const char *get_feature_xml(const char *p, cons= t char **newp, return name ? gdb_static_features[i].xml : NULL; } =20 +void gdb_feature_builder_init(GDBFeatureBuilder *builder, GDBFeature *feat= ure, + const char *name, const char *xmlname) +{ + char *header =3D g_markup_printf_escaped( + "" + "" + "", + name); + + builder->feature =3D feature; + builder->xml =3D g_ptr_array_new(); + g_ptr_array_add(builder->xml, header); + feature->xmlname =3D xmlname; + feature->num_regs =3D 0; +} + +void gdb_feature_builder_append_tag(const GDBFeatureBuilder *builder, + const char *format, ...) +{ + va_list ap; + va_start(ap, format); + g_ptr_array_add(builder->xml, g_markup_vprintf_escaped(format, ap)); + va_end(ap); +} + +void gdb_feature_builder_append_reg(const GDBFeatureBuilder *builder, + const char *name, + int bitsize, + const char *type, + const char *group) +{ + if (group) { + gdb_feature_builder_append_tag( + builder, + "", + name, bitsize, type, group); + } else { + gdb_feature_builder_append_tag( + builder, "", + name, bitsize, type); + } + + builder->feature->num_regs++; +} + +void gdb_feature_builder_end(const GDBFeatureBuilder *builder) +{ + g_ptr_array_add(builder->xml, (void *)""); + g_ptr_array_add(builder->xml, NULL); + + builder->feature->xml =3D g_strjoinv(NULL, (void *)builder->xml->pdata= ); + + for (guint i =3D 0; i < builder->xml->len - 2; i++) { + g_free(g_ptr_array_index(builder->xml, i)); + } + + g_ptr_array_free(builder->xml, TRUE); +} + const GDBFeature *gdb_find_static_feature(const char *xmlname) { const GDBFeature *feature; --=20 2.41.0