From nobody Thu Nov 14 07:10:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1692139217; cv=none; d=zohomail.com; s=zohoarc; b=R37oqqw1eHLg9St2NyL+1+20iMj+Ti4eOe0TFgN6AbljjRuKmxCSX00Mb5WZHlWT7izD4tniYD2sW5I3QXA5Or0doZvXD3+hD+9fI+DYfHsg0UTryccmGAZUXMQe+sS3KJLzRlg9la0AL9ZcPMWPst1pWCHWvB7/v1/JT52YYiY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692139217; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H4pnnHXPSSjR2BrIC+lFb47RzccWp4/dbdlHeRAoFGs=; b=GH/tgMfWOx7lE6SHBz09p5iPPiFHXeb1AG/OGZmxtSwdpcneK31Gvo0BGf+ntJ2T17LrlJhZVjRRYUcps9pg1SkkCiGiegPmHgcfOFkq5nbOtPe64OhFapUBy/V72oNnM0fJIqZcY72PnhREPxnM5Zk1GL8NgiFk849TQwmfC9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16921392178713.4102657572977932; Tue, 15 Aug 2023 15:40:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qW2gV-0005NT-07; Tue, 15 Aug 2023 18:38:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW2gM-0005CX-6x for qemu-devel@nongnu.org; Tue, 15 Aug 2023 18:38:34 -0400 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qW2gF-0006MM-15 for qemu-devel@nongnu.org; Tue, 15 Aug 2023 18:38:31 -0400 Received: by mail-oi1-x234.google.com with SMTP id 5614622812f47-3a751d2e6ecso5016741b6e.0 for ; Tue, 15 Aug 2023 15:38:25 -0700 (PDT) Received: from grind.. (189-69-160-189.dial-up.telesp.net.br. [189.69.160.189]) by smtp.gmail.com with ESMTPSA id be15-20020a056808218f00b003a40b3fce01sm5903418oib.10.2023.08.15.15.38.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 15:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1692139104; x=1692743904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H4pnnHXPSSjR2BrIC+lFb47RzccWp4/dbdlHeRAoFGs=; b=Zi9UwB/rTwnhnxKJ8Th1/cMqzdD6UZVIP/UGk3mWgUGrZHaNXW1O2wjdUp4OuHbZIf pEoEZ0FyGDXYySUspctuGRDnpWjBMGXhyYqa/9YchoZdu/w6ttCGMCpL7sdf+SxE39H5 2dU4bpHz8+hUvZINjSbWGbTc5t8wsbItpxAYOB1xGqZaIjLdy2lQMnaZwoU3SUvMJLw3 Cfc4vT6aLrWd9tevv8Qg9rGlLzYfLmBRw/tfQd+cRHERhPiHQoq5BF65PkQrCQTKi7dH vcs9/2xibcaXBehpmXHQg/F9Z6ioz4C0xzsKg+uo1nxEzYZfAqbEoN+nX1n/ozhaZeOw CeFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692139104; x=1692743904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H4pnnHXPSSjR2BrIC+lFb47RzccWp4/dbdlHeRAoFGs=; b=QxbdLckkrer7UYNIZ5R7nkJsM3+Dh7EbryzgX+V/t9LSH53J+s0sn64mZb7LvToTGM vlGogehgGGC/p9aQ7pyPAWDwyfpYRP7noGGpwEkB6EdU5q+C9ZwAnJP7jra5Gr2QuKLx BGUx9Tyu1uzQPi1+9yPdTbEMJe+iqOmCby+q4249elbxmI6ERMIeK0md5SLFjiE0TdM7 In0nfzPX55VGLdVwY8vT0wtVZkmVb6PiJNaxlXs8VqIDiiJl+tW+/eXMcGUFir3u/Mfo 1IIT45/3DUYZOG18zzlUfOx1ro9aQy2XG4ODHsOI9V9KO8ncTUzwFq9o9wz7XD9lpvrr f2yw== X-Gm-Message-State: AOJu0Yz506aRUSb2IhwLshMekB7knGxetGkxUeuMvV6oUtLQ7RfOhHWb pDt3EBx3pcyMX6aYD52bE4GImnQsHOXnm2VtI/4= X-Google-Smtp-Source: AGHT+IHrun8S8aLUXsYgmCBeOiPLKKg10i0BdKbIhnKmyiMgeVL8HqRikPi3opKkSny+hpHXT08bIQ== X-Received: by 2002:a05:6808:1902:b0:3a7:e4a:5cbd with SMTP id bf2-20020a056808190200b003a70e4a5cbdmr72651oib.31.1692139104282; Tue, 15 Aug 2023 15:38:24 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, Daniel Henrique Barboza Subject: [PATCH v8 12/12] target/riscv: deprecate the 'any' CPU type Date: Tue, 15 Aug 2023 19:37:41 -0300 Message-ID: <20230815223741.433763-13-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230815223741.433763-1-dbarboza@ventanamicro.com> References: <20230815223741.433763-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=dbarboza@ventanamicro.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1692139219087100003 Content-Type: text/plain; charset="utf-8" The 'any' CPU type was introduced in commit dc5bd18fa5725 ("RISC-V CPU Core Definition"), being around since the beginning. It's not an easy CPU to use: it's undocumented and its name doesn't tell users much about what the CPU is supposed to bring. 'git log' doesn't help us either in knowing what was the original design of this CPU type. The closest we have is a comment from Alistair [1] where he recalls from memory that the 'any' CPU is supposed to behave like the newly added 'max' CPU. He also suggested that the 'any' CPU should be removed. The default CPUs are rv32 and rv64, so removing the 'any' CPU will have impact only on users that might have a script that uses '-cpu any'. And those users are better off using the default CPUs or the new 'max' CPU. We would love to just remove the code and be done with it, but one does not simply remove a feature in QEMU. We'll put the CPU in quarantine first, letting users know that we have the intent of removing it in the future. [1] https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg02891.html Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis --- docs/about/deprecated.rst | 12 ++++++++++++ target/riscv/cpu.c | 5 +++++ 2 files changed, 17 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 92a2bafd2b..4ced7427ac 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -371,6 +371,18 @@ QEMU's ``vhost`` feature, which would eliminate the hi= gh latency costs under which the 9p ``proxy`` backend currently suffers. However as of to date no= body has indicated plans for such kind of reimplementation unfortunately. =20 +RISC-V 'any' CPU type ``-cpu any`` (since 8.2) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +The 'any' CPU type was introduced back in 2018 and has been around since t= he +initial RISC-V QEMU port. Its usage has always been unclear: users don't k= now +what to expect from a CPU called 'any', and in fact the CPU does not do an= ything +special that aren't already done by the default CPUs rv32/rv64. + +After the introduction of the 'max' CPU type RISC-V now has a good coverage +of generic CPUs: rv32 and rv64 as default CPUs and 'max' as a feature comp= lete +CPU for both 32 and 64 bit builds. Users are then discouraged to use the '= any' +CPU type starting in 8.2. =20 Block device options '''''''''''''''''''' diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 326b016723..59bd37e033 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1470,6 +1470,11 @@ static void riscv_cpu_realize(DeviceState *dev, Erro= r **errp) RISCVCPUClass *mcc =3D RISCV_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 + if (object_dynamic_cast(OBJECT(dev), TYPE_RISCV_CPU_ANY) !=3D NULL) { + warn_report("The 'any' CPU is deprecated and will be " + "removed in the future."); + } + cpu_exec_realizefn(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); --=20 2.41.0