From nobody Mon Feb 9 09:24:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1692131852; cv=none; d=zohomail.com; s=zohoarc; b=WGPZ4qtTyWu7ArWTKxrKUvtpnddluWQeX4V3+t2Vk4uObjuiM98wRVkixkF6h3evI3K0S2uUbQcYSoyDKraCC6kJrYmBBDE63XBhGvQboYtVnd2MMea3Gm8VoqmceiwT784GthfL80a2P8ht8PT6k3cI+04lUdIDuqdCf4RJB6Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692131852; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sM11NGamBxV0Qh9cz3vCR8Wu3FJz2LD3eLcHOffGpt0=; b=JLkJPuOAl9KDg66IrBKITCaba8/sArDJT+IG750FBsYxRKAE9EFgmlsHCjPCKbHj97mUwZOH/MCXCiN3QToivQjdvSYjDXC4K/UzxkHHKI9j+uOOcJhoitzdtG4rvjyB0+mEub25Vv4ZqRNHpyt7Bbbe0JsKZn4UBQqXYxnVFyc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1692131852852604.782819287679; Tue, 15 Aug 2023 13:37:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qW0mn-0006Sl-Ho; Tue, 15 Aug 2023 16:37:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW0ml-0006Rt-FB for qemu-devel@nongnu.org; Tue, 15 Aug 2023 16:37:03 -0400 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qW0mh-00011t-D6 for qemu-devel@nongnu.org; Tue, 15 Aug 2023 16:37:01 -0400 Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-6bd066b0fd4so4000952a34.2 for ; Tue, 15 Aug 2023 13:36:59 -0700 (PDT) Received: from grind.. (189-69-160-189.dial-up.telesp.net.br. [189.69.160.189]) by smtp.gmail.com with ESMTPSA id v15-20020a0568301bcf00b006b94fb2762asm5526849ota.23.2023.08.15.13.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 13:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1692131818; x=1692736618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sM11NGamBxV0Qh9cz3vCR8Wu3FJz2LD3eLcHOffGpt0=; b=MKuApwV+IOfmawTrqA2r9D9RPYrCNe0ibcLv91sF4mNFuyoX0vZ2AcUNKh9Gn7VoQE mZ3TTbAPeblCtczrFqm9CLTPGhCcni2WbNTRqNOug5bvLe0yO9z16b+8Mb86LvanXszR IyI1gQFC/4f3NwhOXQ9hll6pWQTG6IGpZz+e7WDFHrxc66T7uh65zeov9KZcQ3DngteT zls78Wp5KQ7vz3Gun5Ma91gJ8y1yJ3202xiEx41z/PQbiFaDPa2ajZpfhpMR84KId+oh hbr/r4znroatMI5kdJFdQ03tw6m+sl4wIbNiFGI4+0tSD8dqgdSadeGwIxmKeWhllXY+ CF6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692131818; x=1692736618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sM11NGamBxV0Qh9cz3vCR8Wu3FJz2LD3eLcHOffGpt0=; b=TdetTQeyhO4FKgmDAJN+9lVrPDicH/nZ7CJDtnFkQxFZEoL94JNHb0ggzW6goN8CEU 4UUoFogWqUGbKqs79USONG5S6aui/mZTCsYJVgDuW60sZEZU427wVdryPMbgfQ1F69DY eA7I7D+PXsvRxeX9OmowqFKuDbG0YRpP4NDOlWUVUk9GDQCFe3VcZe7dyrBIRf594DPR sJzQqOCoCY4CnHWtbsBY7ZLcg5MtXFpwJmp4JmjMS5IS1Xx6DLp/ZinU1MEcMfl0XuFk 7JDkLccEdbMKuzvyRq1VXaM1AivGnZp1VOMA8GufF7luVaK/x4bWgZGGuHNGze71ZcOu BGhw== X-Gm-Message-State: AOJu0Yxpe49EB9Q+bA43nL+Dicx50X/uKAZ7hx3JWL/Aqf9Z7ZM/Qs0R xyViR/R0auhUvEIufE0taFuOZTzdBe0NZ/LWV0A= X-Google-Smtp-Source: AGHT+IEufeyRaYLLtvV4qR43dA5GtidhGoFnQU+FsbLOPf7YXA6RfI2Elkk4fmRjnpuzAUkpFDW12Q== X-Received: by 2002:a9d:6a56:0:b0:6b8:8f20:4cbc with SMTP id h22-20020a9d6a56000000b006b88f204cbcmr10927578otn.13.1692131818101; Tue, 15 Aug 2023 13:36:58 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, Daniel Henrique Barboza Subject: [PATCH v2 6/8] target/riscv: use isa_ext_update_enabled() in init_max_cpu_extensions() Date: Tue, 15 Aug 2023 17:36:33 -0300 Message-ID: <20230815203635.400179-7-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230815203635.400179-1-dbarboza@ventanamicro.com> References: <20230815203635.400179-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::335; envelope-from=dbarboza@ventanamicro.com; helo=mail-ot1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1692131854512100003 Content-Type: text/plain; charset="utf-8" Before adding support to detect if an extension was user set we need to handle how we're enabling extensions in riscv_init_max_cpu_extensions(). object_property_set_bool() calls the set() callback for the property, and we're going to use this callback to set the 'multi_ext_user_opts' hash. This means that, as is today, all extensions we're setting for the 'max' CPU will be seen as user set in the future. Let's change set_bool() to isa_ext_update_enabled() that will just enable/disable the flag on a certain offset. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 195a3ce7e6..52c9b04cd5 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -2101,24 +2101,24 @@ static void riscv_init_max_cpu_extensions(Object *o= bj) set_misa(env, env->misa_mxl, env->misa_ext | RVG | RVJ | RVV); =20 for (prop =3D riscv_cpu_extensions; prop && prop->name; prop++) { - object_property_set_bool(obj, prop->name, true, NULL); + isa_ext_update_enabled(cpu, prop->offset, true); } =20 /* set vector version */ env->vext_ver =3D VEXT_VERSION_1_00_0; =20 /* Zfinx is not compatible with F. Disable it */ - object_property_set_bool(obj, "zfinx", false, NULL); - object_property_set_bool(obj, "zdinx", false, NULL); - object_property_set_bool(obj, "zhinx", false, NULL); - object_property_set_bool(obj, "zhinxmin", false, NULL); + isa_ext_update_enabled(cpu, CPU_CFG_OFFSET(ext_zfinx), false); + isa_ext_update_enabled(cpu, CPU_CFG_OFFSET(ext_zdinx), false); + isa_ext_update_enabled(cpu, CPU_CFG_OFFSET(ext_zhinx), false); + isa_ext_update_enabled(cpu, CPU_CFG_OFFSET(ext_zhinxmin), false); =20 - object_property_set_bool(obj, "zce", false, NULL); - object_property_set_bool(obj, "zcmp", false, NULL); - object_property_set_bool(obj, "zcmt", false, NULL); + isa_ext_update_enabled(cpu, CPU_CFG_OFFSET(ext_zce), false); + isa_ext_update_enabled(cpu, CPU_CFG_OFFSET(ext_zcmp), false); + isa_ext_update_enabled(cpu, CPU_CFG_OFFSET(ext_zcmt), false); =20 if (env->misa_mxl !=3D MXL_RV32) { - object_property_set_bool(obj, "zcf", false, NULL); + isa_ext_update_enabled(cpu, CPU_CFG_OFFSET(ext_zcf), false); } } =20 --=20 2.41.0