From nobody Wed Feb 11 04:36:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=ispras.ru ARC-Seal: i=1; a=rsa-sha256; t=1691575724; cv=none; d=zohomail.com; s=zohoarc; b=SllkjWHdeTciiiTC+p6EXNLu+AsICsHr2tCyI2SYtjEFiuV8bHHEyHWHaeOz+HB3RkcL53jPNcO/gy3dQFb/hYjRiJBkhQswfT6/MMHONJgIZQjgA7QmUTotxvTBA+w7w/awEUmiZSVe3a3lSryoOBjWB89eIJJ9g4bImjHGdqQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691575724; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=KSUA1EF/4walk+vI1G+OyBeQQdvGHsA+9ce6SthPjJA=; b=CigmWY6KBqoNrHy1Arcm+2C6TFDZCcaxEMR3gU8jAsdgH4qkgrLtJUjDUqiblGpQSIatGZmMwFZxeSl0gvwJLKJuPlB24aImlFoQhn7fgHzlm1GYVd2dq+poBmwnDE6lVtq32q3jM4i80gc5ApHoQ5susQW/IYH6VeMvG2jCed4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1691575724487595.9866609812163; Wed, 9 Aug 2023 03:08:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTg6d-0001Vv-9t; Wed, 09 Aug 2023 06:07:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTg6a-0001Vh-Ri; Wed, 09 Aug 2023 06:07:53 -0400 Received: from mail.ispras.ru ([83.149.199.84]) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTg6Y-0002KO-Qi; Wed, 09 Aug 2023 06:07:52 -0400 Received: from timbersaw.intra.ispras.ru (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id BA16640F1DD7; Wed, 9 Aug 2023 10:07:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru BA16640F1DD7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1691575665; bh=KSUA1EF/4walk+vI1G+OyBeQQdvGHsA+9ce6SthPjJA=; h=From:To:Cc:Subject:Date:From; b=QtQ1lCqdDSvStM1wKSwkp1/OSv87UHign3hzumGezmoXOhB1pFp9iPduFlVg9EViM R6N6t9vQh3AJosCokV0QMOVTgGm6V6BodlcY6hrr8CJUf6f2Dg5VS7UyhZc4wfvkWj WfDLZXnxykTlCnPiLVf4bBka1fuLebYPaLBBK8aU= From: Maksim Kostin To: qemu-devel@nongnu.org Cc: Maksim Kostin , qemu-ppc@nongnu.org, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, alex.bennee@linaro.org, Vitaly Cheptsov Subject: [PATCH] hw/ppc/e500: fix broken snapshot replay Date: Wed, 9 Aug 2023 13:07:33 +0300 Message-Id: <20230809100733.32189-1-maksim.kostin@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=83.149.199.84; envelope-from=maksim.kostin@ispras.ru; helo=mail.ispras.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ispras.ru) X-ZM-MESSAGEID: 1691575726373100002 Content-Type: text/plain; charset="utf-8" ppce500_reset_device_tree is registered for system reset, but after c4b075318eb1 this function rerandomizes rng-seed via qemu_guest_getrandom_nofail. And when loading a snapshot, it tries to read EVENT_RANDOM that doesn't exist, so we have an error: qemu-system-ppc: Missing random event in the replay log To fix this, use qemu_register_reset_nosnapshotload instead of qemu_register_reset. Reported-by: Vitaly Cheptsov Fixes: c4b075318eb1 ("hw/ppc: pass random seed to fdt ") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1634 Signed-off-by: Maksim Kostin Reviewed-by: Nicholas Piggin --- hw/ppc/e500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 67793a86f1..d5b6820d1d 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -712,7 +712,7 @@ static int ppce500_prep_device_tree(PPCE500MachineState= *machine, p->kernel_base =3D kernel_base; p->kernel_size =3D kernel_size; =20 - qemu_register_reset(ppce500_reset_device_tree, p); + qemu_register_reset_nosnapshotload(ppce500_reset_device_tree, p); p->notifier.notify =3D ppce500_init_notify; qemu_add_machine_init_done_notifier(&p->notifier); =20 --=20 2.34.1