From nobody Mon Feb 9 15:46:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1690993238; cv=none; d=zohomail.com; s=zohoarc; b=WwHReduRwhnpRQ/oaGpU+VWIsX+weZzPptwO5tuGo4MrOblh8Vx43pruDnE36L8XSdY3fPbGCfxQ7r+p1F+Jdq3y5ksTkQyU+Q/RGti/RKlEqoGPxRYU5yJMNceZai66DGe8bzlVCgz1kwek2XmhzgAlVaj+Jh+Xg59sY+Nb/ig= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690993238; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=szJDGoaTe4WEQmpsvs8SO/kWeFKX5HzwL0bTAwlafzc=; b=ZZs7dCERVQj2BquOcqQFVTtxmwkSC9PQena0Hfp5FZn9JwFXtSSiNl1uTK1HRmMoabwSqiqKHJwUNA9hOq+yphTl2Nc1Qt2LaJnObR9V5HUDE+8qFitYzSnzJbTmLCGvi4TU8LBPB8kgYWRSjnMse9/j3I1qCPP/kC/CYOEeFI4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1690993238967921.0898798621405; Wed, 2 Aug 2023 09:20:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qREZL-00062d-AZ; Wed, 02 Aug 2023 12:19:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qREZJ-00061z-MT for qemu-devel@nongnu.org; Wed, 02 Aug 2023 12:19:25 -0400 Received: from home.keithp.com ([63.227.221.253] helo=elaine.keithp.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qREZH-0006Fe-Kt for qemu-devel@nongnu.org; Wed, 02 Aug 2023 12:19:25 -0400 Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id 5930B3F21D87; Wed, 2 Aug 2023 09:19:20 -0700 (PDT) Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavis, port 10024) with LMTP id obvMjmvgwiWO; Wed, 2 Aug 2023 09:19:19 -0700 (PDT) Received: from keithp.com (koto.keithp.com [192.168.11.2]) by elaine.keithp.com (Postfix) with ESMTPSA id DCB4E3F21CDB; Wed, 2 Aug 2023 09:19:18 -0700 (PDT) Received: by keithp.com (Postfix, from userid 1000) id 756AF1E601E9; Wed, 2 Aug 2023 09:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1690993160; bh=FWaOaA0shu6E5Xxbp65+bl2i5eQeXmUhJ2RXCEKKVAM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PGy9toFROtXX41tzZIedJtWuZScvPIFpszKD3H5zNJ5OkwHVZT6pNscoBhpNORTV+ UmmQKtFVpuv3B+xKZIjHMNxQBbFVx6d0D0DkHRz27WLMgROk6UruzNy1DS76j1ShIX tkXl0tm2Kx35sfEOktMu00irinksdHzc65PkTujTHiNMkW/Qg2LbFVqLmpMceZxoLS sAVGWQuIvgYZS+GEOHCbp1Y7Kpoyg1F/0BhdqCI12bWHUP0vHWeT4/WsEGxQvauHzr 0FlXJJMFr38zkLKXzsgHrWoYzG9mUix9YWeWKmxxmXIvv+weC35AENlj/sNv/iv1Yr 8eDD5/EPBU42g== X-Virus-Scanned: Debian amavis at keithp.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1690993158; bh=FWaOaA0shu6E5Xxbp65+bl2i5eQeXmUhJ2RXCEKKVAM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AALJz+Q19qlswWaLcPmiFcngJ8NpYS1YSX3p8F5/TBdLwFstWobH7FSe7vR176NMe KOOe5sKBYY/Qt6m6YKeLhduaLb8iGqZw8RuJpdljFzYJSxCX2ARTHTy1fZripCJrEo +B9pSHVP/v9AHL/dWEM6QkfukS8vXgX0b9KCeMflpZREFm/Lry4Vo0jH+D7cyKs1OT AcQ8NUlgwcAqJxSxXzXHy+cR4VrxNxcUZ5FTitlIbaFRml0v1D1KTUPDsxVpnL1nMD 60trsAJzuMK+H47TWCVMNyu3rQ+qqS/S0GhV3xvvm+8Q3qqjY2lhjYwszhDuV/DPo5 gawlPDoPuyCig== To: qemu-devel@nongnu.org Cc: Laurent Vivier , Keith Packard Subject: [PATCH 2/3] target/m68k: Fix semihost lseek offset computation Date: Wed, 2 Aug 2023 09:19:13 -0700 Message-Id: <20230802161914.395443-3-keithp@keithp.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230802161914.395443-1-keithp@keithp.com> References: <20230802161914.395443-1-keithp@keithp.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.227.221.253; envelope-from=keithp@keithp.com; helo=elaine.keithp.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Keith Packard From: Keith Packard via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1690993240027100009 Content-Type: text/plain; charset="utf-8" The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Signed-off-by: Keith Packard --- target/m68k/m68k-semi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c index 12235759c7..12179bde38 100644 --- a/target/m68k/m68k-semi.c +++ b/target/m68k/m68k-semi.c @@ -166,7 +166,7 @@ void do_m68k_semihosting(CPUM68KState *env, int nr) GET_ARG64(2); GET_ARG64(3); semihost_sys_lseek(cs, m68k_semi_u64_cb, arg0, - deposit64(arg2, arg1, 32, 32), arg3); + deposit64(arg2, 32, 32, arg1), arg3); break; =20 case HOSTED_RENAME: --=20 2.40.1