From nobody Mon Feb 9 08:11:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1690882917; cv=none; d=zohomail.com; s=zohoarc; b=Z55v4FZYgOq+41Q0Rzvh29JFnXFVtZlyEreX4DaikS5g5bcqqKbqZ1c3vOHnFMV/bliosH5ZWzskXSJkb6MagdEVS1L6m7LqKWzYpfZ/VcbqPOILSzqFbiy1Bqlse32XstJNqBr8sDPZRe6m/X3MMoYPJMULRN3d8Ereno9j7dI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690882917; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=gyvr+33HHd+ucSnhpZ5qR44UOgN55PQYSg0osJuZ6Vg=; b=YfMKJ1JnZGwQZ7HGZIXVYPac2WFONLpZ3qSXa7OsBBh/DABBKNMufjiZ09TzfJAOF6MOvQv4NjK1Y4+BO2hCEUpCr2KGifHB4MW8ovNoSAg3B8SRir6msU2+2kUroxpkrG+0r8tkxsqXlqFU1raXd/d9YxkY+dMalxyk3RkG1mQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1690882917689478.7661783444329; Tue, 1 Aug 2023 02:41:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQlsF-0003FO-HU; Tue, 01 Aug 2023 05:41:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQlsA-0003A5-9b for qemu-devel@nongnu.org; Tue, 01 Aug 2023 05:40:58 -0400 Received: from esa2.hc3370-68.iphmx.com ([216.71.145.153]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQls8-0005Bq-Fm for qemu-devel@nongnu.org; Tue, 01 Aug 2023 05:40:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1690882856; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ng+PjkahWZzJhonoLMhtC6+8FiFwsYdx9/qF63/vowA=; b=EFc0HQ1Azs0myZjnL6cT3+L3mKnK8jIS5h/Co0zYr5tg43UTaobqHFeE sZUc/NWvEZzOkawWKMexYSrfavIcVKHgcTbSwm/oNEF30vWA1FajZeBLP lpsanoYN1QGFXVZK2A2YuHqK2LFIFIeR2Vx3H2lgT2b53zkay9HRyiJe9 M=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 117971007 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:PA4hk6riomnVT93LuQthJd8WbXdeBmJKZRIvgKrLsJaIsI4StFCzt garIBmAOqvZYDamKdx1OY+3p0pQ6peAmIM1HlE5qSgxFCgRo5uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weBzCBNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACEWY1OHp96Z/L6UcLZSj956C5blJ7pK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jufoDWmW0lCa7RzzxLVwi+RivHjlhnpXYMdHo+VrMd7oli6kzl75Bo+CgLg/KjRZlSFc8tSL lFR9icwoKwa8kutQd/gGRqirxa5UgU0AoQKVbdgsUfUl/SSulzCboQZctJfQM09uYwyZQAF6 lOmpYzXDCY2l+KbUkvIo994sgiO1TgpwX4qPHFVFVtavIO6+OnfnTqUEI89TffdYsndXGipn mvU9HVWa6A715Zj6kmtwbzQb9tATLDtRxV92AjYV3nNAuhRNN/8PNzABbQ2AJ99wGelorqp5 iJsdzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pS/7LdoAvG4ieB02WirhRdMOS BaC0T69GbcJZCf6BUOJS9zZ5zsWIVjISo2+C6G8gitmaZltbg6XlByClmbJt10BZHMEyPllU b/CKJbEMJrvIfg/pNZAb7tHgOBDK+FX7T+7eK0XODz9gebHPiPEFu1cWLZMB8hghJ65TMzu2 443H6O3J993AYUSvgG/HVYvEG03 IronPort-HdrOrdr: A9a23:x8W2Hq8XruQwcj5epq9uk+C7I+orL9Y04lQ7vn2ZKCY0TiX8ra uTdZsguCMc5Ax6ZJhCo7G90de7Lk80nKQdibX5Vo3PYOCJggWVEL0= X-Talos-CUID: =?us-ascii?q?9a23=3Au228cmqVQPMCVPGfo/Ke6XnmUdE+fz7Z7Ev/H0O?= =?us-ascii?q?XMzlXQafMbgCe45oxxg=3D=3D?= X-Talos-MUID: 9a23:PxY1rwaecddNCOBT5w+xuT18GMxS8aGvB0o/vM8/quuBHHkl X-IronPort-AV: E=Sophos;i="6.01,246,1684814400"; d="scan'208";a="117971007" To: CC: Anthony PERARD Subject: [PULL 3/5] thread-pool: signal "request_cond" while locked Date: Tue, 1 Aug 2023 10:40:36 +0100 Message-ID: <20230801094038.11026-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230801094038.11026-1-anthony.perard@citrix.com> References: <20230801094038.11026-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.71.145.153; envelope-from=prvs=570bccec8=anthony.perard@citrix.com; helo=esa2.hc3370-68.iphmx.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anthony PERARD From: Anthony PERARD via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1690882918394100001 Content-Type: text/plain; charset="utf-8" From: Anthony PERARD thread_pool_free() might have been called on the `pool`, which would be a reason for worker_thread() to quit. In this case, `pool->request_cond` is been destroyed. If worker_thread() didn't managed to signal `request_cond` before it been destroyed by thread_pool_free(), we got: util/qemu-thread-posix.c:198: qemu_cond_signal: Assertion `cond->initia= lized' failed. One backtrace: __GI___assert_fail (assertion=3D0x55555614abcb "cond->initialized", fil= e=3D0x55555614ab88 "util/qemu-thread-posix.c", line=3D198, function=3D0x55555614ad80 <__PRETTY_FUNCTION__.17104> "qemu_cond_signal") = at assert.c:101 qemu_cond_signal (cond=3D0x7fffb800db30) at util/qemu-thread-posix.c:198 worker_thread (opaque=3D0x7fffb800dab0) at util/thread-pool.c:129 qemu_thread_start (args=3D0x7fffb8000b20) at util/qemu-thread-posix.c:5= 05 start_thread (arg=3D) at pthread_create.c:486 Reported here: https://lore.kernel.org/all/ZJwoK50FcnTSfFZ8@MacBook-Air-de-Roger.local= /T/#u To avoid issue, keep lock while sending a signal to `request_cond`. Fixes: 900fa208f506 ("thread-pool: replace semaphore with condition variabl= e") Signed-off-by: Anthony PERARD Reviewed-by: Stefan Hajnoczi Message-Id: <20230714152720.5077-1-anthony.perard@citrix.com> Signed-off-by: Anthony PERARD --- util/thread-pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/thread-pool.c b/util/thread-pool.c index 0d97888df0..e3d8292d14 100644 --- a/util/thread-pool.c +++ b/util/thread-pool.c @@ -120,13 +120,13 @@ static void *worker_thread(void *opaque) =20 pool->cur_threads--; qemu_cond_signal(&pool->worker_stopped); - qemu_mutex_unlock(&pool->lock); =20 /* * Wake up another thread, in case we got a wakeup but decided * to exit due to pool->cur_threads > pool->max_threads. */ qemu_cond_signal(&pool->request_cond); + qemu_mutex_unlock(&pool->lock); return NULL; } =20 --=20 Anthony PERARD