From nobody Wed Feb 11 05:29:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=laplante.io ARC-Seal: i=1; a=rsa-sha256; t=1690342466; cv=none; d=zohomail.com; s=zohoarc; b=ghjB39WotJZhrB8ZcmsvfeC4pjIT/kVBb17X6mUz5Y0fGP8Dw9flF0gUo2DjciFHs2gxhPoPRtcpj1stE+4fqX5KLS1LEm+qsTwlBmhPgJ7h6xlJChT9dG7mujJhQYFyCHHxuHlFocl1Tp+ndGvExVFlGzBcWi+aaxziKnPFTXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690342466; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EtuSgrXwZhMLjgs507zxk5ZwlCfmtLk/i7vXQX5lOqo=; b=Ipp8a4QVE0ZAA0KjcRMk+z7jPtlZ/oT/8eA7CyMSaZKz6CO76aI6gVqxtGM1akXbYWTNlq0pWbZaCppvuo1MfKunA8eTorX4cg8YSxjVRc3kHpOpMaeiyCndzSf7H3bE2zfB3h5BrbGgoHT3Rwp5dRhmsjhHXXToXTjIXjLbUBs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1690342466320923.7645465989983; Tue, 25 Jul 2023 20:34:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOVGP-0005TR-1y; Tue, 25 Jul 2023 23:32:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOVGN-0005RU-Nn; Tue, 25 Jul 2023 23:32:36 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOVGL-0007dv-QZ; Tue, 25 Jul 2023 23:32:35 -0400 Date: Wed, 26 Jul 2023 03:32:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=laplante.io; s=protonmail3; t=1690342351; x=1690601551; bh=EtuSgrXwZhMLjgs507zxk5ZwlCfmtLk/i7vXQX5lOqo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=dl4edW6Mlfg15e9sPMpyi5q4xwjLYviBzeHQTvzzJHwEx113gUuVNHHdc4rErNAed 3rB7t5Wm3fQa7h1PNBslDQF6su/Zsp5axNol/OgZ1PL8FqQX/L8L5ZlgUh9+ZfuPOv 8pq/Wj3fMimCA0NNZmYV2ny2At6OLkN5f4GsNFoDbUr79EvnFHbysYJ6zxDBOoZl7d G7JTqlkIH743TsS9XWqsWF61Saxn2mDXa0jfTXlDjLN0EWbIoYjME+METNWIimzzmS pzDtGX6v4yh0JskOx5Qq125WtiqCRay3xfOdT2oaJ25zICW/oevoxd6tzH5Xrjef8r tqvDf6TQzwIkg== To: qemu-devel@nongnu.org From: Chris Laplante Cc: Joel Stanley , Peter Maydell , qemu-arm@nongnu.org, Chris Laplante Subject: [PATCH v2 5/6] qtest: irq_intercept_[out/in]: return FAIL if no intercepts are installed Message-ID: <20230726030450.757462-6-chris@laplante.io> In-Reply-To: <20230726030450.757462-1-chris@laplante.io> References: <20230726030450.757462-1-chris@laplante.io> Feedback-ID: 43500449:user:proton MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.70.43.17; envelope-from=chris@laplante.io; helo=mail-4317.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @laplante.io) X-ZM-MESSAGEID: 1690342467017100001 Content-Type: text/plain; charset="utf-8" This is much better than just silently failing with OK. Signed-off-by: Chris Laplante Reviewed-by: Peter Maydell --- softmmu/qtest.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/softmmu/qtest.c b/softmmu/qtest.c index 1719bbddc3..c9751f527f 100644 --- a/softmmu/qtest.c +++ b/softmmu/qtest.c @@ -399,6 +399,7 @@ static void qtest_process_command(CharBackend *chr, gch= ar **words) NamedGPIOList *ngl; bool is_named; bool is_outbound; + bool interception_succeeded =3D false; =20 g_assert(words[1]); is_named =3D words[2] !=3D NULL; @@ -431,6 +432,7 @@ static void qtest_process_command(CharBackend *chr, gch= ar **words) if (is_named) { if (ngl->name && strcmp(ngl->name, words[2]) =3D=3D 0)= { qtest_install_gpio_out_intercept(dev, ngl->name, 0= ); + interception_succeeded =3D true; break; } } else if (!ngl->name) { @@ -438,15 +440,22 @@ static void qtest_process_command(CharBackend *chr, g= char **words) for (i =3D 0; i < ngl->num_out; ++i) { qtest_install_gpio_out_intercept(dev, ngl->name, i= ); } + interception_succeeded =3D true; } } else { qemu_irq_intercept_in(ngl->in, qtest_irq_handler, ngl->num_in); + interception_succeeded =3D true; } } - irq_intercept_dev =3D dev; + qtest_send_prefix(chr); - qtest_send(chr, "OK\n"); + if (interception_succeeded) { + irq_intercept_dev =3D dev; + qtest_send(chr, "OK\n"); + } else { + qtest_send(chr, "FAIL No intercepts installed\n"); + } } else if (strcmp(words[0], "set_irq_in") =3D=3D 0) { DeviceState *dev; qemu_irq irq; --=20 2.41.0