From nobody Sat Sep 21 03:06:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1688111470; cv=none; d=zohomail.com; s=zohoarc; b=ffpEnmL8rxfrDTdquYOwcqi9DxYC+SlU+hoaQMZJ6aI+5DuKn+GVXdRB1ujCH73tbPsEIz818TmBtzEyYi9Oh9lDuTGWYRWfkt2wsYjv78HeDh9jB4n+Qpfjj0SXAyC3CgKWwqMCh/qoPsr9W4sI5j6yBvdxKvwPgu4w5TNF2wY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688111470; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2ahW11S+uZ2On3OY63RVZlkvsKIOVQPThr02Mg+XBbA=; b=Rw4y7YkweJDJaiHbjHjV/SXgnM0BbPpslp8ON54ELlouDet38qW+fRm7rHTsDflkl6ibzZwddZCuOIUeGtH+h/YYsGteGmeKDnKqLKJwH1r5MiR6p3TdCApi+9LLrlufUMqDDRfgHNhHxDO/PL3EVELx5pDXh18vlFWGQ43fcWQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1688111470794715.2331792330308; Fri, 30 Jun 2023 00:51:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qF8tQ-0001ur-1U; Fri, 30 Jun 2023 03:50:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF8tO-0001ui-0z for qemu-devel@nongnu.org; Fri, 30 Jun 2023 03:50:10 -0400 Received: from mga03.intel.com ([134.134.136.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF8tM-0002oc-4X for qemu-devel@nongnu.org; Fri, 30 Jun 2023 03:50:09 -0400 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 00:50:06 -0700 Received: from duan-server-s2600bt.bj.intel.com ([10.240.192.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 00:50:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688111408; x=1719647408; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jxpKTAInzfx8UIcmYnemexQBA/d+xvputn2hB27MCd8=; b=Ejz+VvwWO2F32a1XByZ6uSIwMpGDXP2xtabJTRcKbJDk+nZDgmB0S+XI mjAmkuN8Tjd0uCVsepCp6axt89+z8SsPpRZYfaSvbqRa48g7Bl6csYkMR 65oibojQjWRVxVFXslq1fV5omReBODPYyJWwcd72r1XvREreMGjpy4Cqq wXkhcKZZBW7DxM9YEzD9S3bEFmOe4vCxsHFZ+YX6zv1NoT33FjRJKS0iB mXwRHXLcsRjJ4yFNALWKVcSTWYaKXCW9ueFvPdY/kLS/1y/x2T+kNPVxs HWNzQikT71mmO01evotJxzDom+JhrBGhUBaNTOz0n5INnk1JoSvlgJ5ld w==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="365824497" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="365824497" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="841770837" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="841770837" From: Zhenzhong Duan To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, clg@redhat.com, joao.m.martins@oracle.com, avihaih@nvidia.com, chao.p.peng@intel.com Subject: [PATCH v5 7/7] vfio/migration: Remove print of "Migration disabled" Date: Fri, 30 Jun 2023 15:36:37 +0800 Message-Id: <20230630073637.124234-6-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230630073637.124234-1-zhenzhong.duan@intel.com> References: <20230630073637.124234-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.65; envelope-from=zhenzhong.duan@intel.com; helo=mga03.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1688111472877100007 Content-Type: text/plain; charset="utf-8" Property enable_migration supports [on/off/auto]. In ON mode, error pointer is passed to errp and logged. In OFF mode, we doesn't need to log "Migration disabled" as it's intentiona= l. In AUTO mode, we should only ever see errors or warnings if the device supports migration and an error or incompatibility occurs while further probing or configuring it. Lack of support for migration shoundn't generate an error or warning. Signed-off-by: Zhenzhong Duan Reviewed-by: Joao Martins --- hw/vfio/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 9cf70c1965d3..1c969fccc543 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -3209,7 +3209,6 @@ static void vfio_realize(PCIDevice *pdev, Error **err= p) if (!pdev->failover_pair_id) { ret =3D vfio_migration_realize(vbasedev, errp); if (!ret) { - error_report("%s: Migration disabled", vbasedev->name); goto out_deregister; } } --=20 2.34.1