From nobody Tue Feb 10 13:16:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1687971417; cv=none; d=zohomail.com; s=zohoarc; b=I21Lqq5UcXAdPe4MkCIDNCYQhqroCOJMGXaZgetnQHjLyM/oqtr0rY/LwL2ccRB4VVG51dbAifu0xoRy/XF0GF0DtgOzyJvNlg8+8dKT07hySeKachCfEY6XX8sGHxwEMU5fNFjfYMDiC190Z5QTTXuO9g6xM+2mwGI1gckxQH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687971417; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KY3RpidzTumyY+F0nF4/MkUuySfj1G/I09eYQ4e8pkc=; b=Y15JcTFNXzv3yw13FAbH+v3syke+ufEoH80UqzOAydcz3ZHMlEb640U00vtlCdA5Guqacgm8ZYI0wHXg5Jz64QnemyzcUhYdOXGlDlAkt6zLt1GKdFsKoGT+AzPfxALIuxu01rAbXC26wIoZEdUcLyNx8c8bbZvATe8Tyu9VZR8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 168797141763237.42632756600767; Wed, 28 Jun 2023 09:56:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEYSy-0003ZC-EC; Wed, 28 Jun 2023 12:56:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEYSj-0003WF-L8 for qemu-devel@nongnu.org; Wed, 28 Jun 2023 12:56:17 -0400 Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEYSc-0001st-Lj for qemu-devel@nongnu.org; Wed, 28 Jun 2023 12:56:08 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A86741F8D9; Wed, 28 Jun 2023 16:56:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E896138EF; Wed, 28 Jun 2023 16:56:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iKuTBiBmnGRIZwAAMHmgww (envelope-from ); Wed, 28 Jun 2023 16:56:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1687971362; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KY3RpidzTumyY+F0nF4/MkUuySfj1G/I09eYQ4e8pkc=; b=S4OrKwP3r6XoqKmChzBwme/8gv4KxpMzCoa11uDkDo+0n7++w10qVC6R8AjlQSTdqDUHMN sGcxjQfw8ZEkh22IS+2Mi0BhBrKNjAHDboB7Sz5lJCG0NJDSpp8GSxWjEwqsfZgY0672QH iWmCfQ0hjmyCs3dd+LsLt3SfoVy3sus= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1687971362; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KY3RpidzTumyY+F0nF4/MkUuySfj1G/I09eYQ4e8pkc=; b=tLR5VkRisWwZ8Iq/PSE1bTcLa7GU+x1YbLmcqPGBYEvxdIEvyVRY8koiJNwM2xwbF7VBlx h1HQn1sixrNbX9BA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Juan Quintela , Peter Xu , Steve Sistare , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Leonardo Bras , Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH 6/6] tests/qtest: migration-test: Add tests for file-based migration Date: Wed, 28 Jun 2023 13:55:42 -0300 Message-Id: <20230628165542.17214-7-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230628165542.17214-1-farosas@suse.de> References: <20230628165542.17214-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1d; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1687971418856100005 Content-Type: text/plain; charset="utf-8" Add basic tests for file-based migration. Signed-off-by: Fabiano Rosas --- tests/qtest/migration-test.c | 104 +++++++++++++++++++++++++++++++++++ 1 file changed, 104 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index acb778a8cd..b3019f54de 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -52,6 +52,10 @@ static bool got_dst_resume; */ #define DIRTYLIMIT_TOLERANCE_RANGE 25 /* MB/s */ =20 +#define QEMU_VM_FILE_MAGIC 0x5145564d +#define FILE_TEST_FILENAME "migfile" +#define FILE_TEST_OFFSET 0x1000 + #if defined(__linux__) #include #include @@ -763,6 +767,7 @@ static void test_migrate_end(QTestState *from, QTestSta= te *to, bool test_dest) cleanup("migsocket"); cleanup("src_serial"); cleanup("dest_serial"); + cleanup(FILE_TEST_FILENAME); } =20 #ifdef CONFIG_GNUTLS @@ -1460,11 +1465,28 @@ static void test_precopy_common(MigrateCommon *args) */ wait_for_migration_complete(from); =20 + /* + * For file based migration the target must begin its + * migration after the source has finished. + */ + if (strstr(connect_uri, "file:")) { + migrate_incoming_qmp(to, connect_uri, "{}"); + } + if (!got_src_stop) { qtest_qmp_eventwait(from, "STOP"); } } else { wait_for_migration_complete(from); + + /* + * For file based migration the target must begin its + * migration after the source has finished. + */ + if (strstr(connect_uri, "file:")) { + migrate_incoming_qmp(to, connect_uri, "{}"); + } + /* * Must wait for dst to finish reading all incoming * data on the socket before issuing 'cont' otherwise @@ -1682,6 +1704,78 @@ static void test_precopy_unix_compress_nowait(void) test_precopy_common(&args); } =20 +static void test_precopy_file(void) +{ + g_autofree char *uri =3D g_strdup_printf("file:%s/%s", tmpfs, + FILE_TEST_FILENAME); + MigrateCommon args =3D { + .connect_uri =3D uri, + .listen_uri =3D "defer", + }; + + test_precopy_common(&args); +} + +#if defined(__linux__) +static void file_offset_finish_hook(QTestState *from, QTestState *to, void= *opaque) +{ + g_autofree char *path =3D g_strdup_printf("%s/%s", tmpfs, FILE_TEST_FI= LENAME); + size_t size =3D FILE_TEST_OFFSET + sizeof(QEMU_VM_FILE_MAGIC); + uintptr_t *addr, *p; + int fd; + + fd =3D open(path, O_RDONLY); + g_assert(fd !=3D -1); + addr =3D mmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0); + g_assert(addr !=3D MAP_FAILED); + + /* + * Ensure the skipped offset contains zeros and the migration + * stream starts at the right place. + */ + p =3D addr; + while (p < addr + FILE_TEST_OFFSET / sizeof(uintptr_t)) { + g_assert(*p =3D=3D 0); + p++; + } + g_assert_cmpint(cpu_to_be32(*p), =3D=3D, QEMU_VM_FILE_MAGIC); + + munmap(addr, size); + close(fd); +} + +static void test_precopy_file_offset(void) +{ + g_autofree char *uri =3D g_strdup_printf("file:%s/%s,offset=3D%d", tmp= fs, + FILE_TEST_FILENAME, + FILE_TEST_OFFSET); + MigrateCommon args =3D { + .connect_uri =3D uri, + .listen_uri =3D "defer", + .finish_hook =3D file_offset_finish_hook, + }; + + test_precopy_common(&args); +} +#endif + +static void test_precopy_file_offset_bad(void) +{ + /* using a value not supported by qemu_strtosz() */ + g_autofree char *uri =3D g_strdup_printf("file:%s/migfile,offset=3D0x2= 0M", + tmpfs); + MigrateCommon args =3D { + .connect_uri =3D uri, + .listen_uri =3D "defer", + .error_str =3D g_strdup( + "file URI has bad offset 0x20M: Unknown error -22"), + .result =3D MIG_TEST_QMP_ERROR, + }; + + test_precopy_common(&args); + g_free(args.error_str); +} + static void test_precopy_tcp_plain(void) { MigrateCommon args =3D { @@ -2704,6 +2798,16 @@ int main(int argc, char **argv) qtest_add_func("/migration/precopy/unix/compress/nowait", test_precopy_unix_compress_nowait); } + + qtest_add_func("/migration/precopy/file", + test_precopy_file); +#if defined(__linux__) + qtest_add_func("/migration/precopy/file/offset", + test_precopy_file_offset); +#endif + qtest_add_func("/migration/precopy/file/offset/bad", + test_precopy_file_offset_bad); + #ifdef CONFIG_GNUTLS qtest_add_func("/migration/precopy/unix/tls/psk", test_precopy_unix_tls_psk); --=20 2.35.3