From nobody Wed Feb 11 01:09:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1687817301; cv=none; d=zohomail.com; s=zohoarc; b=iypxiDopbwMC+fTPB+YzNcrFGsLFslSWIv2YXXVGnX+Bmd/GHwXXBJuoSgR9RT9fG06kzWJv81OUZyB28wBfQxhw59GVZtnF+5Qvec2iKZrCsUQSaEaqO1m6mezD8if1lr+7m73j2M2O/PJhae/kCI0H/P4jH7EPnZ4ScEvxa48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687817301; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bRHf9h4G/bLvyIWMS65t7lGQ8fTomW8W7GqhcAfU7Pw=; b=cM+VMbV/iZJMd8LRx4sfKyrpLwamq67ZL3Dk5g6ZqGSyoK37sU3H9eJVnKRR1JVkBYIcgORDNVv0a+4qJeZk4P60ufnKIjRDIHppZOSXvlBF30VHqZ/GrowI7phZYG82PN6BE0G5nsAlPY32y+XxKyi5xITcG7XAPZpErlYQgcY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687817301507850.3007183837681; Mon, 26 Jun 2023 15:08:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDuMJ-0003xG-VC; Mon, 26 Jun 2023 18:06:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDuLN-0003B9-5a for qemu-devel@nongnu.org; Mon, 26 Jun 2023 18:06:02 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDuLH-000715-AL for qemu-devel@nongnu.org; Mon, 26 Jun 2023 18:05:56 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-307d20548adso3504584f8f.0 for ; Mon, 26 Jun 2023 15:05:50 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id da16-20020a056000197000b0031274a184d5sm8519676wrb.109.2023.06.26.15.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 15:05:49 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1111D1FFD0; Mon, 26 Jun 2023 22:59:30 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687817149; x=1690409149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bRHf9h4G/bLvyIWMS65t7lGQ8fTomW8W7GqhcAfU7Pw=; b=brGcfdTz7xr3Ga32f4sU/4Z91NcHjo+pIUzY/6Vu0rneSXMf37avVqxo3Bvm8V2VgO 5cOzTJ2T9kimhBDB6qkBA6/1DREmUNdHLCNSVSJAmndmqLIXay96EE6CdIZPL/gZccMc tT+/ulfdp59+yw0QyPMpDwAV10cCS+KkthQ3Rbysy4N3W15j682sSLI5+0I6gethSIU/ ri+uePHyUJB9EbKqZAvy3iWtobjfl+oMKOrMz47FPtBjmdaStTTNXZMnU38sJfuiDUgy slwfYJe4kHl+jLiMeyedIIztcHjbAcV2HxmWnVgMHVQMt4EIC3Ft4J2yNk1SE2QyISXO GKcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687817149; x=1690409149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bRHf9h4G/bLvyIWMS65t7lGQ8fTomW8W7GqhcAfU7Pw=; b=PC3xqfCPOegBlELdrEgUjmakjm9yEAjwu2AA93n//afapJnOZEz3alFdHbDVkcpAH2 R64EUSCBXWB9UARVKtKE1NMcHe0+8LNLNpa0ierh/qgylOYqljZlsCcSdHT/ZJXmqXj8 JmF3ArXX6RrcoS4iYqiglFWnGkmrru9W6rOCco0qM6lXnTgnly3zOrovur+2EMmUO/YH hcRw5JA75vNgyv0alBsivApsHatwoOjSv3sZ5CI8v0Wn3Z2d500pp8Rg2qL9eIWoU6nH zlXmD60Zf34UiRPgzTYxdp0ljNGqM9QHYd4Bqw+yUr5rX3J5qvgjiIEeXeiDK3Pft7B/ 1etw== X-Gm-Message-State: AC+VfDzYEf+s7068DHUNc9nO171VokoIt0jcYgYpnzKVNXZ7jG+RNdIQ byIXs/+3pCrGVdO9WzczmCSECg== X-Google-Smtp-Source: ACHHUZ5dRwh23s0EHeLza5zqm4lzsrPXJoBYBleqls9ic+ve8UIZUShQOZrW2ytj7yN2lXO+sQV3sg== X-Received: by 2002:a5d:4e8f:0:b0:30f:bf2e:4b99 with SMTP id e15-20020a5d4e8f000000b0030fbf2e4b99mr20610579wru.49.1687817149379; Mon, 26 Jun 2023 15:05:49 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Alexander Bulekov , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Juan Quintela , Alexandre Iooss , Thomas Huth , Marcel Apfelbaum , Leif Lindholm , Riku Voipio , Peter Maydell , Paolo Bonzini , Bandan Das , Leonardo Bras , Cleber Rosa , Richard Henderson , Beraldo Leal , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mahmoud Mandour , Stefan Hajnoczi , Yanan Wang , Eduardo Habkost , Bin Meng , qemu-arm@nongnu.org, Wainer dos Santos Moschetta , Darren Kenny , Radoslaw Biernacki , Marcin Juszkiewicz , Qiuhao Li , Laurent Vivier Subject: [PATCH v2 26/26] tests/plugin: Remove duplicate insn log from libinsn.so Date: Mon, 26 Jun 2023 22:59:26 +0100 Message-Id: <20230626215926.2522656-27-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626215926.2522656-1-alex.bennee@linaro.org> References: <20230626215926.2522656-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1687817303050100001 From: Richard Henderson This is a perfectly natural occurrence for x86 "rep movb", where the "rep" prefix forms a counted loop of the one insn. During the tests/tcg/multiarch/memory test, this logging is triggered over 350000 times. Within the context of cross-i386-tci build, which is already slow by nature, the logging is sufficient to push the test into timeout. Signed-off-by: Richard Henderson Message-Id: <20230621111520.1390967-1-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/plugin/insn.c | 9 +-------- tests/tcg/i386/Makefile.softmmu-target | 9 --------- tests/tcg/i386/Makefile.target | 6 ------ tests/tcg/x86_64/Makefile.softmmu-target | 9 --------- 4 files changed, 1 insertion(+), 32 deletions(-) diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c index e251a84d86..5fd3017c2b 100644 --- a/tests/plugin/insn.c +++ b/tests/plugin/insn.c @@ -19,7 +19,6 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_version =3D QEMU_PLUGI= N_VERSION; #define MAX_CPUS 8 /* lets not go nuts */ =20 typedef struct { - uint64_t last_pc; uint64_t insn_count; } InstructionCount; =20 @@ -51,13 +50,7 @@ static void vcpu_insn_exec_before(unsigned int cpu_index= , void *udata) { unsigned int i =3D cpu_index % MAX_CPUS; InstructionCount *c =3D &counts[i]; - uint64_t this_pc =3D GPOINTER_TO_UINT(udata); - if (this_pc =3D=3D c->last_pc) { - g_autofree gchar *out =3D g_strdup_printf("detected repeat executi= on @ 0x%" - PRIx64 "\n", this_pc); - qemu_plugin_outs(out); - } - c->last_pc =3D this_pc; + c->insn_count++; } =20 diff --git a/tests/tcg/i386/Makefile.softmmu-target b/tests/tcg/i386/Makefi= le.softmmu-target index ed922d59c8..5266f2335a 100644 --- a/tests/tcg/i386/Makefile.softmmu-target +++ b/tests/tcg/i386/Makefile.softmmu-target @@ -33,14 +33,5 @@ EXTRA_RUNS+=3D$(MULTIARCH_RUNS) =20 memory: CFLAGS+=3D-DCHECK_UNALIGNED=3D1 =20 -# non-inline runs will trigger the duplicate instruction heuristics in lib= insn.so -run-plugin-%-with-libinsn.so: - $(call run-test, $@, \ - $(QEMU) -monitor none -display none \ - -chardev file$(COMMA)path=3D$@.out$(COMMA)id=3Doutput \ - -plugin ../../plugin/libinsn.so$(COMMA)inline=3Don \ - -d plugin -D $*-with-libinsn.so.pout \ - $(QEMU_OPTS) $*) - # Running QEMU_OPTS+=3D-device isa-debugcon,chardev=3Doutput -device isa-debug-exit,= iobase=3D0xf4,iosize=3D0x4 -kernel diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target index 821822ed0c..f2ee7a4db7 100644 --- a/tests/tcg/i386/Makefile.target +++ b/tests/tcg/i386/Makefile.target @@ -63,12 +63,6 @@ else SKIP_I386_TESTS+=3Dtest-i386-fprem endif =20 -# non-inline runs will trigger the duplicate instruction heuristics in lib= insn.so -run-plugin-%-with-libinsn.so: - $(call run-test, $@, $(QEMU) $(QEMU_OPTS) \ - -plugin ../../plugin/libinsn.so$(COMMA)inline=3Don \ - -d plugin -D $*-with-libinsn.so.pout $*) - # Update TESTS I386_TESTS:=3D$(filter-out $(SKIP_I386_TESTS), $(ALL_X86_TESTS)) TESTS=3D$(MULTIARCH_TESTS) $(I386_TESTS) diff --git a/tests/tcg/x86_64/Makefile.softmmu-target b/tests/tcg/x86_64/Ma= kefile.softmmu-target index 7207fee94c..1bd763f2e6 100644 --- a/tests/tcg/x86_64/Makefile.softmmu-target +++ b/tests/tcg/x86_64/Makefile.softmmu-target @@ -33,14 +33,5 @@ EXTRA_RUNS+=3D$(MULTIARCH_RUNS) =20 memory: CFLAGS+=3D-DCHECK_UNALIGNED=3D1 =20 -# non-inline runs will trigger the duplicate instruction heuristics in lib= insn.so -run-plugin-%-with-libinsn.so: - $(call run-test, $@, \ - $(QEMU) -monitor none -display none \ - -chardev file$(COMMA)path=3D$@.out$(COMMA)id=3Doutput \ - -plugin ../../plugin/libinsn.so$(COMMA)inline=3Don \ - -d plugin -D $*-with-libinsn.so.pout \ - $(QEMU_OPTS) $*) - # Running QEMU_OPTS+=3D-device isa-debugcon,chardev=3Doutput -device isa-debug-exit,= iobase=3D0xf4,iosize=3D0x4 -kernel --=20 2.39.2