From nobody Wed Feb 11 00:59:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1687811205; cv=none; d=zohomail.com; s=zohoarc; b=cLNKYBW/puITfZUE+qW6n/LAOD/vIO7nizQ+okFZP2rd1JR9r/wE/nAM6NOMxYSMA4yR7LEWOIFPUXWTx9ffvrMLqU8TAxhuKYl66nREFeohvh2e5y9WORofSKRTAr3R6MOAyoiaDrzHaFEkdEVmPrWWqAId3DnZ8A26YN4fgG8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687811205; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lp6KR88j71QtkzhoL0VNQhU+0wKLrKZSfG0XhX5V00g=; b=NcQMPh2ise80FdUYpyHK8xDfd9QIBgQdcrmogiUj1GybghRYNxc/YKc9qVUXuJjXc/6DD2RSpr+g1IHdJlqH5NH2xaxmtrxXrNSy1yDVsb66zLuZ+/bowGjDtj6Sy4fxq68tBmz+Zl6jCAkG2Yh0Q4/ucn9RkEQ8Pz5m36hTrYQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687811205358610.4158182971713; Mon, 26 Jun 2023 13:26:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsm8-0005eB-Cw; Mon, 26 Jun 2023 16:25:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsm0-0005aP-Pe for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:22 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsly-000550-Kh for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:20 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-313e12db357so4046618f8f.0 for ; Mon, 26 Jun 2023 13:25:18 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id v2-20020a5d6102000000b003127a21e986sm8193795wrt.104.2023.06.26.13.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:25:16 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3FA4E1FFBC; Mon, 26 Jun 2023 21:25:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687811117; x=1690403117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lp6KR88j71QtkzhoL0VNQhU+0wKLrKZSfG0XhX5V00g=; b=YNUvfeAsZnV6/D+m7nIKOhHvM//ambdKCHNu2NuJLqSCW6R7qjNRtBh8+1Gbbju8je 59akoxOgEOFIczhZCF5+VbHdwqnrEYHtPLAQkVcd8+1boQPAqo2RouW8Qw9Fq6zotyC+ TLOzwMpx/6hrBqKeiqqp3gyJO5XyDfOUduBi7VhiVr7USBEZCFZXkASoO1FLaQp5zGOo aZFY7OD6J5kyuwO7TjQMUY1o8t42EOwP66Vr+1SWi3ghxfn9kJJ1LOc+ZNymLFWeK2kK 3ypSMtE8kDpX1jaY57KCTDRryZuhgzixifvPbu5RzteEZh2kSemD0yhYTTl4qKRlzxRL NLqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687811117; x=1690403117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lp6KR88j71QtkzhoL0VNQhU+0wKLrKZSfG0XhX5V00g=; b=EyRpdKxPB0T95ya3clLVxIziLbQLBdluhPWOGkEiLv9vdbII8K6rhIC+DwnEMkT3BO 3DP3jMoTKbp1GYObB2L0uNp11pJov1DxK16mpE9wEnCavHES7p54mNGICb85K0cCmgJE BYa5+/LwAFomDY4N0BuT/GFne8a7mvXmw+9X7l35JLscjc24V5u8OQGFf/Q5///XlDvK 5ZwcLvBq94BrWzabRAUCjBLivhiHVov9xcamaUOSROrBz0WI5kh7jvEytGZfABcPVDLl lSu1mu6fiWonAkbGqIyQwnAQX8qwnlUF/D5W+l/SCtzWRnfDMTJyewp+rJBS2aB/9ryR tRcw== X-Gm-Message-State: AC+VfDyF3+wRaOkmgTnWgYe/pGLZAsBR61bb7aLnbaUVX1EBhTD8hx3v H3aY6SBRCxNUnBoMQUQEQmLyUg== X-Google-Smtp-Source: ACHHUZ5417vKcdfoQDXWpn45rLUWM3KElM+aZCLyvqw37LblVv1hJGTKdujRMn7ebfnvK4HAjnLgGg== X-Received: by 2002:adf:efca:0:b0:313:f6fc:1f48 with SMTP id i10-20020adfefca000000b00313f6fc1f48mr1804084wrp.14.1687811117190; Mon, 26 Jun 2023 13:25:17 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Qiuhao Li , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Juan Quintela , Marcin Juszkiewicz , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Alexandre Iooss , Peter Xu , Yanan Wang , Mahmoud Mandour , Peter Maydell , Bin Meng , Marcel Apfelbaum , Beraldo Leal , Richard Henderson , Leif Lindholm , Paolo Bonzini , Thomas Huth , Riku Voipio , Cleber Rosa , Alexander Bulekov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Bandan Das , Leonardo Bras , qemu-arm@nongnu.org, Darren Kenny , Wainer dos Santos Moschetta , Laurent Vivier Subject: [PATCH v2 1/6] gitlab: explicit set artifacts publishing criteria Date: Mon, 26 Jun 2023 21:25:10 +0100 Message-Id: <20230626202516.2507915-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626202516.2507915-1-alex.bennee@linaro.org> References: <20230626202516.2507915-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1687811205958100003 From: Daniel P. Berrang=C3=A9 If not set explicitly, gitlab assumes 'when: on_success" as the publishing criteria for artifacts. This is reasonable if the artifact is an output deliverable of the job. This is useless if the artifact is a log file to be used for debugging job failures. This change makes the desired criteria explicit for every job that publishes artifacts. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20230623122100.1640995-2-alex.bennee@linaro.org> Message-Id: <20230503145535.91325-2-berrange@redhat.com> Signed-off-by: Alex Benn=C3=A9e --- .gitlab-ci.d/buildtest-template.yml | 4 +++- .gitlab-ci.d/buildtest.yml | 2 ++ .gitlab-ci.d/crossbuild-template.yml | 1 + .gitlab-ci.d/crossbuilds.yml | 2 ++ .gitlab-ci.d/opensbi.yml | 1 + 5 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-t= emplate.yml index 5da61f4277..f3e39b7eb1 100644 --- a/.gitlab-ci.d/buildtest-template.yml +++ b/.gitlab-ci.d/buildtest-template.yml @@ -25,6 +25,7 @@ # rebuilding all the object files we skip in the artifacts .native_build_artifact_template: artifacts: + when: on_success expire_in: 2 days paths: - build @@ -53,6 +54,7 @@ extends: .common_test_job_template artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" + when: always expire_in: 7 days paths: - build/meson-logs/testlog.txt @@ -68,7 +70,7 @@ policy: pull-push artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" - when: on_failure + when: always expire_in: 7 days paths: - build/tests/results/latest/results.xml diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index aa833b62ca..24bba061cd 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -462,6 +462,7 @@ gcov: coverage: /^\s*lines:\s*\d+.\d+\%/ artifacts: name: ${CI_JOB_NAME}-${CI_COMMIT_REF_NAME}-${CI_COMMIT_SHA} + when: on_success expire_in: 2 days reports: coverage_report: @@ -587,6 +588,7 @@ pages: - make -C build install DESTDIR=3D$(pwd)/temp-install - mv temp-install/usr/local/share/doc/qemu/* public/ artifacts: + when: on_success paths: - public variables: diff --git a/.gitlab-ci.d/crossbuild-template.yml b/.gitlab-ci.d/crossbuild= -template.yml index 6efb0d2a54..d97611053b 100644 --- a/.gitlab-ci.d/crossbuild-template.yml +++ b/.gitlab-ci.d/crossbuild-template.yml @@ -55,6 +55,7 @@ .cross_test_artifacts: artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" + when: always expire_in: 7 days paths: - build/meson-logs/testlog.txt diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 1e0e6c7f2c..34f9df2be9 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -169,6 +169,7 @@ cross-win32-system: CROSS_SKIP_TARGETS: alpha-softmmu avr-softmmu hppa-softmmu m68k-softmmu microblazeel-softmmu mips64el-softmmu nios2-softmmu artifacts: + when: on_success paths: - build/qemu-setup*.exe =20 @@ -184,6 +185,7 @@ cross-win64-system: or1k-softmmu rx-softmmu sh4eb-softmmu sparc64-soft= mmu tricore-softmmu xtensaeb-softmmu artifacts: + when: on_success paths: - build/qemu-setup*.exe =20 diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml index b4d7eef688..fd293e6c31 100644 --- a/.gitlab-ci.d/opensbi.yml +++ b/.gitlab-ci.d/opensbi.yml @@ -63,6 +63,7 @@ build-opensbi: stage: build needs: ['docker-opensbi'] artifacts: + when: on_success paths: # 'artifacts.zip' will contains the following files: - pc-bios/opensbi-riscv32-generic-fw_dynamic.bin - pc-bios/opensbi-riscv64-generic-fw_dynamic.bin --=20 2.39.2 From nobody Wed Feb 11 00:59:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1687811192; cv=none; d=zohomail.com; s=zohoarc; b=hocEkZDCsN4TAwFZEjEs5ikKvWW4JdvlM1iQzgB/eGqKRAupdVisjc774AGzoQ2kuTmcr/tvE5V611v18aTq1dtCwyE5u90cAMV4K0kqieXY6f5HiCwvvjrphveomvJkR+4cYanXW3O9xlNhlZneNY6r0Xorkf1MZCl8kC4aBmA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687811192; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PkkwaC5weGbOgI6TyHV8oGFM7+1AeUMfWTRfSlmxtvc=; b=dAm1jEGdS1X3cRM8KbmcYMQ/eUcC1P8R0qIR+/DqfHWBTXzNE/RH/y/G+OQ6HPpZ7XGYajgqDOBGGT+EVgtwoIiwrFn8oxXj0cezMznG3T4X/nd/3eR/FTruzjyp8jJ6LsyWIazhfBSNdMR29GygFF+ezVgBUPUHCCq3jtv1S+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687811192623907.3975604248117; Mon, 26 Jun 2023 13:26:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsmE-0005qp-Pc; Mon, 26 Jun 2023 16:25:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsm4-0005c1-DU for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:24 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsm0-00055L-HE for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:23 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fa9850bfebso12645155e9.1 for ; Mon, 26 Jun 2023 13:25:19 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id m5-20020a05600c238500b003f900678815sm8700257wma.39.2023.06.26.13.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:25:17 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 588C61FFBD; Mon, 26 Jun 2023 21:25:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PkkwaC5weGbOgI6TyHV8oGFM7+1AeUMfWTRfSlmxtvc=; b=mDaGz5jUFVjy4wOdgoQO36PtD35lqRYewem3qlYGLWlSMw4g92vVp3+pzFU9kXjrGe 2/wxdpneS/M8wT3ZS7KYOVdlXhblzKzMDr0FndcYO7CkgKjso5fQIUcQtnE/LuHCdhE5 WveJMKvEXqXyGzOGwRPCC8xkBnoWWQzWVIwRI3lycPzq6ie4lGUd4QufOZPkyvcfHPV3 Z+bnZ/RZKI8Fe/Lh/nAx3a0NJK7fFdvp3yRhVcWLAwZSFTefLL5cEe2Nk1Jo07Kvj/Ti aFM/H5HCWqVA9szm3t2lzLRp8T1N2ogbN+i0UEfqfuC66PZOdT0s5rYrWfbytqbDKfOn ahCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PkkwaC5weGbOgI6TyHV8oGFM7+1AeUMfWTRfSlmxtvc=; b=HUmCbIjtPzLPC9DEjYi3T+467btis2jR7YiWOQmEwEIylS2DZb1bo4VtrG8mCTrM/W TGAzJP4bB/Us+iDDOtZdnUBynbX00PDEh4CFTra0d8TaGIQl4C+azpn6gE0iGvpu4T97 D4kEf4UWQgcjTgHV9fv+NsN4RPBskPb2egX4X8Cxd4yonef+4SNer6wZ5BtP4nSsQYVv jJJW0T6vhU7RW7rGFCDLMqoeeQeU3MoCbDrK88Q6S17UmlXFkODhPXn1giDBYq4moKwc I5wbi438n/MKh8xmv9TGUWeOYwTa7RGbmt3NccA5ep3bO8h/3GZQG7lvf8u+CzQFQf6k JV2A== X-Gm-Message-State: AC+VfDwgItMVEAqnzXpCicMpYSQ1OGDnqU5GiFlep4prLKuxKowpBI4x 3QpVGrXhny65Jy7InAdITFGEgg== X-Google-Smtp-Source: ACHHUZ4QUZ7VWYymdsjfMJpXTA4tXou6NDi36JgTmd9wHZrdTyLUnXrmdQYJeU9JOtihf/DlzjW+Gw== X-Received: by 2002:a7b:c409:0:b0:3fa:934c:8350 with SMTP id k9-20020a7bc409000000b003fa934c8350mr3236246wmi.27.1687811117937; Mon, 26 Jun 2023 13:25:17 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Qiuhao Li , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Juan Quintela , Marcin Juszkiewicz , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Alexandre Iooss , Peter Xu , Yanan Wang , Mahmoud Mandour , Peter Maydell , Bin Meng , Marcel Apfelbaum , Beraldo Leal , Richard Henderson , Leif Lindholm , Paolo Bonzini , Thomas Huth , Riku Voipio , Cleber Rosa , Alexander Bulekov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Bandan Das , Leonardo Bras , qemu-arm@nongnu.org, Darren Kenny , Wainer dos Santos Moschetta , Laurent Vivier Subject: [PATCH v2 2/6] gitlab: ensure coverage job also publishes meson log Date: Mon, 26 Jun 2023 21:25:11 +0100 Message-Id: <20230626202516.2507915-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626202516.2507915-1-alex.bennee@linaro.org> References: <20230626202516.2507915-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1687811193862100001 From: Daniel P. Berrang=C3=A9 The coverage job wants to publish a coverage report on success, but the tests might fail and in that case we need the meson logs for debugging. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20230623122100.1640995-3-alex.bennee@linaro.org> Message-Id: <20230503145535.91325-3-berrange@redhat.com> Signed-off-by: Alex Benn=C3=A9e --- .gitlab-ci.d/buildtest.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 24bba061cd..a8fd9a0c1f 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -462,9 +462,12 @@ gcov: coverage: /^\s*lines:\s*\d+.\d+\%/ artifacts: name: ${CI_JOB_NAME}-${CI_COMMIT_REF_NAME}-${CI_COMMIT_SHA} - when: on_success + when: always expire_in: 2 days + paths: + - build/meson-logs/testlog.txt reports: + junit: build/meson-logs/testlog.junit.xml coverage_report: coverage_format: cobertura path: build/coverage.xml --=20 2.39.2 From nobody Wed Feb 11 00:59:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1687811196; cv=none; d=zohomail.com; s=zohoarc; b=S0kHHIpxr3QAR/QEqmKdJbVUDn1kKQ9Qj5L4trFsZeLGavR3z/9K6HHU5IG9ucxXukVALzwWcUzSJdfTJDNVOkVZfu8GZpC+jLty37hDSWbzitoSzMVWZBZE5iXAY9I5UQAxdRTo+2cEBuwVehhytU4DBkr2YEykh4HufhUDvds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687811196; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VTHkiiEsGJjQzyOMxbcLNdH7rkjQKhZ4rW+u2UfYIYE=; b=adgpV7mnxqaBnlFN3/GHmVL0iewVHCdlPr+ReEnSl27CeMJQX2Uzp7SHU7+4KIb6UDF2GDoDj8NXuH3H2PuP2bjnBTfzXTI/GirHFTo4BX989c3qix9ks4B3c3QslWDukEmIxt/0T7Lnxc/Z3r2JwT+WsIQ2cYbr/Q51EV1bKaw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687811196559211.26359053616818; Mon, 26 Jun 2023 13:26:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsmG-0005t3-JR; Mon, 26 Jun 2023 16:25:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsm5-0005d9-Bv for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:25 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsm2-00055U-Fd for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:25 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f9b4bf99c2so48109095e9.3 for ; Mon, 26 Jun 2023 13:25:19 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id p9-20020a05600c204900b003f93c450657sm8626035wmg.38.2023.06.26.13.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:25:17 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 71B171FFBE; Mon, 26 Jun 2023 21:25:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VTHkiiEsGJjQzyOMxbcLNdH7rkjQKhZ4rW+u2UfYIYE=; b=MKK8zG4Q7FCjDHFPB1PNyce92Z+i1ui3ci07HtDI7m+wTT0RlHMLS6r0aDFkF72QE5 H+pQ0lSDHUdeLayVAKcbKnxYElXJch5SO/dP5Yt9iJxhQbF6mVXofxD9wWa2HK1g5P6t g1DhYP/Mkl/0fNGbkQVgrLNuIMcJMFDAHUq5nPLlwKTKAvtYd7JWeTallz43Q8dT9Xq/ G88/YFGOX27hNy9ne85XSU1wzaXWVuBBAkNDvJ16205HzFv013U+52C1grVZHkl7/K52 kEoCG658XXoklxhW47HLz15LX0jylwmO6miqQVHRI44+oS25HaPzIqoUipbzvtf7aruS T4ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VTHkiiEsGJjQzyOMxbcLNdH7rkjQKhZ4rW+u2UfYIYE=; b=l3FCBXoJ2bX8KFyAQrnYr1c9wlBGD0r5Ddcx1jR7BZj5ZrLRqz+gm7qVPK5tvmOYnS bnogwRFVQxLlNF1Lym+pr7SQLYXGBg4J64uyt9QN/Wo0mrFQ++RXGV6EpC2NpocHui4J mUhTEYbnay9NDBAFQWUEcG6FpDRzIBRsBfA/aBeJrUtZZxjtrF7A+AQ/+fhBZjtKNvRD Nvtxll2Ly86R54Kq/KXXr46ZmsR6P0edqpw9A9j2iyt504z3ftbt+cOSfyJp0bql0LBP zJ73frTGpFcCIBI0MeLIyU+f/rHuFWdasPtY4Qf9y2hT34h95W0Cy/a6OZelnyYCFixJ 62OQ== X-Gm-Message-State: AC+VfDzvjrB3wg1/ovLAZjjMNzPt6tsag9Gk82ITMGSS6F0k7mPqBEd2 RsgLCzQXPt1fQDGyQUDXqg9JZA== X-Google-Smtp-Source: ACHHUZ7rByVNZ9USQd0sazcRQfCdEfHL5SViOE4UgA+1WQvibiSdRfBlzBhZaDGF9Fa1SRSoRXe7sQ== X-Received: by 2002:a1c:7507:0:b0:3f7:678c:74b0 with SMTP id o7-20020a1c7507000000b003f7678c74b0mr22472542wmc.12.1687811118336; Mon, 26 Jun 2023 13:25:18 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Qiuhao Li , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Juan Quintela , Marcin Juszkiewicz , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Alexandre Iooss , Peter Xu , Yanan Wang , Mahmoud Mandour , Peter Maydell , Bin Meng , Marcel Apfelbaum , Beraldo Leal , Richard Henderson , Leif Lindholm , Paolo Bonzini , Thomas Huth , Riku Voipio , Cleber Rosa , Alexander Bulekov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Bandan Das , Leonardo Bras , qemu-arm@nongnu.org, Darren Kenny , Wainer dos Santos Moschetta , Laurent Vivier Subject: [PATCH v2 3/6] gitlab: reduce testing scope of check-gcov Date: Mon, 26 Jun 2023 21:25:12 +0100 Message-Id: <20230626202516.2507915-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626202516.2507915-1-alex.bennee@linaro.org> References: <20230626202516.2507915-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1687811198082100001 This keeps timing out on gitlab due to some qtests taking a long time. As this is just ensuring the gcov machinery is working and not attempting to be comprehensive lets skip qtest in this run. Message-Id: <20230623122100.1640995-4-alex.bennee@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e --- .gitlab-ci.d/buildtest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index a8fd9a0c1f..77dc83a6be 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -454,7 +454,7 @@ gcov: IMAGE: ubuntu2204 CONFIGURE_ARGS: --enable-gcov TARGETS: aarch64-softmmu ppc64-softmmu s390x-softmmu x86_64-softmmu - MAKE_CHECK_ARGS: check + MAKE_CHECK_ARGS: check-unit check-softfloat after_script: - cd build - gcovr --xml-pretty --exclude-unreachable-branches --print-summary --=20 2.39.2 From nobody Wed Feb 11 00:59:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1687811224; cv=none; d=zohomail.com; s=zohoarc; b=U1fDxpALgp5rLqBa+taRaeDY1/gUQ5A21V/RfaZI5QDrKuAdMqw+bUG1l31XCTaTbn9MtnaH5SaQjGgxTAeHUDKuHeKMSV7xdprPyr4tbT4otv3X9n/F/jCQSZCezGMN4801zpBIfkMBMgw78wyjdy+/TIDm3ddHalAzlK2py/k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687811224; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; b=U8pcZedWntOwssGw4w/0YC0bQEC6gc6hUUkymuUfzHbTGpxebNog8giLoDM4pX2yj8n/+12PlTNXr7vCXw0gC/NxKTGWhiD8/fCFP0JGJ+WPjNZSnLbwsSaenLQacKIg8tbbl4oH0aaXGI7eJOD/m5gHp71c0TL1j3r0/Wvd1a4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687811224644490.3681672898606; Mon, 26 Jun 2023 13:27:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsmH-0005uY-5a; Mon, 26 Jun 2023 16:25:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsm5-0005dC-Ml for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:26 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsm2-00055Q-GH for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:25 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-313f3a6db22so1316646f8f.3 for ; Mon, 26 Jun 2023 13:25:19 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id o10-20020a5d58ca000000b0031128382ed0sm8283322wrf.83.2023.06.26.13.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:25:17 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8A25F1FFBF; Mon, 26 Jun 2023 21:25:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; b=rlEhtYgZC/4LHm7w+Tx/oFBYOax+Ydar4y/83sQWoE7RAwC27lNK6f2/6Ivk8JHaOi NcgFkfqMY063tNjgm/xXa/Hi/zkMe5doCvIup/NeR0VgZKvXSjqlVweX9lVhPIuRXtEN fwlAbibbqsEsylWCB0a30oa1svi9ftwR81qm96uzN3m/l9KyKUT6Bv1RxI3PTOnBYL+u O3Iw5i3ApPy7SZEc1+n2hu0Ta1iD40h9oiDD1YhZV3CkmOEx5iEVL3hVcZiUJAiNerQr 3GVgWuemE3f6NBW86mxJmvx4vWQajYXYxyKOoAiiJxQnw2FAQmZpSOAKl06t31zmQoIe 7jZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; b=ZHKAFHEUYsc9lyDayCIX9E8r3fDeuSj1OCkSFpYF2tvrbzHh9xoYMhcidrzFKPvuZl Co37SYRLjVFssr0gnH20h3zFRnceg4gtZ1ZFielSeVMSAfIsaEaMol5dKjnTm8NJZcQQ ailZrFDIyrIJXYnk97C0qDJsoHrIA0yBBcypmMqSBGEiFvBFKYB2vzknyosVrBZcTtLw kVkHjAHpyVcJE+CUTQQ1LbpQg1OCEI4Sg+cFSd17SRJVnbc8j4PnH6f7kxYPIrda0SJe p5IvJlLH8DR1nPU/m3S/EDmmQMcxbVRwvnwynLUlHpIYKv4J9D1m4Mn6bxdkVEOh9pgd 4TQw== X-Gm-Message-State: AC+VfDxZgVBxZpNuWlzy8M+MMlIvtZBu/iHMV/xZyknYPKYSqtUiNp7m Wjgpv9gUPg/IYDPA4yDg1JCo3w== X-Google-Smtp-Source: ACHHUZ4PpJai4S5/hyfdf42c0Hcs5wcQ+OynL0/pARGzdiZxmzmXkgJJbKpW4Bl2dhQj0RxIx2zA6A== X-Received: by 2002:adf:f711:0:b0:313:e553:b858 with SMTP id r17-20020adff711000000b00313e553b858mr5694878wrp.33.1687811118166; Mon, 26 Jun 2023 13:25:18 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Qiuhao Li , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Juan Quintela , Marcin Juszkiewicz , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Alexandre Iooss , Peter Xu , Yanan Wang , Mahmoud Mandour , Peter Maydell , Bin Meng , Marcel Apfelbaum , Beraldo Leal , Richard Henderson , Leif Lindholm , Paolo Bonzini , Thomas Huth , Riku Voipio , Cleber Rosa , Alexander Bulekov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Bandan Das , Leonardo Bras , qemu-arm@nongnu.org, Darren Kenny , Wainer dos Santos Moschetta , Laurent Vivier , Ani Sinha Subject: [PATCH v2 4/6] docs/devel: remind developers to run CI container pipeline when updating images Date: Mon, 26 Jun 2023 21:25:13 +0100 Message-Id: <20230626202516.2507915-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626202516.2507915-1-alex.bennee@linaro.org> References: <20230626202516.2507915-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1687811226444100005 From: Ani Sinha When new dependencies and packages are added to containers, its important to run CI container generation pipelines on gitlab to make sure that there are= no obvious conflicts between packages that are being added and those that are already present. Running CI container pipelines will make sure that there a= re no such breakages before we commit the change updating the containers. Add a line in the documentation reminding developers to run the pipeline before submitting the change. It will also ease the life of the maintainers. Signed-off-by: Ani Sinha Reviewed-by: Daniel P. Berrang=C3=A9 Message-Id: <20230506072012.10350-1-anisinha@redhat.com> Signed-off-by: Alex Benn=C3=A9e --- docs/devel/testing.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 203facb417..8f18052ba7 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` = project: `CI `__ documentation page on how to trigger gitlab CI pipelines on your change. =20 + * Please also trigger gitlab container generation pipelines on your change + for as many OS distros as practical to make sure that there are no + obvious breakages when adding the new pre-requisite. Please see + `CI `__ documentation + page on how to trigger gitlab CI pipelines on your change. + For enterprise distros that default to old, end-of-life versions of the Python runtime, QEMU uses a separate set of mappings that work with more recent versions. These can be found in ``tests/lcitool/mappings.yml``. --=20 2.39.2 From nobody Wed Feb 11 00:59:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1687811227; cv=none; d=zohomail.com; s=zohoarc; b=LlWejz8XDZG3Jpm01zKA5RCZhku39EVNIlG3vx8Somf7ATvE4DehMOMijOy+jQWSdMXsTK2Afv7xC29Z0d2oO3qFOOYAQtoDGYK1lnN14bBpUEkn8ZeNdVK2HxG0A2D7ano3P9v09vQX3tiKiK0MXEMOch9C20klLQ0MDjZmtV8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687811227; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=I9YIwoz2syzBIvgIfb1KrTiedkOwekCcwMFZMGMcvn4=; b=dVUm3ukgGWaF2m69D5NGw2rHKrQY9Tl5MOthkbc01PdaGXFDul5EIv+RBtLQTLla04iS4Xnz97y5qPVvYUpdqeIR401qH7oxf6nD+qEBFE50CcqBy7GJTxFeomeYXQPrMonPz2rgvVqxomb8RCa+nwo+TKt5lIWE7wjUhOTrVPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687811227241903.8578749115278; Mon, 26 Jun 2023 13:27:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsmI-0005za-0F; Mon, 26 Jun 2023 16:25:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsm5-0005dA-CW for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:25 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsm2-00055s-Fy for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:25 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-313f58d6652so1159649f8f.2 for ; Mon, 26 Jun 2023 13:25:20 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id t24-20020a1c7718000000b003f91e32b1ebsm11506372wmi.17.2023.06.26.13.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:25:18 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A447E1FFC0; Mon, 26 Jun 2023 21:25:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687811119; x=1690403119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I9YIwoz2syzBIvgIfb1KrTiedkOwekCcwMFZMGMcvn4=; b=rVhts01UgxFKWFD6Ed4/uRW1uKUHrgq1waUaAUJ8PfdUVhVgqj0Q+O29ZeoatrHHzU GTvAGqOIXa9E04Oc2E+7hYhS6SGrAHr4CGtKP/ZD9Ba2te6FcxLvqWwA89RC59gemeZy fvUJN5vb1K25J4O0o8Vp+KG4Fhy+/qdMf1fageBgCXmcY02ds5cKfemzuT+qs1lvD1JD WOuqkBcOgG+j47RjOntogoNo7nHYTvylQXlxm3QB/gEy05FQpsWwPiiZAwJTyfkNjp3v w+TTbIP9XhbnTXABqIMEjMat3q90y3FkKOzXK+of7I5rkZQjZKYIVgr5VhTErui/DAHQ rtxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687811119; x=1690403119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I9YIwoz2syzBIvgIfb1KrTiedkOwekCcwMFZMGMcvn4=; b=iTf1Fra3/3OmIBJ7Yl9wmP2+/6D1GGDxDUQJQrAr2ULuV7H5yuRdKNlKFNwgfUkvM/ +75OUXaRS5bs7UryI/ZiFgshl98rnB+7KOufUxNJhC56i5dlBkzEHAWHtaLeGPJ4Iv7N pyTShvBt7JLw1/5v2stVKr1AFLkD+w9jCQ/qUT1gcChYvma4R+a0IlmpbuU5k0TadswU 8V3FIEIsCZPxmLU99E488vMMyBaQfPPOVdHZDPV6XQs7DW6E0TseUXAryy6VTMoQkyDI YUmPKB8zGgqHgihi9I9PCtxHoe+fZrpX05bzdHFDnERJyPMZW2ed0Cwm2o2GKvhhMdhw iBWA== X-Gm-Message-State: AC+VfDzZ5CYW5mx5JnBoh1yrWjtxDmdkZYVU1jns2fN91tNAT6G/9Sme E5aqwa+a2AYmVLVfn9Zs2KkYpA== X-Google-Smtp-Source: ACHHUZ71GG6kpbvuIhKR6xz3KUOK4+H7HTMD3ViibWP6ftr1LB29YXUrs/7yL556fmPhfkupW2R30w== X-Received: by 2002:adf:f752:0:b0:313:f54a:a842 with SMTP id z18-20020adff752000000b00313f54aa842mr2067793wrp.63.1687811119177; Mon, 26 Jun 2023 13:25:19 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Qiuhao Li , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Juan Quintela , Marcin Juszkiewicz , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Alexandre Iooss , Peter Xu , Yanan Wang , Mahmoud Mandour , Peter Maydell , Bin Meng , Marcel Apfelbaum , Beraldo Leal , Richard Henderson , Leif Lindholm , Paolo Bonzini , Thomas Huth , Riku Voipio , Cleber Rosa , Alexander Bulekov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Bandan Das , Leonardo Bras , qemu-arm@nongnu.org, Darren Kenny , Wainer dos Santos Moschetta , Laurent Vivier Subject: [PATCH v2 5/6] tests/tcg: add mechanism to handle plugin arguments Date: Mon, 26 Jun 2023 21:25:14 +0100 Message-Id: <20230626202516.2507915-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626202516.2507915-1-alex.bennee@linaro.org> References: <20230626202516.2507915-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1687811227999100009 We recently missed a regression that should have been picked up by check-tcg. This was because the libmem plugin is effectively a NOP if the user doesn't specify the type to use. Rather than changing the default behaviour add an additional expansion so we can take this into account in future. Message-Id: <20230623122100.1640995-6-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- tests/tcg/Makefile.target | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 72876cc84e..2462c26000 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -169,13 +169,17 @@ extract-plugin =3D $(wordlist 2, 2, $(subst -with-, ,= $1)) =20 RUN_TESTS+=3D$(EXTRA_RUNS) =20 +# Some plugins need additional arguments above the default to fully +# exercise things. We can define them on a per-test basis here. +run-plugin-%-with-libmem.so: PLUGIN_ARGS=3D$(COMMA)inline=3Dtrue$(COMMA)ca= llback=3Dtrue + ifeq ($(filter %-softmmu, $(TARGET)),) run-%: % $(call run-test, $<, $(QEMU) $(QEMU_OPTS) $<) =20 run-plugin-%: $(call run-test, $@, $(QEMU) $(QEMU_OPTS) \ - -plugin $(PLUGIN_LIB)/$(call extract-plugin,$@) \ + -plugin $(PLUGIN_LIB)/$(call extract-plugin,$@)$(PLUGIN_ARGS) \ -d plugin -D $*.pout \ $(call strip-plugin,$<)) else @@ -189,7 +193,7 @@ run-plugin-%: $(call run-test, $@, \ $(QEMU) -monitor none -display none \ -chardev file$(COMMA)path=3D$@.out$(COMMA)id=3Doutput \ - -plugin $(PLUGIN_LIB)/$(call extract-plugin,$@) \ + -plugin $(PLUGIN_LIB)/$(call extract-plugin,$@)$(PLUGIN_ARGS) \ -d plugin -D $*.pout \ $(QEMU_OPTS) $(call strip-plugin,$<)) endif --=20 2.39.2 From nobody Wed Feb 11 00:59:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1687811223; cv=none; d=zohomail.com; s=zohoarc; b=VEcYNTXYmjueAowP0WYvefJc5YZ88C1YG2P75mr6IpSUD8u+Oc7bS10aPfMG4hPP75t2frP6d4Q/Rv6/4Nl8lvdbu6r3DAy34y82Cn9hXNJuqb8X7M5rmu1vGm6p9UNrK0FZb4SBBJtxeA6lZCWLK7hFjWAvzEPT8kHYv/9Mitk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687811223; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UiwEwjAi6lomr9E2iVsjR5pQJHgLNYXOTgd+ktx/cfE=; b=FRqAl5F4Zcu89gjYVyuR85a/DqhHkw4pNiw4rIg4/v8gCNRCK3NlWOsetRO4cPHHH+KUG/OdJkKahai3SgO0LLgG8dujworGzpA97nODefVSRM2XVDYFUVfWXeOLJOYtZWpLS/XkuCqS5c5EKlBU6pVHBeNujRaOeYMSGzoSeV4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687811223561413.52515424177307; Mon, 26 Jun 2023 13:27:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsmH-0005te-2R; Mon, 26 Jun 2023 16:25:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsm5-0005d7-7P for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:25 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsm2-000567-G4 for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:24 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fa7cd95dacso46160795e9.3 for ; Mon, 26 Jun 2023 13:25:20 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id f10-20020a7bcd0a000000b003fa99969e61sm3018272wmj.45.2023.06.26.13.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:25:18 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id BBFB31FFC1; Mon, 26 Jun 2023 21:25:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687811119; x=1690403119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UiwEwjAi6lomr9E2iVsjR5pQJHgLNYXOTgd+ktx/cfE=; b=iu7d9Ue0an7YMNwlflrR3yzAETx5HgQUv/Y6Q+TSzzSQi8fCCUPoGxY7yBeG+hIYZU OZ0O5i4OVltg1k5l5sHWoog895CzR9B/aIct82pQYJnwmT2X59KBk6RxJ8TijccdiHCq hVCSMAqrRr9mddIjOUFVs0rJHNWVDlzosPymLYNwdqTvSmVxbmYyoAF+7LnR6UUgfPNX 7euKiM18I4M9wQpbcmyQH6ku9kDE4XGwjxR0O/VvuyDd48iFA/9JriKUf1Sh7cHWoB8g zBKmpkXflTAYgihJ8AIYSNmD1MUR/sdy4waXf2RQFBM0IzzzKAUkOUqez4/d4snknyWk i4dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687811119; x=1690403119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UiwEwjAi6lomr9E2iVsjR5pQJHgLNYXOTgd+ktx/cfE=; b=MJJZ1Sxno1j8S9o7ZCAd1GuItj0cUXYwr5EVo5iUvoPlzIXh77+827NnURwiqMH8cW VP0yZBE+U/+A3Tx2vjneJlwm7XA/CRA3yA+QFEt8jUZEpmpFa83Rg6gpD5z3H9AwZkQ9 fudffK45f7+nCX290mRrwskOBZUUyBTLGsX7L+lx+zizN4XymYh2/XX74mtP22R//PMw rhI75nIR6N+U3kCadzkSWEv99QsqafkDVpJPHq3i96WmEqdg3V+jiPy3qLOQKCAPaQRw x7W7YlNX1Eah6TaXz8mxTqE5lPrentn2k0CID602wOfsLK2Lje+dPO5+KYHAudJlnL4u lhMQ== X-Gm-Message-State: AC+VfDzkqD60sFh4CF+Unt4GfoCV5HRKfz2AtkssiFnDFGUpz5mgD9I3 8nFehB5J27veWoyZF6f7JLKXFg== X-Google-Smtp-Source: ACHHUZ6pChy/Lf/ZiVXPV7+3Sb1tV8HaDxsVOP5x9pGjnWkY7Ppdn2+5g/ZeDJRSUkvTpfYJZmy11A== X-Received: by 2002:a1c:7c04:0:b0:3fa:85c6:57ff with SMTP id x4-20020a1c7c04000000b003fa85c657ffmr5796679wmc.16.1687811119406; Mon, 26 Jun 2023 13:25:19 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Qiuhao Li , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Juan Quintela , Marcin Juszkiewicz , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Alexandre Iooss , Peter Xu , Yanan Wang , Mahmoud Mandour , Peter Maydell , Bin Meng , Marcel Apfelbaum , Beraldo Leal , Richard Henderson , Leif Lindholm , Paolo Bonzini , Thomas Huth , Riku Voipio , Cleber Rosa , Alexander Bulekov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Bandan Das , Leonardo Bras , qemu-arm@nongnu.org, Darren Kenny , Wainer dos Santos Moschetta , Laurent Vivier Subject: [PATCH v2 6/6] qemu-keymap: properly check return from xkb_keymap_mod_get_index Date: Mon, 26 Jun 2023 21:25:15 +0100 Message-Id: <20230626202516.2507915-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626202516.2507915-1-alex.bennee@linaro.org> References: <20230626202516.2507915-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1687811224036100001 We can return XKB_MOD_INVALID which rightly gets flagged by sanitisers as an overly wide shift attempt. Signed-off-by: Alex Benn=C3=A9e --- qemu-keymap.c | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/qemu-keymap.c b/qemu-keymap.c index 229866e004..8c80f7a4ed 100644 --- a/qemu-keymap.c +++ b/qemu-keymap.c @@ -140,6 +140,18 @@ static void usage(FILE *out) names.options ?: "-"); } =20 +static xkb_mod_mask_t get_mod(struct xkb_keymap *map, const char *name) +{ + xkb_mod_index_t mod; + xkb_mod_mask_t mask =3D 0; + + mod =3D xkb_keymap_mod_get_index(map, name); + if (mod !=3D XKB_MOD_INVALID) { + mask =3D (1 << mod); + } + return mask; +} + int main(int argc, char *argv[]) { struct xkb_context *ctx; @@ -215,14 +227,10 @@ int main(int argc, char *argv[]) mod, xkb_keymap_mod_get_name(map, mod)); } =20 - mod =3D xkb_keymap_mod_get_index(map, "Shift"); - shift =3D (1 << mod); - mod =3D xkb_keymap_mod_get_index(map, "Control"); - ctrl =3D (1 << mod); - mod =3D xkb_keymap_mod_get_index(map, "AltGr"); - altgr =3D (1 << mod); - mod =3D xkb_keymap_mod_get_index(map, "NumLock"); - numlock =3D (1 << mod); + shift =3D get_mod(map, "Shift"); + ctrl =3D get_mod(map, "Control"); + altgr =3D get_mod(map, "AltGr"); + numlock =3D get_mod(map, "NumLock"); =20 state =3D xkb_state_new(map); xkb_keymap_key_for_each(map, walk_map, state); --=20 2.39.2