From nobody Wed Jun 26 16:00:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1687661452; cv=none; d=zohomail.com; s=zohoarc; b=js6xV2Mc0DpgLafYRmxEMKMjtvTN63fTAf7buCD/1SpFa38M8S+AdRZVtQKTWx6aRJeQ7HkC1+HZ/SNJXl61RWd64CamsL7fwr7quW3/efbdHhXfpNZ8fVY0go8iuKUvVs5Kb/hf2hfSRDhzCUK4Ur17mWQ7zkPhuI9Zpolk3OM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687661452; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=lHOgmtQNzLcrquol38mdt4/Uk3UyxUBy7BH05Y99YDw=; b=QukyCxHrUiDbltPtk5iamMEIuwEE09AKsDlkekDGSY8/OlGSPZnBaI2HDKEhZNs8G6c3uLLfdBDjuz1MkcVt6KlpObaZ+CJ6D6IWrCmXWidBv4C3DkarWnDCHXIiibBSKmzZ1NPfSPbbFvdzr/VxMgUi/YTjV6usJs5SZw6d2Zk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<18622748025@163.com> (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687661452527752.8332416284694; Sat, 24 Jun 2023 19:50:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDFpe-0001UE-4i; Sat, 24 Jun 2023 22:50:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <18622748025@163.com>) id 1qDFpc-0001Th-HY for qemu-devel@nongnu.org; Sat, 24 Jun 2023 22:50:28 -0400 Received: from m12.mail.163.com ([220.181.12.215]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <18622748025@163.com>) id 1qDFpa-0000Cr-6O for qemu-devel@nongnu.org; Sat, 24 Jun 2023 22:50:28 -0400 Received: from localhost.localdomain (unknown [103.3.97.171]) by zwqz-smtp-mta-g5-2 (Coremail) with SMTP id _____wDXouRtq5dkDQ1RAw--.57513S2; Sun, 25 Jun 2023 10:50:22 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=lHOgmtQNzLcrquol38 mdt4/Uk3UyxUBy7BH05Y99YDw=; b=Q/YxOA2FLC+CeBRHJpTgzKtWeEWq19vquU W7mWwnUsEFcyaCyU9QX0eIDjFBoi/O7FyiIPjrP3tkDejYwgYYK6bGDu97iF3FE1 eYQO5cDoqT1bHbrN65ejGPjcGDN4AgSHJfzfMuDez8cEOiZlJ4DHVZEjFed55GpJ 7kXVkoSPU= From: "liguang.zhang" <18622748025@163.com> To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, alistair23@gmail.com, "liguang.zhang" Subject: [PATCH] target/riscv: fix the issue of guest reboot then no response or crash in kvm-mode Date: Sun, 25 Jun 2023 10:50:18 +0800 Message-Id: <20230625025018.26956-1-18622748025@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: _____wDXouRtq5dkDQ1RAw--.57513S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxXw17JrWrXrW5ZrWrCryDWrg_yoWrtrW8pF 4DCa98Cr4rt3yxJw1ftFyDJr1rW3yI9FsxArW7ur4SyF45JrZ8J3Z2k3y7Ar98GFy8urWa kFW5GF13uayUta7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07bezVbUUUUU= X-Originating-IP: [103.3.97.171] X-CM-SenderInfo: bpryljasxumiisv6il2tof0z/1tbiyA+ZWVp7KzHzOAAAs3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=220.181.12.215; envelope-from=18622748025@163.com; helo=m12.mail.163.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FROM_LOCAL_DIGITS=0.001, FROM_LOCAL_HEX=0.006, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_BL=0.001, RCVD_IN_MSPIKE_L3=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @163.com) X-ZM-MESSAGEID: 1687661453276100001 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "liguang.zhang" There are two issues when rebooting a guest using KVM 1. When the guest initiates a reboot the host is unable to stop the vcpu 2. When running a SMP guest the qemu monitor system_reset causes a vcpu cra= sh This can be fixed by clearing the CSR values at reset and syncing the MPSTATE with the host. kernel log ```shell $reboot The system is going down NOW! Sent SIGTERM to all processes logout Sent SIGKILL to all processes Requesting system reboot ``` then no response for qemu command: $system_reset: kernel log: ```shell [ 53.739556] kvm [150]: VCPU exit error -95 [ 53.739563] kvm [148]: VCPU exit error -95 [ 53.739557] kvm [149]: VCPU exit error -95 [ 53.740957] kvm [149]: SEPC=3D0x0 SSTATUS=3D0x200004120 HSTATUS=3D0x2002= 001c0 [ 53.740957] kvm [148]: SEPC=3D0x0 SSTATUS=3D0x200004120 HSTATUS=3D0x2002= 001c0 [ 53.741054] kvm [148]: SCAUSE=3D0x14 STVAL=3D0x0 HTVAL=3D0x0 HTINST=3D0x0 [ 53.741058] kvm [149]: SCAUSE=3D0x14 STVAL=3D0x0 HTVAL=3D0x0 HTINST=3D0x0 [ 53.756187] kvm [150]: SEPC=3D0x0 SSTATUS=3D0x200004120 HSTATUS=3D0x2002= 001c0 [ 53.757797] kvm [150]: SCAUSE=3D0x14 STVAL=3D0x0 HTVAL=3D0x0 HTINST=3D0x0 ``` solution: add reset csr and context for riscv vcpu qemu ioctl reset vcpu->arch.power_off state of kvm tests: qemu-system-riscv64 -M virt -bios none -kernel Image \ -smp 4 -enable-kvm \ -append "rootwait root=3D/dev/vda ro" \ -drive file=3Drootfs.ext2,format=3Draw,id=3Dhd0 \ -device virtio-blk-device,drive=3Dhd0 in guest shell: $reboot qemu command: $system_reset --- v3: - change kvm_riscv_set_mpstate_to_kvm to kvm_riscv_sync_mpstate_to_kvm - remove newline after if(cap_has_mp_state) - update submit description Signed-off-by: liguang.zhang --- target/riscv/kvm.c | 44 +++++++++++++++++++++++++++++++++++++++- target/riscv/kvm_riscv.h | 1 + 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c index 0f932a5b96..c478c71905 100644 --- a/target/riscv/kvm.c +++ b/target/riscv/kvm.c @@ -42,6 +42,8 @@ #include "migration/migration.h" #include "sysemu/runstate.h" =20 +static bool cap_has_mp_state; + static uint64_t kvm_riscv_reg_id(CPURISCVState *env, uint64_t type, uint64_t idx) { @@ -99,7 +101,7 @@ static uint64_t kvm_riscv_reg_id(CPURISCVState *env, uin= t64_t type, =20 #define KVM_RISCV_SET_TIMER(cs, env, name, reg) \ do { \ - int ret =3D kvm_set_one_reg(cs, RISCV_TIMER_REG(env, time), ®);= \ + int ret =3D kvm_set_one_reg(cs, RISCV_TIMER_REG(env, name), ®);= \ if (ret) { \ abort(); \ } \ @@ -335,6 +337,24 @@ int kvm_arch_get_registers(CPUState *cs) return ret; } =20 +int kvm_riscv_sync_mpstate_to_kvm(RISCVCPU *cpu, int state) +{ + if (cap_has_mp_state) { + struct kvm_mp_state mp_state =3D { + .mp_state =3D state + }; + + int ret =3D kvm_vcpu_ioctl(CPU(cpu), KVM_SET_MP_STATE, &mp_state); + if (ret) { + fprintf(stderr, "%s: failed to sync MP_STATE %d/%s\n", + __func__, ret, strerror(-ret)); + return -1; + } + } + + return 0; +} + int kvm_arch_put_registers(CPUState *cs, int level) { int ret =3D 0; @@ -354,6 +374,18 @@ int kvm_arch_put_registers(CPUState *cs, int level) return ret; } =20 + if (KVM_PUT_RESET_STATE =3D=3D level) { + RISCVCPU *cpu =3D RISCV_CPU(cs); + if (cs->cpu_index =3D=3D 0) { + ret =3D kvm_riscv_sync_mpstate_to_kvm(cpu, KVM_MP_STATE_RUNNAB= LE); + } else { + ret =3D kvm_riscv_sync_mpstate_to_kvm(cpu, KVM_MP_STATE_STOPPE= D); + } + if (ret) { + return ret; + } + } + return ret; } =20 @@ -428,6 +460,7 @@ int kvm_arch_add_msi_route_post(struct kvm_irq_routing_= entry *route, =20 int kvm_arch_init(MachineState *ms, KVMState *s) { + cap_has_mp_state =3D kvm_check_extension(s, KVM_CAP_MP_STATE); return 0; } =20 @@ -506,10 +539,19 @@ void kvm_riscv_reset_vcpu(RISCVCPU *cpu) if (!kvm_enabled()) { return; } + for (int i=3D0; i<32; i++) + env->gpr[i] =3D 0; env->pc =3D cpu->env.kernel_addr; env->gpr[10] =3D kvm_arch_vcpu_id(CPU(cpu)); /* a0 */ env->gpr[11] =3D cpu->env.fdt_addr; /* a1 */ env->satp =3D 0; + env->mie =3D 0; + env->stvec =3D 0; + env->sscratch =3D 0; + env->sepc =3D 0; + env->scause =3D 0; + env->stval =3D 0; + env->mip =3D 0; } =20 void kvm_riscv_set_irq(RISCVCPU *cpu, int irq, int level) diff --git a/target/riscv/kvm_riscv.h b/target/riscv/kvm_riscv.h index ed281bdce0..88aee902dd 100644 --- a/target/riscv/kvm_riscv.h +++ b/target/riscv/kvm_riscv.h @@ -21,5 +21,6 @@ =20 void kvm_riscv_reset_vcpu(RISCVCPU *cpu); void kvm_riscv_set_irq(RISCVCPU *cpu, int irq, int level); +int kvm_riscv_sync_mpstate_to_kvm(RISCVCPU *cpu, int state); =20 #endif --=20 2.17.1