From nobody Mon Feb 9 18:14:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1687349645; cv=none; d=zohomail.com; s=zohoarc; b=afAKjhlhu1rLGbmgSyOqlBMtLVKInoqsnF+JUkL/ta7ErFdL3y4UHnfnSxM7gK/jU3Ovr6tPDAe8qKolRa81JzAL6UA/uo6X7imZp7/QJ2CN1/XjdJAD/j+6q7jbjd9m0xK4nObireepFsml0CWhqPqtpbTmaCBcvFtsW75amt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687349645; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=h3rtP7yFbELjSwW2aNAU9eKW/GSwxTeiPhLzgW0Tk7M=; b=DFj95c6xBrbypu2NHChDapMeUz/u3HROD8Yy/Hgnk+FQhfcnD9xdTcMgiAYNPdkdv1L7NAk6KFvD8Erx4FDo+/p7UqMJd4qInuNtgHFqp0CS4xsgZiy/3RflcWeb/PCW7k0LRNMosfLjjTOxcZ1VZAqY0oKsjoU6TmrM0JqZMBM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687349645825966.7597159830063; Wed, 21 Jun 2023 05:14:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBwic-0004VZ-Id; Wed, 21 Jun 2023 08:13:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBt3E-0007uZ-K9 for qemu-devel@nongnu.org; Wed, 21 Jun 2023 04:18:52 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBt3B-00055R-8o for qemu-devel@nongnu.org; Wed, 21 Jun 2023 04:18:52 -0400 Received: from dggpemm500018.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QmGXt28cCzqVJN for ; Wed, 21 Jun 2023 16:15:58 +0800 (CST) Received: from localhost.localdomain (10.175.124.27) by dggpemm500018.china.huawei.com (7.185.36.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 21 Jun 2023 16:18:34 +0800 To: CC: , , , , , , , Subject: [PATCH] migrate/multifd: fix coredump when the multifd thread cleanup Date: Wed, 21 Jun 2023 16:18:26 +0800 Message-ID: <20230621081826.3203053-1-zhangjianguo18@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500018.china.huawei.com (7.185.36.111) X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.187; envelope-from=zhangjianguo18@huawei.com; helo=szxga01-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 21 Jun 2023 08:13:45 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: z00619469 From: z00619469 via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1687349647214100002 Content-Type: text/plain; charset="utf-8" From: c00454449 There is a coredump while trying to destroy mutex when p->running is false but p->mutex is not unlock. Make sure all mutexes has been released before destroy them. Signed-off-by: c00454449 --- migration/multifd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index b7ad7002e0..7dcdb2d3a0 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -523,9 +523,7 @@ void multifd_save_cleanup(void) for (i =3D 0; i < migrate_multifd_channels(); i++) { MultiFDSendParams *p =3D &multifd_send_state->params[i]; =20 - if (p->running) { - qemu_thread_join(&p->thread); - } + qemu_thread_join(&p->thread); } for (i =3D 0; i < migrate_multifd_channels(); i++) { MultiFDSendParams *p =3D &multifd_send_state->params[i]; @@ -1040,8 +1038,8 @@ int multifd_load_cleanup(Error **errp) * however try to wakeup it without harm in cleanup phase. */ qemu_sem_post(&p->sem_sync); - qemu_thread_join(&p->thread); } + qemu_thread_join(&p->thread); } for (i =3D 0; i < migrate_multifd_channels(); i++) { MultiFDRecvParams *p =3D &multifd_recv_state->params[i]; --=20 2.21.0.windows.1