From nobody Tue Feb 10 23:32:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1686559160; cv=none; d=zohomail.com; s=zohoarc; b=hFclSF50Ki8hFm9Sn4JTr4UyIBU7AXBeBmJfE9ZmjPqF+2rpgHdXWIfUOXlYYMq/M2zpOKuB234Vc6H5tkegmjaSh/FiuL3SPR04hTH1HEbia/SxW9hMeFgQlSD+IoIBDeo38S6kxGlL22r9YDUh0RZxbSK6UF+MeuOwunKzkQw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686559160; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ztLU/9y0i87CRIItEL/ab+fMhPfuJ6uIu0kT/vmrnJ4=; b=Iz+imCWOBCgxSt7ZR4puiZh57VsB3aFFrTTzDnmzGcwenm+H73IFgOUGel7G3ppVZ73K/Y60HvOXy+h/YpXjKs4jfRsFpSDmNydpNFlTwyG4aTPUXp7eVX1vYDdfSTscXvGHT75pne7CynjERdf1deCLWANlNDqckUgXQC6nfm4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1686559160506521.6042690213908; Mon, 12 Jun 2023 01:39:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8d4E-00011l-Ou; Mon, 12 Jun 2023 04:38:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8d4D-00011Y-FB for qemu-devel@nongnu.org; Mon, 12 Jun 2023 04:38:25 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8d48-0006pD-Re for qemu-devel@nongnu.org; Mon, 12 Jun 2023 04:38:25 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35C6ippq022191; Mon, 12 Jun 2023 08:38:17 GMT Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3r4gs62v56-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jun 2023 08:38:17 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35C8cGdU030522 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jun 2023 08:38:16 GMT Received: from acaggian1-mac.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Mon, 12 Jun 2023 01:38:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=ztLU/9y0i87CRIItEL/ab+fMhPfuJ6uIu0kT/vmrnJ4=; b=aRm+T0rp5DNmvFoo64YvoEfCJklfNuCP6k/BTOgKxW1sSPDz/CxjH42zVqTgjyVsOKZ2 hVzP+7Bkro0AIYdq+exGrJNKDloMK6JCxI3trbdChIcGdknaVTrlTDMAhOsgcm842qwt nqrYE7lT9mHWiCg18KAR+6jufT7ewr5pxSYZleb4UZWhz+wjb+m0ej+YumhrQ6VRsjAw N+QaEESjd8MqpsF8nEb5HUWPS+y7rI6YC4ZNWf9PVEGyxKC2DBYIg8+YHy/DG2Qu9BFF 8y75uMqGoCIlfUrBnJLtgn5/614IAe1d7wsytgQaDUsWQJGFZePkAAztnSSBM2C2Zkl6 Ew== From: Antonio Caggiano To: CC: Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] ui/sdl2: OpenGL window context Date: Mon, 12 Jun 2023 10:38:02 +0200 Message-ID: <20230612083802.2045-1-quic_acaggian@quicinc.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: n_guPhcYwixHulrq3DbkXWe9nWviHPeG X-Proofpoint-ORIG-GUID: n_guPhcYwixHulrq3DbkXWe9nWviHPeG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-12_04,2023-06-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=732 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306120074 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=quic_acaggian@quicinc.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @quicinc.com) X-ZM-MESSAGEID: 1686559161529100003 Content-Type: text/plain; charset="utf-8" When OpenGL is enabled, create only the OpenGL context, ignoring the SDL renderer as it is unused anyway. Signed-off-by: Antonio Caggiano Reviewed-by: Marc-Andr=C3=A9 Lureau --- ui/sdl2.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 9d703200bf..0d91b555e3 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -113,11 +113,11 @@ void sdl2_window_create(struct sdl2_console *scon) =20 SDL_SetHint(SDL_HINT_RENDER_DRIVER, driver); SDL_SetHint(SDL_HINT_RENDER_BATCHING, "1"); - } - scon->real_renderer =3D SDL_CreateRenderer(scon->real_window, -1, 0); =20 - if (scon->opengl) { scon->winctx =3D SDL_GL_CreateContext(scon->real_window); + } else { + /* The SDL renderer is only used by sdl2-2D, when OpenGL is disabl= ed */ + scon->real_renderer =3D SDL_CreateRenderer(scon->real_window, -1, = 0); } sdl_update_caption(scon); } @@ -128,10 +128,14 @@ void sdl2_window_destroy(struct sdl2_console *scon) return; } =20 - SDL_GL_DeleteContext(scon->winctx); - scon->winctx =3D NULL; - SDL_DestroyRenderer(scon->real_renderer); - scon->real_renderer =3D NULL; + if (scon->winctx) { + SDL_GL_DeleteContext(scon->winctx); + scon->winctx =3D NULL; + } + if (scon->real_renderer) { + SDL_DestroyRenderer(scon->real_renderer); + scon->real_renderer =3D NULL; + } SDL_DestroyWindow(scon->real_window); scon->real_window =3D NULL; } --=20 2.40.0