From nobody Tue Feb 10 20:47:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1686052737; cv=none; d=zohomail.com; s=zohoarc; b=U54xjRmSOwNWXHLhSn8mZHvgEuhERH8hZ6jOG4lgU5ARAH6rWVEGPuEuP72ENY9krHWwLTKTK9/e9O9DSrew0xtFoVtBVQQtMdhTb1koYUHjT0udKG473i7sRpQfCxiBw1PJ4CdB3oFozboqgyhiM/6NYorRRyA1X5sl/lvfv+4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686052737; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FxhwVzVRwljnUz15Fjsw4i2JV+aBvDRzU9xpCc326Bw=; b=kZ4vAFOQiuRRfQLppRySayNqXikRf+4G84g+l54B71BICshU51J3FwVeLobKKY3+2SsxMJjPh/GsArZLSLSHxGgEjIocz7G3Kg0+lGyZyc9+Qu/6RtbF4M55Wvxn3jTtxTIdzLNmBwJPYlDXCWUocH8Zaa/ooY3fGNyFu6RLc24= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1686052737735588.8574842405957; Tue, 6 Jun 2023 04:58:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6VKc-0001TH-GK; Tue, 06 Jun 2023 07:58:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6VKP-0000k3-S5 for qemu-devel@nongnu.org; Tue, 06 Jun 2023 07:58:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6VKK-0005vZ-Tp for qemu-devel@nongnu.org; Tue, 06 Jun 2023 07:58:18 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-80-c6uYuGcvOC6YUUkIXPr5OQ-1; Tue, 06 Jun 2023 07:58:14 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D45F1C01E9D for ; Tue, 6 Jun 2023 11:58:13 +0000 (UTC) Received: from localhost (unknown [10.39.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id E02251121314; Tue, 6 Jun 2023 11:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686052695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FxhwVzVRwljnUz15Fjsw4i2JV+aBvDRzU9xpCc326Bw=; b=M/SP8tVxAkmXKEnbHjMU4rgOD9BYcyFDegxsJ3j9HlFxdmwtYCYXMyb0O0SpbcB86ogda6 y0vPMZBogKv+s3ApgOlXLiSW8DMO2rdZkuvIlPGmeBgX5Ag+XhqPdv6p7HNYplmsLwPjOX h758nHFCPEM0+zarhS2eqeP2oQmlcuQ= X-MC-Unique: c6uYuGcvOC6YUUkIXPr5OQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 13/21] ui/egl: default to GLES on windows Date: Tue, 6 Jun 2023 15:56:50 +0400 Message-Id: <20230606115658.677673-14-marcandre.lureau@redhat.com> In-Reply-To: <20230606115658.677673-1-marcandre.lureau@redhat.com> References: <20230606115658.677673-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1686052739317100003 From: Marc-Andr=C3=A9 Lureau Windows GL drivers are notoriously not very good. Otoh, ANGLE provides rock solid GLES implementation on top of direct3d. We should recommend it and default to ES when using EGL (users can easily override this if necessary) Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/egl-helpers.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 4b29dda7ed..1c718b0b98 100644 --- a/ui/egl-helpers.c +++ b/ui/egl-helpers.c @@ -537,6 +537,10 @@ int qemu_egl_init_dpy_mesa(EGLNativeDisplayType dpy, D= isplayGLMode mode) #ifdef WIN32 int qemu_egl_init_dpy_win32(EGLNativeDisplayType dpy, DisplayGLMode mode) { + /* prefer GL ES, as that's what ANGLE supports */ + if (mode =3D=3D DISPLAYGL_MODE_ON) { + mode =3D DISPLAYGL_MODE_ES; + } return qemu_egl_init_dpy(dpy, 0, mode); } #endif --=20 2.40.1