From nobody Mon Feb 9 20:49:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1685327864; cv=none; d=zohomail.com; s=zohoarc; b=jIeXQyRsR10PuLGWNpY8d4Cft/3KvEiEfCdFS12CC0wa4M/W2EByti1rMeLW5CDqn9KLtonlwaLL8EP8wDvEkD7RfjXFJiDCtBiMRMlNyHqI63sOflnP15K9RcJSNhy5qJusOpQ1Tej+5TU1sX7BbwxzqW9ZuzUmHdk3gzmRiDo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685327864; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject; bh=Y/66hfExbGZ3tjBqPhYXz7LQz2FFZ7y3XJ1eS2f/Miw=; b=eVBVWAPUgGORW8mnflIlWowd2y4Ra5ySRMtYaApb881XouN+24QCQ4mV3TVbI55DhhasttcHt61PWUIbcMbBSmrZY9I1WcTcUXrREJzBRlcEb5std0GtQK3YfTcCQEODX5A2DeQfcb4kKG3Ez9mznA/oIbFEfD6qGrA50XnWf4k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1685327864574152.16474253619663; Sun, 28 May 2023 19:37:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3Sl2-00022u-2w; Sun, 28 May 2023 22:37:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3Sl0-00022l-7f for qemu-devel@nongnu.org; Sun, 28 May 2023 22:37:14 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3Sky-0007ve-LB for qemu-devel@nongnu.org; Sun, 28 May 2023 22:37:14 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-52867360efcso1689257a12.2 for ; Sun, 28 May 2023 19:37:10 -0700 (PDT) Received: from alarm.. ([157.82.203.253]) by smtp.gmail.com with ESMTPSA id h15-20020a62b40f000000b0064d2ad04cccsm5882580pfn.175.2023.05.28.19.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 May 2023 19:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1685327829; x=1687919829; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y/66hfExbGZ3tjBqPhYXz7LQz2FFZ7y3XJ1eS2f/Miw=; b=RwFyqwJneec2ncHpIiubj3CTjEcmsNCpF6Rbw6LFnf54VtjWfUpwIZ3so32/SDY5n8 7IqTfdBh1rFlU4flmXVGvDVzI+UzJ+GSaZQE6IUiOhxB9fA3pQ2mB7DvtjWQ4pyQL5pS gbW6gLy9+99FfVhwk5XXB9wVO1I8lxT/quy8Fn8vz/1csZtVvVlMcM7Uw2dm1pCWC0SJ 7zAEqyRi5MN6CqZiYxLaF9Z3Mc0ABWFXbzsUUwrQsut9/540zrxsOhl3NZYB3TZ7J8IG +qhTgCeb+Cu07XZOmLUr+KydawwTqbagSTkNjxW5FSJzAna6w0uqYZ6zQ8E6wJq/slJU b+bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685327829; x=1687919829; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y/66hfExbGZ3tjBqPhYXz7LQz2FFZ7y3XJ1eS2f/Miw=; b=Qt3inn8wnJ/n2nlq5mV2ZdVXT4dhclEWKQNEOc8YXHfBHC/dh0t0UVSfcpcqDe5vLI YgpdkZI9tz9hRSbiSGwHBl3hpYVPxWbNFVWm0xdtmKT1QmSGaePFLmB0zEVbskR+5cks 7Vx7Iu1kbm/S9frKRHOUKToRBVwRXKNyd3R/rz4LARjNrpUbgIJHjs9qwlKsqBi99XtH HW+Fjze473gkzrEZJCMTYkUxIph/QTXFN1ri0qwnvdpqdg6bYJ+MFUJMkgNQMCues+Cg DhiqZZBHdWfb86xLNxmj8C4cXkWqs9l8z1MvehIg/CNwbr+++768nv/7EG3ji6ZKYVWL IeJQ== X-Gm-Message-State: AC+VfDz+Z0rtI0gcSwTfhYJ7TeVCthE+Hr81vm6IOTYyCPticIFznaLI IrWzUe7BnlolKlihskq+X0Mecj/vuoOPUoO8Qz4= X-Google-Smtp-Source: ACHHUZ7rO+tc18ygsvVBexvFBswve4jSBIXTm0Pl3my3yx6XD9oPj4p2kP7CqgB+2li8kUouLyuwag== X-Received: by 2002:a05:6a20:54a6:b0:10d:b160:3d5c with SMTP id i38-20020a056a2054a600b0010db1603d5cmr8106770pzk.12.1685327829089; Sun, 28 May 2023 19:37:09 -0700 (PDT) From: Akihiko Odaki To: Cc: qemu-devel@nongnu.org, Jason Wang , Sriram Yagnaraman , Akihiko Odaki Subject: [PATCH] igb: Remove obsolete workaround for Windows Date: Mon, 29 May 2023 11:37:04 +0900 Message-Id: <20230529023704.9387-1-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::52b; envelope-from=akihiko.odaki@daynix.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1685327866683100003 Content-Type: text/plain; charset="utf-8" I confirmed it works with Windows even without this workaround. It is likely to be a mistake so remove it. Fixes: 3a977deebe ("Intrdocue igb device emulation") Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 97bb5c84ce..abc9bbe937 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -2677,12 +2677,7 @@ static uint32_t igb_get_status(IGBCore *core, int in= dex) res |=3D E1000_STATUS_IOV_MODE; } =20 - /* - * Windows driver 12.18.9.23 resets if E1000_STATUS_GIO_MASTER_ENABLE = is - * left set after E1000_CTRL_LRST is set. - */ - if (!(core->mac[CTRL] & E1000_CTRL_GIO_MASTER_DISABLE) && - !(core->mac[CTRL] & E1000_CTRL_LRST)) { + if (!(core->mac[CTRL] & E1000_CTRL_GIO_MASTER_DISABLE)) { res |=3D E1000_STATUS_GIO_MASTER_ENABLE; } =20 --=20 2.40.1