From nobody Thu Mar 28 21:47:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1685086763; cv=none; d=zohomail.com; s=zohoarc; b=lyN9o9eiNJhZr80Ze5BiHIEmZ0zAKOyWk3d2wNrJZ0m45d8SWav4uLnMCd/cXUAWCY9s3gH1yWgehteJVAKv/LghHZCvRw4W8uxVNQ3Rz5uQd60SEpoBZSFH+s4jd6m+NJzIqarshI4wA7SxFogFlPi9vuCYzqo3RGtMEUnF+wc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685086763; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=514qAoG1H7nkHzEoE1HcfH1ekFaWh30CW32A8Wf8HkU=; b=ZS1nP23701zl0lxJqDtC4UGcLlEGz3GPGfcJffU6TdRJkRsRnss7W2YFWWWMo4b00qGAK5vF5VjGRzANh6AOxt0S9x1Oo+dUVVcReFGTP+ieYFmATUcFRAvWJqmcqHw3FhtCGYsOPQ4ObUmY+IU3/RCM7xOxQt6sQNsHf+SYMAE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1685086763201321.0743638550588; Fri, 26 May 2023 00:39:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2S2P-0007MV-On; Fri, 26 May 2023 03:39:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2S2N-0007MJ-Uu for qemu-devel@nongnu.org; Fri, 26 May 2023 03:38:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2S2M-0005nT-FP for qemu-devel@nongnu.org; Fri, 26 May 2023 03:38:59 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-198-qHzKM0q-NTmfScAZWWzxUw-1; Fri, 26 May 2023 03:38:56 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A0642811E86; Fri, 26 May 2023 07:38:55 +0000 (UTC) Received: from kaapi.redhat.com (unknown [10.67.24.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 09ACF140EBD7; Fri, 26 May 2023 07:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685086737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=514qAoG1H7nkHzEoE1HcfH1ekFaWh30CW32A8Wf8HkU=; b=AXMSsq4aI4OBgPhH1N5KoL3clS8VcNwiGvX/aDaMnkim0CcAVz1YDDR3fW+0NHxdYW/3d+ l65gNMK+bQEakXVBLZ/95euxRfwMZ3kchoQ3qqw5bPEraiDFTUfdBVxwxuuiZH3oKQDJX+ klL4nWDTYxUAKpeOEZntPN26su+gTUI= X-MC-Unique: qHzKM0q-NTmfScAZWWzxUw-1 From: P J P To: Peter Xu Cc: QEMU Developers , Jason Wang , "Michael S . Tsirkin" , Prasad Pandit Subject: [PATCH v1] vhost: release memory objects in error path Date: Fri, 26 May 2023 13:10:51 +0530 Message-Id: <20230526074051.22122-1-ppandit@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=ppandit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1685086763630100001 Content-Type: text/plain; charset="utf-8" From: Prasad Pandit vhost_dev_start function does not release memory objects in case of an error. This may crash the guest with: stack trace of thread 125653: Program terminated with signal SIGSEGV, Segmentation fault #0 memory_listener_register (qemu-kvm + 0x6cda0f) #1 vhost_dev_start (qemu-kvm + 0x699301) #2 vhost_net_start (qemu-kvm + 0x45b03f) #3 virtio_net_set_status (qemu-kvm + 0x665672) #4 qmp_set_link (qemu-kvm + 0x548fd5) #5 net_vhost_user_event (qemu-kvm + 0x552c45) #6 tcp_chr_connect (qemu-kvm + 0x88d473) #7 tcp_chr_new_client (qemu-kvm + 0x88cf83) #8 tcp_chr_accept (qemu-kvm + 0x88b429) #9 qio_net_listener_channel_func (qemu-kvm + 0x7ac07c) #10 g_main_context_dispatch (libglib-2.0.so.0 + 0x54e2f) Release memory_listener and virtqueue objects in the error path. Signed-off-by: Prasad Pandit Reviewed-by: Peter Xu --- hw/virtio/vhost.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) v1: log debug message when event_notifier_init fails diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 23da579ce2..1de3029ae7 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1942,7 +1942,8 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODev= ice *vdev, bool vrings) r =3D event_notifier_init( &hdev->vqs[VHOST_QUEUE_NUM_CONFIG_INR].masked_config_notifier, 0); if (r < 0) { - return r; + VHOST_OPS_DEBUG(r, "event_notifier_init failed"); + goto fail_vq; } event_notifier_test_and_clear( &hdev->vqs[VHOST_QUEUE_NUM_CONFIG_INR].masked_config_notifier); @@ -2004,6 +2005,9 @@ fail_vq: } =20 fail_mem: + if (vhost_dev_has_iommu(hdev)) { + memory_listener_unregister(&hdev->iommu_listener); + } fail_features: vdev->vhost_started =3D false; hdev->started =3D false; --=20 2.40.1