[PATCH 01/30] q800: fix up minor spacing issues in hw_compat_q800 GlobalProperty array

Mark Cave-Ayland posted 30 patches 1 year, 10 months ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Laurent Vivier <laurent@vivier.eu>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
[PATCH 01/30] q800: fix up minor spacing issues in hw_compat_q800 GlobalProperty array
Posted by Mark Cave-Ayland 1 year, 10 months ago
Ensure there is a space before the final closing brace for all global
properties.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/m68k/q800.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
index b35ecafbc7..1aead224e2 100644
--- a/hw/m68k/q800.c
+++ b/hw/m68k/q800.c
@@ -719,14 +719,14 @@ static void q800_init(MachineState *machine)
 }
 
 static GlobalProperty hw_compat_q800[] = {
-    { "scsi-hd", "quirk_mode_page_vendor_specific_apple", "on"},
+    { "scsi-hd", "quirk_mode_page_vendor_specific_apple", "on" },
     { "scsi-hd", "vendor", " SEAGATE" },
     { "scsi-hd", "product", "          ST225N" },
     { "scsi-hd", "ver", "1.0 " },
-    { "scsi-cd", "quirk_mode_page_apple_vendor", "on"},
-    { "scsi-cd", "quirk_mode_sense_rom_use_dbd", "on"},
-    { "scsi-cd", "quirk_mode_page_vendor_specific_apple", "on"},
-    { "scsi-cd", "quirk_mode_page_truncated", "on"},
+    { "scsi-cd", "quirk_mode_page_apple_vendor", "on" },
+    { "scsi-cd", "quirk_mode_sense_rom_use_dbd", "on" },
+    { "scsi-cd", "quirk_mode_page_vendor_specific_apple", "on" },
+    { "scsi-cd", "quirk_mode_page_truncated", "on" },
     { "scsi-cd", "vendor", "MATSHITA" },
     { "scsi-cd", "product", "CD-ROM CR-8005" },
     { "scsi-cd", "ver", "1.0k" },
-- 
2.30.2
Re: [PATCH 01/30] q800: fix up minor spacing issues in hw_compat_q800 GlobalProperty array
Posted by Laurent Vivier 1 year, 9 months ago
Le 24/05/2023 à 23:10, Mark Cave-Ayland a écrit :
> Ensure there is a space before the final closing brace for all global
> properties.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   hw/m68k/q800.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
> index b35ecafbc7..1aead224e2 100644
> --- a/hw/m68k/q800.c
> +++ b/hw/m68k/q800.c
> @@ -719,14 +719,14 @@ static void q800_init(MachineState *machine)
>   }
>   
>   static GlobalProperty hw_compat_q800[] = {
> -    { "scsi-hd", "quirk_mode_page_vendor_specific_apple", "on"},
> +    { "scsi-hd", "quirk_mode_page_vendor_specific_apple", "on" },
>       { "scsi-hd", "vendor", " SEAGATE" },
>       { "scsi-hd", "product", "          ST225N" },
>       { "scsi-hd", "ver", "1.0 " },
> -    { "scsi-cd", "quirk_mode_page_apple_vendor", "on"},
> -    { "scsi-cd", "quirk_mode_sense_rom_use_dbd", "on"},
> -    { "scsi-cd", "quirk_mode_page_vendor_specific_apple", "on"},
> -    { "scsi-cd", "quirk_mode_page_truncated", "on"},
> +    { "scsi-cd", "quirk_mode_page_apple_vendor", "on" },
> +    { "scsi-cd", "quirk_mode_sense_rom_use_dbd", "on" },
> +    { "scsi-cd", "quirk_mode_page_vendor_specific_apple", "on" },
> +    { "scsi-cd", "quirk_mode_page_truncated", "on" },
>       { "scsi-cd", "vendor", "MATSHITA" },
>       { "scsi-cd", "product", "CD-ROM CR-8005" },
>       { "scsi-cd", "ver", "1.0k" },

Reviewed-by: Laurent Vivier <laurent@vivier.eu>