From nobody Tue Feb 10 19:00:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1684810132; cv=none; d=zohomail.com; s=zohoarc; b=Hno0lDqJMELbz7Ud1Lcq2UrZS5aXYZ9MUDTlkHByT+gs1XZcn+cjM5Vnn6xn5JdoPPQiOOVv8HQhtY0jUESdv5RuVsmq7CicdnJaX8PVpGbS5ORSsqdHBJmEiohIo66SiQSWrqNIlx9ymk/eKLNrUFOY3CJ0Qte96XfvBR6iMtE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1684810132; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=k2/liiZ3TVpnprvr/3nGrr3vDF7yO65Gh2yux/g7Esg=; b=mTmdmKpFAIb+e6QlxIyUzc40LSLmCy+8QwqF9Q6yBK4oepYmfZSscLdUqJcdZ3DGlKeRPd0O0GVs5BDdtoSJQLNhZaGpYMgqrHowgSvKicMF9zABK7ZKOv2myOivhz9jGETh30l/zGb6EjVevzVXtcYw4SVIB7GiEDAiFcsv/rY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1684810132251375.99883968485824; Mon, 22 May 2023 19:48:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1I1v-0006II-6s; Mon, 22 May 2023 22:45:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1I1j-0005w1-MA for qemu-devel@nongnu.org; Mon, 22 May 2023 22:45:33 -0400 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1I1R-0004Q7-OQ for qemu-devel@nongnu.org; Mon, 22 May 2023 22:45:31 -0400 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-25394160fd3so2445192a91.3 for ; Mon, 22 May 2023 19:45:13 -0700 (PDT) Received: from alarm.. ([157.82.204.253]) by smtp.gmail.com with ESMTPSA id o10-20020a17090aac0a00b002467717fa60sm4769847pjq.16.2023.05.22.19.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 19:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1684809911; x=1687401911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k2/liiZ3TVpnprvr/3nGrr3vDF7yO65Gh2yux/g7Esg=; b=lRz1ZRRVMxIdpa1zDrg40WDG4nfGLpuqYllALICt+IzswLD/sJkXj1ekcHkW2JOi3q rWnGRJvhTW6z4yXm0zbwVtuFjhQfaZAKwB2FdaFVpO+KUVkpAJvvSJkW6s2ABI1OxuUE ryJLB4pxl7qjGp5UYf4Pamu8sJFR2WqxGPMNnbiGben6ONeAmLKrqioUeptTAJ4QUXV/ AehHcCjRg3tbs2MhzdvBIbePmqm7G2n4CcOipTtOalSm8s8sQnC6+lrm6KeZkspvTzUO f4gjq+c4PiOmYRcdC46wilJn7XrxY99neWz19WF9IP1pnqnIgPIdRm96LkSKT4B38cXQ 4WPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684809911; x=1687401911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k2/liiZ3TVpnprvr/3nGrr3vDF7yO65Gh2yux/g7Esg=; b=JABg0nQ1NyK9z89XEiqrbwPwkzYo2ascp6BBdDtGw/42oj9qq7yB/E+Z7VViry6Ljf PEacluPzPbTUGQbnUlLoyTbDnSNbn2hKRGepZda43L30NbGez/WaETOmsa0d7a/bF/vL P+P9KVMiwlwgDhyI4nZfyj5sws3LqRizPgN83LwdF9v+5mtDakVf7g1KyZmIjZYvOrez Z/6VPKv7Ydgo8caRuQP5oxLtr7YTsT0A92JhFw8fAkkEuGVq1EPBIqzWSU93vzX6veFM Nvqo6TFP9veuk+iRRU8poO1TNF9nzxbFFY3vPfkJVe+Xp8SX3PjNxRqLzWWGnAt9zdPL mwYQ== X-Gm-Message-State: AC+VfDw+yEWN5KAF87A1JrfAXqW4E1JfYTxqltMLV5xxCeJRtxaA4COq AlI+SBSsWEhpaW7rI8UboS7aJA== X-Google-Smtp-Source: ACHHUZ7DrVkwQv/Bi/iJggmrQL/ZU5CgI3LjK9uDsIzHjSstO7hM3wyAbZ2QNRlVYBvNaU4ueuICAw== X-Received: by 2002:a17:90a:ea04:b0:24c:df8:8efa with SMTP id w4-20020a17090aea0400b0024c0df88efamr12032443pjy.39.1684809911448; Mon, 22 May 2023 19:45:11 -0700 (PDT) From: Akihiko Odaki To: Cc: Sriram Yagnaraman , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal , Cleber Rosa , Laurent Vivier , Paolo Bonzini , qemu-devel@nongnu.org, Tomasz Dzieciol , Akihiko Odaki Subject: [PATCH v5 23/48] vmxnet3: Reset packet state after emptying Tx queue Date: Tue, 23 May 2023 11:43:14 +0900 Message-Id: <20230523024339.50875-24-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230523024339.50875-1-akihiko.odaki@daynix.com> References: <20230523024339.50875-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::102c; envelope-from=akihiko.odaki@daynix.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1684810133438100002 Content-Type: text/plain; charset="utf-8" Keeping Tx packet state after the transmit queue is emptied but this behavior is unreliable as the state can be reset anytime the migration happens. Always reset Tx packet state always after the queue is emptied. Signed-off-by: Akihiko Odaki --- hw/net/vmxnet3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 05f41b6dfa..18b9edfdb2 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -681,6 +681,8 @@ static void vmxnet3_process_tx_queue(VMXNET3State *s, i= nt qidx) net_tx_pkt_unmap_frag_pci, PCI_DEVICE(s)); } } + + net_tx_pkt_reset(s->tx_pkt, net_tx_pkt_unmap_frag_pci, PCI_DEVICE(s)); } =20 static inline void @@ -1159,7 +1161,6 @@ static void vmxnet3_deactivate_device(VMXNET3State *s) { if (s->device_active) { VMW_CBPRN("Deactivating vmxnet3..."); - net_tx_pkt_reset(s->tx_pkt, net_tx_pkt_unmap_frag_pci, PCI_DEVICE(= s)); net_tx_pkt_uninit(s->tx_pkt); net_rx_pkt_uninit(s->rx_pkt); s->device_active =3D false; --=20 2.40.1