From nobody Tue Feb 10 19:00:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1684809978; cv=none; d=zohomail.com; s=zohoarc; b=EO62c4ak9z8S8tgWOwRzLjD0e5QKeBlwxH7OqzrAaahJkp/z85sT2+KL66g6lJIKwuw2T4JmsXkr3Sv+VNFpSvyykN4Hl/d7BIWzyFFuA/3L0pRD3lZSIj5/UlZkJ+x8V8uK2V2faBp85D6VRdeXzfIZiFsc1tvEMcUoCKbaJKI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1684809978; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=HE2GeNaiFNy1PaFRDOukmrWos4NXU60+F739Z574TPQ=; b=Hszl5K4fsfNPSBEI0XLxJscYOCvbQQWRjGXYCYJkahuW0/vbkOVFy5zlFo7BZa+b5RRsQTCSJE1VWaJqDVqphd0H3SAIwxLUOa/N5Oe8HXoY2EAmemQRkZ/mes4w/xjGPPk8YQ12SaJHMvksViffFOBxJlh+m6Dpyr5x4xykphc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1684809978267539.3980484274744; Mon, 22 May 2023 19:46:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1I1T-0004ny-WB; Mon, 22 May 2023 22:45:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1I1Q-0004g7-4O for qemu-devel@nongnu.org; Mon, 22 May 2023 22:45:12 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1I1I-0004Dt-EM for qemu-devel@nongnu.org; Mon, 22 May 2023 22:45:11 -0400 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-25374c9be49so4271675a91.3 for ; Mon, 22 May 2023 19:45:02 -0700 (PDT) Received: from alarm.. ([157.82.204.253]) by smtp.gmail.com with ESMTPSA id o10-20020a17090aac0a00b002467717fa60sm4769847pjq.16.2023.05.22.19.44.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 19:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1684809901; x=1687401901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HE2GeNaiFNy1PaFRDOukmrWos4NXU60+F739Z574TPQ=; b=dREdQq8+b3M6kzijsvUqjbiWKjzeC6kc1dXzpdHggTLbPNTPaV49JyBAT/Pf1+99FS BquzsteyedrXC3RZSP49GXV7a2JgufZ1ziLW4H1lZpWotaozvnDKDsgMyPv/qgBAyNQk +YNsohN2ZRp5nq5WCcV4KXBDq8ygl4bZ3sqB9tMPg+XWQ765GSkfGx1KT4UISx+jGyb6 uv1FQ81/PSNVcPvstCSt/HLh8uWGnk95CSgSeLW8o8ov7GNIy1y+aJELb2vyBcrFRqw4 Hnl1rxIorLp62ejkXxVR0WAJK6VZNblZmyU5y46BaQOJALyxsLOYjdUHbP6T5PpO8qnN QfrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684809901; x=1687401901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HE2GeNaiFNy1PaFRDOukmrWos4NXU60+F739Z574TPQ=; b=BxN3sA9in2mBYDVbvP2gzZWxz+71W7dH/6rF0lIBhNjeqSHTJiByDMFNDXrKm9pGNn /TJN4s35nsRUpK5NkldOU0BpOys+WD7ImgrSJYnbyIwKiYCBuTeaQ3lmSweMRwjdqubs 2abpHILFlVHWLX7XKf0AoP//gQi2lQouyadEf1OaVMaRPg20JdwPX2SF2a+MQE7rS96o X05DUxKNBeBGDUrANAH2tNHqTdN9c1Ydefabl4tEAC0TPtt2V9RRMt658rQXawU9D+sD pgajk4HSnIM3rmPy8kbxdzkIGaskr4617CEwLIIKxd7tE9Ob1M1fnveBC/zEvqitL1iT uX6w== X-Gm-Message-State: AC+VfDw7bzQsokASlDk4HuXq1920KzXGCp12wqZmzCqQuGmGWL3lMMP4 CN5k9SUb1oc2Shto44R+BKpgQWE4qEloZWQzySw= X-Google-Smtp-Source: ACHHUZ5Zjl1YtaOIjxm11rPetreyEl1mjvvOvAruGOsGe6YkmlMLj/SmS9snTiolHqCMOYDq4Q8YSg== X-Received: by 2002:a17:90a:e505:b0:255:58c4:fbae with SMTP id t5-20020a17090ae50500b0025558c4fbaemr5793670pjy.10.1684809901368; Mon, 22 May 2023 19:45:01 -0700 (PDT) From: Akihiko Odaki To: Cc: Sriram Yagnaraman , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal , Cleber Rosa , Laurent Vivier , Paolo Bonzini , qemu-devel@nongnu.org, Tomasz Dzieciol , Akihiko Odaki Subject: [PATCH v5 20/48] igb: Remove goto Date: Tue, 23 May 2023 11:43:11 +0900 Message-Id: <20230523024339.50875-21-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230523024339.50875-1-akihiko.odaki@daynix.com> References: <20230523024339.50875-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::1034; envelope-from=akihiko.odaki@daynix.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1684809980262100003 Content-Type: text/plain; charset="utf-8" The goto is a bit confusing as it changes the control flow only if L4 protocol is not recognized. It is also different from e1000e, and noisy when comparing e1000e and igb. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 946b917f91..bae51cbb63 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1297,7 +1297,7 @@ igb_build_rx_metadata(IGBCore *core, break; =20 default: - goto func_exit; + break; } } else { trace_e1000e_rx_metadata_l4_cso_disabled(); --=20 2.40.1