From nobody Mon Feb 9 09:29:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683895346; cv=none; d=zohomail.com; s=zohoarc; b=NI+4iLN+jR3sKxEBkRI3acm/gfElBmHcKwxJ2qbpG1Bi1UW2+eRtj1+ykDyPzHFFsZMFHbwNynjpHsrVpUKteAfYn9sSO5fIoDtm34Qm+xbozgSduI4ImxCWkjz3MnW1PztHBaoSyaFJu5uoGWJgN8wr217fRqaN8lmc+JbV0R0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683895346; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=R5YM/6e0BWSQzhq2cKbq2x0zlYLlhQT27o0fo3HfEp4=; b=i9hUQc1YojA6oxsI6yOvuKHyDZ3KI4O0cP+QoLD27aSQVz+gJa+i3NlXOU4jl0GidPRkrSat8obT7Vo1VbXyf3in1CZ5IjOKW0HLSbii5yjvs+89hLZ+GcavFoAZXd56+fw4m7XANC6PIvH8DDNnYnpxXcYKnn2kEtKYqhWQE+A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683895346545858.0118323695824; Fri, 12 May 2023 05:42:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxS4o-0007YY-SO; Fri, 12 May 2023 08:40:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxS4n-0007YO-Sn for qemu-devel@nongnu.org; Fri, 12 May 2023 08:40:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxS4m-0006MR-Ff for qemu-devel@nongnu.org; Fri, 12 May 2023 08:40:49 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-318-3hMzUySJO-ajj1M2JzMpEQ-1; Fri, 12 May 2023 08:40:42 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F1A2D1C05AFA; Fri, 12 May 2023 12:40:41 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.251]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAFE01121314; Fri, 12 May 2023 12:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683895247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R5YM/6e0BWSQzhq2cKbq2x0zlYLlhQT27o0fo3HfEp4=; b=OlR2MmCCS2MD61clOpW6Yaj9vOCSDkBorczS8riRWmNqWRRmNIS+VYuPzbuLwiAFB2HjPR cYgofiqjaT4LEW9SVMPsHbCjXUz1ncF2ZSojH6qhNXaALqxzdLnt5V2aH8gx2VpiLnkCGW fwlONLscPYSfo7kDabnrGLsMl5XxOpQ= X-MC-Unique: 3hMzUySJO-ajj1M2JzMpEQ-1 From: Thomas Huth To: qemu-devel@nongnu.org, Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Fabiano Rosas Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 04/18] softmmu/vl.c: Disable default NIC if it has not been compiled into the binary Date: Fri, 12 May 2023 14:40:19 +0200 Message-Id: <20230512124033.502654-5-thuth@redhat.com> In-Reply-To: <20230512124033.502654-1-thuth@redhat.com> References: <20230512124033.502654-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683895347107100001 Content-Type: text/plain; charset="utf-8" Don't try to instantiate a default NIC if it is not available (since this will cause QEMU to abort). Emit a warning instead. Signed-off-by: Thomas Huth --- softmmu/vl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/softmmu/vl.c b/softmmu/vl.c index 43d3b972da..b0b96f67fa 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -1294,6 +1294,13 @@ static void qemu_disable_default_devices(void) default_monitor =3D 0; default_net =3D 0; default_vga =3D 0; + } else { + if (default_net && machine_class->default_nic && + !module_object_class_by_name(machine_class->default_nic)) { + warn_report("Default NIC '%s' is not available in this binary", + machine_class->default_nic); + default_net =3D 0; + } } } =20 --=20 2.31.1