From nobody Fri May 17 17:34:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683703580; cv=none; d=zohomail.com; s=zohoarc; b=nzxkTerqPDiMIeTOzS/ASEkgQjmzIIM3j7lphSUFCqdWQIEuFQh+HtSjeIAeersEdrwklVLy1LNEZcvvistHzM7+TcWWBR4mqg/SIiC7jXIzKOu0qEzngTuv5jnbzAFtIN1hyuLOe25cAwp4Z/2vMHphAWq1lQqStxnYAhm3404= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683703580; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=htDJpvgg2eJIL5EgGQgO3RIJgEV0jTSXkAzijWNJDh8=; b=NttkaAD7vRLhDShR/YZu65JRsA/3+OgpVm0kVZfu88Jzcdsp3nprtTAUiFQZtHHjsZNj1W9HOinbp4elBzmsYVqP9uudze445CsUnFnfBPhAUe0GyIqOESVMlJRHXDCHJJ1pxvESXYWofhG+2RYdFoVuPVSzB+Rbbee92uOX0Xg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683703580884326.0289714213726; Wed, 10 May 2023 00:26:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pweCo-0006Lm-UZ; Wed, 10 May 2023 03:25:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pweCk-0006Jq-22 for qemu-devel@nongnu.org; Wed, 10 May 2023 03:25:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pweCi-0004tY-65 for qemu-devel@nongnu.org; Wed, 10 May 2023 03:25:41 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-280-NlyjR3xqPHGsXItn3K01QA-1; Wed, 10 May 2023 03:25:36 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 16DD51C060D1 for ; Wed, 10 May 2023 07:25:36 +0000 (UTC) Received: from localhost (unknown [10.39.208.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A95340C6E67; Wed, 10 May 2023 07:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683703537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=htDJpvgg2eJIL5EgGQgO3RIJgEV0jTSXkAzijWNJDh8=; b=URoTFsu1V9y3xHZoOHwsyrOunS4LjxgNak92LCHXBBxJ9HRXrBa+rBolJgnYA+oxzxtD1o x3cYL3OmayFEadVkTd3GdnZP4WfHWiddQ7xH/S5wqGS7pAVTeRCAmazN9ERlYangXIVihk W4RHEkKvp4X4Eh4C2oiTcfKizWGqKOI= X-MC-Unique: NlyjR3xqPHGsXItn3K01QA-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: berrange@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Subject: [PATCH] chardev: report the handshake error Date: Wed, 10 May 2023 11:25:31 +0400 Message-Id: <20230510072531.3937189-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683703582530100002 From: Marc-Andr=C3=A9 Lureau This can help to debug connection issues. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=3D2196182 Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- chardev/char-socket.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 8c58532171..e8e3a743d5 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -742,8 +742,12 @@ static void tcp_chr_websock_handshake(QIOTask *task, g= pointer user_data) { Chardev *chr =3D user_data; SocketChardev *s =3D user_data; + Error *err =3D NULL; =20 - if (qio_task_propagate_error(task, NULL)) { + if (qio_task_propagate_error(task, &err)) { + error_reportf_err(err, + "websock handshake of character device %s failed= : ", + chr->label); tcp_chr_disconnect(chr); } else { if (s->do_telnetopt) { @@ -778,8 +782,12 @@ static void tcp_chr_tls_handshake(QIOTask *task, { Chardev *chr =3D user_data; SocketChardev *s =3D user_data; + Error *err =3D NULL; =20 - if (qio_task_propagate_error(task, NULL)) { + if (qio_task_propagate_error(task, &err)) { + error_reportf_err(err, + "TLS handshake of character device %s failed: ", + chr->label); tcp_chr_disconnect(chr); } else { if (s->is_websock) { --=20 2.40.1