From nobody Mon Feb 9 20:10:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683619334; cv=none; d=zohomail.com; s=zohoarc; b=NymQGxIq+gCg2587uXkywCzPRjeWoSBklF5ZgkEx8Y8yFhKYsMyNZ5CqW5yTXLKgPY/PQanRD983yMyoxLfrF7mX9S01F24MtjxZ2IT/WE9fQToGEOFnaz2ZacTSXbxMpL1Kc4YYCjcKVKO9S9Q1YxErpEQwVz4a/hXI5ZjArRQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683619334; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jAyvZ+zAzM+Pkjnjm8wlCqVSdqBpE607YsToLccrOys=; b=VpY87fiPmRv1cyFbmEwG6OdQRitZL8XZYFCAIQCI0FeFR4mBzSQItfk9/gQW6f2JSYxILSykbgLacoGC//ppNn0hj8oh6NgkH9IfXDDH7YKZ8Cn5z3SQTV0AvWB6Pnk5q1WaqBqvS/vY3tj0T6RNalu///4uyAziuEnaZQ5uwD4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683619333994447.775327968744; Tue, 9 May 2023 01:02:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwIGr-0008WL-Qu; Tue, 09 May 2023 04:00:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwIGm-0008UQ-2O for qemu-devel@nongnu.org; Tue, 09 May 2023 04:00:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwIGk-0008UY-3J for qemu-devel@nongnu.org; Tue, 09 May 2023 04:00:23 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-151-DyR4KNMVNIqSAMy-uNku8w-1; Tue, 09 May 2023 04:00:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D0A12100F654; Tue, 9 May 2023 08:00:17 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD2492166B26; Tue, 9 May 2023 08:00:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2D58821E6606; Tue, 9 May 2023 10:00:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683619221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jAyvZ+zAzM+Pkjnjm8wlCqVSdqBpE607YsToLccrOys=; b=jMtu4yTLPBKmQpm21xYt3x2KelRC2FeqqTS/wYn+oZvVK/yKl0wt6OatWoC44j9m4JCWo6 4GlljhZyD+PFG42wVTInGa/o6rpIFf/xtKXnl8ws3HY9dclb3kAwVSRkc6uM1i6EkK+lH6 fYIkJRythFqpItDlnsTFrjHbUtZiILw= X-MC-Unique: DyR4KNMVNIqSAMy-uNku8w-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Ani Sinha , Juan Quintela Subject: [PULL 07/17] qapi: Tidy up a slightly awkward TODO comment Date: Tue, 9 May 2023 10:00:01 +0200 Message-Id: <20230509080011.3231661-8-armbru@redhat.com> In-Reply-To: <20230509080011.3231661-1-armbru@redhat.com> References: <20230509080011.3231661-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683619334239100002 Content-Type: text/plain; charset="utf-8" MigrateSetParameters has a TODO comment sitting right behind its doc comment. I wrote it this way to keep it out of the manual, but that reason is not obvious. The previous commit (sphinx/qapidoc: Do not emit TODO sections into user manuals) lets me move it into the doc comment as a TODO section. Signed-off-by: Markus Armbruster Message-Id: <20230428105429.1687850-8-armbru@redhat.com> Reviewed-by: Ani Sinha Reviewed-by: Juan Quintela --- qapi/migration.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 82000adce4..11c09800c2 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -945,10 +945,11 @@ # Features: # @unstable: Member @x-checkpoint-delay is experimental. # +# TODO: either fuse back into MigrationParameters, or make +# MigrationParameters members mandatory +# # Since: 2.4 ## -# TODO either fuse back into MigrationParameters, or make -# MigrationParameters members mandatory { 'struct': 'MigrateSetParameters', 'data': { '*announce-initial': 'size', '*announce-max': 'size', --=20 2.39.2