From nobody Tue Feb 10 19:48:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683391196; cv=none; d=zohomail.com; s=zohoarc; b=T5JwwUl7LwPzzrgGGtFrc2zegXpLzoVhM+VVymJsdWzQU3omM3vO6H9NmPlIn0T5tl0650vI1oRUTuOdWdZhbtSqGF7WfCO6vzvaHpQce2luZcllxp4nhiK8m2WEaJSN35FvUIbqA++bDf8G2MZ+2wEVppfuKgNKrrp3aRlQXy0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683391196; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Pe2s/uDqRflXhELDMB82guoOho7E/nfVEtQ5clZC4uE=; b=mP1QxvJ16k/F5s0oO0hG/Zy+nouUush2KRvl/SsYrfHdaHkP9Bf9ChOKC10hwdZurJTTqw5hUJWZppaKmSyom+6yXI3Zl04gY8TGWfoqMO6evete4Ohu84S8UOellBqD4KWW1QPDKMPbbvJfcqbpYlst9MNWhdULCGfivcRILz4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683391196863827.1350870548958; Sat, 6 May 2023 09:39:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvKvV-0000uh-PI; Sat, 06 May 2023 12:38:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvKvT-0000tx-Sx for qemu-devel@nongnu.org; Sat, 06 May 2023 12:38:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvKvS-000449-97 for qemu-devel@nongnu.org; Sat, 06 May 2023 12:38:27 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-97-KRVOFcssNX2lc2UdYjVCww-1; Sat, 06 May 2023 12:38:22 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E184B185A79C; Sat, 6 May 2023 16:38:21 +0000 (UTC) Received: from localhost (unknown [10.39.208.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2707492B00; Sat, 6 May 2023 16:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683391105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pe2s/uDqRflXhELDMB82guoOho7E/nfVEtQ5clZC4uE=; b=PRebTJWAW1ZjlzNm2qSy1AGUJx4DpAPnxy7N/IGkvqyinv5imi3v7GPXcfo9lwzhOPxAiO J4iWQobM+dX3hTjXqSqAGUMf4T9QYQiF7BxZajvsPVcHnVg6MiDula7HVU0JeQp6ihRbNR EHaxT8ixo+rpDJ6wvxDhfhmircwymZI= X-MC-Unique: KRVOFcssNX2lc2UdYjVCww-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Wainer dos Santos Moschetta , Beraldo Leal , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Thomas Huth , Markus Armbruster , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , dbassey@redhat.com, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eric Blake , Paolo Bonzini Subject: [PATCH 10/12] audio/pw: simplify error reporting in stream creation Date: Sat, 6 May 2023 20:37:33 +0400 Message-Id: <20230506163735.3481387-11-marcandre.lureau@redhat.com> In-Reply-To: <20230506163735.3481387-1-marcandre.lureau@redhat.com> References: <20230506163735.3481387-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683391198857100003 From: Marc-Andr=C3=A9 Lureau create_stream() now reports on all error paths. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Volker R=C3=BCmelin --- audio/pwaudio.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/audio/pwaudio.c b/audio/pwaudio.c index 5c706a9fde..38905f5be2 100644 --- a/audio/pwaudio.c +++ b/audio/pwaudio.c @@ -486,8 +486,6 @@ static int qpw_stream_new(pwaudio *c, PWVoice *v, const char *stream_name, const char *name, enum spa_direction dir) { - int r; - switch (v->info.channels) { case 8: v->info.position[0] =3D SPA_AUDIO_CHANNEL_FL; @@ -540,13 +538,7 @@ qpw_stream_new(pwaudio *c, PWVoice *v, const char *str= eam_name, } =20 /* create a new unconnected pwstream */ - r =3D create_stream(c, v, stream_name, name, dir); - if (r < 0) { - AUD_log(AUDIO_CAP, "Failed to create stream."); - return -1; - } - - return r; + return create_stream(c, v, stream_name, name, dir); } =20 static int @@ -577,7 +569,6 @@ qpw_init_out(HWVoiceOut *hw, struct audsettings *as, vo= id *drv_opaque) r =3D qpw_stream_new(c, v, ppdo->stream_name ? : c->dev->id, ppdo->name, SPA_DIRECTION_OUTPUT); if (r < 0) { - error_report("qpw_stream_new for playback failed"); pw_thread_loop_unlock(c->thread_loop); return -1; } @@ -621,7 +612,6 @@ qpw_init_in(HWVoiceIn *hw, struct audsettings *as, void= *drv_opaque) r =3D qpw_stream_new(c, v, ppdo->stream_name ? : c->dev->id, ppdo->name, SPA_DIRECTION_INPUT); if (r < 0) { - error_report("qpw_stream_new for recording failed"); pw_thread_loop_unlock(c->thread_loop); return -1; } --=20 2.40.1