From nobody Tue Feb 10 16:22:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683200389; cv=none; d=zohomail.com; s=zohoarc; b=bUON8cFHhktNnq2BfQcatFKjR/+pixp0KN/Rz8wIaGf9o11eOvp9MjbkDISN8SrlIWfP2jS1HoqT79Sh99R5uHo6s+8+SmSDAIVT1bpP2ZID3nhbKJyKgACTk8QHMTIpTfdUU8nFrKOulwmakuUQOFEPB2Y+Xp8wh+CngRgBeag= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683200389; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2LA39jyFu5OpB1kSfLhFb6OryEVC1JN71t+N7vfU8h0=; b=iOgaPyDT1hma0Mov0/Kio0yCh34XA7SnnpLlm8YAz6C7nlHuWHXjUM1sT0QUCoe4XJKLnjwem5pzR7cCTh7qLprdq3R7frZY08JHFHd86M7nmXwQ5I8HFVz0uZZr28Ibr0LrW65PaEqY7ypPQizRuRMULCr3haIpY5MUfvmgKe8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683200389579635.3158659227571; Thu, 4 May 2023 04:39:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puXIS-0005wh-Q2; Thu, 04 May 2023 07:38:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puXIR-0005vu-6F for qemu-devel@nongnu.org; Thu, 04 May 2023 07:38:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puXIP-0003Ix-ME for qemu-devel@nongnu.org; Thu, 04 May 2023 07:38:50 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-qEaD6PZqPVK4KA7gTWl57w-1; Thu, 04 May 2023 07:38:46 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AA4F3811E7E; Thu, 4 May 2023 11:38:45 +0000 (UTC) Received: from secure.mitica (unknown [10.39.193.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7BF532166B33; Thu, 4 May 2023 11:38:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683200329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2LA39jyFu5OpB1kSfLhFb6OryEVC1JN71t+N7vfU8h0=; b=QRquQu17Gyw+PpwL16fKr5cmoM91jad7rhyohrMpdDZNUCRWo2YY049XBDmWSRNs3uc2Y+ 0zIwqN2M3/Jz2cUZnOmanYPkDlpLQtN8FpBoRV6Wy1UwH94+/C1BcXv0U5lMX3uw5dLIHN zktd3aTIoOgOeqb1DVHAN2GHbnvhAA8= X-MC-Unique: qEaD6PZqPVK4KA7gTWl57w-1 From: Juan Quintela To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Stefan Hajnoczi , Juan Quintela , Leonardo Bras , Fam Zheng , Peter Xu Subject: [PATCH 1/9] migration: max_postcopy_bandwidth is a size parameter Date: Thu, 4 May 2023 13:38:33 +0200 Message-Id: <20230504113841.23130-2-quintela@redhat.com> In-Reply-To: <20230504113841.23130-1-quintela@redhat.com> References: <20230504113841.23130-1-quintela@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683200391197100011 Content-Type: text/plain; charset="utf-8" So make everything that uses it uint64_t no int64_t. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrang=C3=A9 --- migration/migration.c | 4 ++-- migration/options.c | 2 +- migration/options.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index feb5ab7493..232e387109 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2056,7 +2056,7 @@ static int postcopy_start(MigrationState *ms) QIOChannelBuffer *bioc; QEMUFile *fb; int64_t time_at_stop =3D qemu_clock_get_ms(QEMU_CLOCK_REALTIME); - int64_t bandwidth =3D migrate_max_postcopy_bandwidth(); + uint64_t bandwidth =3D migrate_max_postcopy_bandwidth(); bool restart_block =3D false; int cur_state =3D MIGRATION_STATUS_ACTIVE; =20 @@ -3176,7 +3176,7 @@ fail: void migrate_fd_connect(MigrationState *s, Error *error_in) { Error *local_err =3D NULL; - int64_t rate_limit; + uint64_t rate_limit; bool resume =3D s->state =3D=3D MIGRATION_STATUS_POSTCOPY_PAUSED; =20 /* diff --git a/migration/options.c b/migration/options.c index 7395787960..2e759cc306 100644 --- a/migration/options.c +++ b/migration/options.c @@ -717,7 +717,7 @@ uint64_t migrate_max_bandwidth(void) return s->parameters.max_bandwidth; } =20 -int64_t migrate_max_postcopy_bandwidth(void) +uint64_t migrate_max_postcopy_bandwidth(void) { MigrationState *s =3D migrate_get_current(); =20 diff --git a/migration/options.h b/migration/options.h index 09841d6a63..5cca3326d6 100644 --- a/migration/options.h +++ b/migration/options.h @@ -85,7 +85,7 @@ int migrate_decompress_threads(void); uint64_t migrate_downtime_limit(void); uint8_t migrate_max_cpu_throttle(void); uint64_t migrate_max_bandwidth(void); -int64_t migrate_max_postcopy_bandwidth(void); +uint64_t migrate_max_postcopy_bandwidth(void); int migrate_multifd_channels(void); MultiFDCompression migrate_multifd_compression(void); int migrate_multifd_zlib_level(void); --=20 2.40.0