From nobody Mon May 13 12:28:50 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1682973177; cv=none; d=zohomail.com; s=zohoarc; b=Vm9P66Id52Z42OpBu3HYq2pROo6ivpf4YwUh28TZW9Vd15th2FGsgvkk8n2YrAC4/NIa3sDXtTJC7ZPxwqVHB7PzG2qOgJjypC0xJr2I/D61KZ9VR+6Qzf7Ca1r+mymuOb2PigSAMrLvFIFj7DZT55yoVKxCFy+D0x44F/9D25c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682973177; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=nrDZWzDP2NtKWj2KdFkqn4kla53agoxAoKfKqolxnPo=; b=VYx65pPm/AfymWDcdS4RBoUdixHRPJsU3KhHec9XkIpJoUWb1KRHuZKcKi1KqFrvMTl4sCZwmw+SnUlBVH2fxzKeb80Zn/0U0dI3GbYkWO7KSWmDMcvU9/wGme/OhIl6YAGqAl2RyuL2Vv/N4ZAyizX3SkJQsxFpPQuOU4a79l8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682973177749274.3412937441452; Mon, 1 May 2023 13:32:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptaBg-0000ZU-6G; Mon, 01 May 2023 16:31:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptaBW-0000YX-3w for qemu-devel@nongnu.org; Mon, 01 May 2023 16:31:46 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptaBS-0001fl-2P for qemu-devel@nongnu.org; Mon, 01 May 2023 16:31:44 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 341K2O5R027593; Mon, 1 May 2023 20:31:32 GMT Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qa0a3a59d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 May 2023 20:31:31 +0000 Received: from pps.filterd (NALASPPMTA05.qualcomm.com [127.0.0.1]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 341KUXKZ019499; Mon, 1 May 2023 20:31:31 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA05.qualcomm.com (PPS) with ESMTPS id 3q8vakkqpy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 May 2023 20:31:31 +0000 Received: from NALASPPMTA05.qualcomm.com (NALASPPMTA05.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 341KVUoU020473; Mon, 1 May 2023 20:31:30 GMT Received: from hu-devc-sd-u20-a-1.qualcomm.com (hu-tsimpson-lv.qualcomm.com [10.47.204.221]) by NALASPPMTA05.qualcomm.com (PPS) with ESMTPS id 341KVUFX020472 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 May 2023 20:31:30 +0000 Received: by hu-devc-sd-u20-a-1.qualcomm.com (Postfix, from userid 47164) id 7310D67D; Mon, 1 May 2023 13:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=qcppdkim1; bh=nrDZWzDP2NtKWj2KdFkqn4kla53agoxAoKfKqolxnPo=; b=gLfnBabt1kONE8dYLmeCMTq6eWvLFhn6zwgFRHXxJqjKfnMwl+KEeM9L2aDGuyK+Wab6 oljtmucZL6jULk1ZfP2KQsB5n4//O0g9MSPcJwAbg0/eH8srfnfvDHDWeuNcDFEWTHp5 n1+/KPL9pOxPQvIi8deC4zpugfOqatZmOQG6s9mNQv69QZ0V8u4ZBwnCS7ABB3fXA2P4 KZYtujhMOnQv1dpb+zXFD8GsPq1XJZfU54a17S9zvwDGQgC2xZ7DWslq+MeaozURtZIp MuzmNNsWS2Zx9TreSf7omWSkD88Ma8nfJ3cBZdL8vK9HVopwPjD9YxJEib2mZ85zn6k1 Zw== From: Taylor Simpson To: qemu-devel@nongnu.org Cc: tsimpson@quicinc.com, richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng, bcain@quicinc.com, quic_mathbern@quicinc.com Subject: [PATCH v3] Hexagon (target/hexagon) Additional instructions handled by idef-parser Date: Mon, 1 May 2023 13:31:25 -0700 Message-Id: <20230501203125.4025991-1-tsimpson@quicinc.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: qrOtYYVLIdq0pWmUhD2NXo-GzeqJuxyK X-Proofpoint-GUID: qrOtYYVLIdq0pWmUhD2NXo-GzeqJuxyK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-01_12,2023-04-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=767 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305010166 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=tsimpson@qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @quicinc.com) X-ZM-MESSAGEID: 1682973178914100003 **** Changes in v3 **** Fix bugs exposed by dpmpyss_rnd_s0 instruction Set correct size/signedness for constants Test cases added to tests/tcg/hexagon/misc.c **** Changes in v2 **** Fix bug in imm_print identified in clang build Currently, idef-parser skips all floating point instructions. However, there are some floating point instructions that can be handled. The following instructions are now parsed F2_sfimm_p F2_sfimm_n F2_dfimm_p F2_dfimm_n F2_dfmpyll F2_dfmpylh To make these instructions work, we fix some bugs in parser-helpers.c gen_rvalue_extend gen_cast_op imm_print lexer properly sets size/signedness of constants Test cases added to tests/tcg/hexagon/fpstuff.c Signed-off-by: Taylor Simpson Reviewed-by: Anton Johansson Tested-by: Anton Johansson --- target/hexagon/idef-parser/parser-helpers.h | 2 +- target/hexagon/idef-parser/parser-helpers.c | 41 +++++++++++----- tests/tcg/hexagon/fpstuff.c | 54 +++++++++++++++++++++ tests/tcg/hexagon/misc.c | 35 +++++++++++++ target/hexagon/gen_idef_parser_funcs.py | 10 +++- target/hexagon/idef-parser/idef-parser.lex | 38 +++++++++++++-- target/hexagon/idef-parser/idef-parser.y | 2 - 7 files changed, 162 insertions(+), 20 deletions(-) diff --git a/target/hexagon/idef-parser/parser-helpers.h b/target/hexagon/i= def-parser/parser-helpers.h index 1239d23a6a..7c58087169 100644 --- a/target/hexagon/idef-parser/parser-helpers.h +++ b/target/hexagon/idef-parser/parser-helpers.h @@ -80,7 +80,7 @@ void reg_compose(Context *c, YYLTYPE *locp, HexReg *reg, = char reg_id[5]); =20 void reg_print(Context *c, YYLTYPE *locp, HexReg *reg); =20 -void imm_print(Context *c, YYLTYPE *locp, HexImm *imm); +void imm_print(Context *c, YYLTYPE *locp, HexValue *rvalue); =20 void var_print(Context *c, YYLTYPE *locp, HexVar *var); =20 diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index 86511efb62..0ad917f591 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -167,8 +167,9 @@ void reg_print(Context *c, YYLTYPE *locp, HexReg *reg) EMIT(c, "hex_gpr[%u]", reg->id); } =20 -void imm_print(Context *c, YYLTYPE *locp, HexImm *imm) +void imm_print(Context *c, YYLTYPE *locp, HexValue *rvalue) { + HexImm *imm =3D &rvalue->imm; switch (imm->type) { case I: EMIT(c, "i"); @@ -177,7 +178,21 @@ void imm_print(Context *c, YYLTYPE *locp, HexImm *imm) EMIT(c, "%ciV", imm->id); break; case VALUE: - EMIT(c, "((int64_t) %" PRIu64 "ULL)", (int64_t) imm->value); + if (rvalue->bit_width =3D=3D 32) { + if (rvalue->signedness =3D=3D UNSIGNED) { + EMIT(c, "((uint32_t) 0x%" PRIx32 ")", (uint32_t) imm->valu= e); + } else { + EMIT(c, "((int32_t) 0x%" PRIx32 ")", (int32_t) imm->value); + } + } else if (rvalue->bit_width =3D=3D 64) { + if (rvalue->signedness =3D=3D UNSIGNED) { + EMIT(c, "((uint64_t) 0x%" PRIx64 "ULL)", (uint64_t) imm->v= alue); + } else { + EMIT(c, "((int64_t) 0x%" PRIx64 "LL)", (int64_t) imm->valu= e); + } + } else { + g_assert_not_reached(); + } break; case QEMU_TMP: EMIT(c, "qemu_tmp_%" PRIu64, imm->index); @@ -213,7 +228,7 @@ void rvalue_print(Context *c, YYLTYPE *locp, void *poin= ter) tmp_print(c, locp, &rvalue->tmp); break; case IMMEDIATE: - imm_print(c, locp, &rvalue->imm); + imm_print(c, locp, rvalue); break; case VARID: var_print(c, locp, &rvalue->var); @@ -386,13 +401,10 @@ HexValue gen_rvalue_extend(Context *c, YYLTYPE *locp,= HexValue *rvalue) =20 if (rvalue->type =3D=3D IMMEDIATE) { HexValue res =3D gen_imm_qemu_tmp(c, locp, 64, rvalue->signedness); - bool is_unsigned =3D (rvalue->signedness =3D=3D UNSIGNED); - const char *sign_suffix =3D is_unsigned ? "u" : ""; gen_c_int_type(c, locp, 64, rvalue->signedness); - OUT(c, locp, " ", &res, " =3D "); - OUT(c, locp, "(", sign_suffix, "int64_t) "); - OUT(c, locp, "(", sign_suffix, "int32_t) "); - OUT(c, locp, rvalue, ";\n"); + OUT(c, locp, " ", &res, " =3D ("); + gen_c_int_type(c, locp, 64, rvalue->signedness); + OUT(c, locp, ")", rvalue, ";\n"); return res; } else { HexValue res =3D gen_tmp(c, locp, 64, rvalue->signedness); @@ -961,9 +973,16 @@ HexValue gen_cast_op(Context *c, { assert_signedness(c, locp, src->signedness); if (src->bit_width =3D=3D target_width) { - return *src; - } else if (src->type =3D=3D IMMEDIATE) { HexValue res =3D *src; + res.signedness =3D signedness; + return res; + } else if (src->type =3D=3D IMMEDIATE) { + HexValue res; + if (src->bit_width < target_width) { + res =3D gen_rvalue_extend(c, locp, src); + } else { + res =3D *src; + } res.bit_width =3D target_width; res.signedness =3D signedness; return res; diff --git a/tests/tcg/hexagon/fpstuff.c b/tests/tcg/hexagon/fpstuff.c index 90ce9a6ef3..28f9397155 100644 --- a/tests/tcg/hexagon/fpstuff.c +++ b/tests/tcg/hexagon/fpstuff.c @@ -20,6 +20,7 @@ */ =20 #include +#include =20 const int FPINVF_BIT =3D 1; /* Invalid */ const int FPINVF =3D 1 << FPINVF_BIT; @@ -706,6 +707,57 @@ static void check_float2int_convs() check_fpstatus(usr, FPINVF); } =20 +static void check_float_consts(void) +{ + int res32; + unsigned long long res64; + + asm("%0 =3D sfmake(#%1):neg\n\t" : "=3Dr"(res32) : "i"(0xf)); + check32(res32, 0xbc9e0000); + + asm("%0 =3D sfmake(#%1):pos\n\t" : "=3Dr"(res32) : "i"(0xf)); + check32(res32, 0x3c9e0000); + + asm("%0 =3D dfmake(#%1):neg\n\t" : "=3Dr"(res64) : "i"(0xf)); + check64(res64, 0xbf93c00000000000ULL); + + asm("%0 =3D dfmake(#%1):pos\n\t" : "=3Dr"(res64) : "i"(0xf)); + check64(res64, 0x3f93c00000000000ULL); +} + +static inline unsigned long long dfmpyll(double x, double y) +{ + unsigned long long res64; + asm("%0 =3D dfmpyll(%1, %2)" : "=3Dr"(res64) : "r"(x), "r"(y)); + return res64; +} + +static inline unsigned long long dfmpylh(double acc, double x, double y) +{ + unsigned long long res64 =3D *(unsigned long long *)&acc; + asm("%0 +=3D dfmpylh(%1, %2)" : "+r"(res64) : "r"(x), "r"(y)); + return res64; +} + +static void check_dfmpyxx(void) +{ + unsigned long long res64; + + res64 =3D dfmpyll(DBL_MIN, DBL_MIN); + check64(res64, 0ULL); + res64 =3D dfmpyll(-1.0, DBL_MIN); + check64(res64, 0ULL); + res64 =3D dfmpyll(DBL_MAX, DBL_MAX); + check64(res64, 0x1fffffffdULL); + + res64 =3D dfmpylh(DBL_MIN, DBL_MIN, DBL_MIN); + check64(res64, 0x10000000000000ULL); + res64 =3D dfmpylh(-1.0, DBL_MAX, DBL_MIN); + check64(res64, 0xc00fffffffe00000ULL); + res64 =3D dfmpylh(DBL_MAX, 0.0, -1.0); + check64(res64, 0x7fefffffffffffffULL); +} + int main() { check_compare_exception(); @@ -718,6 +770,8 @@ int main() check_sffixupd(); check_sffms(); check_float2int_convs(); + check_float_consts(); + check_dfmpyxx(); =20 puts(err ? "FAIL" : "PASS"); return err ? 1 : 0; diff --git a/tests/tcg/hexagon/misc.c b/tests/tcg/hexagon/misc.c index e126751e3a..4c994c55bd 100644 --- a/tests/tcg/hexagon/misc.c +++ b/tests/tcg/hexagon/misc.c @@ -385,6 +385,39 @@ void test_count_trailing_zeros_ones(void) check(ct1p(0xffffff0fffffffffULL), 36); } =20 +static inline int dpmpyss_rnd_s0(int x, int y) +{ + int res; + asm("%0 =3D mpy(%1, %2):rnd\n\t" : "=3Dr"(res) : "r"(x), "r"(y)); + return res; +} + +void test_dpmpyss_rnd_s0(void) +{ + check(dpmpyss_rnd_s0(-1, 0x80000000), 1); + check(dpmpyss_rnd_s0(0, 0x80000000), 0); + check(dpmpyss_rnd_s0(1, 0x80000000), 0); + check(dpmpyss_rnd_s0(0x7fffffff, 0x80000000), 0xc0000001); + check(dpmpyss_rnd_s0(0x80000000, -1), 1); + check(dpmpyss_rnd_s0(-1, -1), 0); + check(dpmpyss_rnd_s0(0, -1), 0); + check(dpmpyss_rnd_s0(1, -1), 0); + check(dpmpyss_rnd_s0(0x7fffffff, -1), 0); + check(dpmpyss_rnd_s0(0x80000000, 0), 0); + check(dpmpyss_rnd_s0(-1, 0), 0); + check(dpmpyss_rnd_s0(0, 0), 0); + check(dpmpyss_rnd_s0(1, 0), 0); + check(dpmpyss_rnd_s0(-1, -1), 0); + check(dpmpyss_rnd_s0(0, -1), 0); + check(dpmpyss_rnd_s0(1, -1), 0); + check(dpmpyss_rnd_s0(0x7fffffff, 1), 0); + check(dpmpyss_rnd_s0(0x80000000, 0x7fffffff), 0xc0000001); + check(dpmpyss_rnd_s0(-1, 0x7fffffff), 0); + check(dpmpyss_rnd_s0(0, 0x7fffffff), 0); + check(dpmpyss_rnd_s0(1, 0x7fffffff), 0); + check(dpmpyss_rnd_s0(0x7fffffff, 0x7fffffff), 0x3fffffff); +} + int main() { int res; @@ -522,6 +555,8 @@ int main() =20 test_count_trailing_zeros_ones(); =20 + test_dpmpyss_rnd_s0(); + puts(err ? "FAIL" : "PASS"); return err; } diff --git a/target/hexagon/gen_idef_parser_funcs.py b/target/hexagon/gen_i= def_parser_funcs.py index afe68bdb6f..b766798ad5 100644 --- a/target/hexagon/gen_idef_parser_funcs.py +++ b/target/hexagon/gen_idef_parser_funcs.py @@ -103,7 +103,15 @@ def main(): continue if tag.startswith("V6_"): continue - if tag.startswith("F"): + if ( tag.startswith("F") and + tag not in { + "F2_sfimm_p", + "F2_sfimm_n", + "F2_dfimm_p", + "F2_dfimm_n", + "F2_dfmpyll", + "F2_dfmpylh" + }): continue if tag.endswith("_locked"): continue diff --git a/target/hexagon/idef-parser/idef-parser.lex b/target/hexagon/id= ef-parser/idef-parser.lex index 5eb8ac5a80..4b81e63a02 100644 --- a/target/hexagon/idef-parser/idef-parser.lex +++ b/target/hexagon/idef-parser/idef-parser.lex @@ -401,12 +401,40 @@ STRING_LIT \"(\\.|[^"\\])*\" } return SIGN; } -"0x"{HEX_DIGIT}+ | -{DIGIT}+ { yylval->rvalue.type =3D IMMEDIATE; - yylval->rvalue.bit_width =3D 32; - yylval->rvalue.signedness =3D SIGNED; +"0x"{HEX_DIGIT}+ { uint64_t value =3D strtoull(yytext, NULL, 0); + yylval->rvalue.type =3D IMMEDIATE; yylval->rvalue.imm.type =3D VALUE; - yylval->rvalue.imm.value =3D strtoull(yytext, N= ULL, 0); + yylval->rvalue.imm.value =3D value; + if (value <=3D INT_MAX) { + yylval->rvalue.bit_width =3D sizeof(int) * = 8; + yylval->rvalue.signedness =3D SIGNED; + } else if (value <=3D UINT_MAX) { + yylval->rvalue.bit_width =3D sizeof(unsigne= d int) * 8; + yylval->rvalue.signedness =3D UNSIGNED; + } else if (value <=3D LONG_MAX) { + yylval->rvalue.bit_width =3D sizeof(long) *= 8; + yylval->rvalue.signedness =3D SIGNED; + } else if (value <=3D ULONG_MAX) { + yylval->rvalue.bit_width =3D sizeof(unsigne= d long) * 8; + yylval->rvalue.signedness =3D UNSIGNED; + } else { + g_assert_not_reached(); + } + return IMM; } +{DIGIT}+ { int64_t value =3D strtoll(yytext, NULL, 0); + yylval->rvalue.type =3D IMMEDIATE; + yylval->rvalue.imm.type =3D VALUE; + yylval->rvalue.imm.value =3D value; + if (value >=3D INT_MIN && value <=3D INT_MAX) { + yylval->rvalue.bit_width =3D sizeof(int) * = 8; + yylval->rvalue.signedness =3D SIGNED; + } else if (value >=3D LONG_MIN && value <=3D LO= NG_MAX) { + yylval->rvalue.bit_width =3D sizeof(long) *= 8; + yylval->rvalue.signedness =3D SIGNED; + } else { + printf("value =3D 0x%lx\n", value); + g_assert_not_reached(); + } return IMM; } "0x"{HEX_DIGIT}+"ULL" | {DIGIT}+"ULL" { yylval->rvalue.type =3D IMMEDIATE; diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef= -parser/idef-parser.y index 5444fd4749..5f3907eb28 100644 --- a/target/hexagon/idef-parser/idef-parser.y +++ b/target/hexagon/idef-parser/idef-parser.y @@ -594,8 +594,6 @@ rvalue : FAIL | CAST rvalue { @1.last_column =3D @2.last_column; - /* Assign target signedness */ - $2.signedness =3D $1.signedness; $$ =3D gen_cast_op(c, &@1, &$2, $1.bit_width, $1.signedness); } | rvalue EQ rvalue --=20 2.25.1