From nobody Fri May 10 12:20:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1682714710; cv=none; d=zohomail.com; s=zohoarc; b=JxWzb/LZtt+AVI5qfPUbz8kWRvLNlz8/3kSFL9tp2Z7W7BvaPoFByrAXMA6M6kne/dyUltVLB6rguPyfDzS7RiDFGbp1+C5fx372mTPvXfI5dfLMkl7gj/WtlzAYOPVc0pFYanAiql+Zm2SukILmMqgA1AiV+3hyYMeRzXDADXE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682714710; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=IwXHtb4nXYOEJwrflDMyX7yfJHmgM1MTzsmXyhZ2H3c=; b=DfOSSs+0N943u8Qyu3XqMXE07SjOTeSybL2REEIdvH+Q+EZIsNuzTgRj4tRo+VYq3weRZHR42djsXljg9wwtE1LsuQkqV4plb2I5TirDdHxhav3Tdj3dUWks/RYE3k/gdYJibwHkLsXK/iVjx95OqPQZTeLj2eKLsY7MjiB3vvY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682714710680847.3756510772935; Fri, 28 Apr 2023 13:45:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1psUx3-0000Cc-NA; Fri, 28 Apr 2023 16:44:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psUx2-0000CN-UO for qemu-devel@nongnu.org; Fri, 28 Apr 2023 16:44:20 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psUx0-0002yR-Iu for qemu-devel@nongnu.org; Fri, 28 Apr 2023 16:44:20 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33SJ8Lr1019376; Fri, 28 Apr 2023 20:44:16 GMT Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q8fvngw7m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Apr 2023 20:44:15 +0000 Received: from pps.filterd (NALASPPMTA05.qualcomm.com [127.0.0.1]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 33SKiEtd008231; Fri, 28 Apr 2023 20:44:14 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA05.qualcomm.com (PPS) with ESMTPS id 3q87ypvg5d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Apr 2023 20:44:14 +0000 Received: from NALASPPMTA05.qualcomm.com (NALASPPMTA05.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33SKiEdE008226; Fri, 28 Apr 2023 20:44:14 GMT Received: from hu-devc-sd-u20-a-1.qualcomm.com (hu-tsimpson-lv.qualcomm.com [10.47.204.221]) by NALASPPMTA05.qualcomm.com (PPS) with ESMTPS id 33SKiEpZ008202 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Apr 2023 20:44:14 +0000 Received: by hu-devc-sd-u20-a-1.qualcomm.com (Postfix, from userid 47164) id 1346966C; Fri, 28 Apr 2023 13:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=qcppdkim1; bh=IwXHtb4nXYOEJwrflDMyX7yfJHmgM1MTzsmXyhZ2H3c=; b=XbeTVgwphOSgEtD/Gl2s5dEh5vsOIXnu49wjsMLtboP9AmQLVHxrLiXTcZnI5RUpMhwm w7IgQXq61aop5hwj73cGXwD4OC0dXvxFE2SZ5ap95JXIY5rPi4RUJHteKfJVu5aOzm3B GQUMsZ27c/P4343Ik4xTqGRewVWD4P3UVIagdQt6iDMyGgHSqVj2khEv+A9Uh4IxgB3Z DuFijyUciWk7Za1jeHzGkBtOGfjnY4PB7hkD51oQZ3pL8eZmo5VOn43bU1osb/qxJ4tP 2elm8uivHpO+qtkZpGLYGV/huER+UNkljdoHdyC8bfnaC5V//Dpn7Eeg8Una6QjmDdya jQ== From: Taylor Simpson To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, tsimpson@quicinc.com, richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng, bcain@quicinc.com, quic_mathbern@quicinc.com Subject: [PATCH v2] target/hexagon: fix = vs. == mishap Date: Fri, 28 Apr 2023 13:44:11 -0700 Message-Id: <20230428204411.1400931-1-tsimpson@quicinc.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Cr31RS8wvteo7EscQnJfd7rYLMCRlo7b X-Proofpoint-GUID: Cr31RS8wvteo7EscQnJfd7rYLMCRlo7b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-28_06,2023-04-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=711 spamscore=0 bulkscore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304280170 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=tsimpson@qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @quicinc.com) X-ZM-MESSAGEID: 1682714713055100001 From: Paolo Bonzini **** Changes in v2 **** Fix yyassert's for sign and zero extends Coverity reports a parameter that is "set but never used". This is caused by an assignment operator being used instead of equality. Co-authored-by: Taylor Simpson Signed-off-by: Paolo Bonzini Signed-off-by: Taylor Simpson Reviewed-by: Anton Johansson Tested-by: Anton Johansson --- target/hexagon/idef-parser/parser-helpers.c | 2 +- target/hexagon/idef-parser/idef-parser.y | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index 86511efb62..0a01ec39b7 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1123,7 +1123,7 @@ HexValue gen_extend_op(Context *c, HexValue *value, HexSignedness signedness) { - unsigned bit_width =3D (dst_width =3D 64) ? 64 : 32; + unsigned bit_width =3D (dst_width =3D=3D 64) ? 64 : 32; HexValue value_m =3D *value; HexValue src_width_m =3D *src_width; =20 diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef= -parser/idef-parser.y index 5444fd4749..2561f0ebb0 100644 --- a/target/hexagon/idef-parser/idef-parser.y +++ b/target/hexagon/idef-parser/idef-parser.y @@ -685,7 +685,7 @@ rvalue : FAIL yyassert(c, &@1, $5.type =3D=3D IMMEDIATE && $5.imm.type =3D=3D VALUE, "SXT expects immediate values\n"); - $$ =3D gen_extend_op(c, &@1, &$3, $5.imm.value, &$7, SIGNED); + $$ =3D gen_extend_op(c, &@1, &$3, 64, &$7, SIGNED); } | ZXT '(' rvalue ',' IMM ',' rvalue ')' { @@ -693,7 +693,7 @@ rvalue : FAIL yyassert(c, &@1, $5.type =3D=3D IMMEDIATE && $5.imm.type =3D=3D VALUE, "ZXT expects immediate values\n"); - $$ =3D gen_extend_op(c, &@1, &$3, $5.imm.value, &$7, UNSIGNED= ); + $$ =3D gen_extend_op(c, &@1, &$3, 64, &$7, UNSIGNED); } | '(' rvalue ')' { --=20 2.25.1