From nobody Sun Feb 8 15:54:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1682675154; cv=none; d=zohomail.com; s=zohoarc; b=e7CbxTd6SgYyxWHq4DUr9uhLzxrrmdVMsACDAIGVP9hCgnuZricA/WHlZsw5WygEOMyyHnKVJYze7NihjVS0UxQ3NjSJn9f7t+o1HMysRSjsQ4CXdlKu01dsjTs0QK0s8e/AG3Uo1loPdeRNLVA6DXeuhO9Bvfe/DmtXBNQMHk0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682675154; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wGUIZEXyqc9DsRVKuagHrvkSytTZjdsLflbLid1tWsA=; b=d1jvttifp6cWg1SvnV9UMGHSaGBY8nK0C39FHyWUt9ALDQOKA4TDk/RXWn2SPC7YexhpYv1lMjc0xRwaSWIpRuh2VUpjS+6qFvCCiVzO9hDYP6E5idS75XadJIyz/dgzYi4xHKCFPrWzhpIIoGtT/xCyfk+xtPgayUe1iAACgmY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682675154508441.7072030944537; Fri, 28 Apr 2023 02:45:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1psKeM-0003q5-4i; Fri, 28 Apr 2023 05:44:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psKeJ-0003nV-FW for qemu-devel@nongnu.org; Fri, 28 Apr 2023 05:44:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psKeI-0007bV-0C for qemu-devel@nongnu.org; Fri, 28 Apr 2023 05:44:19 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-362-kFOCYMz3ObuVmulVq5AokA-1; Fri, 28 Apr 2023 05:44:13 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F73C10504A4; Fri, 28 Apr 2023 09:44:13 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id CBED01410F1C; Fri, 28 Apr 2023 09:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682675057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wGUIZEXyqc9DsRVKuagHrvkSytTZjdsLflbLid1tWsA=; b=AUZYpZ4uL0Cvgx1yqXMLLhpNuzng9FewRCL+7eE5GWTfe0JAnV0jNoymK0TFDetQQXaTxU M0UPEAfmFpe/Bw+4NP7Az0ZZ6aBDzC5Z6JgTd4RUOGN88ANqYOLqz3X050Nnh7+9ljG+lb SjnWcWwV/Wk828k28sfzvaUHYVmeMsY= X-MC-Unique: kFOCYMz3ObuVmulVq5AokA-1 From: Thomas Huth To: qemu-devel@nongnu.org, Richard Henderson Cc: Alexander Bulekov , Darren Kenny Subject: [PULL 13/13] apic: disable reentrancy detection for apic-msi Date: Fri, 28 Apr 2023 11:43:46 +0200 Message-Id: <20230428094346.1292054-14-thuth@redhat.com> In-Reply-To: <20230428094346.1292054-1-thuth@redhat.com> References: <20230428094346.1292054-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.171, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1682675155395100001 Content-Type: text/plain; charset="utf-8" From: Alexander Bulekov As the code is designed for re-entrant calls to apic-msi, mark apic-msi as reentrancy-safe. Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny Message-Id: <20230427211013.2994127-9-alxndr@bu.edu> Signed-off-by: Thomas Huth --- hw/intc/apic.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/intc/apic.c b/hw/intc/apic.c index 20b5a94073..ac3d47d231 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -885,6 +885,13 @@ static void apic_realize(DeviceState *dev, Error **err= p) memory_region_init_io(&s->io_memory, OBJECT(s), &apic_io_ops, s, "apic= -msi", APIC_SPACE_SIZE); =20 + /* + * apic-msi's apic_mem_write can call into ioapic_eoi_broadcast, which= can + * write back to apic-msi. As such mark the apic-msi region re-entrancy + * safe. + */ + s->io_memory.disable_reentrancy_guard =3D true; + s->timer =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, apic_timer, s); local_apics[s->id] =3D s; =20 --=20 2.31.1