From nobody Sun May 12 07:11:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1682555492; cv=pass; d=zohomail.com; s=zohoarc; b=ViyhYYYEzBbHv8DIx666SbquVB9TdVtXPXt/oEXSOtEZ1jZLdqHbIbatVg2fWsM5YJotvCop1vgSVuaKQ7V8MoDBgbX0WM8PpOmDl2iEo3h+0D5qbCDEx0TxsV72FetO2+E4KHEvfIpowHuisVIP+nT3hLu0cSjFnQrSqJpgc9o= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682555492; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=SAMuowBtECEOAxEpHUWZCwaHEsjAekYfN3EBU5MMIQ0=; b=KahXpqthGGRszPWVyTrUwt3DVOMoIv9VsjEj92SB0FPeQnSL3p/AzryVHbEpcNQ+cvPZELuJ7f1IYmVYa8HNFAYuSFOnbdzp6JYs1ciuGaHEuD/XHsyB45xEQa7hseouTpRkUvJXOdZI+b+YiEyTOjLrbbob62XFcFPQoc0wSUE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682555492469885.2323881229593; Wed, 26 Apr 2023 17:31:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prpX2-00019b-4C; Wed, 26 Apr 2023 20:30:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prmUv-0001gQ-4j; Wed, 26 Apr 2023 17:16:21 -0400 Received: from mail-dm6nam10on2062b.outbound.protection.outlook.com ([2a01:111:f400:7e88::62b] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prmUr-0000tS-Aw; Wed, 26 Apr 2023 17:16:20 -0400 Received: from DM6PR11CA0005.namprd11.prod.outlook.com (2603:10b6:5:190::18) by CH3PR12MB8935.namprd12.prod.outlook.com (2603:10b6:610:169::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.34; Wed, 26 Apr 2023 21:16:10 +0000 Received: from DM6NAM11FT092.eop-nam11.prod.protection.outlook.com (2603:10b6:5:190:cafe::c9) by DM6PR11CA0005.outlook.office365.com (2603:10b6:5:190::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21 via Frontend Transport; Wed, 26 Apr 2023 21:16:10 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT092.mail.protection.outlook.com (10.13.173.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6340.21 via Frontend Transport; Wed, 26 Apr 2023 21:16:09 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 26 Apr 2023 16:16:08 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 26 Apr 2023 16:16:08 -0500 Received: from xsjtongh40.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 26 Apr 2023 16:16:07 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lvstLooCVOhaNZJ+eBUDhG6bO70VGXk1tlLwhU1307SEwFzt734od1oTIbKa4DUr84ik9DzMmybIDl+J1cHs9NniELlam+ftbhfBG2Tvji7u0oQQp03RFO53RcXAe0HJ4EbJ21urhJLd52JeCyZf1YgcivzgrVfUKSSeVNZHxCGcvKk0/iWGkkMJLyyD82OkZlptgS2EL47BXN89A7IT3H6+4sA0vko+Ha/wYyP+hBYfMUU+TTlskkffVSWYbEywiAsyi+AdG6nT5tiozfIPh1nRNrULGFQXTnvY0NIKGRL91kvJdYViX8Jumcb3tq+ipliKmWMHWwQf4D2Bxs25+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SAMuowBtECEOAxEpHUWZCwaHEsjAekYfN3EBU5MMIQ0=; b=fpxvNnL2VnFzqWvhEuvssOARJPi3D7uicMzLvm8og1NLlU02RIOuKGS2CRlr8ue03Gxjc82xiklKPF69WUxWeekun9ruBvnciAfzpzQT7XnowDw8TdIRcd4kFO3Zuu7dtmgw7Z0ybXomODPuGoEWgLpq/VCy7caEZkIo0bR9jmugF8LIJ0UoKtx9rY8aPzDx79JLqihf+KkLPJu3SoPlwbcaqJw1Ze8K7e919d1F6DE1YIqf7ZH6cGzsU2TyJpLZuEeRqTbHKivqjfeaG2FRknWGXdNCNFC/PgpVGFC9B1QqRJU2Ktest7F2Q4K0r5FTO4SDhw6dfsDIpQeh7HH3wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SAMuowBtECEOAxEpHUWZCwaHEsjAekYfN3EBU5MMIQ0=; b=SJbiZK5yQhn+rEMpyNF86g8FYfNs2SecGIPzfGSMA3j2doI9lVpsCw+J4U6wh9J0v0PxWHfGHmHadRXzzD9oizsxsMDJwTzGjD+nJzYf2ZR1CIJKKdTFbnW1lRcR6OySLwlMvPf35rYNyNUk5Der+zJwzI+XmReSgxuZwKTnR88= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Tong Ho To: CC: , , , , , Subject: [PATCH] hw/nvram: Avoid unnecessary Xilinx eFuse backstore write Date: Wed, 26 Apr 2023 14:16:07 -0700 Message-ID: <20230426211607.2054776-1-tong.ho@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT092:EE_|CH3PR12MB8935:EE_ X-MS-Office365-Filtering-Correlation-Id: 99b7529d-6dae-438e-5865-08db469b74f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xN2Jlx+9WnjurHIgmqAsDxpZ3li9b4B31xXzr8L6lGwIn4vAlp+ME6w8Wv2XUKn048LbgfV4C+tWWDflZO2U0GeBE9TYuU9671w/dRTm517WKQQnYJ6tzYe/ZzjHCCh4c2Os1vjjKlfsNsSLXLjntxrYkwEEQJvrdfPlagz58wq4AbxeLy8NTuY1n7TQ36uaryMLotL/Yi44aAjGskQeLvFZUOh04u+0ojuLQ3XxMgp1XKz8CQvudXpxH83Q1QLZ894QAMbyUBMyi06zgHuVUB6WvRuRAjUvzYg8BkRuDIntATPxE6LEzwUMXEDSBw49xt1CASl0/Tvl0zP7O/AxxXg8IfdGG1Ky0WKtyK49n6P9fGd+WF52qDWzwNqJlOt9uJjoMNch6iplbTf2Yz/B2JuY1vRdsUezPb5AdMEH86BGe6QxEs6rJPajH9+8U7Fm+P1f1A21dmdy22+AXHNC6kgK7BCDs22Ji5224UOTs5CCFQqi1sFRCBzQOzixPIN4M93qbArZ8GZVy1yf4DLTEo/38j09pi5O/f5j1hUxHycfuV/AB+Ieumu2SZtZ64l9LCv1oAX3gow28O5HYZMvn5mkSdMP4Vb+7akGwuct0P5Aw7MEy8UYDwYSNY2Z4wrp73hluYdLVD2woUTgWQ9eVsM2vd/fklZIhG4H/CQo7qp/cfTZ6MZnrWZ4emYaSpv/FqdkimHxk6RE/n6EjRvIt+O97qXU3nQ+dKjSv2jPJR4= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199021)(46966006)(40470700004)(36840700001)(82740400003)(44832011)(316002)(6916009)(4326008)(40460700003)(41300700001)(81166007)(5660300002)(356005)(8936002)(8676002)(36756003)(82310400005)(86362001)(2906002)(2616005)(40480700001)(26005)(1076003)(478600001)(36860700001)(83380400001)(426003)(336012)(186003)(47076005)(70206006)(54906003)(70586007)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 21:16:09.8059 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99b7529d-6dae-438e-5865-08db469b74f0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT092.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8935 Received-SPF: softfail client-ip=2a01:111:f400:7e88::62b; envelope-from=tong.ho@amd.com; helo=NAM10-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 26 Apr 2023 20:30:42 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1682555494556100001 Content-Type: text/plain; charset="utf-8" Add a check in the bit-set operation to write the backstore only if the affected bit is 0 before. With this in place, there will be no need for callers to do the checking in order to avoid unnecessary writes. Signed-off-by: Tong Ho Reviewed-by: Alistair Francis Reviewed-by: Francisco Iglesias Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/nvram/xlnx-efuse.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/nvram/xlnx-efuse.c b/hw/nvram/xlnx-efuse.c index fdfffaab99..655c40b8d1 100644 --- a/hw/nvram/xlnx-efuse.c +++ b/hw/nvram/xlnx-efuse.c @@ -143,6 +143,8 @@ static bool efuse_ro_bits_find(XlnxEFuse *s, uint32_t k) =20 bool xlnx_efuse_set_bit(XlnxEFuse *s, unsigned int bit) { + uint32_t set, *row; + if (efuse_ro_bits_find(s, bit)) { g_autofree char *path =3D object_get_canonical_path(OBJECT(s)); =20 @@ -152,8 +154,13 @@ bool xlnx_efuse_set_bit(XlnxEFuse *s, unsigned int bit) return false; } =20 - s->fuse32[bit / 32] |=3D 1 << (bit % 32); - efuse_bdrv_sync(s, bit); + /* Avoid back-end write unless there is a real update */ + row =3D &s->fuse32[bit / 32]; + set =3D 1 << (bit % 32); + if (!(set & *row)) { + *row |=3D set; + efuse_bdrv_sync(s, bit); + } return true; } =20 --=20 2.25.1