From nobody Tue Feb 10 23:14:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1682505594; cv=none; d=zohomail.com; s=zohoarc; b=TuPNjclTb2GrTJH4b+624oYGwHkTcAkkY3UDpAbhnZYh5wDAGs1xlx9MZJbz0IkAXYgCwmIXV6XixZqgUwWrWBeskbWTZKWq3WuBp58UQMe8ae6J9bd6i6QwGBZ1nMucy98jJ+Wuf9Nno7x1gzOpvgPBdvSa//MPCS8Dr/ooulY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682505594; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=gxmYdGyeyclr6nIITv2T0ZzAW4fVgPRCULVfg9/kFCc=; b=Cju6iCiWI0DcKfLu5yQbV2aMxsOA6uP+lRp71XNbPCqZcCIQRRjPXf1yT7rwBxOIqPEW5ZRJJfPWK/vwipHJOptc3ewLVvXLZ808nE+DS/oxVQTIIYd9Szx2gyEsGHmP6qYYWaRQXs7JokKWYYpaQVmmunmN9OK1IXK2A0YvaoI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682505594805287.0884347250212; Wed, 26 Apr 2023 03:39:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prcXo-0002Ke-9g; Wed, 26 Apr 2023 06:38:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prcXm-00029l-C9 for qemu-devel@nongnu.org; Wed, 26 Apr 2023 06:38:38 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prcXk-0003D3-FK for qemu-devel@nongnu.org; Wed, 26 Apr 2023 06:38:37 -0400 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-63b62d2f729so5526806b3a.1 for ; Wed, 26 Apr 2023 03:38:36 -0700 (PDT) Received: from alarm.u-tokyo.ac.jp ([157.82.194.15]) by smtp.gmail.com with ESMTPSA id m11-20020a63580b000000b0051322a5aa64sm9317919pgb.3.2023.04.26.03.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 03:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1682505515; x=1685097515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gxmYdGyeyclr6nIITv2T0ZzAW4fVgPRCULVfg9/kFCc=; b=MPairb+DMLnLRuNk1P+3Dw4c8G0MZWQY87RcZTyeXGnz+9ze6dVomNTkIJN5GH0pvx 5d6ERaSyogsuZms+wbSo6bjFupQHa/A90lPE8TpwE4TCIOL6CIhZzrG0WhZsUWTKCKqf Sm269HXSabTQu+LC/H/3cNU91QCZn7zFCyqmaI3FHaUoDaS7PN97mihKsJj/A/o2ky6y swh1qQHWg/enaYxOC1ah3VtEBneDgDKWcPKAMUYj/Kg9bt7GWvPL7LMX5DwSVzqq1pz5 23a5c5TBCywdIhS4Rd212RD9ysuwg+pwVB3x/uySkkeeWR3eV1523g8E0azK6S6lsxeq hbjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682505515; x=1685097515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gxmYdGyeyclr6nIITv2T0ZzAW4fVgPRCULVfg9/kFCc=; b=lzcJwS/AbUbhw8vflh5L+JxU2Pdzy7+skgzanhuhkzPbRjwtK4PWQPlFxa6A7HH72+ xOD7R5IjgqCTB4mBu5YtPQnZ97rEXQKLYyG9kYyYDvy+vjpkTVY88StijV3H2OZtZpHK ihtHF6if17m/GXxdkznLjYwcJchQEqGwn6Ib56W2qNVeNi/xeVq2TjLi54atsWuNKL1n L/phdE9GRnbURD2aB4pJQS/rAlmUQ0lBdRM905rswcsSbviq8mXnfvfBPya/WS1HqsIa /wHVHEOkRWvPYcgCpovgsoXgj+UV9sEbdHMRgb/jf9j1qYS6DA2EypSLL+IKrPjKvjX7 4Mxg== X-Gm-Message-State: AAQBX9dQnAFOJfHVN0OQTGfMLlXezv0yUyikGd+ZnDV8zXli6O+f1Xv5 kDqk2N+OJ9mWC5Ewc2XJBHIWoQ== X-Google-Smtp-Source: AKy350ZtKemE62+YEBZyON7cHzwdIuOBfLlFDejQbJq5q90XJIIdS/Pl6s2aXs7OzuVCfgEnfNmBDw== X-Received: by 2002:a05:6a21:99a5:b0:f2:8c89:cd30 with SMTP id ve37-20020a056a2199a500b000f28c89cd30mr22697818pzb.13.1682505515250; Wed, 26 Apr 2023 03:38:35 -0700 (PDT) From: Akihiko Odaki To: Cc: Sriram Yagnaraman , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal , Cleber Rosa , Laurent Vivier , Paolo Bonzini , qemu-devel@nongnu.org, Tomasz Dzieciol , Akihiko Odaki Subject: [PATCH v4 20/48] igb: Remove goto Date: Wed, 26 Apr 2023 19:36:48 +0900 Message-Id: <20230426103716.26279-21-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230426103716.26279-1-akihiko.odaki@daynix.com> References: <20230426103716.26279-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::42f; envelope-from=akihiko.odaki@daynix.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1682505596674100003 Content-Type: text/plain; charset="utf-8" The goto is a bit confusing as it changes the control flow only if L4 protocol is not recognized. It is also different from e1000e, and noisy when comparing e1000e and igb. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 946b917f91..bae51cbb63 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1297,7 +1297,7 @@ igb_build_rx_metadata(IGBCore *core, break; =20 default: - goto func_exit; + break; } } else { trace_e1000e_rx_metadata_l4_cso_disabled(); --=20 2.40.0