From nobody Tue Feb 10 23:00:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1682488720; cv=none; d=zohomail.com; s=zohoarc; b=fzkp1WmSyRU/MeLVqp+QWSgRpyybs1P7keCT/h8w/9RvknZjCuaX7XTHzkOhMi/Jkb8tmKUBvZHXYQzIxzcGKMkgbvhH7RBo3giZoIqIfG16QvIiJllmbh78r9MKe9nOWl9//394R7weFzNHOvQ2dwgc9KWsL8YbCZb4p+CAGlQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682488720; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4Hz9ZJyOHb7HeMMGGGjq9hemFWL+7NMJVM41BZbVF+U=; b=bFxLiDEfuisp6/HsoZa/eCQNKgFu2IFo3d2HWJi4v79T3uZLas2Td2P68VzxwFR1jLYXu0kmSKy6JpRh9X6bCqHR2PqAeWfZ3aghrr4P79bHudK2SivAGbQXN+TjReE2Tn4CTyYd3YMTv26G1QL+BynUtj/Y025WIak7QTiV7Jw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682488720822267.42200444609125; Tue, 25 Apr 2023 22:58:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prYAB-00068n-GY; Wed, 26 Apr 2023 01:57:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prYA5-000650-2a for qemu-devel@nongnu.org; Wed, 26 Apr 2023 01:57:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prYA1-0002l8-Sk for qemu-devel@nongnu.org; Wed, 26 Apr 2023 01:57:52 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-111-VY1c3qtyMhCCTrJ_ToMP6Q-1; Wed, 26 Apr 2023 01:57:45 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5CF2885C069; Wed, 26 Apr 2023 05:57:45 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B80640C6E67; Wed, 26 Apr 2023 05:57:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1FD0B21F1674; Wed, 26 Apr 2023 07:57:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682488669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Hz9ZJyOHb7HeMMGGGjq9hemFWL+7NMJVM41BZbVF+U=; b=CDUq313j2IT5QN2YL/GEgrJBcc1l4laBhg9DegdPz7ZJurMsW6czN4VhwSGs7BL+dPeywy eUjow2BOgQV0Eq0EYBTdoRAuXzqfl6E7YkZyG2rjvTH8T2ztv86Iw8fG/267OsZjWAvScJ RGuAIgxDDIrYCP98FPulM0UNb5FMo3I= X-MC-Unique: VY1c3qtyMhCCTrJ_ToMP6Q-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Eric Blake Subject: [PULL 01/17] qapi: Fix error message format regression Date: Wed, 26 Apr 2023 07:57:28 +0200 Message-Id: <20230426055744.1041930-2-armbru@redhat.com> In-Reply-To: <20230426055744.1041930-1-armbru@redhat.com> References: <20230426055744.1041930-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.171, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1682488722333100003 Content-Type: text/plain; charset="utf-8" Commit 52a474180ae3 changed reporting of errors connected to a source location without mentioning it in the commit message. For instance, $ python scripts/qapi-gen.py tests/qapi-schema/unknown-escape.json tests/qapi-schema/unknown-escape.json:3:21: unknown escape \x became scripts/qapi-gen.py: tests/qapi-schema/unknown-escape.json:3:21: unknow= n escape \x This is not how compilers report such errors, and Emacs doesn't recognize the format. Revert this change. Fixes: 52a474180ae3 (qapi-gen: Separate arg-parsing from generation) Signed-off-by: Markus Armbruster Message-Id: <20230316071325.492471-2-armbru@redhat.com> Reviewed-by: Eric Blake --- scripts/qapi/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/main.py b/scripts/qapi/main.py index fc216a53d3..316736b6a2 100644 --- a/scripts/qapi/main.py +++ b/scripts/qapi/main.py @@ -98,6 +98,6 @@ def main() -> int: builtins=3Dargs.builtins, gen_tracing=3Dnot args.suppress_tracing) except QAPIError as err: - print(f"{sys.argv[0]}: {str(err)}", file=3Dsys.stderr) + print(err, file=3Dsys.stderr) return 1 return 0 --=20 2.39.2