From nobody Wed Feb 11 00:59:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1682420244; cv=none; d=zohomail.com; s=zohoarc; b=FPKoYWx0Milvaua5V6mnTc4pcNIB/irpR9IF5BNH1xCJKY342gv0BPzGVPhxF/fCpeaZ6XIX3qVGwSK4c8I1kBPhIna7W2F56Nc0LGLpVjHECiQu+MInarvsgz+qfhkk/cyZQWABgjKVLzLQmoIda3M6sJKNAGYBZ4cRs+KfgqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682420244; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T4OMW3uNIsuTtXXlaMvFRDkYLhI73waVVu2T/GxdfZQ=; b=WBUEMfJGKiVdZFeOcIYf30dfh5LMg/uKQcqdDjKdHbdKD+vdWz1u97Fo5i/LPTXugW8Nd3Uc58moT0484IQX8vuKVTTxOrsZtJf4eFT/oFVxsoMO7yWp8zarg8B9eq91759rvYrome3N5DXcD76wwkBCQbvhSrEr8Il24UUdFZU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682420244121969.787551324134; Tue, 25 Apr 2023 03:57:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prGLZ-0001xn-NP; Tue, 25 Apr 2023 06:56:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prGLT-0001u6-Rc for qemu-devel@nongnu.org; Tue, 25 Apr 2023 06:56:29 -0400 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prGLQ-0004gq-L1 for qemu-devel@nongnu.org; Tue, 25 Apr 2023 06:56:27 -0400 Received: from mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net [IPv6:2a02:6b8:c00:2582:0:640:9a17:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id 3B1476098F; Tue, 25 Apr 2023 13:56:19 +0300 (MSK) Received: from vsementsov-nix.yandex-team.ru (unknown [2a02:6b8:b081:b440::1:14]) by mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id 4uDLUS1OcKo0-tVwmMd5C; Tue, 25 Apr 2023 13:56:18 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1682420178; bh=T4OMW3uNIsuTtXXlaMvFRDkYLhI73waVVu2T/GxdfZQ=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=JhhP2+WhuAZhTAgJleS7ORULKuwxT8qXC/1FaTMv5Cmuejsdb540aqKOx6qyaby03 UfyNT6bJkyj1TdmNMc4W1ckU3aaVyOXeKABLT0U82M6bCKTjPKn4lZfM+Lt92DSGY2 m0ZvCafjJ+caL1bfZR5Spa+8TTwpTuvgWtQ8S8gs= Authentication-Results: mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Cc: marcel.apfelbaum@gmail.com, mst@redhat.com, philmd@linaro.org, david@redhat.com, peterx@redhat.com, pbonzini@redhat.com, vsementsov@yandex-team.ru, den-plotnikov@yandex-team.ru, lersek@redhat.com, kraxel@redhat.com Subject: [PATCH 2/3] pci: pci_add_option_rom(): refactor: use g_autofree for path variable Date: Tue, 25 Apr 2023 13:56:02 +0300 Message-Id: <20230425105603.137823-3-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230425105603.137823-1-vsementsov@yandex-team.ru> References: <20230425105603.137823-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1682420244595100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/pci/pci.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 4a61c8d24a..a442f8fce1 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2292,7 +2292,7 @@ static void pci_add_option_rom(PCIDevice *pdev, bool = is_default_rom, Error **errp) { int64_t size; - char *path; + g_autofree char *path =3D NULL; void *ptr; char name[32]; const VMStateDescription *vmsd; @@ -2337,16 +2337,13 @@ static void pci_add_option_rom(PCIDevice *pdev, boo= l is_default_rom, size =3D get_image_size(path); if (size < 0) { error_setg(errp, "failed to find romfile \"%s\"", pdev->romfile); - g_free(path); return; } else if (size =3D=3D 0) { error_setg(errp, "romfile \"%s\" is empty", pdev->romfile); - g_free(path); return; } else if (size > 2 * GiB) { error_setg(errp, "romfile \"%s\" too large (size cannot exceed 2 G= iB)", pdev->romfile); - g_free(path); return; } if (pdev->romsize !=3D -1) { @@ -2354,7 +2351,6 @@ static void pci_add_option_rom(PCIDevice *pdev, bool = is_default_rom, error_setg(errp, "romfile \"%s\" (%u bytes) " "is too large for ROM size %u", pdev->romfile, (uint32_t)size, pdev->romsize); - g_free(path); return; } } else { @@ -2372,10 +2368,8 @@ static void pci_add_option_rom(PCIDevice *pdev, bool= is_default_rom, ptr =3D memory_region_get_ram_ptr(&pdev->rom); if (load_image_size(path, ptr, size) < 0) { error_setg(errp, "failed to load romfile \"%s\"", pdev->romfile); - g_free(path); return; } - g_free(path); =20 if (is_default_rom) { /* Only the default rom images will be patched (if needed). */ --=20 2.34.1