From nobody Mon Feb 9 16:19:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1682366659; cv=none; d=zohomail.com; s=zohoarc; b=mqBpRsbEsY/zQgfQbUlz2o88NBz3+4s3QEGmG0WUagzJsryUd7Fe7AoXjWuBdUXu/dG4vhO/e3Ar26ugWfTJvOHVwpZaiVXXUgdllepvpWlj3L9Xtko9n8ZVfAX6tB1u7TQlyTDfY76eQz471p0soG4goI0dn6TeUDiOuTHwVjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682366659; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TR90EIS18UVyGds2jFRXjl24pA0rHLnN+HKJ4k91mQc=; b=aY36QoeU34j//D4X5G2EJr+KIjTJEDJK++9TB2g0gz0lXf1frhp8O1nsxwCjCutmTUhDV03xKHxgpxh2vFt3KKxIabNmzhFUPQAfejL6yJKWbXUDIuVNZwB7JBsVtPpkEXIunHsu1SDGGxvUrd60l2hFZMoP8R0ocMvfjCNNorw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682366659075655.1344533051334; Mon, 24 Apr 2023 13:04:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pr2P2-0007yV-P2; Mon, 24 Apr 2023 16:03:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pr2P0-0007uY-MU for qemu-devel@nongnu.org; Mon, 24 Apr 2023 16:03:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pr2Oy-00010t-Km for qemu-devel@nongnu.org; Mon, 24 Apr 2023 16:03:10 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-460-zhe__F8EP_u0QQ15lGpyyQ-1; Mon, 24 Apr 2023 16:03:04 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D85F6381494C; Mon, 24 Apr 2023 20:03:03 +0000 (UTC) Received: from scv.redhat.com (unknown [10.22.34.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F5FD1121318; Mon, 24 Apr 2023 20:03:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682366588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TR90EIS18UVyGds2jFRXjl24pA0rHLnN+HKJ4k91mQc=; b=eRpCJ2zOO6cLZfVFhMhiioSeg3Psrpkfw4JqMl1flel6G5FxkkXy8Cb0zO04G72WZkx7IH Rm/2srvCCoAZTQ4L4GVp9wpUDSwDlMC1myYp0MXIqoy02NafH8IdLxNiu6mJNI18DVCEHO jBNMV7o2L24dMXfW3qXjaWpP8Gh49u0= X-MC-Unique: zhe__F8EP_u0QQ15lGpyyQ-1 From: John Snow To: qemu-devel@nongnu.org Cc: Warner Losh , Beraldo Leal , John Snow , Kyle Evans , Paolo Bonzini , Thomas Huth , Daniel Berrange , Reinoud Zandijk , Wainer dos Santos Moschetta , Cleber Rosa , Ryo ONODERA , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Ani Sinha , "Michael S. Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH v3 19/20] configure: use --diagnose option with meson ensure Date: Mon, 24 Apr 2023 16:02:47 -0400 Message-Id: <20230424200248.1183394-20-jsnow@redhat.com> In-Reply-To: <20230424200248.1183394-1-jsnow@redhat.com> References: <20230424200248.1183394-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.171, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1682366660686100001 Content-Type: text/plain; charset="utf-8" Rely on the diagnosis information from mkvenv so it can be removed from the configure script. Signed-off-by: John Snow --- configure | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/configure b/configure index ae55de1408..0881fffc14 100755 --- a/configure +++ b/configure @@ -1096,8 +1096,6 @@ fi =20 # Resolve PATH python=3D"$(command -v "$python")" -# This variable is intended to be used only for error messages: -target_python=3D$python =20 # Create a Python virtual environment using our configured python. # The stdout of this script will be the location of a symlink that @@ -1134,16 +1132,9 @@ fi if ! $python "${source_path}/python/scripts/mkvenv.py" ensure \ $mkvenv_flags \ --dir "${source_path}/python/wheels" \ + --diagnose "meson" \ "meson>=3D0.61.5" ; then - # We're very out of luck. Try to give a good diagnostic. - if test -e pyvenv/bin/meson; then - echo "Meson is too old: $(pyvenv/bin/meson --version)" - elif has meson ; then - echo "Meson was found installed on your system," \ - "but not for the configured Python interpreter ($target_pytho= n)." - echo "(Hint: check '$(which meson)' to see which interpreter its s= hebang uses.)" - fi exit 1 fi =20 --=20 2.39.2