From nobody Tue Feb 10 17:03:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=126.com ARC-Seal: i=1; a=rsa-sha256; t=1682333694; cv=none; d=zohomail.com; s=zohoarc; b=jk++dh51uQtz8BYGDu5rkqDOEcam2foPDAzswVI6tPrQPEZzLhrETJAREcuZ0tamPeXC2eKB89z1NKvfc9q8YeuE+owBoc8kwKlefQ9I70OHgkVBRCM1SlXKFksOigosJLERWXetYi8vwRl8YO2n6Fa+9iwOY33mN4F8qkWH5QM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682333694; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=fqESsEnKzYjAhZ67VSGkaT6Ox9XNCkYYHLmrxEgBcIw=; b=HNmD1pmGRKEnOF6Nbos5+3E1gt4GgAEsvI4HytYt+/SqLNElMU/NauxBLB4WrIfqgfDlLRCoUyuIlA7r3iFiS1IekiDiQvLs0oladApm3fnJXqxxYXZEi15HPuR20TSkkhUBOfCP3wBAutQRYzYspDfxUNUG4W6x0BhPckR4XRA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682333694953896.7532634060921; Mon, 24 Apr 2023 03:54:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqtqC-0003iX-VC; Mon, 24 Apr 2023 06:54:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqtqA-0003bb-MT; Mon, 24 Apr 2023 06:54:38 -0400 Received: from m126.mail.126.com ([220.181.12.37]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqtq7-0006t3-EA; Mon, 24 Apr 2023 06:54:38 -0400 Received: from localhost.localdomain (unknown [171.15.162.83]) by zwqz-smtp-mta-g4-1 (Coremail) with SMTP id _____wA3HGhOXEZkHU0AAA--.656S4; Mon, 24 Apr 2023 18:39:11 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=fqESs EnKzYjAhZ67VSGkaT6Ox9XNCkYYHLmrxEgBcIw=; b=XOKR3jrOVr2eHSw+YIEPB PZrPnG/Nz+fXpNYcsir8WT61KrPGPne/NPIWW6YfYBLvK48vqF1jR0etUejjKNA9 8blae85ep51wJtr2p7RQGHSTOQSVOvxxrCMOpjGbzUfXzFKues8/Igl9gC+moXnV OkBg2s6fejfdhmA67/jHlA= From: wangliangzz@126.com To: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-stable@nongnu.org, wangliangzz@126.com Cc: kwolf@redhat.com, hreitz@redhat.com, eesposit@redhat.com, Wang Liang Subject: [PATCH v2] block/monitor/block-hmp-cmds.c: Fix crash when execute hmp_commit Date: Mon, 24 Apr 2023 18:39:02 +0800 Message-Id: <20230424103902.45265-1-wangliangzz@126.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wA3HGhOXEZkHU0AAA--.656S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7tFyxZFWDXw1kWrW3Wr1kuFg_yoW8GrW7pF s7Gr9a9rZYya4S9a1vy3WIqF1rWws5ZF48uwn2vws5urWfJwnFyr4jyr1jva45XryxJFZF 9r10gFy2yF90krJanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UYfO7UUUUU= X-Originating-IP: [171.15.162.83] X-CM-SenderInfo: pzdqwzpldqw6b26rjloofrz/1tbiuQ9b1lpEAaFjTgAAso Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=220.181.12.37; envelope-from=wangliangzz@126.com; helo=m126.mail.126.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @126.com) X-ZM-MESSAGEID: 1682333695850100001 Content-Type: text/plain; charset="utf-8" From: Wang Liang hmp_commit() calls blk_is_available() from a non-coroutine context (and in the main loop). blk_is_available() is a co_wrapper_mixed_bdrv_rdlock function, and in the non-coroutine context it calls AIO_WAIT_WHILE(), which crashes if the aio_context lock is not taken before. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1615 Signed-off-by: Wang Liang Reviewed-by: Emanuele Giuseppe Esposito --- block/monitor/block-hmp-cmds.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c index 2846083546..ca2599de44 100644 --- a/block/monitor/block-hmp-cmds.c +++ b/block/monitor/block-hmp-cmds.c @@ -214,15 +214,17 @@ void hmp_commit(Monitor *mon, const QDict *qdict) error_report("Device '%s' not found", device); return; } - if (!blk_is_available(blk)) { - error_report("Device '%s' has no medium", device); - return; - } =20 bs =3D bdrv_skip_implicit_filters(blk_bs(blk)); aio_context =3D bdrv_get_aio_context(bs); aio_context_acquire(aio_context); =20 + if (!blk_is_available(blk)) { + error_report("Device '%s' has no medium", device); + aio_context_release(aio_context); + return; + } + ret =3D bdrv_commit(bs); =20 aio_context_release(aio_context); --=20 2.27.0