From nobody Wed Feb 11 02:57:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=126.com ARC-Seal: i=1; a=rsa-sha256; t=1682248868; cv=none; d=zohomail.com; s=zohoarc; b=a9Mvca8zfkXRZBK2EL2bJPoDMxyVIzDKWKwKfDDLo6a2L0xtKA7/cIDD6Ti+FNWv40xaRw4dm+1vnTuZIjlJ2Wi0OHP622wxJ9U3UTFtApU4MH+YUqkH6kEDZ3gHLgXIoLj699/h72h6vRiJwEPqJlhc1mfWrN2kHeDZy/SqtAI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682248868; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ebl07GebzCOVDDhGD98t3Ddps69egG12kzEc6uWERm4=; b=ly6diPQVX4b6czP2JwBRvtHJisW/vlGa6j24w3ZaeDaLIvOEUz/vJqNooTppYa+Xx8XS2q7qq588wZS4yJ3M6wRXGNkHZukYVBaISyboLH1617bKvLguRWPN01SKZSpHdp6KEW8IrNB9uy8PH3mmwPNKIfo17v1zZcId6zurfPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682248868845580.4988279798445; Sun, 23 Apr 2023 04:21:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqXlA-0006rX-Ku; Sun, 23 Apr 2023 07:20:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqXl8-0006rG-4e; Sun, 23 Apr 2023 07:19:58 -0400 Received: from m126.mail.126.com ([220.181.12.36]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqXl4-0001TI-A2; Sun, 23 Apr 2023 07:19:57 -0400 Received: from localhost.localdomain (unknown [171.15.162.83]) by zwqz-smtp-mta-g1-1 (Coremail) with SMTP id _____wA3DbBmEEVknegnBg--.6289S4; Sun, 23 Apr 2023 19:03:03 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=ebl07 GebzCOVDDhGD98t3Ddps69egG12kzEc6uWERm4=; b=GW7qsoNL7G/qJofc4kZtn bOdoLX3SIGP/X4oacsowWipvNlod05qGjUVt4q7VPqljycwtSc2WET4h0xdQsE33 lYA9EUHvL8rBEgcTrxoVx2Gqm6M7o9TKy8P+6eQdYpG4a/gSe+k4kOJ1IXI7iBWQ mEyP+nufJ69Lom+W00kCLQ= From: wangliangzz@126.com To: qemu-devel@nongnu.org, qemu-block@nongnu.org, wangliangzz@126.com Cc: kwolf@redhat.com, hreitz@redhat.com, eesposit@redhat.com, Wang Liang Subject: [PATCH] block/monitor/block-hmp-cmds.c: Fix crash when execute hmp_commit Date: Sun, 23 Apr 2023 19:02:54 +0800 Message-Id: <20230423110254.35672-1-wangliangzz@126.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wA3DbBmEEVknegnBg--.6289S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7JF1rCryUKr1DZF1DAr1fJFb_yoWkCFb_Ga 18XFZ3X39FvFWSkrsFyFn8ArWrt3y3Cr4ftFs8Ka93WFW8t3Z7Krn7JrnIvFy5XF4Uuas3 Jr4kZF1DZwnrujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUgdb5UUUUU== X-Originating-IP: [171.15.162.83] X-CM-SenderInfo: pzdqwzpldqw6b26rjloofrz/1tbiJBpa1lpEHeikggABs+ Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=220.181.12.36; envelope-from=wangliangzz@126.com; helo=m126.mail.126.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @126.com) X-ZM-MESSAGEID: 1682248870771100001 Content-Type: text/plain; charset="utf-8" From: Wang Liang We need to get the aio_context before calling the blk_is_available. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1615 Signed-off-by: Wang Liang Reviewed-by: Emanuele Giuseppe Esposito --- block/monitor/block-hmp-cmds.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c index 2846083546..ca2599de44 100644 --- a/block/monitor/block-hmp-cmds.c +++ b/block/monitor/block-hmp-cmds.c @@ -214,15 +214,17 @@ void hmp_commit(Monitor *mon, const QDict *qdict) error_report("Device '%s' not found", device); return; } - if (!blk_is_available(blk)) { - error_report("Device '%s' has no medium", device); - return; - } =20 bs =3D bdrv_skip_implicit_filters(blk_bs(blk)); aio_context =3D bdrv_get_aio_context(bs); aio_context_acquire(aio_context); =20 + if (!blk_is_available(blk)) { + error_report("Device '%s' has no medium", device); + aio_context_release(aio_context); + return; + } + ret =3D bdrv_commit(bs); =20 aio_context_release(aio_context); --=20 2.27.0