From nobody Tue Feb 10 19:50:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1681969755; cv=none; d=zohomail.com; s=zohoarc; b=lntUeO9VsHEGgwtROhMiHSguUUH4ixvTvzIPZeG/gJYhhyaZpEBiiBh3TrLq6PiA/TkJoFmpreTt1sqYAN6N74gbCkRb27EIYZvOjZl/3oCWhaPOpwaeHHS8usz2yFGFr37L1+0Qs56b1ZEz0xWRobW+sw/NJJm08fj7NXSnbQw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681969755; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=LNbtNm08oFX/Kr+hWh5WddPg3P8O9fRwIo9uMNbOz2E=; b=JWNXQSyLOgZQmXCDPKjdyxaRx0MmzaZ5ykCpY6QIVxaqOTQVCEif7jseXPFaRiooUZeB7isjDDLjqUFPQs3QAITlx2HbR7zdOKUOb7IiE4N/MmwU3n+3TMXCRUWpKDWr6mDZrOQqFMgt7MQXia8SogRvZ3hili9rIIF2MUV0+O8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681969755942419.8958176357029; Wed, 19 Apr 2023 22:49:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppNA0-0007pQ-Mp; Thu, 20 Apr 2023 01:48:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppN9y-0007mk-NO for qemu-devel@nongnu.org; Thu, 20 Apr 2023 01:48:46 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppN9x-0001KG-50 for qemu-devel@nongnu.org; Thu, 20 Apr 2023 01:48:46 -0400 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-247122e9845so402356a91.0 for ; Wed, 19 Apr 2023 22:48:44 -0700 (PDT) Received: from alarm.flets-east.jp ([2400:4050:a840:1e00:4457:c267:5e09:481b]) by smtp.gmail.com with ESMTPSA id x15-20020a17090a46cf00b00247164c1947sm2769255pjg.0.2023.04.19.22.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 22:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1681969724; x=1684561724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LNbtNm08oFX/Kr+hWh5WddPg3P8O9fRwIo9uMNbOz2E=; b=0ZZwrk/5N+cSCjmrvdsQqZvihfwcImyW5ITjCEXwx70Axn2jITox43ZUOy8F1kDKMp 79DuctehS3PbshlZ0gJeJX5KswoNCbWuWIx5i2IRrAKhBSrMs5ry8aPkJEEVVtIpLLPG QzGGHfrtq/g4Iew6NZJOAaQfC+8tcTkycZ7HPEaq7lBOO350B3JjOZTWGOTU8D0ee7Jx cvnQQZc/pRDmP7jR/QLSbCp0/NlYTA+vt5sidm3CbsoYw4/B3cXITDRkcXWb+ww56aVl tap++Yw27FlvaCzH5ariPi5nkzF8vPBVchcC0TxRUDRCk3IGxoWrPHW9ZerskoHDuuoY byyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681969724; x=1684561724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LNbtNm08oFX/Kr+hWh5WddPg3P8O9fRwIo9uMNbOz2E=; b=Asildha9v4JE48DTc/lbfS9KbKgSaW5apu6KqF42C+yPQoza4Dtl0oFan7K4vdgbNm wK4oeqq2hdZQ/SiQkqqWL8Mtb4Y5c4XJePoqhEfKT2SSkpj4PyMJPIQ4Yax1UlyOoWl7 1fkpGWxbuNaVMKnXz/Qd2gZ40jeX5Ef5aYuv8xwgAk7+T19EbZIggPRiVHzs1i8j8LFR o0IIkDJiaEBU6x3CxMRIC+xJug0HhePw70BZCoy4RTILzp2Tq6lF2+Kz3OZTqe/NZIsA 3z6+17twZyvsh/E24XI0sCFcwyOCUziU843vmpxZstjjwvoCp7kNpvX3HYn58YDxAQ1f /RyA== X-Gm-Message-State: AAQBX9fLOvA5VRJW0BNETTeKKVcJ7GezxelCmG3rIkoXdaDmSrK87mpj U/FYKAn2Inn0c2bKpXjbgsE6gA== X-Google-Smtp-Source: AKy350Y9aZoyaS4EJwTEUBI+UJ/1MYxc7dyGL2TZwB6McT1BJW5bhvsomnUzIiUoUbJ5aJPRsQOnpg== X-Received: by 2002:a17:90a:72c5:b0:23f:e4b7:afb3 with SMTP id l5-20020a17090a72c500b0023fe4b7afb3mr611621pjk.9.1681969723859; Wed, 19 Apr 2023 22:48:43 -0700 (PDT) From: Akihiko Odaki To: Cc: Sriram Yagnaraman , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal , Cleber Rosa , Laurent Vivier , Paolo Bonzini , qemu-devel@nongnu.org, Tomasz Dzieciol , Akihiko Odaki Subject: [PATCH v2 19/41] igb: Remove goto Date: Thu, 20 Apr 2023 14:46:35 +0900 Message-Id: <20230420054657.50367-20-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230420054657.50367-1-akihiko.odaki@daynix.com> References: <20230420054657.50367-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::1034; envelope-from=akihiko.odaki@daynix.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1681969757743100012 Content-Type: text/plain; charset="utf-8" The goto is a bit confusing as it changes the control flow only if L4 protocol is not recognized. It is also different from e1000e, and noisy when comparing e1000e and igb. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index dabf1a91d8..d966aa6bfa 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1297,7 +1297,7 @@ igb_build_rx_metadata(IGBCore *core, break; =20 default: - goto func_exit; + break; } } else { trace_e1000e_rx_metadata_l4_cso_disabled(); --=20 2.40.0