From nobody Tue Feb 10 04:29:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681824722; cv=none; d=zohomail.com; s=zohoarc; b=NfK+h4R6sJ1BxSnmtvYb6SeWgxiZxpopjhxYjuK5SLEqx4zwswHzkSjB1w4q3VOCO5C93Fez/KbpIW5U4Kf7wuTGmMZ9fLbOSFJZ59RPCpyW+rCBmTnLLlnUlGIv+m4FbZPoZclW3Z6SUumk7WcELVIOanDOZYGSh46uF1ifFro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681824722; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=F7dQAKpk96paTPu8mAEJxP+k6HXblvCSN8kQtAOwZ6s=; b=nyeU1zF1jL1Hf1dZtReMMOIty4SjV5vlytjYRHwdpW91yCTaWY7NVjEx9N4K85Z056BwMDKSfnDK6kiDVrlTeRM5fz0XSxZC/r+CU2QuwMcbmDHAbl183lOhIjv5xfUsAkaeDAearBWxYRqFKPz39AbOrD+QV0YhLk3XLO+YdEE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681824722843531.5794293463417; Tue, 18 Apr 2023 06:32:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1polQe-0004Tv-Dh; Tue, 18 Apr 2023 09:31:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1polQM-0004PN-AE for qemu-devel@nongnu.org; Tue, 18 Apr 2023 09:31:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1polQK-0000uV-PA for qemu-devel@nongnu.org; Tue, 18 Apr 2023 09:31:10 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-v7ijYICRNvSQ7NtBDclpJg-1; Tue, 18 Apr 2023 09:31:04 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E1FA3185A7A4 for ; Tue, 18 Apr 2023 13:31:03 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1691B40C6E6F; Tue, 18 Apr 2023 13:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681824668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F7dQAKpk96paTPu8mAEJxP+k6HXblvCSN8kQtAOwZ6s=; b=SZ1p+BTwRTIXhU7FKWJgMljqrjlUrqRgsy5y4dYDV4gQdn/6XqghIvJSaWWOcMHjKRQuPW 0ar+ZLpZuoAzJwewG7zsnTELC45jcbBGVtj80Se2dxT1Gy6+PeeC5FWfSgKHj5ZZSf7ls6 pi7ojVRs4tN1K3KhsTb2p2QbcMPWdjc= X-MC-Unique: v7ijYICRNvSQ7NtBDclpJg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Juan Quintela , Thomas Huth , Paolo Bonzini , Laurent Vivier , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 1/2] tests/qtest: capture RESUME events during migration Date: Tue, 18 Apr 2023 14:30:59 +0100 Message-Id: <20230418133100.48799-2-berrange@redhat.com> In-Reply-To: <20230418133100.48799-1-berrange@redhat.com> References: <20230418133100.48799-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681824723432100001 When running migration tests we monitor for a STOP event so we can skip redundant waits. This will be needed for the RESUME event too shortly. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Juan Quintela --- tests/qtest/migration-helpers.c | 12 +++++++++--- tests/qtest/migration-helpers.h | 1 + 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helper= s.c index f6f3c6680f..61396335cc 100644 --- a/tests/qtest/migration-helpers.c +++ b/tests/qtest/migration-helpers.c @@ -24,14 +24,20 @@ #define MIGRATION_STATUS_WAIT_TIMEOUT 120 =20 bool got_stop; +bool got_resume; =20 -static void check_stop_event(QTestState *who) +static void check_events(QTestState *who) { QDict *event =3D qtest_qmp_event_ref(who, "STOP"); if (event) { got_stop =3D true; qobject_unref(event); } + event =3D qtest_qmp_event_ref(who, "RESUME"); + if (event) { + got_resume =3D true; + qobject_unref(event); + } } =20 #ifndef _WIN32 @@ -48,7 +54,7 @@ QDict *wait_command_fd(QTestState *who, int fd, const cha= r *command, ...) va_end(ap); =20 resp =3D qtest_qmp_receive(who); - check_stop_event(who); + check_events(who); =20 g_assert(!qdict_haskey(resp, "error")); g_assert(qdict_haskey(resp, "return")); @@ -73,7 +79,7 @@ QDict *wait_command(QTestState *who, const char *command,= ...) resp =3D qtest_vqmp(who, command, ap); va_end(ap); =20 - check_stop_event(who); + check_events(who); =20 g_assert(!qdict_haskey(resp, "error")); g_assert(qdict_haskey(resp, "return")); diff --git a/tests/qtest/migration-helpers.h b/tests/qtest/migration-helper= s.h index a188b62787..726a66cfc1 100644 --- a/tests/qtest/migration-helpers.h +++ b/tests/qtest/migration-helpers.h @@ -16,6 +16,7 @@ #include "libqtest.h" =20 extern bool got_stop; +extern bool got_resume; =20 #ifndef _WIN32 G_GNUC_PRINTF(3, 4) --=20 2.40.0 From nobody Tue Feb 10 04:29:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681824718; cv=none; d=zohomail.com; s=zohoarc; b=giuId/6BilSqOdGNiwzCo57mM+3safBr6d/YO/t9JISkkKBKJXXwFeCy84sydrpOF7H25fipmziWray0A1zaqZroDvMMFLDdoLyQTG3lOtdignWampS/DFPq3OX8fI3L01xeTkOBBiLTd5hi0JoMORZOVDI9MVqiyJ54oY8CMmU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681824718; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oILfNF6JpbWDS/bd7J5ZggBnMQShfldM7P82jsiPaRg=; b=VwbOf2YcuSec2AZYew8MPf6ijj+UdiWKZ/+J3NNgJEASLQ6CVvhc4Nr+Fc/L6NTq/Z3R2HiV9jYpu+Af6Jf134aIjZziIYRL92c0SpvbLvDGgoIbVi/GKhOYxp4l16wf2UjAfzqAb26rQbB8Kd0v3b7oz8Gi04lf1/2uHYL5JVI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 168182471804929.702281640887804; Tue, 18 Apr 2023 06:31:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1polQV-0004Tb-Q3; Tue, 18 Apr 2023 09:31:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1polQM-0004PO-Ea for qemu-devel@nongnu.org; Tue, 18 Apr 2023 09:31:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1polQK-0000uH-Rg for qemu-devel@nongnu.org; Tue, 18 Apr 2023 09:31:10 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-6iPLCKYpMxG2TEmmRbFpVg-1; Tue, 18 Apr 2023 09:31:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DA9A8385054E for ; Tue, 18 Apr 2023 13:31:04 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1ED8E40C6E21; Tue, 18 Apr 2023 13:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681824666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oILfNF6JpbWDS/bd7J5ZggBnMQShfldM7P82jsiPaRg=; b=W00lJ+NSxVtrkPnWyqWnx+5meNW9mWLci0SHruzOZyTZvtg+D0X+/acdgfJX4jqGheFKWh //8c2VC2Sli/XTIwYrGmaEJMgAuoBLBt6q2D8UP0J36INcsjv/JGTGwo5SpYFnqVNNnGte 09Nm0nC3/4eTKj/MRauvRuZ85RuAjOQ= X-MC-Unique: 6iPLCKYpMxG2TEmmRbFpVg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Juan Quintela , Thomas Huth , Paolo Bonzini , Laurent Vivier , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 2/2] tests/qtest: make more migration pre-copy scenarios run non-live Date: Tue, 18 Apr 2023 14:31:00 +0100 Message-Id: <20230418133100.48799-3-berrange@redhat.com> In-Reply-To: <20230418133100.48799-1-berrange@redhat.com> References: <20230418133100.48799-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681824720062100001 There are 27 pre-copy live migration scenarios being tested. In all of these we force non-convergance and run for one iteration, then let it converge and wait for completion during the second (or following) iterations. At 3 mbps bandwidth limit the first iteration takes a very long time (~30 seconds). While it is important to test the migration passes and convergance logic, it is overkill to do this for all 27 pre-copy scenarios. The TLS migration scenarios in particular are merely exercising different code paths during connection establishment. To optimize time taken, switch most of the test scenarios to run non-live (ie guest CPUs paused) with no bandwidth limits. This gives a massive speed up for most of the test scenarios. For test coverage the following scenarios are unchanged * Precopy with UNIX sockets * Precopy with UNIX sockets and dirty ring tracking * Precopy with XBZRLE * Precopy with multifd Signed-off-by: Daniel P. Berrang=C3=A9 --- tests/qtest/migration-test.c | 34 +++++++++++++++++++++++++++------- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 3b615b0da9..cdc9635f0b 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -574,6 +574,9 @@ typedef struct { /* Optional: set number of migration passes to wait for */ unsigned int iterations; =20 + /* Whether the guest CPUs should be running during migration */ + bool live; + /* Postcopy specific fields */ void *postcopy_data; bool postcopy_preempt; @@ -1329,7 +1332,11 @@ static void test_precopy_common(MigrateCommon *args) return; } =20 - migrate_ensure_non_converge(from); + if (args->live) { + migrate_ensure_non_converge(from); + } else { + migrate_ensure_converge(from); + } =20 if (args->start_hook) { data_hook =3D args->start_hook(from, to); @@ -1357,16 +1364,20 @@ static void test_precopy_common(MigrateCommon *args) qtest_set_expected_status(to, EXIT_FAILURE); } } else { - if (args->iterations) { - while (args->iterations--) { + if (args->live) { + if (args->iterations) { + while (args->iterations--) { + wait_for_migration_pass(from); + } + } else { wait_for_migration_pass(from); } + + migrate_ensure_converge(from); } else { - wait_for_migration_pass(from); + qtest_qmp_discard_response(from, "{ 'execute' : 'stop'}"); } =20 - migrate_ensure_converge(from); - /* We do this first, as it has a timeout to stop us * hanging forever if migration didn't converge */ wait_for_migration_complete(from); @@ -1375,7 +1386,12 @@ static void test_precopy_common(MigrateCommon *args) qtest_qmp_eventwait(from, "STOP"); } =20 - qtest_qmp_eventwait(to, "RESUME"); + if (!args->live) { + qtest_qmp_discard_response(to, "{ 'execute' : 'cont'}"); + } + if (!got_resume) { + qtest_qmp_eventwait(to, "RESUME"); + } =20 wait_for_serial("dest_serial"); } @@ -1393,6 +1409,7 @@ static void test_precopy_unix_plain(void) MigrateCommon args =3D { .listen_uri =3D uri, .connect_uri =3D uri, + .live =3D true, }; =20 test_precopy_common(&args); @@ -1408,6 +1425,7 @@ static void test_precopy_unix_dirty_ring(void) }, .listen_uri =3D uri, .connect_uri =3D uri, + .live =3D true, }; =20 test_precopy_common(&args); @@ -1519,6 +1537,7 @@ static void test_precopy_unix_xbzrle(void) .start_hook =3D test_migrate_xbzrle_start, =20 .iterations =3D 2, + .live =3D true, }; =20 test_precopy_common(&args); @@ -1919,6 +1938,7 @@ static void test_multifd_tcp_none(void) MigrateCommon args =3D { .listen_uri =3D "defer", .start_hook =3D test_migrate_precopy_tcp_multifd_start, + .live =3D true, }; test_precopy_common(&args); } --=20 2.40.0