From nobody Tue Feb 10 03:45:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681484383; cv=none; d=zohomail.com; s=zohoarc; b=l2DtWUCO8MWT+qdo3D1zfu9EaqUbUEI6yrD4dWSk0YnEdn9Z5jlJ5n5SfZWayrhwHc1bJg3vO2974i5FA7gfFcVv9bfC9Q3kjt5Z0LzFVf+iw2iQBvDqH6lIeoVoONnd6vT0POrqLIx0sVPDSxQYt9G9qu33D1FYgqPB4X/yFbw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681484383; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uvxfEszOFYq/ycMg/QUYJNRfK1mwdC48h3QWrbvLx84=; b=APnG3kCrtSgDZbccvdrbin3ZSEuZyy95PzZp27/55sNepmnBowb7LyvXRJG/uRRd4XGPRW9NZT4eIFrtritRh947L3yldDNetm19A9ZJtI6pXklYa+jVltc81HPGsx45i4MbmdQBulM2BIyOfQUwVLVt3yGzhf6J71K3yEevJBg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681484383863378.7476645593963; Fri, 14 Apr 2023 07:59:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnKtA-0005wi-IP; Fri, 14 Apr 2023 10:59:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnKt9-0005wA-6n for qemu-devel@nongnu.org; Fri, 14 Apr 2023 10:58:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnKt7-0001iw-QS for qemu-devel@nongnu.org; Fri, 14 Apr 2023 10:58:58 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-Z55BplX0M_-4TuQVBDk69g-1; Fri, 14 Apr 2023 10:58:51 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B9D4B8996E0; Fri, 14 Apr 2023 14:58:50 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C1F3BC88; Fri, 14 Apr 2023 14:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681484336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvxfEszOFYq/ycMg/QUYJNRfK1mwdC48h3QWrbvLx84=; b=B4UWvXEnnt71iIhdf6l2sv0ZZKWllvhAg0fJwmTaP1c+jb0OUtZUajaXdnn5fr8OZsjxI0 eF2LopPhWq/XScWfV3PKNlMoW5Y0KWdTtm4SXtf/tojxexfD4jqt0EudKlXDIfDxZINU08 wMfP5vEIZM9Nj30nAG62M91Ltvb16qc= X-MC-Unique: Z55BplX0M_-4TuQVBDk69g-1 From: Thomas Huth To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Eldon Stegall , Camilla Conte Subject: [PATCH 1/2] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs Date: Fri, 14 Apr 2023 16:58:44 +0200 Message-Id: <20230414145845.456145-2-thuth@redhat.com> In-Reply-To: <20230414145845.456145-1-thuth@redhat.com> References: <20230414145845.456145-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681484384411100001 Content-Type: text/plain; charset="utf-8" After "make check-venv" had been added to these jobs, they started to re-run "configure" each time since our logic in the makefile thinks that some files are out of date here. Avoid it with the same trick that we are using in buildtest-template.yml already by disabling the up-to-date check via NINJA=3D":". Fixes: 1d8cf47e5b ("tests: run 'device-crash-test' from tests/venv") Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index ba6f551752..333eea9dd3 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -102,7 +102,7 @@ crash-test-debian: IMAGE: debian-amd64 script: - cd build - - make check-venv + - make NINJA=3D":" check-venv - tests/venv/bin/python3 scripts/device-crash-test -q ./qemu-system-i3= 86 =20 build-system-fedora: @@ -145,7 +145,7 @@ crash-test-fedora: IMAGE: fedora script: - cd build - - make check-venv + - make NINJA=3D":" check-venv - tests/venv/bin/python3 scripts/device-crash-test -q ./qemu-system-ppc - tests/venv/bin/python3 scripts/device-crash-test -q ./qemu-system-ri= scv32 =20 --=20 2.31.1 From nobody Tue Feb 10 03:45:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681484370; cv=none; d=zohomail.com; s=zohoarc; b=l9pWg6oE94BMsuRRJCxlsXp48HHCNdohuL6RCniKNE34f+YlSJw2p+YZE3/c+Z8W+v5O/IcZPKzMcxN3sgnOhNoYKDQNFJ0EwmTQBQnaepyKpyiPx5DH8YdAKURnG6BTn1mGUvPcPhJ8UNMnOhKW/hNnyt8NsQwjNghQ3Xq7J+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681484370; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=grTVzAluaVkwrO7QXvyzHZ/daRWWGLEpkQVnIpo6k94=; b=PJ3Gszj6mhNKbxPSh/33vRBMlqedODOsGVR1nu7dgNzwbnkeDqQTK5E4CC7VLSfBaXIHXwNeimF9cNp+G4dTbzgWCiYmG7vp6usyjxUIS8+QwJXKYF3hDwhO6IMY7oey+e1+f0/waeFCL5CvnKZLup+vOTIyyXevI+xVYt21Id4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681484370780696.6122465819083; Fri, 14 Apr 2023 07:59:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnKt8-0005v9-Sh; Fri, 14 Apr 2023 10:58:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnKt6-0005u7-HU for qemu-devel@nongnu.org; Fri, 14 Apr 2023 10:58:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnKt5-0001iZ-4n for qemu-devel@nongnu.org; Fri, 14 Apr 2023 10:58:56 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-547-47D6MkmIPPi-D-ylQ5WQYQ-1; Fri, 14 Apr 2023 10:58:52 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5903280C8C8; Fri, 14 Apr 2023 14:58:52 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FEE0BC88; Fri, 14 Apr 2023 14:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681484334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=grTVzAluaVkwrO7QXvyzHZ/daRWWGLEpkQVnIpo6k94=; b=W+pPuIumqE7GMf13YvFl1qzEUQyAIf3Ielmslib9qm816sTUrEFE4/gIuRi0L2fkkkWQj+ XETt2L/os4+Z/6Mwe/VLAlCWYp4AzqytHNNjyLKsVPuM7ASVtvRkGuYJTVu+kt4aKw/tT9 mE8aOH7qTVfJP+tkt8XcPNZiofAp7NA= X-MC-Unique: 47D6MkmIPPi-D-ylQ5WQYQ-1 From: Thomas Huth To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Eldon Stegall , Camilla Conte Subject: [PATCH 2/2] scripts/device-crash-test: Add a parameter to run with TCG only Date: Fri, 14 Apr 2023 16:58:45 +0200 Message-Id: <20230414145845.456145-3-thuth@redhat.com> In-Reply-To: <20230414145845.456145-1-thuth@redhat.com> References: <20230414145845.456145-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681484371804100001 Content-Type: text/plain; charset="utf-8" We're currently facing the problem that the device-crash-test script runs twice as long in the CI when a runner supports KVM - which sometimes results in a timeout of the CI job. To get a more deterministic runtime here, add an option to the script that allows to run it with TCG only. Reported-by: Eldon Stegall Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml | 2 +- scripts/device-crash-test | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 333eea9dd3..bb3650a51c 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -103,7 +103,7 @@ crash-test-debian: script: - cd build - make NINJA=3D":" check-venv - - tests/venv/bin/python3 scripts/device-crash-test -q ./qemu-system-i3= 86 + - tests/venv/bin/python3 scripts/device-crash-test -q --tcg-only ./qem= u-system-i386 =20 build-system-fedora: extends: diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 73bcb98693..b74d887331 100755 --- a/scripts/device-crash-test +++ b/scripts/device-crash-test @@ -397,7 +397,7 @@ def binariesToTest(args, testcase): =20 =20 def accelsToTest(args, testcase): - if getBinaryInfo(args, testcase['binary']).kvm_available: + if getBinaryInfo(args, testcase['binary']).kvm_available and not args.= tcg_only: yield 'kvm' yield 'tcg' =20 @@ -510,6 +510,8 @@ def main(): help=3D"Full mode: test cases that are expected to= fail") parser.add_argument('--strict', action=3D'store_true', dest=3D'strict', help=3D"Treat all warnings as fatal") + parser.add_argument('--tcg-only', action=3D'store_true', dest=3D'tcg_o= nly', + help=3D"Only test with TCG accelerator") parser.add_argument('qemu', nargs=3D'*', metavar=3D'QEMU', help=3D'QEMU binary to run') args =3D parser.parse_args() --=20 2.31.1