From nobody Tue Feb 10 02:01:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1681140939; cv=none; d=zohomail.com; s=zohoarc; b=Rj44yAvw8opM5wj9Sk9K+dD6c6Jb0kCMLdQ8NPRh1irUJuRijZiuKbsoJWchEN0nIxIpjJTKZHIj2EpZhIaZrB/4qdElL31yiW6/cUVsTEOLzmA+rPhgwHdY8p0YtYPMfybTm93TaYCGw/uLw72khOiAsqSuiM7EhHYDsdX5c+g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681140939; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rcNEhGFLchqZMB3huLw45XXaPWISEFJfrSvpuPV2BPc=; b=idGvw4JA2VfxU0qhFUBW1bRAmGj1q682+AhQGP1ryCsBZheVa1OQlvsmK6ZfOvMeLhBXbxgZzSc8lUIHG9aglXuFfO3KZ0makgbXTZK6asGuWtFokvjiyhOhnaC7PAflbXbtN/fxuAdaZdr9ZIhTPkOF1fq7ygKVt06Xb8MKdVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681140938798687.8549547446504; Mon, 10 Apr 2023 08:35:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pltXl-0000bW-K8; Mon, 10 Apr 2023 11:34:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pltXi-0000UX-Gr for qemu-devel@nongnu.org; Mon, 10 Apr 2023 11:34:54 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pltXg-0000nP-5i for qemu-devel@nongnu.org; Mon, 10 Apr 2023 11:34:54 -0400 Received: by mail-pl1-x62a.google.com with SMTP id ke16so4885857plb.6 for ; Mon, 10 Apr 2023 08:34:51 -0700 (PDT) Received: from stoup.. ([2602:ae:1541:f901:2e6b:e4d3:9526:71d6]) by smtp.gmail.com with ESMTPSA id jj6-20020a170903048600b001a64e854553sm534402plb.159.2023.04.10.08.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 08:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681140890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rcNEhGFLchqZMB3huLw45XXaPWISEFJfrSvpuPV2BPc=; b=AyjpoMXiXPIjRc41wrEmqxI6orJkcCMvzAJEB3j5RxJw1PpqKF5YCb86SHu8dZBsIA mDwPbmSt14OJ7CdRb3AXyyuRRA0m1Q6BRonkP3QS6M6MljZ+IogZu70PDhXgMOjcgTZp +sP+WSBUACNkHx3+XDFi02UOBdJzQsw7fxNOKXNcvFdc7HRE1GiZbNYIikb7aLZw/PuZ 8x4KurMCj1uvQ/9Dl3Um5fjO1IwhXtz27bVjU4RoXmwbW4sXOdo7ypoQqslC29MRlv4t hfjLwr9fYJaDrRZUlq2dZbybzHqNt6lm9yy2Ao4orHuEhrDkwpHf+k8gnndIM0ch6oO/ 5ofg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681140890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rcNEhGFLchqZMB3huLw45XXaPWISEFJfrSvpuPV2BPc=; b=GZXBoe7IQselhmGvgk3iH5l8OAupIaIJMSqjokbz+DMPzHPtHOyJX8PFacakjURrXT cGpv0PsgfJfsc5ISRDRifG9+LELUaVoY3zBrnMhN7lIFvWvgyO404L+/X+19rbmBMkK8 Hu+cwyyLlRlOAxC7glGl3PhXCX3iDXke5pX+eD2RjwI/haRQpeCJS0eMoeqPeimT5qWA MwQLxiu8zHac/uCeyc7LmxUCgHYk/P0VpVOen6BG9LOF3Xv7F9qrWsxNgkikGZdgqcmJ 3FhThB2jgYAm79iIrFAcuTVAgQsD9jLEjLnhx+h7YQvHB/fZwm9MFYNLLGev1j2uFcqe fYcw== X-Gm-Message-State: AAQBX9ehr6OBRCrknMARm16c85+2mZc7pS/Yq+kq1P2oeVa0hWV0jA+C Lm46tg2gfr45v23/ngimurXWSIKMzrXW1suPuAQ= X-Google-Smtp-Source: AKy350araymii7Q9LaWEQHlyfWjW3nFs3kRz8uhq1wES1LcKF/06+9o1GTYjDAh8SYmIDENwFgzcBg== X-Received: by 2002:a17:903:4101:b0:1a5:19bc:d70d with SMTP id r1-20020a170903410100b001a519bcd70dmr8196103pld.38.1681140890674; Mon, 10 Apr 2023 08:34:50 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Subject: [PULL 1/3] tcg/i386: Adjust assert in tcg_out_addi_ptr Date: Mon, 10 Apr 2023 08:34:46 -0700 Message-Id: <20230410153448.787498-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230410153448.787498-1-richard.henderson@linaro.org> References: <20230410153448.787498-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1681140940096100001 Content-Type: text/plain; charset="utf-8" We can arrive here on _WIN64 because Int128 is passed by reference. Change the assert to check that the immediate is in range, instead of attempting to check the host ABI. Fixes: 6a6d772e30d ("tcg: Introduce tcg_out_addi_ptr") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1581 Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.c.inc b/tcg/i386/tcg-target.c.inc index 4444eb9234..5a151fe64a 100644 --- a/tcg/i386/tcg-target.c.inc +++ b/tcg/i386/tcg-target.c.inc @@ -1082,7 +1082,7 @@ static void tcg_out_addi_ptr(TCGContext *s, TCGReg rd= , TCGReg rs, tcg_target_long imm) { /* This function is only used for passing structs by reference. */ - tcg_debug_assert(TCG_TARGET_REG_BITS =3D=3D 32); + tcg_debug_assert(imm =3D=3D (int32_t)imm); tcg_out_modrm_offset(s, OPC_LEA, rd, rs, imm); } =20 --=20 2.34.1 From nobody Tue Feb 10 02:01:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1681140922; cv=none; d=zohomail.com; s=zohoarc; b=TZU40XTqTIsH6+0XqA7HcSD7jkPOBFYqPP/Z7ou3FtwLjFofyTenL5T4c7ttsv9dE3ksv5XOl3YXP+vzMYJM+JTpM+Lxr5NTq4EQdi2GSRZkMT04rVwfTUepXa4pAlisXTg9aS/bD6cr/s1fvUpVNVGAogXAJv2mJWD6KDrgT4Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681140922; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lnXUaEENQ1jQIIP6iKAfC6khYvLIRe71lrXEP0Olkj4=; b=VURysapIEtsB4fZhvRqklPqkSWBe0z6wMcPdWEOSABq8a3rjMpRPDUxFUKsrqQNy7reBg1HsBWfLzUqKAemulwoMJ59VU+zfYzlcSA6m6Pt2sROXszmHZwlA+FhuXojp0u5kK0xQJUXZEh+P1D0VL8juZqOc+iqmTtdrQrg2s4c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681140921804941.2592530497211; Mon, 10 Apr 2023 08:35:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pltXl-0000ar-07; Mon, 10 Apr 2023 11:34:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pltXi-0000Vb-Ne for qemu-devel@nongnu.org; Mon, 10 Apr 2023 11:34:54 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pltXh-0000nZ-1V for qemu-devel@nongnu.org; Mon, 10 Apr 2023 11:34:54 -0400 Received: by mail-pj1-x102f.google.com with SMTP id l9-20020a17090a3f0900b0023d32684e7fso12916591pjc.1 for ; Mon, 10 Apr 2023 08:34:52 -0700 (PDT) Received: from stoup.. ([2602:ae:1541:f901:2e6b:e4d3:9526:71d6]) by smtp.gmail.com with ESMTPSA id jj6-20020a170903048600b001a64e854553sm534402plb.159.2023.04.10.08.34.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 08:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681140891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lnXUaEENQ1jQIIP6iKAfC6khYvLIRe71lrXEP0Olkj4=; b=AyC1xutJVN2WpA3l2onnUy33e2QCFeI8zi7cr8YuRhlNn+XLPW55MXXKeg8h6JAljw d70+JEU/bDmY190ajZ3mZywW4yGjw37x12imDgTlrVcra3Nf81VsYVLm72dR5BxmGgnm GP0uoDVFIL5cB7MKOTZVWY8ZFOwwSWVkP0FNioRmgPhblFBb10xY5sS36M3iCJOEDaUz LGBY77WaxF4H+NqEbTnSzBjgx4yRWHde5Kp7h7N/8aNzNDV+b7V5tXy0lN0I7JRAC+EX M6zTTzTd4T25ZrrMsxa582vFy3IYdF2Nwb5Ylt/3NGb4TKVpeC4e7bIVGt99qSBtpyAJ B5Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681140891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lnXUaEENQ1jQIIP6iKAfC6khYvLIRe71lrXEP0Olkj4=; b=ZtZk5Yzcbwa/j3tTmu5FNAblplEwuVCcPWHQR4GigykMV3nh3YXHMGhobutthswbqJ qtlzQQLxN2xSwb+ns0nzR/FCSEAXRJq6Bp8GPJEb5zpS40Kzc1GGSToaQe9EZywubpPh I6ik+N4ZOINBF7HfydmKKZq3W1hHC1/6jIUh6VgGYLEUnUW0SE/B0zAmeyQvvaeONQnt FAsvBKRWf6kiG5TfV7Jd7k87f1Bs5/QptKkhEraQ3WR/hfTF0H6sZnNbElAgyv7vEvt+ elr7ddWaOaQufFmnZFuoycc7Glqrsbkj/Og5Kw5duEr+UMuI2s8QT2NQCI/IXl4sE5Q3 VEZQ== X-Gm-Message-State: AAQBX9epWxOOZSXFLlRw/Qr2yoxLrKk8hZMjDVcTSxf6ibsOjWpwfrd7 aq26lmnVkeZa2WaDRKox8muxwHPM5ifLMoVrTlU= X-Google-Smtp-Source: AKy350YBI+U5SRewm+onur3jMIyy05jdGGaU9jnBvNfrtKPNL7tCbjDiXpzv+umvkC6s4FlJPPyv/A== X-Received: by 2002:a17:903:244d:b0:1a1:aa68:7e61 with SMTP id l13-20020a170903244d00b001a1aa687e61mr15586536pls.33.1681140891508; Mon, 10 Apr 2023 08:34:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Subject: [PULL 2/3] tcg/mips: Fix TCG_TARGET_CALL_RET_I128 for o32 abi Date: Mon, 10 Apr 2023 08:34:47 -0700 Message-Id: <20230410153448.787498-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230410153448.787498-1-richard.henderson@linaro.org> References: <20230410153448.787498-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1681140923069100003 Content-Type: text/plain; charset="utf-8" The return is by reference, not in 4 integer registers. This error resulted in qemu-system-i386: tcg/mips/tcg-target.c.inc:140: \ tcg_target_call_oarg_reg: Assertion `slot >=3D 0 && slot <=3D 1' failed. Fixes: 5427a9a7604 ("tcg: Add TCG_TARGET_CALL_{RET,ARG}_I128") Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h index 68b11e4d48..2431fc5353 100644 --- a/tcg/mips/tcg-target.h +++ b/tcg/mips/tcg-target.h @@ -84,13 +84,14 @@ typedef enum { #if _MIPS_SIM =3D=3D _ABIO32 # define TCG_TARGET_CALL_STACK_OFFSET 16 # define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_EVEN +# define TCG_TARGET_CALL_RET_I128 TCG_CALL_RET_BY_REF #else # define TCG_TARGET_CALL_STACK_OFFSET 0 # define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_NORMAL +# define TCG_TARGET_CALL_RET_I128 TCG_CALL_RET_NORMAL #endif #define TCG_TARGET_CALL_ARG_I32 TCG_CALL_ARG_NORMAL #define TCG_TARGET_CALL_ARG_I128 TCG_CALL_ARG_EVEN -#define TCG_TARGET_CALL_RET_I128 TCG_CALL_RET_NORMAL =20 /* MOVN/MOVZ instructions detection */ #if (defined(__mips_isa_rev) && (__mips_isa_rev >=3D 1)) || \ --=20 2.34.1 From nobody Tue Feb 10 02:01:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1681140950; cv=none; d=zohomail.com; s=zohoarc; b=iX9aFY/4P1toPutwaNdmsoZ4dEOsFvkifHfCDo+mndRosAvM3SDr2kD0uD3VErp/e1C4xTZdhHZAeodYyCD1gvvjViqRC0f6TJTVjpYPeoO18elRrlCFJg2ivrOA1WLETODbZ+0RFI68HbTi3PylDlGC4ju0iLhT1UIwzNUJFoc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681140950; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gBl5GODmqunu8RhMyVnek3iPrET/1omof3j02qUp0Cw=; b=mcfL2SLWDcqZ+AhmjRQe/TVI17r/6jf4bGqymJNXRXGPYHQk26N00V7unkQn/8KOOucwEdHffRHiiZjcqTZUZ7eE/jGYVuvwdK8NoNb/f2kmgdpArQ30ey0a+csJC04uUUjWtAKzxF9rWNZrkZ1DnhHkTYSeLZizvmqiBbrB5X8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681140950145133.0620997028842; Mon, 10 Apr 2023 08:35:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pltXm-0000bp-44; Mon, 10 Apr 2023 11:34:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pltXj-0000Xr-7W for qemu-devel@nongnu.org; Mon, 10 Apr 2023 11:34:55 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pltXh-0000nf-HU for qemu-devel@nongnu.org; Mon, 10 Apr 2023 11:34:54 -0400 Received: by mail-pl1-x636.google.com with SMTP id q2so9832865pll.7 for ; Mon, 10 Apr 2023 08:34:53 -0700 (PDT) Received: from stoup.. ([2602:ae:1541:f901:2e6b:e4d3:9526:71d6]) by smtp.gmail.com with ESMTPSA id jj6-20020a170903048600b001a64e854553sm534402plb.159.2023.04.10.08.34.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 08:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681140892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gBl5GODmqunu8RhMyVnek3iPrET/1omof3j02qUp0Cw=; b=NmMmV9wr+UoyWtllFJOOoYCEeNv9SAP+ygvNMlQXKIIUNneqCsR9j4HXlg5N1Egmn/ ldGOSgdb8e2vsFZg9N/TZvKazNqXHHYGg25DRbBnGt9mO8SAsR1CY5sjv6eX9r8aKQ/H JKzhsapjs3TiW5hkCHFcE8P94SnRhTqF9kj8VxnmzOcoJvj+JUGd67Mi+oBsoSlW3AZ8 B7Hq8oCHp/LfkGiOfCuOx/qRWowDoGFQfLnbyWzPzs1Ibnypdnp9d/gX9fWoB34y5Yu/ W7Mczya6vb4rWVtWMR+LSMrBpu/QOOkR88IAEnPpT0urRnTqPuuEt4S0x8CHXlUjel/e NYQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681140892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gBl5GODmqunu8RhMyVnek3iPrET/1omof3j02qUp0Cw=; b=Mn1hhdJ5HNcPhdxCFLeF/cEtgIdtamNIbcOgU56lRVC5TegZhTiUncfsbk9uRJhCDR 1fmY9YFnFiMtGzPUx2D7q4k6hhv5WePEhAi+zhHuf2sVR0F60pOFfOJR5gkRjTlPOSP1 GyNQXMbs0/c1XqX6QDaIBNJXqsA8RqaDd3lKuGw6jueK9nG7XM2xp73ZAWhEP/vcGmZ1 VRgqoVvCicqFeuPUAtR5Es2YAQL8tTDD2IYhibc9iX4IutcCCv+hoo/dC/PidCpt9BjA uwYzcDVejFsC0QhDOfI0ApkRBumOJsMD/RbFCqJhBr75/7mlxedgfPFKPBIBY2dGNPMQ QwMA== X-Gm-Message-State: AAQBX9eMwrtwxPugWcGk2h6T3hEh9/n1eBzLtyiynqjcAA1uhyo2Cmvh 4nonUgcrYMRC+HiCl+Porju6GDXOAZ4V8K1vVCc= X-Google-Smtp-Source: AKy350bvQx22D0phDnUNcfksSQTOR0xfXLg6nEa6zhV+oxHIGC3t6ladeKcS8KtFHQ/bOvjXPBwclQ== X-Received: by 2002:a17:902:fb07:b0:1a5:ac0e:a4ea with SMTP id le7-20020a170902fb0700b001a5ac0ea4eamr5348007plb.29.1681140892246; Mon, 10 Apr 2023 08:34:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Mark Cave-Ayland Subject: [PULL 3/3] tcg/ppc: Fix TCG_TARGET_CALL_{ARG,RET}_I128 for ppc32 Date: Mon, 10 Apr 2023 08:34:48 -0700 Message-Id: <20230410153448.787498-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230410153448.787498-1-richard.henderson@linaro.org> References: <20230410153448.787498-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1681140952185100001 Content-Type: text/plain; charset="utf-8" For both _CALL_SYSV and _CALL_DARWIN, return is by reference, not in 4 integer registers. For _CALL_SYSV, argument is also by reference. This error resulted in $ ./qemu-system-i386 -nographic qemu-system-i386: tcg/ppc/tcg-target.c.inc:185: \ tcg_target_call_oarg_reg: Assertion `slot >=3D 0 && slot <=3D 1' fa= iled. Fixes: 5427a9a7604 ("tcg: Add TCG_TARGET_CALL_{RET,ARG}_I128") Tested-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc index afadf9a1e3..066b49224a 100644 --- a/tcg/ppc/tcg-target.c.inc +++ b/tcg/ppc/tcg-target.c.inc @@ -46,17 +46,18 @@ =20 #if TCG_TARGET_REG_BITS =3D=3D 64 # define TCG_TARGET_CALL_ARG_I32 TCG_CALL_ARG_EXTEND +# define TCG_TARGET_CALL_RET_I128 TCG_CALL_RET_NORMAL #else # define TCG_TARGET_CALL_ARG_I32 TCG_CALL_ARG_NORMAL +# define TCG_TARGET_CALL_RET_I128 TCG_CALL_RET_BY_REF #endif #ifdef _CALL_SYSV # define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_EVEN +# define TCG_TARGET_CALL_ARG_I128 TCG_CALL_ARG_BY_REF #else # define TCG_TARGET_CALL_ARG_I64 TCG_CALL_ARG_NORMAL +# define TCG_TARGET_CALL_ARG_I128 TCG_CALL_ARG_NORMAL #endif -/* Note sysv arg alignment applies only to 2-word types, not more. */ -#define TCG_TARGET_CALL_ARG_I128 TCG_CALL_ARG_NORMAL -#define TCG_TARGET_CALL_RET_I128 TCG_CALL_RET_NORMAL =20 /* For some memory operations, we need a scratch that isn't R0. For the A= IX calling convention, we can re-use the TOC register since we'll be reloa= ding --=20 2.34.1