From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529906; cv=none; d=zohomail.com; s=zohoarc; b=SsykozapBwwIyTZFyhZ6iy4MjF45D7DtbzAheAqVeKIUC22tkgrhjV3kF5FL0iBWM/y8t8h6BQPa1WEcB6GmmPF20eQLimoJuXFnEXrojGuu2TUSbxft2DvUAyqaQL5ppHayJ/YFoD+pRBNKkowU+qtNHhrrd2rCdTOcfxbT4bY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529906; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VBQGpqWmgJmN3spJtbY9ofJJqcdbpRTH4FCdiaUq178=; b=GLH7T+DZJccLR9zR2PnWh1b34/WUh/1WrmTPZKHvgratBsZKwwFI3XvBN5Ceo3j4fE+fMBNCv/PSe8nmqX8157SzvGZ1EqWwJZwv/XpRzqMdcPDlSMB4ah4u+BZlx40W33vy1xCb/DFAW9PmoYePW3Zbs5DSuckcYTk47viLFw0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529906251582.4857628584207; Mon, 3 Apr 2023 06:51:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYs-0002xP-Ga; Mon, 03 Apr 2023 09:49:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYq-0002uY-8s for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:28 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYm-0004tC-9j for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:27 -0400 Received: by mail-wm1-x330.google.com with SMTP id m6-20020a05600c3b0600b003ee6e324b19so18179980wms.1 for ; Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id t14-20020a05600c198e00b003ee1e07a14asm19528903wmq.45.2023.04.03.06.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:21 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id CCCCE1FFB8; Mon, 3 Apr 2023 14:49:20 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VBQGpqWmgJmN3spJtbY9ofJJqcdbpRTH4FCdiaUq178=; b=H4QstZX/rS1x1LifCE9PcChSlhTKrXM1xvEbZTlLirjUI/RKnVpIUf5i0ZDtBZYRX+ BXEEzSG+k9s3MkHeQnsexzyaMFuT5wqn3PUAKKS9MMVd85bE5Ghku89tTedIx1ORbbDM 7fwKLJsWRHoy7kj5r53uVIdQMKNChX4p9mxE0hlNr27F2Xq/Kxz1SheWm1TF89jS0sKs Yqyy3YdqRE12hYcOnLu65RT52HTSpbHmN9laA5R8bbWO1YP9xrbfcJJHnYZsC/AKUSpU eUGnAGbALhvUf6T5fvwIYkh1Wxw0u3qoU6hFrEA8L1jCb1mFb2u7gOxGANgT5+MLZPRL vV1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VBQGpqWmgJmN3spJtbY9ofJJqcdbpRTH4FCdiaUq178=; b=GkjjcAbAo/6kHv3evC0F/2DdvITbf2PtkLf+E1txqQM3wb7rxLQTY8v3lKduB/YRQq xTRO2tAIsTwA4EH2mA0h09K1MTskxteWaxKl4okyWUy9cttjTDWW/sH2qDanTx+QjBMt +LCBEUSpWkKaM+nxvNU/+6hpUY7QkTejyuCb5dfGp+DTNL4NUxkMOiDMmGeTlfZySKMb h+/F9Kys+tOx5U1PSVIBtmSPIQkh187Zu93McPuaiGI7Z6dl+/hEPkA8vjMCQmqGHqtP YYBPQ9TIeL0RBsZny5ss/Nnkn2O6+xn9xwU2t3uNsdvWZcW1WHawQTrz1rYva9JYRtPP HD5w== X-Gm-Message-State: AAQBX9elf8RgNDg4NgZ8QpK5CbCmyxwDtYDfV/MDeHnnBv9xtQCVe+0Q jUr6SWMgAKEPcE1ZPb77a5nRLg== X-Google-Smtp-Source: AKy350adEMNdoAny6K7tt+gEXhIno5WjB+5zl1E0OzgZy/kdk0TZ8Gz6NZBlFwEo4yk3JyvTab8maA== X-Received: by 2002:a05:600c:220c:b0:3ef:61f7:7d34 with SMTP id z12-20020a05600c220c00b003ef61f77d34mr22447919wml.1.1680529761634; Mon, 03 Apr 2023 06:49:21 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf , Kautuk Consul Subject: [PATCH v2 01/11] scripts/coverage: initial coverage comparison script Date: Mon, 3 Apr 2023 14:49:10 +0100 Message-Id: <20230403134920.2132362-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529908246100003 This is a very rough and ready first pass at comparing gcovr's json output between two different runs. At the moment it will give you a file level diff between two runs but hopefully it wont be too hard to extend to give better insight. After generating the coverage results you run with something like: ./scripts/coverage/compare_gcov_json.py \ -a ./builds/gcov.config1/coverage.json \ -b ./builds/gcov.config2/coverage.json My hope is we can use this to remove some redundancy from testing as well as evaluate if new tests are actually providing additional coverage or just burning our precious CI time. Signed-off-by: Alex Benn=C3=A9e Cc: Kautuk Consul Acked-by: Thomas Huth Message-Id: <20230330101141.30199-2-alex.bennee@linaro.org> --- MAINTAINERS | 5 ++ scripts/coverage/compare_gcov_json.py | 119 ++++++++++++++++++++++++++ 2 files changed, 124 insertions(+) create mode 100755 scripts/coverage/compare_gcov_json.py diff --git a/MAINTAINERS b/MAINTAINERS index ef45b5e71e..9e1a60ea24 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3908,3 +3908,8 @@ Performance Tools and Tests M: Ahmed Karaman S: Maintained F: scripts/performance/ + +Code Coverage Tools +M: Alex Benn=C3=A9e +S: Odd Fixes +F: scripts/coverage/ diff --git a/scripts/coverage/compare_gcov_json.py b/scripts/coverage/compa= re_gcov_json.py new file mode 100755 index 0000000000..1b92dc2c8c --- /dev/null +++ b/scripts/coverage/compare_gcov_json.py @@ -0,0 +1,119 @@ +#!/usr/bin/env python3 +# +# Compare output of two gcovr JSON reports and report differences. To +# generate the required output first: +# - create two build dirs with --enable-gcov +# - run set of tests in each +# - run make coverage-html in each +# - run gcovr --json --exclude-unreachable-branches \ +# --print-summary -o coverage.json --root ../../ . *.p +# +# Author: Alex Benn=C3=A9e +# +# SPDX-License-Identifier: GPL-2.0-or-later +# + +import argparse +import json +import sys +from pathlib import Path + +def create_parser(): + parser =3D argparse.ArgumentParser( + prog=3D'compare_gcov_json', + description=3D'analyse the differences in coverage between two run= s') + + parser.add_argument('-a', type=3DPath, default=3DNone, + help=3D('First file to check')) + + parser.add_argument('-b', type=3DPath, default=3DNone, + help=3D('Second file to check')) + + parser.add_argument('--verbose', action=3D'store_true', default=3DFals= e, + help=3D('A minimal verbosity level that prints the= ' + 'overall result of the check/wait')) + return parser + + +# See https://gcovr.com/en/stable/output/json.html#json-format-reference +def load_json(json_file_path: Path, verbose =3D False) -> dict[str, set[in= t]]: + + with open(json_file_path) as f: + data =3D json.load(f) + + root_dir =3D json_file_path.absolute().parent + covered_lines =3D dict() + + for filecov in data["files"]: + file_path =3D Path(filecov["file"]) + + # account for generated files - map into src tree + resolved_path =3D Path(file_path).absolute() + if resolved_path.is_relative_to(root_dir): + file_path =3D resolved_path.relative_to(root_dir) + # print(f"remapped {resolved_path} to {file_path}") + + lines =3D filecov["lines"] + + executed_lines =3D set( + linecov["line_number"] + for linecov in filecov["lines"] + if linecov["count"] !=3D 0 and not linecov["gcovr/noncode"] + ) + + # if this file has any coverage add it to the system + if len(executed_lines) > 0: + if verbose: + print(f"file {file_path} {len(executed_lines)}/{len(lines)= }") + covered_lines[str(file_path)] =3D executed_lines + + return covered_lines + +def find_missing_files(first, second): + """ + Return a list of files not covered in the second set + """ + missing_files =3D [] + for f in sorted(first): + file_a =3D first[f] + try: + file_b =3D second[f] + except KeyError: + missing_files.append(f) + + return missing_files + +def main(): + """ + Script entry point + """ + parser =3D create_parser() + args =3D parser.parse_args() + + if not args.a or not args.b: + print("We need two files to compare") + sys.exit(1) + + first_coverage =3D load_json(args.a, args.verbose) + second_coverage =3D load_json(args.b, args.verbose) + + first_missing =3D find_missing_files(first_coverage, + second_coverage) + + second_missing =3D find_missing_files(second_coverage, + first_coverage) + + a_name =3D args.a.parent.name + b_name =3D args.b.parent.name + + print(f"{b_name} missing coverage in {len(first_missing)} files") + for f in first_missing: + print(f" {f}") + + print(f"{a_name} missing coverage in {len(second_missing)} files") + for f in second_missing: + print(f" {f}") + + +if __name__ =3D=3D '__main__': + main() --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529874; cv=none; d=zohomail.com; s=zohoarc; b=DEVnCWnHNzkdNrtvO07la3dzWbVCLkl0+QfpAQsVLgUQOKDkXyUE/gbcdqRxULoDV5rFriyQjE/FbfLe+zY17FVFBYziw1J4uvlaWIwANHDJB9/KEJV6m3PN3E2KbJr9I5wEpahZQ4zlUKXkw/VIVTCVx4zKfgyDbTYTlnGA4eU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529874; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mN816sNtX5Vdj2G92pvv8I3i5QnGeNTrX25n5LbvU4I=; b=Kx6ZNmm7Zv0RuL18ph3lYM1Cbq1UkgkMN69ctqjvMhbrilb1z698ngBhyG/RRgm4sZe/gN/+t1R+otPcTGQRpKf5MXBeXuCQU7cTUCeAOWx1kNFRJRkw9VgfYbwSdyY2TzQHkK6WUmpg9AlHZS5sIxqJHGqPxv8ph7Zt0l2p8Gc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529874721965.8601366614815; Mon, 3 Apr 2023 06:51:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYr-0002vs-DP; Mon, 03 Apr 2023 09:49:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYq-0002u2-0G for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:28 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYm-0004tH-Ad for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:27 -0400 Received: by mail-wm1-x331.google.com with SMTP id hg25-20020a05600c539900b003f05a99a841so240154wmb.3 for ; Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id l7-20020a05600c4f0700b003ef5deb4188sm19526828wmq.17.2023.04.03.06.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:21 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E356F1FFBA; Mon, 3 Apr 2023 14:49:20 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mN816sNtX5Vdj2G92pvv8I3i5QnGeNTrX25n5LbvU4I=; b=O5sLqRX3o8wg3JSEuHWQfk7e53SjZslyalKpbNubzgxabPQbImJEAab9cWKIwTylAL WgcyZqFlockFyY+eZ0Bf7vXgYjz2ZTwNjuS2v73b4lgsIVnXRvHaM3qr2WnHPKUdJAQI 5B7WEues0f+SO+CL77LGCSGQrN7h0W/Tk+GIroANmG1yd2r3D4iFC3sC8EHZrTpiedQM sCILzvAqFtezCm6x72Z0UwzZmMlakI+VNU2GyYzB0Ne1NYLNF4GJQVY+tueL2OS5ZQkU bx43IXHTD/y2FJ9UOtFFsIU3eYKPZNE6kaHy0DTyMLxFc6WvKs0qn0lonWM8EUzREfvE 2wSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mN816sNtX5Vdj2G92pvv8I3i5QnGeNTrX25n5LbvU4I=; b=0OiRLCRsYem6KPfZy2SlMw8t3M2fukc49xL8UcOX685K8dIBavZfBGA/61m7il2ztW 4YbjIqRX9UrQ29jJJYYJXLAiIWs5x9gtx7siUKJvWmpxtRSjzMLZVAdeuBkSYJ5CM46y RiWO7/XfkA/YbCi+gG3REaIYhtMJD4ga2bygtMpANLXZ1JW+ZFFh75zXqpldDb7TPO8g fUKQY2yuMmSqHOfhbpW2uLN6L/Vxg6OxefjqaJXiuebWrJ2wd2GRYxL/47ADdz1ZoMwb 5HVPTG8J7Tu/OUMp07TuYNaaCjj9hi0PjBGS58Bj/NwGmAsE6p1t20U5o+BAQ4/Vhzdn lSiw== X-Gm-Message-State: AAQBX9d88S9o/uG0L9N3wNxjMmjTCClMNxpmxOPzI8heVB42fOTp4+/a D8ERIVLQH2Ra0T6BKjH1u1AKjcZ5aDojsUpDnMk= X-Google-Smtp-Source: AKy350ZwFB2r0eAYmFp0426BeiHDQwJvp+zag6ay5Q14nm/hpxxlQCHq0zP0DbsDmaKOiNfdE1IMxQ== X-Received: by 2002:a7b:c045:0:b0:3ef:6fee:8057 with SMTP id u5-20020a7bc045000000b003ef6fee8057mr19211144wmc.25.1680529761833; Mon, 03 Apr 2023 06:49:21 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf , Richard Henderson Subject: [PATCH v2 02/11] gdbstub: Only build libgdb_user.fa / libgdb_softmmu.fa if necessary Date: Mon, 3 Apr 2023 14:49:11 +0100 Message-Id: <20230403134920.2132362-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529876779100011 From: Philippe Mathieu-Daud=C3=A9 It is pointless to build libgdb_user.fa in a system-only build (or libgdb_softmmu.fa in a user-only build). Besides, in some restricted build configurations, some APIs might be restricted / not available. Example in a KVM-only builds where TCG is disabled: $ ninja qemu-system-x86_64 [99/2187] Compiling C object gdbstub/libgdb_user.fa.p/user.c.o FAILED: gdbstub/libgdb_user.fa.p/user.c.o ../../gdbstub/user.c: In function =E2=80=98gdb_breakpoint_insert=E2=80=99: ../../gdbstub/user.c:438:19: error: implicit declaration of function =E2= =80=98cpu_breakpoint_insert=E2=80=99; did you mean =E2=80=98gdb_breakpoint_= insert=E2=80=99? [-Werror=3Dimplicit-function-declaration] 438 | err =3D cpu_breakpoint_insert(cpu, addr, BP_GDB, NULL= ); | ^~~~~~~~~~~~~~~~~~~~~ | gdb_breakpoint_insert ../../gdbstub/user.c:438:19: error: nested extern declaration of =E2=80= =98cpu_breakpoint_insert=E2=80=99 [-Werror=3Dnested-externs] ../../gdbstub/user.c: In function =E2=80=98gdb_breakpoint_remove=E2=80=99: ../../gdbstub/user.c:459:19: error: implicit declaration of function =E2= =80=98cpu_breakpoint_remove=E2=80=99; did you mean =E2=80=98gdb_breakpoint_= remove=E2=80=99? [-Werror=3Dimplicit-function-declaration] 459 | err =3D cpu_breakpoint_remove(cpu, addr, BP_GDB); | ^~~~~~~~~~~~~~~~~~~~~ | gdb_breakpoint_remove ../../gdbstub/user.c:459:19: error: nested extern declaration of =E2=80= =98cpu_breakpoint_remove=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors ninja: build stopped: subcommand failed. Fixes: 61b2e136db ("gdbstub: only compile gdbstub twice for whole build") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20230329161852.84992-1-philmd@linaro.org> Signed-off-by: Alex Benn=C3=A9e Message-Id: <20230330101141.30199-3-alex.bennee@linaro.org> --- gdbstub/meson.build | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdbstub/meson.build b/gdbstub/meson.build index bd5c5cd67d..cdb4d28691 100644 --- a/gdbstub/meson.build +++ b/gdbstub/meson.build @@ -20,11 +20,13 @@ gdb_softmmu_ss =3D gdb_softmmu_ss.apply(config_host, st= rict: false) libgdb_user =3D static_library('gdb_user', gdb_user_ss.sources() + genh, name_suffix: 'fa', - c_args: '-DCONFIG_USER_ONLY') + c_args: '-DCONFIG_USER_ONLY', + build_by_default: have_user) =20 libgdb_softmmu =3D static_library('gdb_softmmu', gdb_softmmu_ss.sources() + genh, - name_suffix: 'fa') + name_suffix: 'fa', + build_by_default: have_system) =20 gdb_user =3D declare_dependency(link_whole: libgdb_user) user_ss.add(gdb_user) --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529807; cv=none; d=zohomail.com; s=zohoarc; b=kGK1jJMVmmaKOQ5Y5loNoCy1McMagbJ/70VF5ZlcWPausTMpgNGLg8f1Y+nb30l4tBk29JOLnltEAhfN+LEjJNHNZZql7ql6sPvFP8PdEjO10vkhRBhKqiD/2xWfbwLpfQGZEzeV9Kl7OD5QmHFkTo9jOZk2RpEPD/fSRR74mUQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529807; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dHHLYJ1Q7CDYpzOnQyJie+UJ0r74Mi54/+ouByLjk3E=; b=gQBuqJc+ETdfhV7cwrtxGz0orJN5twGecHQRfuLjrA5z0ABjlPj3snk2ohqFPL7VSsqvJ7oQEmw6/eI3N0aonxqvMGUySg9tvneXXtBt86nGMMgxWY0hr4ZoKZBYNX0iEGLOGal92fG3K4PeaqNHaD3XmYauj88gjZy6r12DocM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529807728933.4605371807482; Mon, 3 Apr 2023 06:50:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYp-0002ty-Ma; Mon, 03 Apr 2023 09:49:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYo-0002t0-Lx for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:26 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYm-0004tX-6v for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:26 -0400 Received: by mail-wm1-x333.google.com with SMTP id hg25-20020a05600c539900b003f05a99a841so240162wmb.3 for ; Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id iv19-20020a05600c549300b003ef69873cf1sm19941464wmb.40.2023.04.03.06.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:21 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 05D4F1FFBB; Mon, 3 Apr 2023 14:49:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dHHLYJ1Q7CDYpzOnQyJie+UJ0r74Mi54/+ouByLjk3E=; b=CWzuya7JW2bY34opxAKYIrNfyS65J2Ve7Op8RUvVCTJWgo8mFVV0WttZ5XTBIOpOuw qEc0uVEkLj4BSXrkGYzQuo4l+mgtk1/Cg5F8oZdEugZIT790Y3kd7/R/ROH79z7UrZQ0 v3Sn6tKQEDY9L3zgiYs7vsdbe8VCOYPEkeTzMCKl6g63yKNr+tFOllZTZi0lmaKWowSm PARwtkZgJ1mpnizEjF6BHJMoGJzl5i5cHzOy7KasRbZka01wrMHVeI0zfyoEPcjqUfVu oF/kl0e4k2mu2v96VOyu3vif1056EhDnaETNYv0h58W43SS6YkTyw2bu6X5j4qNswFKj vOHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dHHLYJ1Q7CDYpzOnQyJie+UJ0r74Mi54/+ouByLjk3E=; b=I06xUuPu0UDUOxMDH3/LQDW17aYDXsYCcxJnqLpWgJo0/c9VWyRTxDibKOR2p2i7eU j8LfITFajPwYyFR6fOGZ4omLyNV2JGGivqr6R50O1hKTttK40UNn0I2W+flS5HvSACVW E4b24vt2nCAULWNca9JJ3RfX0PktsHXgswvdE+NNEMLkyiB9yVjVUWTBPo56Jr21LUKB KWyvaD82bTmMwKv4REF/uuxe36y8IumHyH3G3yxAIs5L6gHlzmzjawHuyvUEUEC5hS0V cMb73M37SK1kiAlj8cIbDoAvUIESSuUI9PQrOZEchvCU4Suw9IoniQumtNtbfa8jSP/4 u+Xw== X-Gm-Message-State: AO0yUKXdzopt+7xjQeXkmdEtGk106xpti100Y/j5/G3kfzUHbrZ1vHlI P4QQp2r1klSUj4mroTLiNbsONA== X-Google-Smtp-Source: AK7set8bJ8p2Mjm4rby/PfqCRzfAP52hZFXF8mjkWC1Vnn5qr98rrvtqR8gLVZ45HJE2Z+KffldK9w== X-Received: by 2002:a05:600c:acb:b0:3ee:4f92:907b with SMTP id c11-20020a05600c0acb00b003ee4f92907bmr26589298wmr.14.1680529762237; Mon, 03 Apr 2023 06:49:22 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf Subject: [PATCH v2 03/11] gdbstub: don't report auxv feature unless on Linux Date: Mon, 3 Apr 2023 14:49:12 +0100 Message-Id: <20230403134920.2132362-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529809728100005 The later handler if conditionally compiled only for Linux but we forgot to ensure we don't advertise it lest we confuse our BSD brethren. Signed-off-by: Alex Benn=C3=A9e Fixes: 51c623b0de ("gdbstub: add support to Xfer:auxv:read: packet") Reported-by: Warner Losh Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Warner Losh Tested-by: Warner Losh Message-Id: <20230403120250.2071560-1-alex.bennee@linaro.org> --- gdbstub/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 2a66371aa5..0760d78685 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1468,7 +1468,7 @@ static void handle_query_supported(GArray *params, vo= id *user_ctx) ";ReverseStep+;ReverseContinue+"); } =20 -#ifdef CONFIG_USER_ONLY +#if defined(CONFIG_USER_ONLY) && defined(CONFIG_LINUX) if (gdbserver_state.c_cpu->opaque) { g_string_append(gdbserver_state.str_buf, ";qXfer:auxv:read+"); } --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529872; cv=none; d=zohomail.com; s=zohoarc; b=AijAplMNpSWIL3C9zZ5BpshUZtb1g7uxYXffRXaN5L6RcuzbSO7YLkzOGWxqM4aP49gpVhodoxNub2qgHr1bzD2TXauvT55rHo4ee3+tZgEhaaJ49m4GgbVcCmqr8SM7VYMUY167ObuyacRSsKe/kbWmWmLVpqIMD6lX6P9op0k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529872; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b5aVTp29ura2AnXi+mbMTi4HjJNdcHU6J80+OlMAlxY=; b=B+Fmc+cVDAx31TYEcx0RK5x+bge9LMqv2OBDZ2PEuy4kOvdMHa9s0F4Jeup7IfkNULVnU6OJJqqWGqFZ7htiPxdfMcLFSqSVrL9kA7doHXPzTwRZu+w6x2rbc9s1GK/isnGwDodJGyIQoObnJDBqNL6T3nYrlcgWH5VI5pVowws= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529872613419.431447723328; Mon, 3 Apr 2023 06:51:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYs-0002xJ-2p; Mon, 03 Apr 2023 09:49:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYq-0002uF-55 for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:28 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYm-0004u8-FA for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:27 -0400 Received: by mail-wm1-x332.google.com with SMTP id l15-20020a05600c4f0f00b003ef6d684102so14580060wmq.3 for ; Mon, 03 Apr 2023 06:49:24 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id v20-20020a7bcb54000000b003ed2c0a0f37sm12120590wmj.35.2023.04.03.06.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:21 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1C5EE1FFBC; Mon, 3 Apr 2023 14:49:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b5aVTp29ura2AnXi+mbMTi4HjJNdcHU6J80+OlMAlxY=; b=ZHIf9dTR9loLxTXKZEIR0EGR/ksvgHBfh1pbCJ0NAkJGnCKcyHG7CzrW/CiT/e6zrH c5PIqG8eRCQSzO+W6MlMgOpUEKLOlaONVz+0y/Ie32Pv08zCE9wv5KII/7LySQ9cSifv 0VrF88QHDe1uAetUbtrP+UgQGfpltXIh8k2NUcHjpHKnuEOzeGy0++076bIUD5CfPngY HxCpv57KPdzbJm73+iwV28AthNhhn3UrMkEROc9b4h6AZbsBiXpFFs5jAPNRM0gFsHDG Li+H/g22R0opKVbB3rO6gqSRAFd5djOPW5X0t3kyLNzlJi89cuEmwvGDtGR/ciSuieM3 R7bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b5aVTp29ura2AnXi+mbMTi4HjJNdcHU6J80+OlMAlxY=; b=wICBvoy1vlk1lh7ZDbXRC6uLbQ52tpXGkNmX43GdxBr5DCmmBLYmPaqRUBzXRFvwLV l9hhjV9IQhf48c9JkMc1KtUr6T0f61BpVPxhLO3bjqdpe5pJcU7y1HZCv75BLhqmjl/1 fcVpBALdlaFocmeoyIcXlj2A2qDAaDDqZ3Nyd3MByYZOGACNMKbNzqr/E50YY2UAGB5S aonxPMgA01BlMMkaZRf1K8ElQ2TeLvoCcS+zwi46DsxnnDHWu83L7g0RuW6JrsM4BMq0 QinFX3BY3wL8kLO+2LoP+hA46Juoc2D+xlX9ChULWU152MGJC9DdVXmZrb79gB9HJKCu 1Abw== X-Gm-Message-State: AO0yUKUdq3wbqU1eFqbEcF2OZFf6eYktp5RGuan2lx3J57nocBenRoW6 TcmwKcUNVA24UPDrQUng5lsLcQ== X-Google-Smtp-Source: AK7set8lYRugOBzrVk1ygXZ1aDlYhbI/8TypyTwOwvLQVpeVrOmym+zLvkt3BbgcjuFifdsfynZTog== X-Received: by 2002:a1c:7516:0:b0:3ef:3ce6:7c69 with SMTP id o22-20020a1c7516000000b003ef3ce67c69mr27186739wmc.8.1680529763045; Mon, 03 Apr 2023 06:49:23 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf , Markus Armbruster , Kashyap Chamarthy Subject: [PATCH v2 04/11] MAINTAINERS: add a section for policy documents Date: Mon, 3 Apr 2023 14:49:13 +0100 Message-Id: <20230403134920.2132362-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529874741100007 We don't update these often but now at least we have a few like minded individuals keeping reviewers eye out for changes. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth Reviewed-by: Warner Losh Reviewed-by: Markus Armbruster Reviewed-by: Kashyap Chamarthy Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20230330101141.30199-4-alex.bennee@linaro.org> --- MAINTAINERS | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e1a60ea24..2f67894604 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -64,6 +64,20 @@ L: qemu-devel@nongnu.org F: * F: */ =20 +Project policy and developer guides +R: Alex Benn=C3=A9e +R: Daniel P. Berrang=C3=A9 +R: Thomas Huth +R: Markus Armbruster +R: Philippe Mathieu-Daud=C3=A9 +W: https://www.qemu.org/docs/master/devel/index.html +S: Odd Fixes +F: docs/devel/style.rst +F: docs/devel/code-of-conduct.rst +F: docs/devel/conflict-resolution.rst +F: docs/devel/submitting-a-patch.rst +F: docs/devel/submitting-a-pull-request.rst + Responsible Disclosure, Reporting Security Issues ------------------------------------------------- W: https://wiki.qemu.org/SecurityProcess --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529837; cv=none; d=zohomail.com; s=zohoarc; b=XtNWymONl6bHYH39T+Ns1+tNtCYbvNUFUm8kGWG3C7a0C/oWaWdnv4X3vgD13FSlLazjaIdxZHOw+gagA5LbxyhVuHtF4jnRdu139WKs9ZlxGIWebGJ2RBNBW1SaZ4HVFaXkwoPj1Gtuy6Fbx0zJAzLANLfoTh0S5ktAiuez8IA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529837; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QIAbN9ckX3lGfUzvEPz/vzPNYZxaSL+GVZgf5wv9fMw=; b=PzmsaqU5l3U5iqfV/v0T+M4uwNJUky+NAk0gyT/me00oTFBFVTv+7Bmzous80fRdDb4AuBl7t0RM2HYZGpiOmbpb8njAGJ0Ri3LfyMoSzUylFNIaBp0k5RIdXjy+J9jeUljHPvncExLmC57QChEMsZ/w+ctiMLHq4Tnwqqr4DrY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 168052983743794.34624161298882; Mon, 3 Apr 2023 06:50:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYs-0002xp-Pm; Mon, 03 Apr 2023 09:49:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYq-0002vJ-GY for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:28 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYn-0004uV-9V for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:28 -0400 Received: by mail-wm1-x32a.google.com with SMTP id m6-20020a05600c3b0600b003ee6e324b19so18180052wms.1 for ; Mon, 03 Apr 2023 06:49:24 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id l7-20020a05600c4f0700b003ef5deb4188sm19526847wmq.17.2023.04.03.06.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 329FE1FFBD; Mon, 3 Apr 2023 14:49:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QIAbN9ckX3lGfUzvEPz/vzPNYZxaSL+GVZgf5wv9fMw=; b=LWUprjACAXh+rLjO+aP8mffyvPwH4ehS4JZikFQAibUBF0T9DkF4kdhb7lHWFZKQRr /4ALZYok7J+Boq7MVhqfKjWiCieBWXUjgeEJGbFtw1Gds6GKdMxi9wLJzMjrcdJqohlV OoEZ8CMWkpf2UDeGOvCGc6UJHpsMgIGU8iejcuZl1+Bp+OKnTfv1/AYDwIGGA9ZYn4bB DVlZHzvRpSe45DYQHZsUV8HowyoYF7txt7KNlkEbkUdkQFEt6b7odwVWcP7zut9mXuEF BU32cAEjuwEi2re9se/CocXw7PQ4xlznkJFvt9jpcG88WWkCPUHT2fIj0ckekv1APwPG 2xtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QIAbN9ckX3lGfUzvEPz/vzPNYZxaSL+GVZgf5wv9fMw=; b=auxNn6wa2yofFMcAS0fKTYSNZSyFpQf7jYKmdD4bDiv1RAvxvenEEePFAhBAjKdqqQ VcshBDe7u/2Kwx8dE3nmvi8eRm83kWRvXoyiUXJEpAc/tDSkanPmiNs4+ndm3/YQLVpH VhrUNy+3r1lPZI1K16u1HLO28DVH3F8+B+f9CTC8FEPqiMBgz67XCMRD7V4chVzu0cNg EVMBNg+y1IjmFhE0hrwtEAVXPW7VYQZvFPnMNUJ1Vl1Dpv6+0LmOlNxhC4yvk8Xgv/6O MxLj8R6QugdIyBNLp379WHfP8ubIdoSAZ6P2Wivd7Los2y+LjZ90956c8PfyQGDBauo+ RhIg== X-Gm-Message-State: AO0yUKVLbWbU3gIgGR8OnF8qqLtMBPyxnNmj339mUG32PikidiWZpiIx x65oSwYpJGEbOKJtF5b9N9EkKg== X-Google-Smtp-Source: AK7set/iPqa1oDkXeWQmk6LoRUQ6t2lI5DVpIiIXbiFyL4cXuZzRcD8PTVowcXFiJ8fJgH1SLa7O1Q== X-Received: by 2002:a05:600c:ace:b0:3ed:98c1:2e5b with SMTP id c14-20020a05600c0ace00b003ed98c12e5bmr26622637wmr.9.1680529763808; Mon, 03 Apr 2023 06:49:23 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf , Michael Tokarev Subject: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev Date: Mon, 3 Apr 2023 14:49:14 +0100 Message-Id: <20230403134920.2132362-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529839351100003 We are a bit premature in recommending -blockdev/-device as the best way to configure block devices, especially in the common case. Improve the language to hopefully make things clearer. Suggested-by: Michael Tokarev Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth Message-Id: <20230330101141.30199-5-alex.bennee@linaro.org> --- qemu-options.hx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 59bdf67a2c..9a69ed838e 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1143,10 +1143,14 @@ have gone through several iterations as the feature= set and complexity of the block layer have grown. Many online guides to QEMU often reference older and deprecated options, which can lead to confusion. =20 -The recommended modern way to describe disks is to use a combination of +The most explicit way to describe disks is to use a combination of ``-device`` to specify the hardware device and ``-blockdev`` to describe the backend. The device defines what the guest sees and the -backend describes how QEMU handles the data. +backend describes how QEMU handles the data. The ``-drive`` option +combines the device and backend into a single command line options +which is useful in the majority of cases. Older options like ``-hda`` +bake in a lot of assumptions from the days when QEMU was emulating a +legacy PC, they are not recommended for modern configurations. =20 ERST =20 --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529869; cv=none; d=zohomail.com; s=zohoarc; b=h9u72jcN+6SfKK1M1F/NJuPjaG3IZTGnL6cYgyxTzllDXu/T35hwRXlU06lJqjBHaCcXdX32TLECuf6+5VxW6JbnTyJ24Re6FKOpb6SGKlSsfsN05tu0ODrlDoSrglAMU8RdL+RxwH257PVmIyKYIHy9zhqDfhxU/+SrjVUjCaI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529869; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NTOWIebDq0xH5MEdgwVyuiNxE4JxhgEfL/zEAMmcLTQ=; b=bDCvOBBXKti2AD5QAZvqZxB7ENgg6an1/EDLMO4BX0Y2rD3yYwesbe40dkxMfnG3JuSA2iZxeBAiRcyLdW/ScV1AjPtIBOBEGS/MlcI/PhpGjqHES0gonaMe7uokXnHcX5FWDFDBEz4LGHhTGp0l1DrxSTf8l0Wb1gzPfLz46AA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529869857571.8848522691608; Mon, 3 Apr 2023 06:51:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYt-0002z4-J5; Mon, 03 Apr 2023 09:49:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYr-0002vq-B0 for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:29 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYn-0004um-Hq for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:29 -0400 Received: by mail-wr1-x436.google.com with SMTP id r29so29388040wra.13 for ; Mon, 03 Apr 2023 06:49:25 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id e11-20020a5d4e8b000000b002cde626cd96sm9760207wru.65.2023.04.03.06.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 51E3D1FFBE; Mon, 3 Apr 2023 14:49:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NTOWIebDq0xH5MEdgwVyuiNxE4JxhgEfL/zEAMmcLTQ=; b=Pd745bmnXlfs4LJh75sVHpdsPA+xhcR3XlKK3TosfuE1r4GmjMcCMK//Sg5U8B9OCy QApDpXjTidsFf6gSbmq2SgYwstpQ7u2awLYYx+4Vk6KUWZCwSWqLUJc+NeSG8H+V/dcS Dwbel5nNX0LpskAYoI3JNAv7Z3EznmNWbtxvBkjFqblsWce7z949QLS4zc79G8/BxSbl QSU/Lc8ZBOAeIZwJ/NOLRhqcgUAl4KP04pfjAGGX6zJyVB8QT3D5VkPhJV6sx3HNLe+I Jc9DoN1KL+ilRkw0P1VXc/p4l+WpoPVl1zCyAStMx/mXL11fRlcfkeTPV+1SMtDRrmRW LP+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NTOWIebDq0xH5MEdgwVyuiNxE4JxhgEfL/zEAMmcLTQ=; b=tAiKtnL2uTNoZnqthWYcgG98AdIKGiNt8KvABLCzQMO0kFDopQdY9sHSIC0TtWODMU jCqwY7IXkRBp1RzemGJBnyss/VVjnO+COgUNhWx/4Fnj6Y1EyLkrIb0XCpGhyVfx4zUa ExkGyuiQuqse5ssSsE2/pF9oHhedb8PNy4s4jRYL+hl1E3fxdN+3lfvY2uePCEsdllrl OomN72RSVU1L0ZEgiDnBe470WJEXT7y7XxBKmK2ooRLhBRwQDGtzFjcfya93BrvwICpz tbBWxXZ4Cg79WA1vQXM8uREMKEIn3iCXybARGoJxjTvTBoaT8Oo7rz7uXCBuXYmysaCf at+g== X-Gm-Message-State: AAQBX9eJpQBSi8XUuwN3DPRCYDswY43AHtRlzBnN0T7j9cw+yth/9suj GE/bqhFIarDoHCDVhgvsUVBpNg== X-Google-Smtp-Source: AKy350ZRhlxNrjjVOSPUKEPVG7isDQmeeJWmbFFZBRlp1mMjzm7Mq0oej7yeF6yUqNQCE7KoPphvYw== X-Received: by 2002:a5d:408b:0:b0:2cb:76d4:42ea with SMTP id o11-20020a5d408b000000b002cb76d442eamr29007696wrp.36.1680529764015; Mon, 03 Apr 2023 06:49:24 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf Subject: [PATCH v2 06/11] metadata: add .git-blame-ignore-revs Date: Mon, 3 Apr 2023 14:49:15 +0100 Message-Id: <20230403134920.2132362-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529872039100003 Someone mentioned this on IRC so I thought I would try it out with a few commits that are pure code style fixes. Signed-off-by: Alex Benn=C3=A9e Message-Id: <20230318115657.1345921-1-alex.bennee@linaro.org> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20230330101141.30199-6-alex.bennee@linaro.org> --- v2 - rm extraneous + --- .git-blame-ignore-revs | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .git-blame-ignore-revs diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs new file mode 100644 index 0000000000..93718ef425 --- /dev/null +++ b/.git-blame-ignore-revs @@ -0,0 +1,21 @@ +# +# List of code-formatting clean ups the git blame can ignore +# +# git blame --ignore-revs-file .git-blame-ignore-revs +# +# or +# +# git config blame.ignoreRevsFile .git-blame-ignore-revs +# + +# gdbstub: clean-up indents +ad9e4585b3c7425759d3eea697afbca71d2c2082 + +# e1000e: fix code style +0eadd56bf53ab196a16d492d7dd31c62e1c24c32 + +# target/riscv: coding style fixes +8c7feddddd9218b407792120bcfda0347ed16205 + +# replace TABs with spaces +48805df9c22a0700fba4b3b548fafaa21726ca68 --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529863; cv=none; d=zohomail.com; s=zohoarc; b=N+9vsuNhbsgJjphKcsoymHvIsu+pgotD/sY1lInM+LmAXKyEMtFL9UtYkfJXreISuhRPFs9Qx2ritA4WOMKUE8eQNw4Q1XKdhq8vRRaRmhqQK47LBSqGojhue6cr5xgZh5MHC8qr6ErAt9xkHAFFRMvdLCh6RMpCz59op6LtbGs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529863; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GjJ0WrIm2Di0AKuPGaQhGuqTtmI2bcqfL0u1knytYyA=; b=X/2mYcyfDV/ZDp6mhh4VEKZENSbjbV7Vy4JVWTFzM4Yw4OZWktsf1rrGoGab5JjPBhmPY9iuMS3oAb+gxOn+mkmHyNEBki4GMPO6OQSoAVuXXSRqgTg/OSGYs/ENP0wN9wnPZFQgB5r7QO9VeN318+pRULlJatnjRJAeq79RjTo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529863744988.2201493672112; Mon, 3 Apr 2023 06:51:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYu-000308-DT; Mon, 03 Apr 2023 09:49:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYr-0002ww-R1 for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:29 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYn-0004ur-Te for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:29 -0400 Received: by mail-wr1-x433.google.com with SMTP id y14so29447002wrq.4 for ; Mon, 03 Apr 2023 06:49:25 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id z6-20020a5d4d06000000b002e6d4ac31a3sm7433916wrt.72.2023.04.03.06.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6799D1FFBF; Mon, 3 Apr 2023 14:49:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GjJ0WrIm2Di0AKuPGaQhGuqTtmI2bcqfL0u1knytYyA=; b=JaVTpA1WR5Yo7HRGCieD9YHpHG6U+azsDNIGhcFsSoWXaTyGJ5nteWKiXEEwk/kw5K 4z/HoY6XttEATEGH7ML2L997lwjyaICp58vZdfBt7Ul4c19wLOOL8BaRtOmvSRUuhed7 F7xab7P0e5GN5SX2AiIVAfbcRe/dg27YalMfRch9sGsLGTKbnuA8YicvcomfH+IfCH9r yVPY/U2gVCrVeue5OHDtNrUdHp/MGzzkoCWB1mxWhuzHAzkS8TVmgzbRXCEx5/h5OI/5 cq4Yc7i4nLK00nhoQn/G9sEJn3XzQD/Ddu+otDQolTbDvgrnOtmxHCp7MTofBVl/bMtO ZnpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GjJ0WrIm2Di0AKuPGaQhGuqTtmI2bcqfL0u1knytYyA=; b=GQOXwIWfzN2uWnOXV9P5sAiQuR4S/Q1vml/jQGnout/eEzyZnbs329HWvxuV/erRrx OhZY6Xnb+fK1TmjPyCcm4O1HuujRQBWYaU2CgtRj8fC5TFcLRoWdpt9yxNf8osWRfBM1 lPiDbSFMSmCucbm2RY37aVp/Ff+Yz9fyCDnb1X1e9ALyN4FxzLVHcl6YuyOP/7Ca5HGA oKprnsCyR0rsKkUnjCbwO+FOLJM48aJCgjsRb4v45UeesYabb1IdPKUx/M05T5oVhtuV HyxVGSjxJMjUIKL5QdMZGWxzMFAwiGNyZGhxQUbrbFox4KDQi4HE8WTVGQFx9j0V79Dv 72ig== X-Gm-Message-State: AAQBX9cjlnHRTNp7l0XhIwuQpmMoqMpOBqNJyA97osfXrargt7Ui5F03 +zDWfLTLF3wzlO++dUniF7PqhQ== X-Google-Smtp-Source: AKy350Zih1/UPPhQr8jYeGyPYonELcT+rZRHLNBwD0ldfATP2SC3xnwB/VAGhSWQTnQNEnfb2Ap/xA== X-Received: by 2002:adf:ce02:0:b0:2c7:cdf:e548 with SMTP id p2-20020adfce02000000b002c70cdfe548mr27185931wrn.71.1680529764201; Mon, 03 Apr 2023 06:49:24 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf , Marco Liebel , Brian Cain Subject: [PATCH v2 07/11] Use hexagon toolchain version 16.0.0 Date: Mon, 3 Apr 2023 14:49:16 +0100 Message-Id: <20230403134920.2132362-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529865922100007 From: Marco Liebel Signed-off-by: Marco Liebel Reviewed-by: Brian Cain Message-Id: <20230329142108.1199509-1-quic_mliebel@quicinc.com> Signed-off-by: Alex Benn=C3=A9e Message-Id: <20230330101141.30199-7-alex.bennee@linaro.org> --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/debian-hexagon-cross.docker b/tests/d= ocker/dockerfiles/debian-hexagon-cross.docker index 5308ccb8fe..b99d99f943 100644 --- a/tests/docker/dockerfiles/debian-hexagon-cross.docker +++ b/tests/docker/dockerfiles/debian-hexagon-cross.docker @@ -27,7 +27,7 @@ RUN apt-get update && \ =20 =20 ENV TOOLCHAIN_INSTALL /opt -ENV TOOLCHAIN_RELEASE 15.0.3 +ENV TOOLCHAIN_RELEASE 16.0.0 ENV TOOLCHAIN_BASENAME "clang+llvm-${TOOLCHAIN_RELEASE}-cross-hexagon-unkn= own-linux-musl" ENV TOOLCHAIN_URL https://codelinaro.jfrog.io/artifactory/codelinaro-toolc= hain-for-hexagon/v${TOOLCHAIN_RELEASE}/${TOOLCHAIN_BASENAME}.tar.xz =20 --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529807; cv=none; d=zohomail.com; s=zohoarc; b=FEtc0KPzTFgsmot9uVs97xHEjaeKc3KBog9BH8G7Y/zT69O3gbH9FSd/irLKNr0ZjDAkEkoQOSNV0xVG1DlGkEOKKQ8kWDQn5CUWF/nvAlqpGc8/N5RQtgTxYhITRuxDa4RakT5rYfWKBIR8c5ohQPgxNsk9nusuEdgN4xiUcMM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529807; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BNNm+hFhYmn6A4btsbTy8z3ys/wMqr7F5fsQ6UPTE0U=; b=CajMEeKNqxjz7fUZX+WpptMhx5CoWiVRBgTP0RgveqmA5OcqZ/Sd8dSae3s1i0nUzQXkBbw3zuTosakvjOeOzxaAAInUrVSrf7qBo77G1kSyByZ8UHaFTHcg2jRbacyxIBwHMDV08yfwHj3/tcuhN6uRjLawCc8RW+dsYjZv548= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529807676821.9373678499002; Mon, 3 Apr 2023 06:50:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYw-00032H-Rv; Mon, 03 Apr 2023 09:49:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYs-0002xX-Jm for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:30 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYo-0004vi-Av for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:30 -0400 Received: by mail-wm1-x332.google.com with SMTP id n10-20020a05600c4f8a00b003ee93d2c914so19552524wmq.2 for ; Mon, 03 Apr 2023 06:49:25 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id r16-20020a05600c35d000b003ee9f396dcesm19503795wmq.30.2023.04.03.06.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7E9FF1FFB7; Mon, 3 Apr 2023 14:49:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529765; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BNNm+hFhYmn6A4btsbTy8z3ys/wMqr7F5fsQ6UPTE0U=; b=uMZTW/+EF5o1W2A5JdfLs4oBqxYHeVBh65G8DF6NWJWPjReRFhKuCC/ncNpHwzh1qs mMEW2tZDNckEfFHS0GjWwR6IQexwG7ZXXRhicNL8f20z5m5Wdk3P5cQ8w/jkdpiCdqDL nLh92n6g0umdfLVI/eQbiF1cxRXgRItEeUiApK+mbKSMit9AUhnjl4hdTriQp+jk79nE 6tFc8cnDjdFMut0KwN1OCHIduIw+ynMVFPZ/mXSo/w5MIZx1TOwiMx0bB0B/C3Z3gm0j 6ePgrajdov1CzO49xyt1IvyKD+1XurKgKZaKP/PrY/1o3SOzUPkceYK5rLcstSpCjaYb OY9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529765; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BNNm+hFhYmn6A4btsbTy8z3ys/wMqr7F5fsQ6UPTE0U=; b=PAgQW8SVBaO7qrjjQJiXbsV7dlV2FtGrDSZkTqf3EnGB05PBI6nP4CXj559X9oRPwl o5RP25Ex7eqMNO7qcCvsMgZuq/jS+fZlXqYIrUUVb1fme/UUn1I5tiSraHk8ySYM4UhA og/3EzTaghnKHH4tkfrWPognNYVo+CKVborXO0sN6kTcNSwtsu6PZqNl2bxFJUDuix3h bvxaxMf1CprMyCPdYUS+q04g8bJvXjC+K3oBfKujlIAw+uF0H/wpVtV0MP92GS6khpsG xJ/JIj0huP2lPMxQ1hYgUXgQoHZ/RHoDMoVCRKah+manRs93j7hVvsqd4E6eUR/qXJly E4bw== X-Gm-Message-State: AAQBX9dg5lOdP8L2Th+af3v6Jek8IQR77naTuOaBkIWs6XC8E5qXllZI LyDNmXim3AHQXEPe48afYDjSdg== X-Google-Smtp-Source: AKy350b3NNR46AzUUhLxuq4xz5tHpBeQaaVzMjYEw3SBCZ7bSYJ9UQeC7a2TmNiaH4Ew781UGyqx8w== X-Received: by 2002:a7b:c4c7:0:b0:3ef:6ae7:8994 with SMTP id g7-20020a7bc4c7000000b003ef6ae78994mr21868141wmk.22.1680529765031; Mon, 03 Apr 2023 06:49:25 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 08/11] tests/qemu-iotests: explicitly invoke 'check' via 'python' Date: Mon, 3 Apr 2023 14:49:17 +0100 Message-Id: <20230403134920.2132362-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529809737100006 From: Daniel P. Berrang=C3=A9 The 'check' script will use "#!/usr/bin/env python3" by default to locate python, but this doesn't work in distros which lack a bare 'python3' binary like NetBSD. We need to explicitly invoke 'check' by referring to the 'python' variable in meson, which resolves to the detected python binary that QEMU intends to use. This fixes a regression introduced by commit 51ab5f8bd795d8980351f8531e54995ff9e6d163 Author: Daniel P. Berrang=C3=A9 Date: Wed Mar 15 17:43:23 2023 +0000 iotests: register each I/O test separately with meson Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20230329124539.822022-1-berrange@redhat.com> Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth Message-Id: <20230330101141.30199-8-alex.bennee@linaro.org> --- tests/qemu-iotests/meson.build | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build index a162f683ef..9735071a29 100644 --- a/tests/qemu-iotests/meson.build +++ b/tests/qemu-iotests/meson.build @@ -47,19 +47,20 @@ foreach format, speed: qemu_iotests_formats endif =20 rc =3D run_command( - [qemu_iotests_check_cmd] + args + ['-n'], + [python, qemu_iotests_check_cmd] + args + ['-n'], check: true, ) =20 foreach item: rc.stdout().strip().split() - args =3D ['-tap', '-' + format, item, + args =3D [qemu_iotests_check_cmd, + '-tap', '-' + format, item, '--source-dir', meson.current_source_dir(), '--build-dir', meson.current_build_dir()] # Some individual tests take as long as 45 seconds # Bump the timeout to 3 minutes for some headroom # on slow machines to minimize spurious failures test('io-' + format + '-' + item, - qemu_iotests_check_cmd, + python, args: args, depends: qemu_iotests_binaries, env: qemu_iotests_env, --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529915; cv=none; d=zohomail.com; s=zohoarc; b=gMZ+VV5bTtMAPKVoT4f4jjBLD8GRVRaSzJOceHPdCnkij1t0uDoR35IoYfUPyGPN+cctxsay5ng4KGQ5PkJV558ZtgJiFuSJRabpOAxi7e5vroySinFn+tf2DIsuwC1LqhrXZowNy+Qh0eYYnOcqzDnyI4mPSrYDD3l2lez5LY8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529915; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PldKx1qfpz7lDvG61jB68knTHdO2ooZN76NERNqkzDY=; b=Gr4WiTUgHs5R6fTI5MQbNxuOz07yfQUMxXsJKtJaKTU9ojkULTgzkFMzTgfX2htogAZamHlbor49+y523MAfufXk4qdhhOVRQd2ZmjH4Rq+6GNxjQCI1QCcmzH5YX+6LoTDUEUbEwT3dEANGcirTMV2t1uPnK+7YGDiBi3c/WnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529915467831.8953459484003; Mon, 3 Apr 2023 06:51:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYu-00030S-VG; Mon, 03 Apr 2023 09:49:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYs-0002xO-Ev for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:30 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYn-0004t5-UC for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:30 -0400 Received: by mail-wr1-x436.google.com with SMTP id q19so26356676wrc.5 for ; Mon, 03 Apr 2023 06:49:25 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id p13-20020a05600c468d00b003ef7058ea02sm19327158wmo.29.2023.04.03.06.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 960301FFC0; Mon, 3 Apr 2023 14:49:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529765; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PldKx1qfpz7lDvG61jB68knTHdO2ooZN76NERNqkzDY=; b=tAaXPTuxrZUwgDhNs2VAA3i3A5sbpUS96TJNu9EnHiuS5McEnfl5cstLz9L8iPRyMm jWDWiyCo47qpsZoFmbQlC86I9o0KKIsuvTeq+G6EWzEJkwAAJpeHCXDuAQsCgp2zn9eX F4qqn5xVcYpsCdCgRKXYKrcLgDuVHj3/chtJPS5xOJaQqG0XSxlyHWqCpnnl5tDVrWwd EhL57J/td90pFXIrSsBfNC92WqwTVsqMuokr0Zsf2W5SUy3L5RWjqyLYARjjsoYgZyCW p7Jd4iSOaVHpFVYz33XRBz8xdSqji6nhgSHdB/Kbk3PNu/cm1fr86kp6okiP5IdY760a pjow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529765; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PldKx1qfpz7lDvG61jB68knTHdO2ooZN76NERNqkzDY=; b=UDn3GmVhn7GrUF3UMLWEKxkPxmQCFWzf9b6m0T/wpmDZyipxvWeoW5YcGGmzIYo2GN gn5d9DlgnTZRySYfMIhrZ4BraLgsAoBCepwMjGfQo8z+v5qQYDdONdJ2YEEf4iXqwicM DIKWE5Qckt/a+cDcDIgVgyMeRap+9V/j/7eBZ+3A/SGff3QPQ7gjto4SqBlBmmXj5ydG 73YAuQdykrFpL5T04hxiWMC7b4JY4Y4W6Q72Kkh1tBgnUWDgkfPukjIW9MPSg+X+mBWk QldfieTjBSh+kd7yW0tkcTbEIHDjX+SngBJ6w7bQFy86eopFi2cdaokqKrb/yvFcvfZn aZ2w== X-Gm-Message-State: AAQBX9fM/78u9OLpWAWPUFZBjuZYCyO9C7nhau0iwewI12id+DLud4tC xN7NeQhtuwWnzPSdRsZhjjeTcw== X-Google-Smtp-Source: AKy350bQGOJWN5zGDlFHeOGdE2SUiSfVLxmAnGCX0rxA7lXuuoZ5vohL7JrbQpsr9aKTsRFQUoJkHg== X-Received: by 2002:adf:e848:0:b0:2c7:fde:f7e0 with SMTP id d8-20020adfe848000000b002c70fdef7e0mr24295594wrn.65.1680529765220; Mon, 03 Apr 2023 06:49:25 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 09/11] tests/vm: use the default system python for NetBSD Date: Mon, 3 Apr 2023 14:49:18 +0100 Message-Id: <20230403134920.2132362-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529916293100001 From: Daniel P. Berrang=C3=A9 Currently our NetBSD VM recipe requests instal of the python37 package and explicitly tells QEMU to use that version of python. Since the NetBSD base ISO was updated to version 9.3 though, the default system python version is 3.9 which is sufficiently new for QEMU to rely on. Rather than requesting an older python, just test against the default system python which is what most users will have. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20230329124601.822209-1-berrange@redhat.com> Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth Message-Id: <20230330101141.30199-9-alex.bennee@linaro.org> Tested-by: Philippe Mathieu-Daud=C3=A9 --- tests/vm/netbsd | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index aa54338dfa..0b9536ca17 100755 --- a/tests/vm/netbsd +++ b/tests/vm/netbsd @@ -30,7 +30,6 @@ class NetBSDVM(basevm.BaseVM): "git-base", "pkgconf", "xz", - "python37", "ninja-build", =20 # gnu tools @@ -66,7 +65,7 @@ class NetBSDVM(basevm.BaseVM): mkdir src build; cd src; tar -xf /dev/rld1a; cd ../build - ../src/configure --python=3Dpython3.7 --disable-opengl {configure_= opts}; + ../src/configure --disable-opengl {configure_opts}; gmake --output-sync -j{jobs} {target} {verbose}; """ poweroff =3D "/sbin/poweroff" --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529916; cv=none; d=zohomail.com; s=zohoarc; b=lF3OkydbYDRPBHWYhg6EicE/in+2YBcBVSZfInfHigYpo3BqS34jpfaA10/zx6ZtDwKJKtTanx2BUp6CENyNUnZltOe+V6GtG8Rbw+9KQ7eL3Lerbw8qw+gsEiX1bIuUVj6icSwU8pVdLzBrgbAwQSEYiX4kXMvJ+MPGIeSckIk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529916; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H2FeLZKR7rrXEZU0aPhVzNZ/e8CIWD3g/VnvrT6YWk8=; b=XnwxeHfoH8dv8L3IMw/qXVQei4MJ5xgt/SRNM9/L+sJLYq/vbDxSr6qSe8kaLK4rtGKn1ejNssq+j5sFVD493v2U8tT8SofQU0FcV/mYo0qNRo83c19DcWrnAqciBgvkPqq8L4NADLuznAj4krirMdwQIXByFnXK3OSv63DKj6o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529916346766.7391413469398; Mon, 3 Apr 2023 06:51:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYu-000309-Kb; Mon, 03 Apr 2023 09:49:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYt-0002zX-Or for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:31 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYp-0004wm-AT for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:31 -0400 Received: by mail-wm1-x32c.google.com with SMTP id o32so17157827wms.1 for ; Mon, 03 Apr 2023 06:49:26 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id m8-20020a7bce08000000b003ee70225ed2sm12182902wmc.15.2023.04.03.06.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id AC70C1FFC1; Mon, 3 Apr 2023 14:49:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529766; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H2FeLZKR7rrXEZU0aPhVzNZ/e8CIWD3g/VnvrT6YWk8=; b=kZmtBOf2iDPBbqPfDNkM9lOnUFuhMtgPgELYV+FeVe/tevJcmAoJoNpdgj0ET4cVJn VHV1zWCKYwQ54Kaa4Qk/UY5c2/V28c2nip5l6WG2XVmBYXaCUJcgq2H25E5MoOxv/J9o gqaz602XARMBoQilmFjbdQMTpXp9Ols/uPMZwaXeWQ/YsftVBAnOCkPFJVwOEhJAGzHj 4igZo/d/GSphULrD/hJbheAsFgf9D4zgVjv6r61QXFW0doyoAWpTelVO61it552Ydcqp YwZABI2ajwBiOLZhRjDPk5sQYvjnZNLMorQ7GQa/YoFiart/Ta2VcGkqcwVjjuQk0okv /LVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529766; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H2FeLZKR7rrXEZU0aPhVzNZ/e8CIWD3g/VnvrT6YWk8=; b=Z7qTyhTjGy/PtnLGOWGj0TOAhxwUZx8Q07wYLkwjiUgWuJFjmkfSoctFNb3ZueycKD RA9oF0+TjWJDn6eagLwLOBQYHIt3XGMfW/ny5XedGGpIOQzWE1ZSV6mn9MNGiR0f+Ng2 YJh4dZ6hQE5JJiVL14EAvTIW5G+vs4m+I+SpNOJTBo+pUn1wmuqbgCc49dtu8mXFrGf3 TKxCiXmCqRRc951dv49Q1A5wd+uE5cQSZVvspeqTB9KpQ0j7A/6lNNoMg5xCBLocXmuD EYcuhnc01uuMSp0EN9/7MjRNAHy4FH81SUjC3IinHVNqu0g+VnKcNmcTPCY8xU8UAe1V 3k9g== X-Gm-Message-State: AAQBX9fuA/w+tynOHvYCB//CQ/WazzZZh5//CBPsyjFEy1KQ+7at8j1C 6xvMaB1bE6BsawP+hab8q4cNJg== X-Google-Smtp-Source: AKy350YA40DrGkbdfx/WSsRDtrRoPhUtAlw/ACRAcCii+kLbD9pF4FXTjcactSbOaqPqWUvzTTEOXw== X-Received: by 2002:a1c:4b04:0:b0:3ed:c84c:7efe with SMTP id y4-20020a1c4b04000000b003edc84c7efemr13588895wma.7.1680529766064; Mon, 03 Apr 2023 06:49:26 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf Subject: [PATCH v2 10/11] gitlab: fix typo Date: Mon, 3 Apr 2023 14:49:19 +0100 Message-Id: <20230403134920.2132362-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529918298100007 Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20230330101141.30199-11-alex.bennee@linaro.org> --- .gitlab-ci.d/base.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml index 0274228de8..2fbb58d2a3 100644 --- a/.gitlab-ci.d/base.yml +++ b/.gitlab-ci.d/base.yml @@ -75,5 +75,5 @@ - if: '$QEMU_CI !=3D "2" && $CI_PROJECT_NAMESPACE !=3D "qemu-project"' when: manual =20 - # Jobs can run if any jobs they depend on were successfull + # Jobs can run if any jobs they depend on were successful - when: on_success --=20 2.39.2 From nobody Tue Feb 10 17:02:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1680529863; cv=none; d=zohomail.com; s=zohoarc; b=U3glAZq76sM+UN7ZoR7xrfxECg6ZdzJlwl6pgWv4SGVg5CmSySj0tG+hPA7BoSP+JxjOdlzBsXNY6QwhL0odpBNPDL1Q430F9DIx4n0DCFs7czjdTAFRK3cI277KhSMjZctJCh1se01xtb2DyBLDG0NVWIC61dTJD4sBxbV131M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680529863; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vKaHaFlstk5VQMLZ9VjcumTBmG2FDADA92zKOBfHglo=; b=WjXP+ncZvZH0r0h/3txR2pVI5g7ATIZPoHrs2bNH0u2WGsyBFjOMR7dwfTWq7RGstLwPzQEnNJOErs3aPGvCLttQaW2EQr8dr0+9XNoAYYHdqlqRTTh0Xa6hX0net+ZrxeoT1rk8XaIKjxjoV8XB3WgdPSO9KbfKdMdeYAYTQjk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680529863852312.7669032914815; Mon, 3 Apr 2023 06:51:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYx-00032h-F6; Mon, 03 Apr 2023 09:49:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYt-0002zI-JW for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:31 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYp-0004wd-7V for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:31 -0400 Received: by mail-wr1-x42f.google.com with SMTP id r29so29388123wra.13 for ; Mon, 03 Apr 2023 06:49:26 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id j8-20020adfe508000000b002cfe71153b4sm9696735wrm.60.2023.04.03.06.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:23 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id C43841FFB8; Mon, 3 Apr 2023 14:49:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529766; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vKaHaFlstk5VQMLZ9VjcumTBmG2FDADA92zKOBfHglo=; b=c4D5FAHNNne6aHzgXm5PKvuQrV0KwTkfjJrPgEUCbjhxQtZdGE6JVakoULkhd4i0Jp KQ44SWWS+vuj0c/x1WHBgAJVF0VkrLqxVfK+GJjHs7Vea8fmVUlRf1Ue5TAdeVnp9KRt HyiaBIFGGqVpXbqVvGqeMubwlUqQNCZtGvzXPLyTiBafiVbmJ5rk5FMteRW5UZpVxlOP Coe1KPAvwVYf9gfUKbXzQm/PUx95STeBTH+X/m9TYt0ik4ltlVpmOHols2Q8yhqBI2oc T7M2Qg9KeZKsqn6T1nFy3QM0dtzikm8kUK4amICoZQ+Ulw9BczaCvvd3MmZdonHSCx4j 3oXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529766; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vKaHaFlstk5VQMLZ9VjcumTBmG2FDADA92zKOBfHglo=; b=smpzb6t8JZUUp3WAjEPBR5KCOB9oSRFmhPEN8pE3tgLKpHErKX1Uw9K59qaoITmWik gh/a0EwJBTMzb4/q3skBTSTp171CA4kj+Hwbvo/Qa2tMfv23hGzXKqJrIfjichn2w454 gBRF94KVfU/hlPB9/G5+YGwbd/NDKa1p3SsGCPeCTEus/QZtMedk68b+0PUwsl7P/La3 iLfDi7KK1DwqjqxPsvjafLY68Lp0wN3WnkMr0roPQCJruPfIrkATiNV4gYkUSWKuIQgw 1zHAEp8hoMNPzCrLjo8773SsfTL8L9EzsOkL0EU+/5nTPMHRkW8JhAp/KwUDRdeEjbqi 1nmw== X-Gm-Message-State: AAQBX9c28NgHr8sXIB/y5++dC2UfELlkFlvgePaVLzmXBEXykH39AVUo kkMMKeyNDf4k7yIwEMZQ+9QaNw== X-Google-Smtp-Source: AKy350Ydv65QkkABiTX0HooAnoZ65jAKnxHGHWOofsFjIU4hIEUqi5s3uitbO13gUcAIrUZq7sRtTA== X-Received: by 2002:a05:6000:ca:b0:2d6:5afe:7b91 with SMTP id q10-20020a05600000ca00b002d65afe7b91mr12487847wrx.30.1680529765861; Mon, 03 Apr 2023 06:49:25 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf , David Woodhouse Subject: [PATCH v2 11/11] tests/avocado: Test Xen guest support under KVM Date: Mon, 3 Apr 2023 14:49:20 +0100 Message-Id: <20230403134920.2132362-12-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1680529864746100003 From: David Woodhouse Exercise guests with a few different modes for interrupt delivery. In particular we want to cover: =E2=80=A2 Xen event channel delivery via GSI to the I/O APIC =E2=80=A2 Xen event channel delivery via GSI to the i8259 PIC =E2=80=A2 MSIs routed to PIRQ event channels =E2=80=A2 GSIs routed to PIRQ event channels As well as some variants of normal non-Xen stuff like MSI to vAPIC and PCI INTx going to the I/O APIC and PIC, which ought to still work even in Xen mode. Signed-off-by: David Woodhouse Signed-off-by: Alex Benn=C3=A9e Message-Id: <20230324160719.1790792-1-alex.bennee@linaro.org> --- v2 - catch fail to launch and skip on lack of support --- tests/avocado/kvm_xen_guest.py | 170 +++++++++++++++++++++++++++++++++ 1 file changed, 170 insertions(+) create mode 100644 tests/avocado/kvm_xen_guest.py diff --git a/tests/avocado/kvm_xen_guest.py b/tests/avocado/kvm_xen_guest.py new file mode 100644 index 0000000000..112c955976 --- /dev/null +++ b/tests/avocado/kvm_xen_guest.py @@ -0,0 +1,170 @@ +# KVM Xen guest functional tests +# +# Copyright =C2=A9 2021 Red Hat, Inc. +# Copyright =C2=A9 2023 Amazon.com, Inc. or its affiliates. All Rights Res= erved. +# +# Author: +# David Woodhouse +# Alex Benn=C3=A9e +# +# SPDX-License-Identifier: GPL-2.0-or-later + +import os + +from qemu.machine import machine + +from avocado_qemu import LinuxSSHMixIn +from avocado_qemu import QemuSystemTest +from avocado_qemu import wait_for_console_pattern + +class KVMXenGuest(QemuSystemTest, LinuxSSHMixIn): + """ + :avocado: tags=3Darch:x86_64 + :avocado: tags=3Dmachine:q35 + :avocado: tags=3Daccel:kvm + :avocado: tags=3Dkvm_xen_guest + """ + + KERNEL_DEFAULT =3D 'printk.time=3D0 root=3D/dev/xvda console=3DttyS0' + + kernel_path =3D None + kernel_params =3D None + + # Fetch assets from the kvm-xen-guest subdir of my shared test + # images directory on fileserver.linaro.org where you can find + # build instructions for how they where assembled. + def get_asset(self, name, sha1): + base_url =3D ('https://fileserver.linaro.org/s/' + 'kE4nCFLdQcoBF9t/download?' + 'path=3D%2Fkvm-xen-guest&files=3D' ) + url =3D base_url + name + # use explicit name rather than failing to neatly parse the + # URL into a unique one + return self.fetch_asset(name=3Dname, locations=3D(url), asset_hash= =3Dsha1) + + def common_vm_setup(self): + # We also catch lack of KVM_XEN support if we fail to launch + self.require_accelerator("kvm") + + self.vm.set_console() + + self.vm.add_args("-accel", "kvm,xen-version=3D0x4000a,kernel-irqch= ip=3Dsplit") + self.vm.add_args("-smp", "2") + + self.kernel_path =3D self.get_asset("bzImage", + "367962983d0d32109998a70b45dcee4= 672d0b045") + self.rootfs =3D self.get_asset("rootfs.ext4", + "f1478401ea4b3fa2ea196396be44315bab2b= b5e4") + + def run_and_check(self): + self.vm.add_args('-kernel', self.kernel_path, + '-append', self.kernel_params, + '-drive', f"file=3D{self.rootfs},if=3Dnone,forma= t=3Draw,id=3Ddrv0", + '-device', 'xen-disk,drive=3Ddrv0,vdev=3Dxvda', + '-device', 'virtio-net-pci,netdev=3Dunet', + '-netdev', 'user,id=3Dunet,hostfwd=3D:127.0.0.1:0= -:22') + + try: + self.vm.launch() + except machine.VMLaunchFailure as e: + if "Xen HVM guest support not present" in e.output: + self.cancel("KVM Xen support is not present (need v5.12+ k= ernel with CONFIG_KVM_XEN)") + elif "Property 'kvm-accel.xen-version' not found" in e.output: + self.cancel("QEMU not built with CONFIG_XEN_EMU support") + else: + raise e + + self.log.info('VM launched, waiting for sshd') + console_pattern =3D 'Starting dropbear sshd: OK' + wait_for_console_pattern(self, console_pattern, 'Oops') + self.log.info('sshd ready') + self.ssh_connect('root', '', False) + + self.ssh_command('cat /proc/cmdline') + self.ssh_command('dmesg | grep -e "Grant table initialized"') + + def test_kvm_xen_guest(self): + """ + :avocado: tags=3Dkvm_xen_guest + """ + + self.common_vm_setup() + + self.kernel_params =3D (self.KERNEL_DEFAULT + + ' xen_emul_unplug=3Dide-disks') + self.run_and_check() + self.ssh_command('grep xen-pirq.*msi /proc/interrupts') + + def test_kvm_xen_guest_nomsi(self): + """ + :avocado: tags=3Dkvm_xen_guest_nomsi + """ + + self.common_vm_setup() + + self.kernel_params =3D (self.KERNEL_DEFAULT + + ' xen_emul_unplug=3Dide-disks pci=3Dnomsi') + self.run_and_check() + self.ssh_command('grep xen-pirq.* /proc/interrupts') + + def test_kvm_xen_guest_noapic_nomsi(self): + """ + :avocado: tags=3Dkvm_xen_guest_noapic_nomsi + """ + + self.common_vm_setup() + + self.kernel_params =3D (self.KERNEL_DEFAULT + + ' xen_emul_unplug=3Dide-disks noapic pci=3Dn= omsi') + self.run_and_check() + self.ssh_command('grep xen-pirq /proc/interrupts') + + def test_kvm_xen_guest_vapic(self): + """ + :avocado: tags=3Dkvm_xen_guest_vapic + """ + + self.common_vm_setup() + self.vm.add_args('-cpu', 'host,+xen-vapic') + self.kernel_params =3D (self.KERNEL_DEFAULT + + ' xen_emul_unplug=3Dide-disks') + self.run_and_check() + self.ssh_command('grep xen-pirq /proc/interrupts') + self.ssh_command('grep PCI-MSI /proc/interrupts') + + def test_kvm_xen_guest_novector(self): + """ + :avocado: tags=3Dkvm_xen_guest_novector + """ + + self.common_vm_setup() + self.kernel_params =3D (self.KERNEL_DEFAULT + + ' xen_emul_unplug=3Dide-disks' + + ' xen_no_vector_callback') + self.run_and_check() + self.ssh_command('grep xen-platform-pci /proc/interrupts') + + def test_kvm_xen_guest_novector_nomsi(self): + """ + :avocado: tags=3Dkvm_xen_guest_novector_nomsi + """ + + self.common_vm_setup() + + self.kernel_params =3D (self.KERNEL_DEFAULT + + ' xen_emul_unplug=3Dide-disks pci=3Dnomsi' + + ' xen_no_vector_callback') + self.run_and_check() + self.ssh_command('grep xen-platform-pci /proc/interrupts') + + def test_kvm_xen_guest_novector_noapic(self): + """ + :avocado: tags=3Dkvm_xen_guest_novector_noapic + """ + + self.common_vm_setup() + self.kernel_params =3D (self.KERNEL_DEFAULT + + ' xen_emul_unplug=3Dide-disks' + + ' xen_no_vector_callback noapic') + self.run_and_check() + self.ssh_command('grep xen-platform-pci /proc/interrupts') --=20 2.39.2