From nobody Mon Feb 9 06:50:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1680181923; cv=none; d=zohomail.com; s=zohoarc; b=lpmjPj+3RJQZceewesmw5uCongMfOxFwdfurijbCmu2tQs42QSu49HACFefPnYGj+G8s5vogwSYnVIDXUJ3ycUoGGij7iwufryQiQtcv9SKv1S5Rzr4xjqtlA51Q7u0CX9aAfK5I0Bi3LO4XHara4hvXjzJkYllJgRvyU6EJjQU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680181923; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=GFU9gNXqwv3B7kWQcAHttWZVvsZ4Whn/lvOJHgkqThA=; b=LUdbKE6HRYZ6WNVfSQ9ZybIhlqixqr0WmVQMOpo4kOmgT3l0n4zRNOvcQ/1E6Lh5HCneUOl8S0X9qe+GKThRpI7jMNvsVTa9UP4LMzl5MjbqgqSwkOiGX2MKnf5vxr9s7uQKzK82nEleX4ft8tD1it8nw4e4muH+gxHh9aOu+GY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680181923530327.3598882773356; Thu, 30 Mar 2023 06:12:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phs3k-0003c4-Nu; Thu, 30 Mar 2023 09:11:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phs3j-0003br-9p for qemu-devel@nongnu.org; Thu, 30 Mar 2023 09:11:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phs3g-0000pu-FH for qemu-devel@nongnu.org; Thu, 30 Mar 2023 09:11:18 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-339-13P__VQyPkWlqQLI_S3YGQ-1; Thu, 30 Mar 2023 09:11:13 -0400 Received: by mail-wr1-f72.google.com with SMTP id i19-20020adfa513000000b002dc1cdac53fso1953217wrb.5 for ; Thu, 30 Mar 2023 06:11:13 -0700 (PDT) Received: from [192.168.10.118] ([2001:b07:6468:f312:4783:a68:c1ee:15c5]) by smtp.gmail.com with ESMTPSA id y21-20020a7bcd95000000b003edc11c2ecbsm5927617wmj.4.2023.03.30.06.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 06:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680181874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GFU9gNXqwv3B7kWQcAHttWZVvsZ4Whn/lvOJHgkqThA=; b=JZ4YeeP5aOXdHeXt1UG7iA5LkNWqsqpGS3GwYhGySxFoJTYnlDpZCmop5SLurf0UrPTz+v k5OBAR/LsClAnHN6kaJYP0X8+BhxuPqUf02+fk//RyMwJoLIOTm5k+O8z78qJx31eatZ3F 2vTQD11nzKcFvqDe5lFL7JYzM6PrluU= X-MC-Unique: 13P__VQyPkWlqQLI_S3YGQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680181871; x=1682773871; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GFU9gNXqwv3B7kWQcAHttWZVvsZ4Whn/lvOJHgkqThA=; b=EY+zabMWpVPXDQIsrKxh+Z81CdPFt5r8uV0ihWiAtKxJ1Zti/NFHpDGx/xqBCoaLQa cusvcaHrAffsMgbORhwwRjXjUKQG+pfP6xfNnhGrx+Ykq6jH1kebmfg8ThTHq+74S8xn EyzYc4KRdCy4YgUBBmKSUfzouYqJH3Kewt17t+R3odRenjefLSf+dUJIAvn8E1cWOOeW iFkitzBO/g/1WZT7nGnxdRZwduEpimzrnlxibuX5lRho9rYKiHoreFmWHXJwFqpJfk2N zH/WtJif5uQN0Sm1Oh94yKtU91ULRsfcYw/1V05tDmF58Kajpk5EifPVE5+oMRNZF7id nPoA== X-Gm-Message-State: AO0yUKV1/fFILnkev3Juh2vSJjkPMCOveE0HhMNFoqFwNUzeXv3M5eZE RthmTdY4fWBZse2kHbLPZ8rDUcg0eiQIvyVMilX2SCd34CjAQGujqxE3eIf5tccLQ9UkYDfNMBr V46PHI7Y+8RHCmHwJkfMzEslVIiRHQAqPjT0VsfclCds3ecgACkwCI0EMFo5OJcGMg5HcSlKcXh EZ+w== X-Received: by 2002:a1c:790b:0:b0:3ed:9ed7:d676 with SMTP id l11-20020a1c790b000000b003ed9ed7d676mr17700898wme.13.1680181871516; Thu, 30 Mar 2023 06:11:11 -0700 (PDT) X-Google-Smtp-Source: AK7set/4Ke+DuobKtQRuY+r+ND/TYM/eOjhP4HZOgfVlEmT+tIBEn5N1GrzJL/DtF7HPKeIagYEPfA== X-Received: by 2002:a1c:790b:0:b0:3ed:9ed7:d676 with SMTP id l11-20020a1c790b000000b003ed9ed7d676mr17700878wme.13.1680181871120; Thu, 30 Mar 2023 06:11:11 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: "Michael S . Tsirkin" Subject: [PATCH] tests: bios-tables-test: replace memset with initializer Date: Thu, 30 Mar 2023 15:11:09 +0200 Message-Id: <20230330131109.47856-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1680181925104100001 Content-Type: text/plain; charset="utf-8" Coverity complains that memset() writes over a const field. Use an initializer instead, so that the const field is left to zero. Tests that have to write the const field already use an initializer for the whole struct, here I am choosing the smallest possible patch (which is not that small already). Cc: Michael S. Tsirkin Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- tests/qtest/bios-tables-test.c | 123 ++++++++++++--------------------- 1 file changed, 43 insertions(+), 80 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 873358943784..464f87382e23 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -438,10 +438,9 @@ static void test_acpi_asl(test_data *data) { int i; AcpiSdtTable *sdt, *exp_sdt; - test_data exp_data; + test_data exp_data =3D {}; gboolean exp_err, err, all_tables_match =3D true; =20 - memset(&exp_data, 0, sizeof(exp_data)); exp_data.tables =3D load_expected_aml(data); dump_aml_files(data, false); for (i =3D 0; i < data->tables->len; ++i) { @@ -853,12 +852,11 @@ static uint8_t base_required_struct_types[] =3D { =20 static void test_acpi_piix4_tcg(void) { - test_data data; + test_data data =3D {}; =20 /* Supplying -machine accel argument overrides the default (qtest). * This is to make guest actually run. */ - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.required_struct_types =3D base_required_struct_types; data.required_struct_types_len =3D ARRAY_SIZE(base_required_struct_typ= es); @@ -868,9 +866,8 @@ static void test_acpi_piix4_tcg(void) =20 static void test_acpi_piix4_tcg_bridge(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".bridge"; data.required_struct_types =3D base_required_struct_types; @@ -906,9 +903,8 @@ static void test_acpi_piix4_tcg_bridge(void) =20 static void test_acpi_piix4_no_root_hotplug(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".roothp"; data.required_struct_types =3D base_required_struct_types; @@ -923,9 +919,8 @@ static void test_acpi_piix4_no_root_hotplug(void) =20 static void test_acpi_piix4_no_bridge_hotplug(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".hpbridge"; data.required_struct_types =3D base_required_struct_types; @@ -940,9 +935,8 @@ static void test_acpi_piix4_no_bridge_hotplug(void) =20 static void test_acpi_piix4_no_acpi_pci_hotplug(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".hpbrroot"; data.required_struct_types =3D base_required_struct_types; @@ -962,9 +956,8 @@ static void test_acpi_piix4_no_acpi_pci_hotplug(void) =20 static void test_acpi_q35_tcg(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.required_struct_types =3D base_required_struct_types; data.required_struct_types_len =3D ARRAY_SIZE(base_required_struct_typ= es); @@ -994,9 +987,8 @@ static void test_acpi_q35_tcg_core_count2(void) =20 static void test_acpi_q35_tcg_bridge(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".bridge"; data.required_struct_types =3D base_required_struct_types; @@ -1009,9 +1001,8 @@ static void test_acpi_q35_tcg_bridge(void) =20 static void test_acpi_q35_tcg_no_acpi_hotplug(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".noacpihp"; data.required_struct_types =3D base_required_struct_types; @@ -1105,9 +1096,8 @@ static void test_acpi_q35_tcg_mmio64(void) =20 static void test_acpi_piix4_tcg_cphp(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".cphp"; test_acpi_one("-smp 2,cores=3D3,sockets=3D2,maxcpus=3D6" @@ -1121,9 +1111,8 @@ static void test_acpi_piix4_tcg_cphp(void) =20 static void test_acpi_q35_tcg_cphp(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".cphp"; test_acpi_one(" -smp 2,cores=3D3,sockets=3D2,maxcpus=3D6" @@ -1141,9 +1130,8 @@ static uint8_t ipmi_required_struct_types[] =3D { =20 static void test_acpi_q35_tcg_ipmi(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".ipmibt"; data.required_struct_types =3D ipmi_required_struct_types; @@ -1156,9 +1144,8 @@ static void test_acpi_q35_tcg_ipmi(void) =20 static void test_acpi_q35_tcg_smbus_ipmi(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".ipmismbus"; data.required_struct_types =3D ipmi_required_struct_types; @@ -1171,12 +1158,11 @@ static void test_acpi_q35_tcg_smbus_ipmi(void) =20 static void test_acpi_piix4_tcg_ipmi(void) { - test_data data; + test_data data =3D {}; =20 /* Supplying -machine accel argument overrides the default (qtest). * This is to make guest actually run. */ - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".ipmikcs"; data.required_struct_types =3D ipmi_required_struct_types; @@ -1189,9 +1175,8 @@ static void test_acpi_piix4_tcg_ipmi(void) =20 static void test_acpi_q35_tcg_memhp(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".memhp"; test_acpi_one(" -m 128,slots=3D3,maxmem=3D1G" @@ -1205,9 +1190,8 @@ static void test_acpi_q35_tcg_memhp(void) =20 static void test_acpi_piix4_tcg_memhp(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".memhp"; test_acpi_one(" -m 128,slots=3D3,maxmem=3D1G" @@ -1221,9 +1205,8 @@ static void test_acpi_piix4_tcg_memhp(void) =20 static void test_acpi_piix4_tcg_nosmm(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".nosmm"; test_acpi_one("-machine smm=3Doff", &data); @@ -1232,9 +1215,8 @@ static void test_acpi_piix4_tcg_nosmm(void) =20 static void test_acpi_piix4_tcg_smm_compat(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".smm-compat"; test_acpi_one("-global PIIX4_PM.smm-compat=3Don", &data); @@ -1243,9 +1225,8 @@ static void test_acpi_piix4_tcg_smm_compat(void) =20 static void test_acpi_piix4_tcg_smm_compat_nosmm(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".smm-compat-nosmm"; test_acpi_one("-global PIIX4_PM.smm-compat=3Don -machine smm=3Doff", &= data); @@ -1254,9 +1235,8 @@ static void test_acpi_piix4_tcg_smm_compat_nosmm(void) =20 static void test_acpi_piix4_tcg_nohpet(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.machine_param =3D ",hpet=3Doff"; data.variant =3D ".nohpet"; @@ -1266,9 +1246,8 @@ static void test_acpi_piix4_tcg_nohpet(void) =20 static void test_acpi_q35_tcg_numamem(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".numamem"; test_acpi_one(" -object memory-backend-ram,id=3Dram0,size=3D128M" @@ -1278,9 +1257,8 @@ static void test_acpi_q35_tcg_numamem(void) =20 static void test_acpi_q35_kvm_xapic(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".xapic"; test_acpi_one(" -object memory-backend-ram,id=3Dram0,size=3D128M" @@ -1291,9 +1269,8 @@ static void test_acpi_q35_kvm_xapic(void) =20 static void test_acpi_q35_tcg_nosmm(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".nosmm"; test_acpi_one("-machine smm=3Doff", &data); @@ -1302,9 +1279,8 @@ static void test_acpi_q35_tcg_nosmm(void) =20 static void test_acpi_q35_tcg_smm_compat(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".smm-compat"; test_acpi_one("-global ICH9-LPC.smm-compat=3Don", &data); @@ -1313,9 +1289,8 @@ static void test_acpi_q35_tcg_smm_compat(void) =20 static void test_acpi_q35_tcg_smm_compat_nosmm(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".smm-compat-nosmm"; test_acpi_one("-global ICH9-LPC.smm-compat=3Don -machine smm=3Doff", &= data); @@ -1324,9 +1299,8 @@ static void test_acpi_q35_tcg_smm_compat_nosmm(void) =20 static void test_acpi_q35_tcg_nohpet(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.machine_param =3D ",hpet=3Doff"; data.variant =3D ".nohpet"; @@ -1336,9 +1310,8 @@ static void test_acpi_q35_tcg_nohpet(void) =20 static void test_acpi_q35_kvm_dmar(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".dmar"; test_acpi_one("-machine kernel-irqchip=3Dsplit -accel kvm" @@ -1348,9 +1321,8 @@ static void test_acpi_q35_kvm_dmar(void) =20 static void test_acpi_q35_tcg_ivrs(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".ivrs"; data.tcg_only =3D true, @@ -1360,9 +1332,8 @@ static void test_acpi_q35_tcg_ivrs(void) =20 static void test_acpi_piix4_tcg_numamem(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.variant =3D ".numamem"; test_acpi_one(" -object memory-backend-ram,id=3Dram0,size=3D128M" @@ -1379,7 +1350,7 @@ static void test_acpi_tcg_tpm(const char *machine, co= nst char *tpm_if, machine, tpm_if); char *tmp_path =3D g_dir_make_tmp(tmp_dir_name, NULL); TPMTestState test; - test_data data; + test_data data =3D {}; GThread *thread; const char *suffix =3D tpm_version =3D=3D TPM_VERSION_2_0 ? "tpm2" : "= tpm12"; char *args, *variant =3D g_strdup_printf(".%s.%s", tpm_if, suffix); @@ -1399,7 +1370,6 @@ static void test_acpi_tcg_tpm(const char *machine, co= nst char *tpm_if, thread =3D g_thread_new(NULL, tpm_emu_ctrl_thread, &test); tpm_emu_test_wait_cond(&test); =20 - memset(&data, 0, sizeof(data)); data.machine =3D machine; data.variant =3D variant; =20 @@ -1434,9 +1404,8 @@ static void test_acpi_q35_tcg_tpm12_tis(void) =20 static void test_acpi_tcg_dimm_pxm(const char *machine) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D machine; data.variant =3D ".dimmpxm"; test_acpi_one(" -machine nvdimm=3Don,nvdimm-persistence=3Dcpu" @@ -1504,7 +1473,6 @@ static void test_acpi_virt_tcg_memhp(void) =20 static void test_acpi_microvm_prepare(test_data *data) { - memset(data, 0, sizeof(*data)); data->machine =3D "microvm"; data->required_struct_types =3D NULL; /* no smbios */ data->required_struct_types_len =3D 0; @@ -1513,7 +1481,7 @@ static void test_acpi_microvm_prepare(test_data *data) =20 static void test_acpi_microvm_tcg(void) { - test_data data; + test_data data =3D {}; =20 test_acpi_microvm_prepare(&data); test_acpi_one(" -machine microvm,acpi=3Don,ioapic2=3Doff,rtc=3Doff", @@ -1523,7 +1491,7 @@ static void test_acpi_microvm_tcg(void) =20 static void test_acpi_microvm_usb_tcg(void) { - test_data data; + test_data data =3D {}; =20 test_acpi_microvm_prepare(&data); data.variant =3D ".usb"; @@ -1534,7 +1502,7 @@ static void test_acpi_microvm_usb_tcg(void) =20 static void test_acpi_microvm_rtc_tcg(void) { - test_data data; + test_data data =3D {}; =20 test_acpi_microvm_prepare(&data); data.variant =3D ".rtc"; @@ -1545,7 +1513,7 @@ static void test_acpi_microvm_rtc_tcg(void) =20 static void test_acpi_microvm_pcie_tcg(void) { - test_data data; + test_data data =3D {}; =20 test_acpi_microvm_prepare(&data); data.variant =3D ".pcie"; @@ -1557,7 +1525,7 @@ static void test_acpi_microvm_pcie_tcg(void) =20 static void test_acpi_microvm_ioapic2_tcg(void) { - test_data data; + test_data data =3D {}; =20 test_acpi_microvm_prepare(&data); data.variant =3D ".ioapic2"; @@ -1622,9 +1590,8 @@ static void test_acpi_virt_tcg_pxb(void) =20 static void test_acpi_tcg_acpi_hmat(const char *machine) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D machine; data.variant =3D ".acpihmat"; test_acpi_one(" -machine hmat=3Don" @@ -1721,9 +1688,8 @@ static void test_acpi_virt_tcg_acpi_hmat(void) =20 static void test_acpi_q35_tcg_acpi_hmat_noinitiator(void) { - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.variant =3D ".acpihmat-noinitiator"; test_acpi_one(" -machine hmat=3Don" @@ -1772,9 +1738,8 @@ static void test_acpi_erst(const char *machine) { gchar *tmp_path =3D g_dir_make_tmp("qemu-test-erst.XXXXXX", NULL); gchar *params; - test_data data; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D machine; data.variant =3D ".acpierst"; params =3D g_strdup_printf( @@ -1802,7 +1767,7 @@ static void test_acpi_microvm_acpi_erst(void) { gchar *tmp_path =3D g_dir_make_tmp("qemu-test-erst.XXXXXX", NULL); gchar *params; - test_data data; + test_data data =3D {}; =20 test_acpi_microvm_prepare(&data); data.variant =3D ".pcie"; @@ -2003,10 +1968,9 @@ static void test_oem_fields(test_data *data) =20 static void test_acpi_piix4_oem_fields(void) { - test_data data; char *args; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_PC; data.required_struct_types =3D base_required_struct_types; data.required_struct_types_len =3D ARRAY_SIZE(base_required_struct_typ= es); @@ -2022,10 +1986,9 @@ static void test_acpi_piix4_oem_fields(void) =20 static void test_acpi_q35_oem_fields(void) { - test_data data; char *args; + test_data data =3D {}; =20 - memset(&data, 0, sizeof(data)); data.machine =3D MACHINE_Q35; data.required_struct_types =3D base_required_struct_types; data.required_struct_types_len =3D ARRAY_SIZE(base_required_struct_typ= es); @@ -2041,7 +2004,7 @@ static void test_acpi_q35_oem_fields(void) =20 static void test_acpi_microvm_oem_fields(void) { - test_data data; + test_data data =3D {}; char *args; =20 test_acpi_microvm_prepare(&data); --=20 2.39.2